20b44d8ff49
Diff: https://reviews.apache.org/r/37426/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
ontainerizer/provisioners/docker/store.cpp (line 169)
<https://reviews.apache.org/r/37197/#comment150226>
extra newline?
- Jojy Varghese
On Aug. 11, 2015, 11:21 p.m., Lily Chen wrote:
>
> ---
> This is an automatically genera
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37426/#review95281
-------
On Aug. 13, 2015, 12:46 a.m., Jojy Varghese wrote:
>
> ---
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95238
---
On Aug. 13, 2015, 8:29 a.m., Jojy Varghese wrote:
>
> ---
Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95238
---
On Aug. 13, 2015, 8:29 a.m., Jojy Varghese wrote:
>
> --
c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
.
Thanks,
Jojy Varghese
hanged the logic to look for http server URL's domain first to populate the
"Host" field.
Diffs
-
3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166
Diff: https://reviews.apache.org/r/37426/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
)
<https://reviews.apache.org/r/37197/#comment149127>
prefer using explicit captures.
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
)
<https://reviews.apache.org/r/37197/#comment149125>
Why extra newline?
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
)
<https://reviews.apache.org/r/37197/#comment149117>
Why not use the new c++11 "delete" keyword?
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
>
> ---
> This is an automatically generated e-mail.
)
<https://reviews.apache.org/r/37197/#comment149115>
I think new files should have javadoc style comments.
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
>
> ---
> This is an automatically generated e-mail.
)
<https://reviews.apache.org/r/37197/#comment149114>
What is the ownership model of Fetcher member? How do you know that the
pointer is valid through the life of StoreProcess object?
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen
e actually make
> > their way to the socket by doing a read and parsing into a request?
>
> Jojy Varghese wrote:
> After dicussing with you, decided to create a separate ticket that
> address this.
Created MESOS-3153
- Jojy
-
but for future reference:
> > please use full words for variable names e.g. `responseBuffer`
>
> Jojy Varghese wrote:
> I will create tickets(JIRA) to address it?
Created MESOS-3153
- Jojy
---
This is an a
eme.
JIRA: MESOS-3093
Diffs (updated)
-
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/ssl_tests.cpp
2fe50601615b0bee57bd3e05dc9c932f93ca7477
Diff: https://reviews.apache.org/r/36757/diff/
Testing
---
make check
Tha
ly, visit:
https://reviews.apache.org/r/36757/#review92966
---
On July 27, 2015, 1:56 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To re
ps://reviews.apache.org/r/36757/#review93049
-------
On July 27, 2015, 1:56 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail.
720/#comment147323>
complexity of a function is measured by the nested if condition in it.
Maybe we accomplish the same using simple small functions ?
- Jojy Varghese
On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote:
>
> -
720/#comment147318>
Why not static initialization pattern :
OK ok = {
.type = Response::PIPE,
.reader = pipe.reader(),
};
Maybe its not allowed in the coding style but I would think it looks
elegant.
- Jojy Varghese
On July 25, 2015, 2:
https://reviews.apache.org/r/36757/#review92966
---
On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
make check
Thanks,
Jojy Varghese
t here is for having "some" payload and https not
crapping out for actual POST data.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92921
--
IRA: MESOS-3093
Diffs (updated)
-
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/ssl_tests.cpp
2fe50601615b0bee57bd3e05dc9c932f93ca7477
Diff: https://reviews.apache.org/r/36757/diff/
Testing
---
make check
Thanks,
Jojy Varghese
k
Thanks,
Jojy Varghese
c/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/ssl_tests.cpp
2fe50601615b0bee57bd3e05dc9c932f93ca7477
Diff: https://reviews.apache.org/r/36757/diff/
Testing
---
make check
Thanks,
Jojy Varghese
,
Jojy Varghese
Description
---
Added ONCE guard for Eventloop::initialize
Diffs
-
3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8
Diff: https://reviews.apache.org/r/36712/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
Thanks,
Jojy Varghese
/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
---
make check
Thanks,
Jojy Varghese
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
487734316e1f626bac0543d453646555ea51b4b9
support/post-reviews.py 78201ee79dc528a0cfdd0b89cc0a191be3d5846c
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/
Testing
---
make check
Thanks,
Jojy Varghese
(updated)
-
src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f
src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
(updated)
-
src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f
src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
ater on.
> >
> > I think we should go back to the exact same order as before unless you
> > have reasons to do this change.
>
> Jojy Varghese wrote:
> The thought was as follows:
> - We called inspect to get the pid. So first we check for a pid. Th
-----
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36326/#review91342
---
On July 9, 2015, 8:38 p.m., Jojy Varghese wrote:
>
> ---
> Thi
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
serving doxygen. Not sure what else I could have added. Sugestions are
welcome.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review91168
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36326/#review91005
---
On July 9, 2015, 8:38 p.m., Jojy Varghese wrote:
>
>
)
-
src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f
src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/
Testing
---
make check
Thanks,
Jojy Varghese
6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
src/slave/containerizer/isolators/cgroups/cpushare.cpp
f56e97dcf91a6f5c9a8abe4afe9dc1a1d47df330
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
onst Stat' rather than forcing it on the
> > caller :)
> >
> > (3) Any reason not to use 'Duration' for these fields?
>
> Jojy Varghese wrote:
> 1) Absolutely I can.
> 2) I wanted to reflect the semantics of the stats call. When you
/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
est
> > just calling cgroups::stat for now, should simplify this and make it easier
> > for the reader. :)
>
> Jojy Varghese wrote:
> The only reason being that the way cpuacct creates Stat should be
> encapsulated in the cpuacct::Stat. This is the same reason there is a p
est
> > just calling cgroups::stat for now, should simplify this and make it easier
> > for the reader. :)
>
> Jojy Varghese wrote:
> The only reason being that the way cpuacct creates Stat should be
> encapsulated in the cpuacct::Stat. This is the same reason there is a p
est
> > just calling cgroups::stat for now, should simplify this and make it easier
> > for the reader. :)
>
> Jojy Varghese wrote:
> The only reason being that the way cpuacct creates Stat should be
> encapsulated in the cpuacct::Stat. This is the same reason there is a p
hat the way cpuacct creates Stat should be encapsulated
in the cpuacct::Stat. This is the same reason there is a parse method in Stat.
But I can change it to use cgroups::stat if absolutely necessary.
- Jojy
-------
This i
475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
> On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
> > src/linux/cgroups.cpp, line 2060
> > <https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060>
> >
> > Why add trailing underscore?
>
> Jojy Varghese wrote:
> As a memb
t; else, so curious to see what others think.
> > Personally I don't think it provides any additional benefits here.
>
> Jojy Varghese wrote:
> The advantage is that otherwise we will end up copy-paste code of parsing
> at two places(line 0 and line 1)
>
> T
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90140
-------
On July 1, 2015, 9:38 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e
scoped for the function.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90139
---
On July 1, 201
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90139
---
On July 1, 2015, 9:38 p.m., Jojy Varghese wrote:
>
>
://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
---
make check
Thanks,
Jojy Varghese
libprocess/3rdparty/stout/include/stout/utils.hpp
09a1dcd3b3a082544d221fbfeab9a3d3d9f85e2f
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
c2c6a6ac97044f2317418295f48d75e94de4112b
Diff: https://reviews.apache.org/r/35743/diff/
Testing
---
make check
Thanks,
Jojy Varghese
minus the small trivial
> > run-time cost.
>
> Jojy Varghese wrote:
> Not sure if adding a boost dependency just for size operator would get us
> anything here.
>
> Anand Mazumdar wrote:
> Then can we change these to std::array and just invoke the size()
reviews.apache.org/r/35743/#review88852
---
On June 22, 2015, 9:27 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To re
/flags.hpp
7584cb871d02ad01021f0c3439ea205736d4f6b4
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
c2c6a6ac97044f2317418295f48d75e94de4112b
Diff: https://reviews.apache.org/r/35743/diff/
Testing
---
make check
Thanks,
Jojy Varghese
t. So we cant use it for constant objects.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88203
---
On June 17, 2015
---
Replaced dynamic hashmap creation with c++11's static initialization.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
8c102fb7d1f79ee768cb06de3a976ea12f958712
Diff: https://reviews.apache.org/r/35544/diff/
Testing
---
make check
Thanks,
Jojy Varghese
ld naturally fit into the overall scheme.
- Jojy Varghese
On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
tps://reviews.apache.org/r/29406/#comment140298>
General question about the net namespace in the code: why is the network
structure not templatized on the Layer 3(IP) family(inet/inet6 etc)? This would
make it easy to specialize on these families and also make Ipv6 easy.
- Jojy Varghese
On June 13
<https://reviews.apache.org/r/34943/#comment139961>
Style comment: Default captures are considered stylistically bad. Captures
should be explicit(Meyers, Effective Modern C++, Item 31).
- Jojy Varghese
On June 11, 2015, 1:52 p.m., Benjamin Hindman
tps://reviews.apache.org/r/34943/#comment139192>
style question: Why not use static array declaration :
const char *args[] = {
"/path/to/program",
"blah"
};
and also make the function argument const char**?
- Jojy Varghese
On June 5,
701 - 781 of 781 matches
Mail list logo
