Review Request 42518: Disabled "drop_log_memory" flag for glog.

- src/logging/logging.cpp f7619b18fa4a78b20951edad892ca5c616bbed55 Diff: https://reviews.apache.org/r/42518/diff/ Testing --- Verified with the patch by running under gdb and placing a breakpoint on posix_fadvise. The breakpoint doesn't hit anymore. Thanks, Kapil Arya

Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.

make check Thanks, Kapil Arya

Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.

and placing a breakpoint on posix_fadvise. The breakpoint doesn't hit anymore. Thanks, Kapil Arya

Review Request 43741: Fixed symlink generation for DESTDIR installs.

DESTDIR=/tmp` with and without the patch. Thanks, Kapil Arya

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

/diff/ Testing --- Ran `make install DESTDIR=/tmp` with and without the patch. Thanks, Kapil Arya

Re: Review Request 43382: Updated Doxyfile to use relative path.

doxygen to strip out '/path/to/mesos/' from the generated links. Diffs (updated) - Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 Diff: https://reviews.apache.org/r/43382/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43319: Remove markdown files from doxygen.

/README.md 78609fb68182338199b4d0ad4c333c8f34274ee5 src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1 Diff: https://reviews.apache.org/r/43319/diff/ Testing --- Thanks, Kapil Arya

Review Request 44694: Enabled multiple calls to ModuleManager::load().

497ed87bddce23bb457373da40dc87111c04136d Diff: https://reviews.apache.org/r/44694/diff/ Testing --- Added new tests and ran make check. Thanks, Kapil Arya

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

://reviews.apache.org/r/44694/diff/ Testing --- Added new tests and ran make check. Thanks, Kapil Arya

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

Is this an internal invariant? Yes, the hashmap provides it. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/#review123077 ----

Review Request 45900: Removed stale contender/detector files.

/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 Diff: https://reviews.apache.org/r/45900/diff/ Testing --- make check. Thanks, Kapil Arya

Review Request 45901: Removed unsed headers from master contender/detector files.

. Thanks, Kapil Arya

Review Request 45876: Fixed library lookup for Master detector/contender modules.

Description --- See summary. Diffs - src/tests/module.cpp 4b2404871386319393fc09e1dce872cf6bd43279 Diff: https://reviews.apache.org/r/45876/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review127497 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review127499 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02 p.m

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review127496 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/#review127491 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44547: Added functions in promises to the future header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review127490 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review127488 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review127487 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review127492 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review127489 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review127498 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02 p.m

Re: Review Request 45900: Removed stale contender/detector files.

/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 Diff: https://reviews.apache.org/r/45900/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

042505346636de8e1d258ca3f866e7c35acfca01 src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a Diff: https://reviews.apache.org/r/45901/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 45419: Cleaned up ModuleManager.

tps://reviews.apache.org/r/45419/#comment188813> Should we use the following instead? ``` namespace mesos { namespace module { ``` Although there is no consistensy in the code base, the above format seems to be used more often :). - Kapil Arya On March 29, 20

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review126359 --- - Kapil Arya On March 23, 2016, 7:04 p.m., Anurag Singh wrote

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

er, can we replace `type` with a more explicit name? - Kapil Arya On March 23, 2016, 7:04 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

tests/slave_recovery_tests.cpp (lines 78 - 79) <https://reviews.apache.org/r/44288/#comment189289> Alphabetize. src/tests/slave_tests.cpp (lines 71 - 72) <https://reviews.apache.org/r/44288/#comment189290> ditto - Kapil Arya On March 23, 2016, 7:04 p.m., Anu

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review126358 --- Ship it! Ship It! - Kapil Arya On March 23, 2016, 7:04 p.m

Re: Review Request 44289: Added support for contender and detector modules.

to test_master_contender_module.cpp and so on? src/master/contenders/zookeeper.cpp (line 27) <https://reviews.apache.org/r/44289/#comment189342> This should come near the top. - Kapil Arya On March 23, 2016, 7:06 p.m., Anurag Singh

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130423 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 10:21 a.m

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/#review130429 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 10:02 a.m

Re: Review Request 46262: Added a LoggingTest with authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review130427 --- Ship it! Ship It! - Kapil Arya On April 15, 2016, 3:01 a.m

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

tps://reviews.apache.org/r/46261/#comment194173> Newline? - Kapil Arya On April 21, 2016, 1:58 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/#review130426 --- Ship it! Ship It! - Kapil Arya On April 22, 2016, 3:14 p.m

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

g/r/46255/#comment193901> slave->agent? src/tests/main.cpp (lines 34 - 35) <https://reviews.apache.org/r/46255/#comment193865> Alphabetize? src/tests/main.cpp (line 79) <https://reviews.apache.org/r/46255/#comment193904> Why not check the return value here too? -

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/#review130201 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 4:21 p.m

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

ense to have a default 'None()' here and simplify the `initialize` function? - Kapil Arya On April 15, 2016, 2:56 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

55 - 58) <https://reviews.apache.org/r/46259/#comment193914> trailing underscore? 3rdparty/libprocess/include/process/metrics/metrics.hpp (line 67) <https://reviews.apache.org/r/46259/#comment193916> Any reason for not making it 'None()' by default to simplify the call sit

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

ERTOOL->ENABLE_GPERFTOOLS transition. - Kapil Arya On April 21, 2016, 4:29 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46462/#review130437 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 12:22 p.m

Re: Review Request 46647: Added the '--enable-perftools' flag to configure docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46647/#review130482 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:45 p.m

Re: Review Request 46643: Fixed the build when perftools is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46643/#review130481 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:19 p.m

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/#review130619 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:25 p.m

Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46529/diff/ Testing --- Thanks, Kapil Arya

Review Request 46523: Sanitized libprocess/Makefile.am.

/46523/diff/ Testing --- Thanks, Kapil Arya

Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya

Review Request 46538: Install module dependencies in build/3rdparty as well.

0523151d924a1398334767bd401ae84e41bdceb7 Diff: https://reviews.apache.org/r/46538/diff/ Testing --- Thanks, Kapil Arya

Review Request 46524: Sanitized src/Makefile.am.

--- Thanks, Kapil Arya

Review Request 46526: Updated 3rdparty paths in Python build scripts.

--- Thanks, Kapil Arya

Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.

/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46531/diff/ Testing --- Thanks, Kapil Arya

Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46521/diff/ Testing --- Thanks, Kapil Arya

Review Request 46534: Updated stout path for mesos_split.py.

/diff/ Testing --- Thanks, Kapil Arya

Review Request 46536: Updated stout path in newbie-guide.

/ Testing --- Thanks, Kapil Arya

Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.

3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3 Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya

Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya

Review Request 46537: Added --enable-install-module-dependencies.

ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46537/diff/ Testing --- Thanks, Kapil Arya

Review Request 46539: Removed libprocess/3rdparty references from misc files.

/46539/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46516: Sorted option checks for libprocess configure.ac.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

lly generated e-mail. To reply, visit: > https://reviews.apache.org/r/46514/#review129976 > --- > > > > The issue MESOS-5245 seems not found here. > > - haosdent huang > > >

Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

ae91a07e2bafd97566ac6e6873990302acad14c9 src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46529/diff/ Testing --- Thanks, Kapil Arya

Review Request 46518: Sorted option checks for top-level configure.ac.

/diff/ Testing --- Thanks, Kapil Arya

Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

/ax_cxx_compile_stdcxx.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/46527/diff/ Testing --- Thanks, Kapil Arya

Review Request 46520: Added --with-stout flag to libprocess configure.

/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46520/diff/ Testing --- Thanks, Kapil Arya

Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya

Review Request 46533: Stopped using libprocess/stout configure scripts.

://reviews.apache.org/r/46533/diff/ Testing --- Thanks, Kapil Arya

Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya

Review Request 46532: Updated LDADD flags for libprocess tests.

://reviews.apache.org/r/46532/diff/ Testing --- Thanks, Kapil Arya

Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

: https://reviews.apache.org/r/46514/diff/ Testing --- Thanks, Kapil Arya

Review Request 46540: Updated pkg-config file to include module dependency info.

a0cc66a77058bf4beaa21d7dd4208654c6185640 Diff: https://reviews.apache.org/r/46540/diff/ Testing --- Thanks, Kapil Arya

Review Request 46535: Updated stout path for doxygen main page.

/ Testing --- Thanks, Kapil Arya

Review Request 46516: Sorted option checks for libprocess configure.ac.

://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46524: Sanitized src/Makefile.am.

/r/46524/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46521/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46533/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.

: https://reviews.apache.org/r/46539/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46523: Sanitized libprocess/Makefile.am.

: https://reviews.apache.org/r/46523/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46518: Sorted option checks for top-level configure.ac.

://reviews.apache.org/r/46518/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

-specific configure script. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.

/r/46526/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46534: Updated stout path for mesos_split.py.

://reviews.apache.org/r/46534/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

/stout/m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/46527/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.

c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46531/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46535: Updated stout path for doxygen main page.

://reviews.apache.org/r/46535/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

f7aa579f133d19c3ef252773c5ed868c977785cd Diff: https://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.

Diff: https://reviews.apache.org/r/46517/diff/ Testing --- Thanks, Kapil Arya

Review Request 46540: Updated pkg-config file to include module dependency info.

a0cc66a77058bf4beaa21d7dd4208654c6185640 Diff: https://reviews.apache.org/r/46540/diff/ Testing --- Thanks, Kapil Arya

Review Request 46538: Install module dependencies in build/3rdparty as well.

0523151d924a1398334767bd401ae84e41bdceb7 Diff: https://reviews.apache.org/r/46538/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46536: Updated stout path in newbie-guide.

://reviews.apache.org/r/46536/diff/ Testing --- Thanks, Kapil Arya

Review Request 46537: Added --enable-install-module-dependencies.

ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46537/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.

f7aa579f133d19c3ef252773c5ed868c977785cd 3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3 Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya

Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya

Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.

://reviews.apache.org/r/46517/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46514/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46516: Sorted option checks for libprocess configure.ac.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46813: Update distribute to setuptools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131165 --- Ship it! Ship It! - Kapil Arya On April 29, 2016, 5:13 a.m

<    1   2   3   4   5   6   7   8   >