ently unsupported). This is the correct behaviour, and it
properly exercises the code added in this patch.
Thanks,
Kevin Klues
value '1,2,3.0':
Expecting all elements to be unsigned integers
./bin/mesos-slave.sh --master=127.0.0.1:5050 --nvidia_gpu_devices=1,2,3
SUCCESS
Thanks,
Kevin Klues
no delegate
was set on the master for some reason.
- Kevin Klues
On March 14, 2016, 5:40 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
eviews.apache.org/r/44439/#comment185779>
This test will probably have to change given the new semantics of
`devices::list()`
- Kevin Klues
On March 14, 2016, 6:25 p.m., Abhishek Dasgupta wrote:
>
>
marking this as incorrect spacing, but I downloaded it
locally, and everything looks good.
For future reference to people watching this review: to get the right
spacing, you should set your tabspace=8 and then tab out until the '\'s all
line up.
- Kevin Klues
On March 14, 2016, 6:
et()));
Try access2 = Access::parse("t r w");
EXPECT_ERROR(access2);
}
```
Normally we put extra spaces to separate `EXPECT` calls from a sequence of
operations that precede it. However, in this case, each `EXPECT` call is
directl
are it against the Selector / Access objects that are passed in.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44439/#review122646
---
On March 7, 2016, 6:27 a.m., Abhishek Dasgupta wrote:
>
,
Kevin Klues
,
Kevin Klues
name.
Thanks,
Kevin Klues
about accessing the enpoint
without the process name.
Thanks,
Kevin Klues
the updated documentation generated from this script.
Thanks,
Kevin Klues
for the
`--nvidia_gpu_devices` flag, which uses this functionality.
Thanks,
Kevin Klues
hanks!
src/Makefile.am (line 2097)
<https://reviews.apache.org/r/45806/#comment191077>
I would probably put a space here after the colon.
- Kevin Klues
On April 7, 2016, 7:10 a.m., zhou xing wrote:
>
> ---
> This is a
`. The fewer places we need to make changes in the future, the
better.
src/Makefile.am (line 2079)
<https://reviews.apache.org/r/45806/#comment190763>
I would probably align the "\" with the rest of them. Set your tab-space
to 8 to see them line up.
- Kevin Klues
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote:
> > Ship It!
My only comment would be to add a comment about what this line is doing. It's
not obvious that this is the delimiter used in verbose mode.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/#review127476
---
Ship it!
Ship It!
- Kevin Klues
On April 6, 2016, 9:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45768/#review127467
---
Ship it!
Ship It!
- Kevin Klues
On April 6, 2016, 9:30 p.m
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote:
> > support/hooks/commit-msg, line 20
> > <https://reviews.apache.org/r/45768/diff/1/?file=1326651#file1326651line20>
> >
> > You should probably quote the $LINE variable here. You should also use
>
INE
do
if [[ "${LINE:0:1}" == "#" ]]; then continue; fi
LENGTH=$(echo $LINE | wc -c)
if [ "$LENGTH" -gt "73" ]; then
echo >&2 "Error: No line in the commit message summary may exceed
72 characters."
/
Testing
---
make check
Thanks,
Kevin Klues
://reviews.apache.org/r/45856/diff/
Testing
---
make check -j
```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess"
bin/mesos-tests.sh
SUCCESS
```
Thanks,
Kevin Klues
tab
* The Resources section of the table in the Offers tab
```
Thanks,
Kevin Klues
76be32842e8b437fda40c8565a34ec4f8d8dfbcc
Diff: https://reviews.apache.org/r/45855/diff/
Testing
---
Looked at regenerated website and it seems to include the new documentation
properly.
Thanks,
Kevin Klues
: https://reviews.apache.org/r/45853/diff/
Testing
---
The webui still appears to work in all respects without this file.
Thanks,
Kevin Klues
eprecated' here is that this code will remain
even after the term 'slave' is depracated. It will only be removed once the
full rename is complete.
- Kevin Klues
On April 12, 2016, 6:34 a.m., zhou xing wrote:
>
> ---
> This is an automa
est from 1 test case ran. (10260 ms total)
[ PASSED ] 1 test.
```
Thanks,
Kevin Klues
---
Fixed indent in Nvidia GPU test.
Diffs
-
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c
Diff: https://reviews.apache.org/r/45969/diff/
Testing
---
Thanks,
Kevin Klues
tps://reviews.apache.org/r/45999/#comment191447>
Is there a reason, we can't just remove the gc process from the list as a
preliminary step, and then leave the rest of the logic as is? Followed by the
explicit gc terminate/delete?
- Kevin Klues
On April 11, 2016, 3:48 a.m., Neil Conway
aGpu' tests will run
--
```
Thanks,
Kevin Klues
b0f58035c7c819b42e5f249fadd97312f9e3ac7b
Diff: https://reviews.apache.org/r/45715/diff/
Testing (updated)
---
Test in subsequent commit.
Thanks,
Kevin Klues
://reviews.apache.org/r/45854/diff/
Testing
---
make check
Thanks,
Kevin Klues
/diff/
Testing (updated)
---
Ran:
```
GTEST_FILTER="SlaveTest.MetricsInMetricsEndpoint:SlaveTest.MetricsInMetricsEndpoint"
make -j check
SUCCESS
```
Thanks,
Kevin Klues
eworks tab
* The Resources section of the table in the Slaves tab
* The Resources section of the table in the Offers tab
```
Thanks,
Kevin Klues
ecifically:
```
* The Resources section in the left sidebar of the main page
* The Resources section of the table in the Frameworks tab
* The Resources section of the table in the Slaves tab
* The Resources section of the table in the Offers tab
```
Thanks,
Kevin Klues
To reply, visit:
https://reviews.apache.org/r/45855/#review127534
-------
On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4585
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/#review128213
---
Ship it!
Ship It!
- Kevin Klues
On April 10, 2016, 6:43 a.m
---
Test coming in subsequent commit.
Thanks,
Kevin Klues
/r/45969/diff/
Testing
---
Thanks,
Kevin Klues
[ OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10020
ms)
[--] 1 test from NvidiaGpuTest (10026 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (10059 ms total)
[ PASSED ] 1 test.
```
Thanks,
Kevin Klues
8)
<https://reviews.apache.org/r/44975/#comment186467>
Why the newline here?
src/tests/containerizer/cgroups_tests.cpp (lines 1360 - 1368)
<https://reviews.apache.org/r/44975/#comment186470>
This pattern doesn't look very mesos-like to me. I'll defer to @bmahler or
@nnielson f
<https://reviews.apache.org/r/44974/#comment186461>
I would probably put the `stringify(devicEntry)` directly in the `write()`
call. No need to create a remporary variable here unnecessarily.
src/linux/cgroups.cpp (line 2642)
<https://reviews.apache.org/r/44974/#comment186462>
review based
off of a branch I pushed out to github:
https://github.com/klueska-mesosphere/mesos/commits/r/a10gupta/cgroups-devices
The old reviews that this review is based on are:
https://reviews.apache.org/r/44439/
https://reviews.apache.org/r/44796/
- Kevin Klues
On March 17, 2016, 7:21 p.m
According to the style, `case` entries should be indented by 2 spaces.
src/linux/cgroups.cpp (lines 2499 - 2562)
<https://reviews.apache.org/r/44974/#comment186728>
These will go away.
src/linux/cgroups.cpp (lines 2663 - 2697)
<https://reviews.apache.org/r/44974/#comment186729>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44832/#review124608
---
Ship it!
Ship It!
- Kevin Klues
On March 16, 2016, 1:50 a.m
> On March 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> >
> > --> Have you sent an email to dev/user list about this backwards
> > incompatible change? If not, you should.
> >
> > --> If users are depending on the return code
feb095da4521f678c96f4cc53bdfda262d350388
src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534
Diff: https://reviews.apache.org/r/44365/diff/
Testing
---
Thanks,
Kevin Klues
://reviews.apache.org/r/44364/diff/
Testing
---
Thanks,
Kevin Klues
4530336b0b5480dc1935cf5fb30a9dd0f003b77c
support/install-nvidia-gdk.sh PRE-CREATION
Diff: https://reviews.apache.org/r/44360/diff/
Testing
---
Thanks,
Kevin Klues
apache.org/r/44366/diff/
Testing
---
Thanks,
Kevin Klues
to
conditionally build support for Nvidia GPUs into Mesos.
Diffs
-
configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517
Diff: https://reviews.apache.org/r/44361/diff/
Testing
---
Thanks,
Kevin Klues
izer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp
PRE-CREATION
src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534
Diff: https://reviews.apache.org/r/44363/diff/
Testing
---
Thanks,
Kevin Klues
.
The installation script itself takes a few parameters.
Run it as support/install-nvidia-gdk.sh --help to see its usage
semantics.
Diffs (updated)
-
support/install-nvidia-gdk.sh PRE-CREATION
Diff: https://reviews.apache.org/r/44360/diff/
Testing
---
Thanks,
Kevin Klues
it:
https://reviews.apache.org/r/44366/#review122059
---
On March 4, 2016, 1:11 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/44366/#review122059
-------
On March 4, 2016, 1:11 a.m., Kevin Klues wrote:
>
> ---
>
> On April 3, 2016, 4:21 p.m., Kevin Klues wrote:
> > support/mesos-style.py, line 43
> > <https://reviews.apache.org/r/45033/diff/5/?file=1322861#file1322861line43>
> >
> > This will not work with `re.match()`. As is, this will only match if
> &g
candidates_set))
total_errors = license_errors + encoding_errors + lint_errors
```
- Kevin Klues
On April 2, 2016, 1:41 a.m., Yong Tang wrote:
>
> ---
> This is an automati
2016, 1:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi
> Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> R
includes patches from Kevin Klues and haosdent.
```
Thanks!
- Kevin Klues
On April 3, 2016, 8:36 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
e want to
exclude).
I updated the patch I referenced before to include this.
- Kevin Klues
On April 3, 2016, 7:46 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
these now!
Only comment would be on the summary line. We typically phrase the summary line
in the past tense, with a period at the end, i.e.:
```
Changed some non-ascii characters to ascii equivalent.
```
- Kevin Klues
On April 3, 2016, 9 p.m., Yong Tang wrote
to:
```
Changed some non-ascii characters in libprocess to their ascii equivalent.
```
- Kevin Klues
On April 3, 2016, 9:01 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On April 3, 2016, 4:21 p.m., Kevin Klues wrote:
> > support/mesos-style.py, line 43
> > <https://reviews.apache.org/r/45033/diff/5/?file=1322861#file1322861line43>
> >
> > This will not work with `re.match()`. As is, this will only match if
> &g
- Kevin Klues
On March 29, 2016, 6:59 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45439/
> --
'nvidia_gpu_devices': Failed to load value '1,2,3.0':
Expecting all elements to be unsigned integers
./bin/mesos-slave.sh --master=127.0.0.1:5050 --nvidia_gpu_devices=1,2,3
SUCCESS
Thanks,
Kevin Klues
/include
--with-nvml-lib=/opt/nvidia-gdk/usr/src/gdk/nvml/lib
```
Thanks,
Kevin Klues
./bin/mesos-slave.sh --master=127.0.0.1:5050 --nvidia_gpu_devices=1,2,3
SUCCESS
Thanks,
Kevin Klues
patch.
Thanks,
Kevin Klues
/
Testing
---
Rebuilt with nvidia gpu support for both clang and gcc.
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126895
---
Ship it!
Ship It!
- Kevin Klues
On April 4, 2016, 3:21 p.m
ng Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
>
> (Updated April 4, 2016, 3
n:/usr/sbin:/usr/bin)
--
No 'nvidia-smi' command found so no 'NvidiaGpu' tests will run
--
```
Thanks,
Kevin Klues
b0f58035c7c819b42e5f249fadd97312f9e3ac7b
Diff: https://reviews.apache.org/r/45715/diff/
Testing
---
Thanks,
Kevin Klues
org/r/45806/#comment192283>
Assuming this is the right fix, you probably need DESTDIR here too
- Kevin Klues
On April 14, 2016, 3:23 a.m., zhou xing wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
recent updates, so it
failed on the uninstall (which is now fixed). Could you push this review one
more time to trigger the ReviewBot again to verify that it actually works? (I
tested locally and it seems to).
- Kevin Klues
On April 14, 2016, 4:24 a.m., zhou xing wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/#review128834
---
Ship it!
Ship It!
- Kevin Klues
On April 14, 2016, 4:23 a.m
test procedure for
verifying that this all works as expected. I'd suggest for @vinode to think
about touchig up the commit messages a bit.
Other than that, looks great! Thanks for all your work on this!
- Kevin Klues
On April 13, 2016, 2:57 a.m., zhou xing wrote
in the bugs field with MESOS-3782
Also, for reference, this is an add-on to https://reviews.apache.org/r/45806
for changes in the 3rdparty/libprocess files.
- Kevin Klues
On April 13, 2016, 3:57 a.m., zhou xing wrote
------
On April 14, 2016, 8:33 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46220/
> --
views.apache.org/r/46676/
> -------
>
> (Updated April 26, 2016, 6:06 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-52
ce5245883f3d2661812272702c0d2060513b6d88
src/linux/ldcache.hpp PRE-CREATION
src/linux/ldcache.cpp PRE-CREATION
src/tests/ldcache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/47485/diff/
Testing
---
GTEST_FILTER="LdcacheTest.Parse" make check -j
Thanks,
Kevin Klues
check -j
Thanks,
Kevin Klues
ce5245883f3d2661812272702c0d2060513b6d88
src/linux/ldcache.hpp PRE-CREATION
src/linux/ldcache.cpp PRE-CREATION
src/tests/ldcache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/47485/diff/
Testing
---
GTEST_FILTER="LdcacheTest.Parse" make check -j
Thanks,
Kevin Klues
distribution by default).
Diffs (updated)
-
3rdparty/stout/configure.ac ada1e22c72875fe9d557f07e4846128be0bcef13
3rdparty/stout/include/stout/elf.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/47482/diff/
Testing
---
Thanks,
Kevin Klues
://reviews.apache.org/r/47610/diff/
Testing
---
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47625/#review134075
---
Ship it!
Ship It!
- Kevin Klues
On May 20, 2016, 12:55 a.m
on website pages/the new version of the the website/
- Kevin Klues
On May 20, 2016, 3:34 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
updated website.
```
- Kevin Klues
On May 20, 2016, 5:30 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
ted e-mail. To reply, visit:
https://reviews.apache.org/r/47707/#review134329
---
On May 23, 2016, 12:45 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically genera
sit:
> https://reviews.apache.org/r/47719/
>
> On May 23rd, 2016, 5:29 p.m. UTC, *Kevin Klues* wrote:
>
> Looks good. Just curous -- how did you upload the pictures to the testing
> section? Is there someway to make them smaller next time?
>
> LoL I upload it via jira and use 
tor module.
Sure.
> On May 23, 2016, 7:56 p.m., Benjamin Mahler wrote:
> > src/slave/slave.cpp, lines 481-484
> > <https://reviews.apache.org/r/47707/diff/1/?file=1391157#file1391157line481>
> >
> > Could you handle the discarded case? We d
also return additional resources
> > // that it wishes to manage if they were not specified.
> > // For example, a GPU isolator, seeing that "gpus" is unspecified
> > // may probe the system and decide to manage some GPUs (i.e. it
> > // will return
be that the `string` object
> > will be created only once as opposed to being first created and then copied.
OK, good to know.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.
ce5245883f3d2661812272702c0d2060513b6d88
src/linux/ldcache.hpp PRE-CREATION
src/linux/ldcache.cpp PRE-CREATION
src/tests/ldcache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/47485/diff/
Testing
---
GTEST_FILTER="LdcacheTest.Parse" make check -j
Thanks,
Kevin Klues
approach as you suggest.
Need to convince a shepherd though.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47481/#review133904
------
705f132de31ccd2e0180079124ff20b37208356a
Diff: https://reviews.apache.org/r/47601/diff/
Testing
---
`make -j check`
`OS=ubuntu:14.04 COMPILER=gcc CONFIGURATION=--verbose ENVIRONMENT="GLOG_v=1
MESOS_VERBOSE=1" ./support/docker_build.sh`
Thanks,
Kevin Klues
CONFIGURATION=--verbose ENVIRONMENT="GLOG_v=1
MESOS_VERBOSE=1" ./support/docker_build.sh`
Thanks,
Kevin Klues
td::vector` or instead, like
> ```
> std::vector buffer;
> buffer.reserve(BUFSIZ);
> ```
>
> Jan Schlicht wrote:
> Please see the discussion at https://reviews.apache.org/r/47481/ on why
> this isn't any of the suggested types.
>
> Kevin Klues wrote
src/linux/ldcache.hpp PRE-CREATION
src/linux/ldcache.cpp PRE-CREATION
src/tests/ldcache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/47485/diff/
Testing
---
GTEST_FILTER="LdcacheTest.Parse" make check -j
Thanks,
Kevin Klues
represented by the JSON, not the exact JSON strings themselves.
Diffs
-
src/tests/persistent_volume_endpoints_tests.cpp
a57461d881b2bf0175f83b50b0a46167acd5bd3e
Diff: https://reviews.apache.org/r/47708/diff/
Testing
---
make -j check
Thanks,
Kevin Klues
301 - 400 of 1309 matches
Mail list logo
