ework need to
> > re-launch this task again even though this task might already been finished
> > in agent. Can you please add some best practise for this case?
>
> Neil Conway wrote:
> I'm not sure what else we can say here: the best practice we're
> recommend
quot;three or five
> > instances is typical but should be a odd number"
>
> Neil Conway wrote:
> Is an odd number of scheduler instances actually required? Offhand, I
> don't see why, as long as you can reliably elect a leader -- e.g., if you
> have Zk conf
quot; page here (leaving the
"high-availability" page for the operator-centric parts of configuring Mesos to
run in HA mode).
Thanks,
Neil Conway
ll open a
jira.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112882
---
On Jan. 5, 2016, 6:43 a.m., Neil Conway wrote:
>
"high-availability" page for the operator-centric parts of configuring Mesos to
run in HA mode).
Thanks,
Neil Conway
here (leaving the
"high-availability" page for the operator-centric parts of configuring Mesos to
run in HA mode).
Thanks,
Neil Conway
igh-availability" page for the operator-centric parts of configuring Mesos to
run in HA mode).
Thanks,
Neil Conway
/r/41952/diff/
Testing
---
Previewed with site-docker.
Thanks,
Neil Conway
-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb
Diff: https://reviews.apache.org/r/41952/diff/
Testing
---
Previewed with site-docker.
Thanks,
Neil Conway
`configuration.md` and
the content of the various `flags.cpp` files (first thing I checked: "api"
still appears in `src/logging/flags.cpp` but we now use "API" in
`configuration.md`; likely other instances as well).
- Neil Conway
On Jan. 5, 2016, 7:53 p
here (leaving the
"high-availability" page for the operator-centric parts of configuring Mesos to
run in HA mode).
Thanks,
Neil Conway
)
<https://reviews.apache.org/r/42002/#comment173657>
Not you, but I'd say "This will", not "It will".
- Neil Conway
On Jan. 7, 2016, 12:47 a.m., Adam B wrote:
>
> ---
> This is an automat
ibprocess/README.md (line 323)
<https://reviews.apache.org/r/42030/#comment173903>
Do we really have to look at all the code paths within `doHttpGet`? By the
time `getBlob()` returns to the caller (i.e., by the time anyone might satisfy
the future in question), `doHttpGet` must have been called and
(line 254)
<https://reviews.apache.org/r/42040/#comment173938>
I'd just say "endpoint", we said "HTTP" in this sentence already.
docs/quota.md (line 259)
<https://reviews.apache.org/r/42040/#comment173940>
&qu
---
Fixed typos in comments.
Diffs
-
src/python/interface/src/mesos/interface/__init__.py
ce00d5434c0da3778dbab19f5ddc5accf4cd5154
Diff: https://reviews.apache.org/r/42044/diff/
Testing
---
Thanks,
Neil Conway
wonder?
- Neil Conway
On Jan. 8, 2016, 1:29 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Jan. 7, 2016, 11:21 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/README.md, line 323
> > <https://reviews.apache.org/r/42030/diff/1/?file=1186438#file1186438line323>
> >
> > Do we really have to look at all the code paths within `doHttpGet`? By
&g
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 226
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line226>
> >
> > Fix this link -- probably just link to roles.md. Although we don't
> > really c
ed"
docs/quota.md (line 175)
<https://reviews.apache.org/r/42040/#comment174243>
"reregister"
docs/quota.md (line 176)
<https://reviews.apache.org/r/42040/#comment174244>
add "or" at the end of the first bullet point
- Neil Conway
On Jan. 8
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41567/#review113438
---
On Dec. 18, 2015, 9:30 p.m., Neil Conway wrote:
>
> ---
> Th
69ddf906f2041bba84d7e1a20f90ee18817b4e64
src/tests/role_tests.cpp 91a6d27158a21ae11dd310dd1f55922dc147e6f3
Diff: https://reviews.apache.org/r/41567/diff/
Testing
---
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41810/#review113623
---
Should this also update `v1/mesos.proto`?
- Neil Conway
On Dec
/src/tests/metrics_tests.cpp
b84dc8d858f58bc9f52b218b7153510417cf34c2
Diff: https://reviews.apache.org/r/42121/diff/
Testing
---
./3rdparty/libprocess/libprocess-tests
--gtest_filter="MetricsTest.SnapshotTimeout" --gtest_repeat=2000
--gtest_break_on_failure
Thanks,
Neil Conway
h-availability" page here (leaving the
"high-availability" page for the operator-centric parts of configuring Mesos to
run in HA mode).
Thanks,
Neil Conway
://reviews.apache.org/r/42153/diff/
Testing
---
Thanks,
Neil Conway
06231d96c6c99cada0cd46d6ef1e3f64039215c2
3rdparty/libprocess/src/process.cpp 7fd278a3672f5f57e667520e91dbaa30eb16c3ed
3rdparty/libprocess/src/tests/http_tests.cpp
e5999d8b49937a17033482c21536edb5c10420e6
Diff: https://reviews.apache.org/r/42152/diff/
Testing
---
Thanks,
Neil Conway
Description
---
stout: Fixed typo in warning message.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp
82596edb365f8c259ead23c05f9e6e2eab565d32
Diff: https://reviews.apache.org/r/42151/diff/
Testing
---
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113815
---
Ship it!
Ship It!
- Neil Conway
On Jan. 11, 2016, 6:51 p.m
tps://reviews.apache.org/r/42172/#comment174814>
Maybe clarify that `ContainerLogger` is a Mesos module, and link to the
module documentation immediately? (I know we link below but we could make it
more obvious.)
Overall, looks good!
- Neil Conway
On Jan. 12, 2016, 1:07 a.m., Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review114040
---
Ship it!
Ship It!
- Neil Conway
On Jan. 12, 2016, 7:24 p.m
Thanks,
Neil Conway
://reviews.apache.org/r/42208/diff/
Testing
---
mesos-tests --gtest_repeat=25 --gtest_break_on_failure # fails
deterministically w/o patch
Thanks,
Neil Conway
3a89e0ac3029f4a33
src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
Diff: https://reviews.apache.org/r/41806/diff/
Testing
---
make check
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42121/#review113827
---
On Jan. 10, 2016, 8:33 p.m., Neil Conway wrote:
>
>
/#review114086
---
On Jan. 12, 2016, 8:47 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41806/
tatus_update_manager_tests.cpp
bd34b97a3559a5fea9a7a253a89e0ac3029f4a33
src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
Diff: https://reviews.apache.org/r/41806/diff/
Testing
---
make check
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42216/#review114271
---
Ship it!
Ship It!
- Neil Conway
On Jan. 12, 2016, 10:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42262/#review114272
---
Ship it!
Ship It!
- Neil Conway
On Jan. 13, 2016, 8:38 p.m
message?
- Neil Conway
On Jan. 13, 2016, 12:05 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
?
- Neil Conway
On Jan. 12, 2016, 10:27 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/
Testing
---
Ran the test a few hundred times with and without the change; without the
change, a warning is observed. With the change, no warning is observed.
Thanks,
Neil Conway
/r/42265/diff/
Testing
---
Ran each test a few hundred times with and without the changes; without the
changes, a warning is observed. With the changes, no warning is observed.
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42269/#review114297
---
Ship it!
Ship It!
- Neil Conway
On Jan. 13, 2016, 10:06 p.m
tps://reviews.apache.org/r/42386/#comment175723>
Should be "bool", not "const bool&".
- Neil Conway
On Jan. 16, 2016, 5 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically gen
`foreach` here.
src/tests/hierarchical_allocator_tests.cpp (line 2216)
<https://reviews.apache.org/r/41672/#comment175804>
"Adding a framework"
src/tests/hierarchical_allocator_tests.cpp (line 2228)
<https://reviews.apache.org/r/41672/#comment175806>
Whitespace after the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42457/#review115048
---
Ship it!
Ship It!
- Neil Conway
On Jan. 18, 2016, 1:20 p.m
> On Jan. 18, 2016, 8:29 a.m., Neil Conway wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2096-2101
> > <https://reviews.apache.org/r/41672/diff/6/?file=1181569#file1181569line2096>
> >
> > I think we should make `i` an `int`, not `unsigned
7fe566770bbd802111885de061a53a3edf914840
Diff: https://reviews.apache.org/r/42265/diff/
Testing
---
Ran each test a few hundred times with and without the changes; without the
changes, a warning is observed. With the changes, no warning is observed.
Thanks,
Neil Conway
/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a
Diff: https://reviews.apache.org/r/41952/diff/
Testing
---
Previewed with site-docker.
Thanks,
Neil Conway
f969975f242f7fc7a8b7a89e3e211d2201c9114a
Diff: https://reviews.apache.org/r/41952/diff/
Testing
---
Previewed with site-docker.
Thanks,
Neil Conway
.
Repository: mesos
Description
---
Added discussion about allowing multiple frameworks in a role.
Diffs
-
docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb
Diff: https://reviews.apache.org/r/42517/diff/
Testing
---
Previewed on github.
Thanks,
Neil Conway
609a63cbff2d9c652af45ba16152ce3caf48
Diff: https://reviews.apache.org/r/42517/diff/
Testing
---
Previewed on github.
Thanks,
Neil Conway
://reviews.apache.org/r/42517/diff/
Testing (updated)
---
Previewed on github.
Note that the link to `roles.md` doesn't work at the moment, but I believe it
should work once Joerg's fix for the `Rakefile` is merged.
Thanks,
Neil Conway
/whitelist_watcher.cpp 14d7de751884d4734942e315e61a94c29868ff4b
src/zookeeper/detector.cpp a3d68c12e3800805a35f9bb05e7689830eedbae6
Diff: https://reviews.apache.org/r/42615/diff/
Testing
---
"make check" on OSX and Arch Linux.
Thanks,
Neil Conway
c0be974ea2dc74c63ec3561403b3f4d3722a8df3
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55
Diff: https://reviews.apache.org/r/42617/diff/
Testing
---
"make check" on OSX and Arch Linux.
Thanks,
Neil Conway
/
Testing
---
"make check" on OSX and Arch Linux.
Thanks,
Neil Conway
example,
`GLOG_v`.
- Neil Conway
On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/42673/diff/
Testing
---
Verified that GMock warnings are observed w/o this review; after applying the
review and running `--gtest_repeat=100`, no warnings were observed.
Thanks,
Neil Conway
well? Note that the bugs in the old approach are a lot
less likely to occur when the struct has a lot of fields.
Thanks,
Neil Conway
---
Seems like these snuck in due to copy-and-pastes that were concurrent with the
patch to fixup the rest of the instances of this comment.
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42704/#review116043
---
Ship it!
Ship It!
- Neil Conway
On Jan. 25, 2016, 5:44 a.m
g/r/42733/#comment177166>
This is actually correct as written, no? i.e., if principal isn't set,
`principal()` will return the empty string. Since an empty string isn't a legal
principle, the comparison should just work, I believe.
- Neil Conway
On Jan. 25, 2016, 9:02 p.m.,
/
Testing
---
Thanks,
Neil Conway
check that two reservations with the same role but different
principals are considered distinct.
Diffs
-
src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
Diff: https://reviews.apache.org/r/42751/diff/
Testing
---
Thanks,
Neil Conway
(updated)
---
make check
Thanks,
Neil Conway
Diff: https://reviews.apache.org/r/42752/diff/
Testing
---
Thanks,
Neil Conway
,
Neil Conway
---
Added documentation for labeled reserved resources.
Diffs
-
docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
Diff: https://reviews.apache.org/r/42755/diff/
Testing
---
Thanks,
Neil Conway
Diff: https://reviews.apache.org/r/42754/diff/
Testing
---
make check
Thanks,
Neil Conway
/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45
src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5
Diff: https://reviews.apache.org/r/42754/diff/
Testing
---
make check
Thanks,
Neil Conway
om the middle of a
`RepeatedPtrField` requires moving the suffix of the vector down by one element.
- Neil Conway
On Jan. 26, 2016, 12:10 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail.
g/r/42762/#comment177237>
Would `static constexpr` be better?
- Neil Conway
On Jan. 26, 2016, 12:10 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Jan. 26, 2016, 12:29 a.m., Neil Conway wrote:
> > src/common/roles.cpp, line 59
> > <https://reviews.apache.org/r/42762/diff/1/?file=1220834#file1220834line59>
> >
> > Would `static constexpr` be better?
>
> Benjamin Bannier wrote:
> A `st
---
Fixed a typo in an example framework.
Diffs
-
src/examples/load_generator_framework.cpp
d84e36af586c47c4bf6b26b9df8120884c024ffd
Diff: https://reviews.apache.org/r/42765/diff/
Testing
---
Thanks,
Neil Conway
---
Removed an unused variable.
Diffs
-
src/jvm/jvm.cpp d831c9da1d82d5e745537a8eea71e0faad60334a
Diff: https://reviews.apache.org/r/42766/diff/
Testing
---
make check
Thanks,
Neil Conway
/diff/
Testing
---
make check
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42761/#review116277
---
Ship it!
Ship It!
- Neil Conway
On Jan. 26, 2016, 5:38 a.m
+` operator depend on
`operator+` being implemented correctly.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review116289
-----
/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45
src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5
Diff: https://reviews.apache.org/r/42754/diff/
Testing
---
make check
Thanks,
Neil Conway
s://reviews.apache.org/r/42754/#review116304
-------
On Jan. 26, 2016, 6:34 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42787/#review116402
---
Ship it!
Ship It!
- Neil Conway
On Jan. 26, 2016, 7:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42788/#review116403
---
Ship it!
Ship It!
- Neil Conway
On Jan. 26, 2016, 7:41 a.m
<https://reviews.apache.org/r/42786/#comment177444>
Should just be `string`, not `std::string`.
- Neil Conway
On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To
nd in a period.
support/endpoint-docs.cpp (line 328)
<https://reviews.apache.org/r/42789/#comment177451>
Comment should end in a period.
support/endpoint-docs.cpp (line 383)
<https://reviews.apache.org/r/42789/#comment177450>
Comment should end in
791/#comment177511>
Should capitalize "HTTP" (both times).
- Neil Conway
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
516>
This shouldn't be necessary now that we have implicit roles.
- Neil Conway
On Jan. 20, 2016, 6:08 a.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/
Testing
---
make check
Thanks,
Neil Conway
.
Thanks,
Neil Conway
on OSX and Arch Linux.
Thanks,
Neil Conway
k" on OSX and Arch Linux.
Thanks,
Neil Conway
---
Fixed some typos.
Diffs
-
docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
src/slave/containerizer/mesos/isolators/posix/disk.cpp
fd9b3abfe2c502c69ba7b2f0b2015fe90888d5bc
Diff: https://reviews.apache.org/r/42900/diff/
Testing
---
Thanks,
Neil Conway
---
Fixed a few typos in the HA framework guide.
Diffs
-
docs/high-availability-framework-guide.md
3d429d85edce695f608320cab05cdafdafa4a42e
Diff: https://reviews.apache.org/r/42901/diff/
Testing
---
Thanks,
Neil Conway
/
Testing
---
make check
Thanks,
Neil Conway
---
stout: Mark an unused function parameter appropriately.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
a3dc7697f5f041a503e4aa84df67c915c43b76b5
Diff: https://reviews.apache.org/r/42971/diff/
Testing
---
make check
Thanks,
Neil Conway
---
stout: Fixed typo (unintended inequality between pointer value and 0).
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
2a188459465a5203c56d788a74e69d403790c5bf
Diff: https://reviews.apache.org/r/42972/diff/
Testing
---
make check
Thanks,
Neil Conway
/process.hpp
1e4126f1082c24debd9d713b490d18f5ed83f0be
Diff: https://reviews.apache.org/r/42973/diff/
Testing
---
make check
Thanks,
Neil Conway
---
libprocess: Removed unused variable.
Diffs
-
3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
Diff: https://reviews.apache.org/r/42974/diff/
Testing
---
make check
Thanks,
Neil Conway
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/#review116993
---
On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
>
> ---
> This is an automatic
OTNULL` before this statement now?
>
> Neil Conway wrote:
> Is there value in doing that? In principle, we'd need a `CHECK_NOTNULL`
> before dereferencing _any_ pointer, which seems like it would add a lot of
> clutter...
>
> Anand Mazumdar wrote:
> Certainly.
80e80853e1b99
src/zookeeper/zookeeper.hpp 573ff5bca56cbb7efb98f6eb4f1796a2bc176b5e
src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8
Diff: https://reviews.apache.org/r/42987/diff/
Testing
---
make check
Thanks,
Neil Conway
701 - 800 of 2193 matches
Mail list logo
