eed to keep stuff in sync?
Same for all other references of that flag / help messages?
- Till Toenshoff
On May 20, 2016, 2:40 a.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47786/#review134728
---
Ship it!
Ship It!
- Till Toenshoff
On May 24, 2016, 6:06
running a
`bootstrap` I am getting
```
configure.ac:62: error: required file '3rdparty/Makefile.in' not found
configure.ac:64: error: required file '3rdparty/gmock_sources.cc.in' not found
```
- Till Toenshoff
On May 24, 2016, 2:49 a.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47610/#review134749
---
Ship it!
Ship It!
- Till Toenshoff
On May 20, 2016, 12:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47609/#review134750
---
Ship it!
Ship It!
- Till Toenshoff
On May 19, 2016, 6:08
n do a much better job than I ever
could for such updated comment :)
Please note that we commonly have the "link" to the JIRA issue as trailing
sentence; "... See MESOS-."
- Till Toenshoff
On May 25, 2016, 6:4
Greg for taking the time
and typing in the comments as discussed verbally - much appreciated :).
- Till Toenshoff
On May 23, 2016, 4:37 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Greg for taking the time
and typing in the comments as discussed verbally - much appreciated :).
- Till Toenshoff
On May 25, 2016, 6:08 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47519/#review135091
---
Ship it!
Ship It!
- Till Toenshoff
On May 18, 2016, 8:04
Greg for taking the time
and typing in the comments as discussed verbally - much appreciated :).
- Till Toenshoff
On May 18, 2016, 8:04 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Greg for taking the time
and typing in the comments as discussed verbally - much appreciated :).
- Till Toenshoff
On May 18, 2016, 8:05 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Greg for taking the time
and typing in the comments as discussed verbally - much appreciated :).
- Till Toenshoff
On May 18, 2016, 8:06 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47516/#review135096
---
Ship it!
Ship It!
- Till Toenshoff
On May 18, 2016, 8:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48033/#review135492
---
Ship it!
Ship It!
- Till Toenshoff
On May 30, 2016, 10:23
this was
0ba45c8c0af084bd8a2278170f9ab0a8467d631d (https://reviews.apache.org/r/48010)
- Till Toenshoff
On May 30, 2016, 10:21 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviews.apache.org/r/48039/#comment200501>
Is there a JIRA around introducing LocalAuthorizer specific deprecation
cycles - I would like to understand why we are not pushing this request out to
any authorizer (module).
- Till Toenshoff
On May 30, 2016, 1:17 p.m., Michael Park
906/#comment200503>
This looks borked.
- Till Toenshoff
On May 26, 2016, 5:04 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/#comment200506>
Missing?
```
#include
```
```
#include
```
- Till Toenshoff
On May 26, 2016, 5:57 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
creating a local const in the first place?
src/tests/main.cpp (line 31)
<https://reviews.apache.org/r/47123/#comment200509>
Insert blank line.
- Till Toenshoff
On May 26, 2016, 5:04 p.m., Kapil Arya wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47906/#review135519
---
Ship it!
Ship It!
- Till Toenshoff
On May 30, 2016, 2:43
g/r/48048/#comment200542>
s/whoe/whose
docs/authorization.md (line 132)
<https://reviews.apache.org/r/48048/#comment200545>
I have trouble understanding
```
_It still takes types ANY and NONE to allow or deny access._
```
Why "still" - in wh
/mesos/authorizer/authorizer.proto 0142476
Diff: https://reviews.apache.org/r/47505/diff/
Testing
---
make check (OSX)
Thanks,
Till Toenshoff
reply, visit:
https://reviews.apache.org/r/47505/#review133707
-------
On May 31, 2016, 5:59 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically
to upgrade the messages in the future.
Yup, follow-up coming.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47505/#review133707
-------
On May 31, 2016, 5:59 p.m., Till Toenshoff wrote:
>
://reviews.apache.org/r/47505/diff/
Testing
---
make check (OSX)
Thanks,
Till Toenshoff
/authorizer.proto
0142476a2f9c905aafd3e41adc9842445c9309e7
Diff: https://reviews.apache.org/r/47505/diff/
Testing
---
make check (OSX)
Thanks,
Till Toenshoff
Vinod Kone.
Repository: mesos
Description
---
see summary.
Diffs
-
src/authorizer/local/authorizer.cpp 29bcb404c390bfb446af11796836a4a8181bbeee
Diff: https://reviews.apache.org/r/48085/diff/
Testing
---
make check
Thanks,
Till Toenshoff
Schad, and Vinod Kone.
Repository: mesos
Description
---
Updated comments in authorizer.proto.
Diffs
-
include/mesos/authorizer/authorizer.proto
0142476a2f9c905aafd3e41adc9842445c9309e7
Diff: https://reviews.apache.org/r/48093/diff/
Testing
---
Thanks,
Till Toenshoff
/
Testing
---
make check
Thanks,
Till Toenshoff
-----
On May 31, 2016, 9:15 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48093/
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48132/#review135806
---
Ship it!
Ship It!
- Till Toenshoff
On June 1, 2016, 4:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48133/#review135807
---
Ship it!
Ship It!
- Till Toenshoff
On June 1, 2016, 4:14
Description
---
see summary.
Diffs
-
src/tests/authorization_tests.cpp bcad250b4376ba71b04e5280ec6e4cd17abd8ae6
Diff: https://reviews.apache.org/r/48137/diff/
Testing
---
make check
Thanks,
Till Toenshoff
141/#comment200893>
Can we be sure that all Mesos supported versions of Maven actually support
this flag?
- Till Toenshoff
On June 1, 2016, 8:21 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail.
workaround Benjamin!
src/Makefile.am (line 2086)
<https://reviews.apache.org/r/48164/#comment200928>
Let's add a comment explaining this move, please.
- Till Toenshoff
On June 2, 2016, 9:31 a.m., Benjamin Bannier wrote:
>
> -
> On June 2, 2016, 9:36 a.m., Till Toenshoff wrote:
> > Thanks for testing a supplying a neat workaround Benjamin!
s/a supplying/and supplying/
- Till
---
This is an automatically generated e-mail. To reply, vis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48164/#review135936
---
Ship it!
Ship It!
- Till Toenshoff
On June 2, 2016, 12:13
apil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47930/
> ---
>
> (Updated May 26, 2016, 11:30 p.m.)
>
>
> Review request for mesos and Till To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47755/#review136188
---
Ship it!
Ship It!
- Till Toenshoff
On May 24, 2016, 2:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47756/#review136189
---
Ship it!
Ship It!
- Till Toenshoff
On May 24, 2016, 2:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47924/#review136190
---
Ship it!
Ship It!
- Till Toenshoff
On May 26, 2016, 11:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47925/#review136191
---
Ship it!
Ship It!
- Till Toenshoff
On May 26, 2016, 11:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47928/#review136192
---
Ship it!
Ship It!
- Till Toenshoff
On June 4, 2016, 7:04
so, how does that work with a non-bundled parser?
Finally, why are we calling this "libry_http_parser" and not
"libhttp_parser"?
- Till Toenshoff
On May 26, 2016, 11:30 p.m., Kapil Arya wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47931/#review136194
---
Ship it!
Ship It!
- Till Toenshoff
On June 4, 2016, 7:01
pache.org/r/47932/#comment201209>
Wrong header again, use the "Apache License Version 2.0" header instead.
- Till Toenshoff
On May 26, 2016, 11:30 p.m., Kapil Arya wrote:
>
> ---
> This is an automaticall
.org/r/47929/#comment201211>
Wrong header, use the "Apache License Version 2.0" header.
- Till Toenshoff
On May 26, 2016, 11:30 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48246/#review136198
---
Ship it!
Ship It!
- Till Toenshoff
On June 4, 2016, 2:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48245/#review136199
---
Ship it!
Ship It!
- Till Toenshoff
On June 4, 2016, 2:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48247/#review136197
---
Ship it!
Ship It!
- Till Toenshoff
On June 4, 2016, 2:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48244/#review136200
---
Ship it!
- Till Toenshoff
On June 4, 2016, 2:29 a.m., Neil
244/#comment201212>
I was too slow when trying to commit this. Needs rebase now, sorry.
- Till Toenshoff
On June 4, 2016, 2:29 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48263/#review136425
---
Ship it!
Ship It!
- Till Toenshoff
On June 6, 2016, 8:22
il. To reply, visit:
> https://reviews.apache.org/r/48263/
> ---
>
> (Updated June 6, 2016, 8:22 a.m.)
>
>
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-5405
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review136426
---
Ship it!
Ship It!
- Till Toenshoff
On June 6, 2016, 3:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48269/#review136632
---
Ship it!
Ship It!
- Till Toenshoff
On June 6, 2016, 10:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48409/#review137269
---
Ship it!
Ship It!
- Till Toenshoff
On June 8, 2016, 1:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48420/#review137270
---
Ship it!
Ship It!
- Till Toenshoff
On June 8, 2016, 4:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48626/#review137271
---
Ship it!
Ship It!
- Till Toenshoff
On June 13, 2016, 9:54
tps://reviews.apache.org/r/48598/#comment202429>
Would it make sense to link the authorization documentation here?
- Till Toenshoff
On June 13, 2016, 9:50 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e
12:03 a.m.)
>
>
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, Kapil Arya, Jan
> Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This gives external projects easier access to the test
971 - 1980)
<https://reviews.apache.org/r/47374/#comment202408>
Good point, I very much agree.
- Till Toenshoff
On June 11, 2016, 12:03 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48206/#review137645
---
Ship it!
Ship It!
- Till Toenshoff
On June 3, 2016, 2:31
> On June 14, 2016, 12:26 a.m., Till Toenshoff wrote:
> > Overall, I am not convinced this is reaching the goals we have just yet...
> >
> > Let me try to specify our goals;
> > (a) we want to enable mesos-modules (tests) to reuse our test helpers/utils
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48495/#review137971
---
Ship it!
Ship It!
- Till Toenshoff
On June 15, 2016, 7:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48496/#review137972
---
Ship it!
Ship It!
- Till Toenshoff
On June 15, 2016, 6:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48497/#review137977
---
Ship it!
Ship It!
- Till Toenshoff
On June 16, 2016, 1:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48765/#review137989
---
Ship it!
Ship It!
- Till Toenshoff
On June 16, 2016, 12:56
> On June 16, 2016, 3 p.m., Till Toenshoff wrote:
> > Ship It!
Will fix the tiny comment typo while committing.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48765/#rev
-framework-development-guide.md (line 312)
<https://reviews.apache.org/r/48790/#comment203239>
s/by/on/
- Till Toenshoff
On June 16, 2016, 1:01 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
.org/r/48789/#comment203236>
one space less
src/tests/authorization_tests.cpp (line 2242)
<https://reviews.apache.org/r/48789/#comment203238>
s/a//
src/tests/authorization_tests.cpp (line 2243)
<https://reviews.apache.org/r/48789/#comment203237>
s/awithout/without/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48806/#review138099
---
Ship it!
Ship It!
- Till Toenshoff
On June 16, 2016, 6 p.m
---
>
> (Updated June 16, 2016, 10:06 a.m.)
>
>
> Review request for mesos, Joerg Schad and Till Toenshoff.
>
>
> Bugs: MESOS-5588
> https://issues.apache.org/jira/browse/MESOS-5588
>
>
> Repository: mesos
>
>
> Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48764/#review138119
---
Ship it!
Ship It!
- Till Toenshoff
On June 16, 2016, 5:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48635/#review138123
---
Ship it!
Ship It!
- Till Toenshoff
On June 13, 2016, 1:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48684/#review138126
---
Ship it!
Ship It!
- Till Toenshoff
On June 14, 2016, 12:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48781/#review138198
---
Ship it!
Ship It!
- Till Toenshoff
On June 17, 2016, 9:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48849/#review138239
---
Ship it!
Ship It!
- Till Toenshoff
On June 17, 2016, 2:22
/48919/diff/
Testing
---
make check & functional testing.
Thanks,
Till Toenshoff
/
Testing
---
make check & functional testing.
Thanks,
Till Toenshoff
703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48920/diff/
Testing
---
make check & functional testing.
Thanks,
Till Toenshoff
-
src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0
Diff: https://reviews.apache.org/r/48923/diff/
Testing
---
make check & functional testing.
Thanks,
Till Toenshoff
(lines 94 - 95)
<https://reviews.apache.org/r/48925/#comment203624>
Remove the whitespaces here please - then, to make it fit into 80 chars,
break at the argument.
```
response.mutable_get_weights()->add_weight_infos()->CopyFrom(
weightInfo);
```
- Till To
/
Testing
---
Thanks,
Till Toenshoff
reg Mann, and Kapil Arya.
>
>
> Bugs: MESOS-5637
> https://issues.apache.org/jira/browse/MESOS-5637
>
>
> Repository: mesos
>
>
> Description
> ---
>
> see summary.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/src/process.cpp
> 703f673a98102958c5e2b0c1833efad2ddc53ef8
>
> Diff: https://reviews.apache.org/r/48919/diff/
>
>
> Testing
> ---
>
> make check & functional testing.
>
>
> Thanks,
>
> Till Toenshoff
>
>
thorizer fails to process the request.
Like it - ty!
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48932/#review138493
-----
.apache.org/r/48918/#review138488
---
On June 19, 2016, 3:02 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48937/#review138509
---
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2016, 12:12
/libprocess/src/process.cpp 703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48919/diff/
Testing
---
make check & functional testing.
Thanks,
Till Toenshoff
the problem.
Diffs (updated)
-
3rdparty/libprocess/src/process.cpp 703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48920/diff/
Testing
---
make check & functional testing.
Thanks,
Till Toenshoff
aed56300f1090c816ab2893c20e87fd37230a9a7
Diff: https://reviews.apache.org/r/48932/diff/
Testing
---
Thanks,
Till Toenshoff
703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48919/diff/
Testing (updated)
---
make check (OSX and some Linux distros)
Thanks,
Till Toenshoff
/libprocess/src/process.cpp 703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48920/diff/
Testing (updated)
---
make check (OSX and some Linux distros) & functional testing.
Thanks,
Till Toenshoff
://reviews.apache.org/r/48918/diff/
Testing (updated)
---
make check (OSX and some Linux distros)
Thanks,
Till Toenshoff
will now receive a
ServiceUnavailable.
Diffs
-
src/tests/slave_tests.cpp ad36b74c12e52435b356bced1d15bd33983949e0
Diff: https://reviews.apache.org/r/48923/diff/
Testing (updated)
---
make check (OSX and some Linux distros)
Thanks,
Till Toenshoff
e here to make that more obvious.
How about:
```
NOTE: When adding new actions to these proto definitions that entities in
these messages are `required`. Absent ...
```
- Till Toenshoff
On June 20, 2016, 12:12 a.m., Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48920/#review138547
-------
On June 20, 2016, 5:49 a.m., Till Toenshoff wrote:
>
> -
/libprocess/src/process.cpp 703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48919/diff/
Testing
---
make check (OSX and some Linux distros)
Thanks,
Till Toenshoff
the problem.
Diffs (updated)
-
3rdparty/libprocess/src/process.cpp 703f673a98102958c5e2b0c1833efad2ddc53ef8
Diff: https://reviews.apache.org/r/48920/diff/
Testing
---
make check (OSX and some Linux distros) & functional testing.
Thanks,
Till Toenshoff
aed56300f1090c816ab2893c20e87fd37230a9a7
Diff: https://reviews.apache.org/r/48932/diff/
Testing
---
Thanks,
Till Toenshoff
801 - 900 of 1274 matches
Mail list logo
