t the connection breaks.
- Anand Mazumdar
On Dec. 4, 2017, 6:04 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
src/master/master.cpp
Line 2671 (original), 2671 (patched)
<https://reviews.apache.org/r/63674/#comment267868>
While you are at it you can remove the bit about the driver since this
function only applies to the HTTP based frameworks.
- Anand Mazumdar
On Nov. 8, 2017, 5:31 p.m.
> On Oct. 14, 2017, 1:40 a.m., Anand Mazumdar wrote:
> > src/tests/scheduler_http_api_tests.cpp
> > Lines 737-747 (patched)
> > <https://reviews.apache.org/r/62241/diff/1/?file=1820104#file1820104line737>
> >
> > Kill this? We don't need this to te
src/tests/scheduler_http_api_tests.cpp
Lines 737-747 (patched)
<https://reviews.apache.org/r/62241/#comment265135>
Kill this? We don't need this to test if the downgrade worked.
- Anand Mazumdar
On Sept. 12, 2017, 12:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62240/#review188052
---
Ship it!
Ship It!
- Anand Mazumdar
On Sept. 12, 2017, 12:59
-----
On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62479/
>
> This ensures agent doesn't recover old live executors.
> > Step 2: Restart the agent.
> > ```
>
> Vinod Kone wrote:
> this seems problematic, though i can't easily tell which test is
> breaking. GarbageCollectorIntegrationTe
/62481/diff/3/
Changes: https://reviews.apache.org/r/62481/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
/62481/diff/3/
Changes: https://reviews.apache.org/r/62481/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
anges: https://reviews.apache.org/r/62554/diff/4-5/
Testing
---
make check
Thanks,
Anand Mazumdar
b5fc45887e25345d49feb4975f6256cfd7b0fe55
Diff: https://reviews.apache.org/r/62477/diff/4/
Changes: https://reviews.apache.org/r/62477/diff/3-4/
Testing
---
make check
Thanks,
Anand Mazumdar
https://reviews.apache.org/r/62554/diff/3-4/
Testing
---
make check
Thanks,
Anand Mazumdar
/
Testing
---
make check
Thanks,
Anand Mazumdar
ving the `latest` symlink. What
do you think?
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/#review186171
----
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62479/#review186180
---
On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
>
> ---
>
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/62478/#review186177
-------
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> ---
>
: https://reviews.apache.org/r/62481/diff/2/
Changes: https://reviews.apache.org/r/62481/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
ps://reviews.apache.org/r/62477/#review186176
-------
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail.
sting
---
make check
Thanks,
Anand Mazumdar
Restart the agent.
> > ```
>
> Andrew Schwartzmeyer wrote:
> This appears to be failing due to
> https://issues.apache.org/jira/browse/MESOS-7604. If you want to use
> `TEST_F_TEMP_DISABLED_ON_WINDOWS` that'd be fine, and add a `//
> TODO(andschwa): En
s.cpp d260a1c9560e8ff6b46eea7f2f4ddb11e18653e3
Diff: https://reviews.apache.org/r/62531/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
ched)
<https://reviews.apache.org/r/62478/#comment262407>
Separate this into two functions.
- Anand Mazumdar
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mai
://reviews.apache.org/r/62475/diff/4/
Changes: https://reviews.apache.org/r/62475/diff/3-4/
Testing
---
make check
Thanks,
Anand Mazumdar
aking it `repeated`.
- Anand Mazumdar
On Sept. 21, 2017, 9:38 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
://issues.apache.org/jira/browse/MESOS-8007
Repository: mesos
Description
---
See summary.
Diffs
-
docs/operator-http-api.md f6cfcf1b8bbdc79fac2f361fb770546baf01d992
Diff: https://reviews.apache.org/r/62507/diff/1/
Testing
---
Verified that the doc renders fine.
Thanks,
Anand
dfba4181203e23f7eedf67c19379d031e0993fd5
Diff: https://reviews.apache.org/r/62476/diff/2/
Changes: https://reviews.apache.org/r/62476/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
://reviews.apache.org/r/62475/diff/3/
Changes: https://reviews.apache.org/r/62475/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
://reviews.apache.org/r/62475/diff/2/
Changes: https://reviews.apache.org/r/62475/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
_tests.cpp d260a1c9560e8ff6b46eea7f2f4ddb11e18653e3
Diff: https://reviews.apache.org/r/62480/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
5581861e8ff834b4e79a51bef5f28aac7e7d259d
src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
Diff: https://reviews.apache.org/r/62481/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
behavior when they come back post a reboot.
Diffs
-
src/slave/slave.cpp 01020a624bdd67ee6371f607d897ad71a2cdcc82
Diff: https://reviews.apache.org/r/62479/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
dation.cpp a6e6a90af7d8d1242e28e93af551a2096db62939
Diff: https://reviews.apache.org/r/62478/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
---
make check
Thanks,
Anand Mazumdar
Diff: https://reviews.apache.org/r/62476/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
new agent.
Diffs
-
include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
Diff: https://reviews.apache.org/r/62475/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
7;t had
a dependency in the past.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62148/#review184823
-------
On Se
r.cpp ce69258027ed50867569374d2d827fc3cc651744
src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554
Diff: https://reviews.apache.org/r/62148/diff/1/
Testing (updated)
---
make check (Ensured tests still work when run in a loop)
Thanks,
Anand Mazumdar
s.hpp 444c75763aea995708db0b17eafee2d22c912554
Diff: https://reviews.apache.org/r/62148/diff/1/
Testing
---
Thanks,
Anand Mazumdar
How about:
"Disconnected with the Mesos master; invoking the disconnected callback" to
be consistent with the registered logging message?
- Anand Mazumdar
On Aug. 31, 2017, 7:09 a.m., Alexander Rukletsov wrote:
>
>
Ditto as above. We shouldn't double log here.
- Anand Mazumdar
On Aug. 30, 2017, 2:14 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/#review184204
---
Ship it!
Thanks for the cleanup!
- Anand Mazumdar
On Aug
mimic the invariant of
the v1 interface that we can only receive an event after successfully
connecting with the master?
- Anand Mazumdar
On Aug. 30, 2017, 2:16 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatica
these new helpers first to be
consistent within this file.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61575/#review182895
://reviews.apache.org/r/61575/diff/4/
Changes: https://reviews.apache.org/r/61575/diff/3-4/
Testing
---
make check
Thanks,
Anand Mazumdar
/
Testing
---
sudo make check (tests pass)
Thanks,
Anand Mazumdar
iff: https://reviews.apache.org/r/61573/diff/4/
Changes: https://reviews.apache.org/r/61573/diff/3-4/
Testing
---
make check
Thanks,
Anand Mazumdar
a1880595ff015475f1ba49437d49f7397da19422
Diff: https://reviews.apache.org/r/61575/diff/3/
Changes: https://reviews.apache.org/r/61575/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61668/diff/3/
Changes: https://reviews.apache.org/r/61668/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61668/diff/2/
Changes: https://reviews.apache.org/r/61668/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
ps://reviews.apache.org/r/61668/#review182974
-------
On Aug. 15, 2017, 5:40 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail.
4bd40c32625bc1f7998d523c6ee81bf78ac74538
src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
Diff: https://reviews.apache.org/r/61574/diff/3/
Changes: https://reviews.apache.org/r/61574/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
https://issues.apache.org/jira/browse/MESOS-6535
Repository: mesos
Description
---
See summary.
Diffs
-
src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61668/diff/1/
Testing
---
make check
Thanks,
Anand
4bd40c32625bc1f7998d523c6ee81bf78ac74538
src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
Diff: https://reviews.apache.org/r/61574/diff/2/
Changes: https://reviews.apache.org/r/61574/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
: https://reviews.apache.org/r/61570/diff/3/
Changes: https://reviews.apache.org/r/61570/diff/2-3/
Testing
---
make check
Thanks,
Anand Mazumdar
e-mail. To reply, visit:
https://reviews.apache.org/r/61573/#review182888
-------
On Aug. 14, 2017, 5:19 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6
b9776314a8781963b92ba9ac297654f61a443bc8
Diff: https://reviews.apache.org/r/61575/diff/2/
Changes: https://reviews.apache.org/r/61575/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
/2/
Changes: https://reviews.apache.org/r/61570/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
nested container.
Diffs (updated)
-
src/slave/http.cpp 2d33f0b498c8c819d1aaa6b39ae38b1009fda3e4
Diff: https://reviews.apache.org/r/61572/diff/2/
Changes: https://reviews.apache.org/r/61572/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
573/diff/2/
Changes: https://reviews.apache.org/r/61573/diff/1-2/
Testing
---
make check
Thanks,
Anand Mazumdar
,
Anand Mazumdar
a003e1b80dc9b4dec5b3fbbadb2daecf855c90c7
Diff: https://reviews.apache.org/r/61571/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
://reviews.apache.org/r/61572/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
eeds to be done instead of using a constant grace
period.
Diffs
-
src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61573/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
9bac9541acd24e1123ca5dd5925e2a1381d13b4a
include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734
Diff: https://reviews.apache.org/r/61569/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
Diff: https://reviews.apache.org/r/61574/diff/1/
Testing
---
make check
Thanks,
Anand Mazumdar
/
Testing
---
make check
Thanks,
Anand Mazumdar
make
this function invoke that? Also, goes for L3751
- Anand Mazumdar
On Aug. 3, 2017, 5:56 p.m., Quinn Leng wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
part. Can you
split the test into a separate review?
src/master/http.cpp
Lines 3791-3823 (patched)
<https://reviews.apache.org/r/61222/#comment257873>
Can this code be shared with the original `teardown()` method of the old
API to avoid duplication?
- Anand Mazumdar
On July 28, 2017
g/r/60508/#comment257821>
Missing indent.
- Anand Mazumdar
On July 26, 2017, 4:46 p.m., Ilya Pronin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
-
>
> (Updated July 27, 2017, 10 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-7246
> https://issues.apache.org/jira/browse/MESOS-7246
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Ad
(patched)
<https://reviews.apache.org/r/61194/#comment257222>
s/re-register/re-registers
- Anand Mazumdar
On July 27, 2017, 10 p.m., Quinn Leng wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60928/#review181593
---
Ship it!
Ship It!
- Anand Mazumdar
On July 25, 2017, 8:24
ched)
<https://reviews.apache.org/r/60929/#comment257180>
Why newline here?
- Anand Mazumdar
On July 18, 2017, 12:18 a.m., Quinn Leng wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60930/#review181587
---
Ship it!
Ship It!
- Anand Mazumdar
On July 18, 2017, 12:23
src/tests/api_tests.cpp
Lines 2082 (patched)
<https://reviews.apache.org/r/60931/#comment257173>
s/As a result, the/The
- Anand Mazumdar
On July 18, 2017, 12:29 a.m., Quinn Leng wrote:
>
> ---
> This is an automatically gen
with the master.
```
src/tests/api_tests.cpp
Lines 2060-2062 (patched)
<https://reviews.apache.org/r/60931/#comment256789>
Kill this. Let's send a request to the `/teardown` endpoint to tear-down
the framework and use that to verify the `FRAMEWORK_REMOVED` event
ed event was that we only store the `AgentID` in
the registry; so the `AgentInfo` is not available to us upon a failover. But,
it seems like we already have `FrameworkInfo` available here.
- Anand Mazumdar
On July 18, 2017, 12:23 a.m., Quin
uld ideally be sent here i.e., for all instances when a
framework is recovered or not.
src/master/master.cpp
Lines 3138-3141 (patched)
<https://reviews.apache.org/r/60929/#comment256774>
Similar comments around where this should be placed as earlier.
- Anand Mazumdar
On July 18
we typically leave a newline after multi line statements. Might
not be needed post my earlier comment.
src/common/protobuf_utils.cpp
Lines 830-838 (patched)
<https://reviews.apache.org/r/60928/#comment256755>
Ditto (new lines)
- Anand Mazumdar
On July 19, 2017, 6:47 p.m.
side `addFramework()` to be consistent with how
`TASK_ADDED` and `TASK_UPDATED` events are being sent i.e., from `addTask()`
and `updateTask()`?
src/master/master.cpp
Lines 3005 (patched)
<https://reviews.apache.org/r/60928/#comment256301>
Kill this; The line is self explanatory
<https://reviews.apache.org/r/59950/#comment251853>
hmm, this would be flaky. We need to do this before sending the accept call?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 1401 (patched)
<https://reviews.apache.org/r/59950/#comment251854>
Kill this.
- An
ews.apache.org/r/59949/#comment251851>
s/here//
src/launcher/default_executor.cpp
Lines 385 (patched)
<https://reviews.apache.org/r/59949/#comment251849>
s/from/from the
- Anand Mazumdar
On June 15, 2017, 12:38 a.m.,
/reviews.apache.org/r/59949/#comment251496>
Also, in addition to the verbosity, can we do it only once since it's the
same for all the tasks in the task group?
See my earlier comments around moving this block outside.
Also, use `'MESOS_CONTAINER_IP'` in quotes insid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59662/#review176528
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59671/#review176526
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59673/#review176482
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59672/#review176480
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:51
`?
- Anand Mazumdar
On May 30, 2017, 11:50 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59670/#review176478
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:50
)
<https://reviews.apache.org/r/59669/#comment249830>
Move this below `std::set`?
- Anand Mazumdar
On May 30, 2017, 11:18 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59668/#review176475
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:18
e this above `checkpointFramework()`?
- Anand Mazumdar
On May 30, 2017, 11:17 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
)
<https://reviews.apache.org/r/59666/#comment249827>
Update the summary/description to `hasTask()` instead of `addTask()`?
- Anand Mazumdar
On May 30, 2017, 11:17 p.m., Jie Yu wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59665/#review176469
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:16
to be private
anymore?
- Anand Mazumdar
On May 30, 2017, 11:16 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59663/#review176467
---
Ship it!
Good catch!
- Anand Mazumdar
On May 30, 2017, 11
tps://reviews.apache.org/r/59662/#comment249825>
hmm, I like it the other way around i.e., since this class has a lot of
public fields, `struct` is more reasonable here. A `class` with default scoping
as `public` seems non-intuitive.
@bmahler what do you think?
- Anand Mazumdar
On May 30, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59661/#review176465
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59660/#review176464
---
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:14
constructor declaration now that it no longer
needs to be private. This would help readability.
- Anand Mazumdar
On May 30, 2017, 11:14 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To r
1 - 100 of 1643 matches
Mail list logo
