Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Feb. 3, 2017, 10:45 a.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1263 > > > > > > Could you follow up with a patch so this call is `dispatch`'ed? > > > > Right n

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Feb. 3, 2017, 10:45 a.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1263 > > > > > > Could you follow up with a patch so this call is `dispatch`'ed? > > > > Right n

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Feb. 3, 2017, 2:45 a.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1263 > > > > > > Could you follow up with a patch so this call is `dispatch`'ed? > > > > Right no

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Feb. 3, 2017, 11:45 a.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1263 > > > > > > Could you follow up with a patch so this call is `dispatch`'ed? > > > > Right n

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Feb. 3, 2017, 2:45 a.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1263 > > > > > > Could you follow up with a patch so this call is `dispatch`'ed? > > > > Right no

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review164111 --- src/master/allocator/mesos/hierarchical.cpp (line 1257)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Jan. 31, 2017, 1:46 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Jan. 31, 2017, 1:41 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review163610 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Jan. 21, 2017, 1:24 a.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1314 > > > > > > We can use the `|=` operator now that it's added. Added, was waiting for that commit =D -

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Jan. 27, 2017, 2:33 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Jan. 19, 2017, 2:45 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1273-1280 > > > > > > This change introduces an additional trip through the allocator's queue > > after

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review162529 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (line 130

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review162229 --- Fix it, then Ship it! The logic looks good to me, just a few mi

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Jan. 12, 2017, 6:55 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Dec. 21, 2016, 6:02 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Dec. 20, 2016, 7:35 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Dec. 20, 2016, 7:20 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Dec. 12, 2016, 9:30 a.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1307 > > > > > > s/a single slaveId/a single `slaveId`/ to be consistent. Changed the wording to describe th

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review158818 --- This patch itself LGTM. Will give ship it once we confirm the flak

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review153345 --- Jacob, regaring the test failure of `OversubscriptionTest.Rescind

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Oct. 18, 2016, 4:14 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 十月 4, 2016, 9:47 p.m., Guangya Liu wrote: > > Jacob, two other comments for this: > > > > 1) when will you have the patch `SmallOfferFilter` ready for review? > > 2) I think we may need another benchmark test which only do two operations: > > a) add multiple agents first 2) add multiple fr

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Oct. 4, 2016, 9:47 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1306 > > > > > > The `addFramework` will call `allocate()` and allocate `all agents > > resources` but not a `s

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Oct. 5, 2016, 1:02 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1313-1318 > > > > > > The intention of making allocate asynchronous and returning a Future is > > that the

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 十月 5, 2016, 1:02 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1313-1318 > > > > > > The intention of making allocate asynchronous and returning a Future is > > that the c

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151436 --- src/master/allocator/mesos/hierarchical.cpp (lines 1305 - 1310) <

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Oct. 4, 2016, 9:47 p.m., Guangya Liu wrote: > > Jacob, two other comments for this: > > > > 1) when will you have the patch `SmallOfferFilter` ready for review? > > 2) I think we may need another benchmark test which only do two operations: > > a) add multiple agents first 2) add multiple

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Oct. 1, 2016, 12:11 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1311 > > > > > > I think that here we should return `Nothing()` but not > > `allocation.get()`, as `allocation

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Oct. 4, 2016, 11:31 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151408 --- Jacob, two other comments for this: 1) when will you have the pat

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Oct. 4, 2016, 9:31 p.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 28, 2016, 9:33 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 224 > > > > > > ``` > > // If no run is queued we only update `allocationCandidates` > > ``` > > >

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151117 --- src/master/allocator/mesos/hierarchical.cpp (line 1303)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review150760 --- src/master/allocator/mesos/hierarchical.hpp (line 224)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 28, 2016, 8:21 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review150508 --- Looking to the test update. src/master/allocator/mesos/hierarchi

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 26, 2016, 4:27 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix, the

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review150281 --- I think that you are still working on the test cases as I saw many

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix, the

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 23, 2016, 2:40 a.m., Guangya Liu wrote: > > It is really weired that the performance of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/7` > > does not improve much when calling `addSlave`, need check more for why > > `addSlave` was same? Without fix, the

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 23, 2016, 4:32 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 21, 2016, 5:41 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 12, 2016, 8:46 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 273-274 > > > > > > It seems a bit odd that the caller has to both touch allocation > > candidates and then

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review148579 --- src/master/allocator/mesos/hierarchical.hpp (lines 227 - 228)

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_B

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_B

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENC

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_B

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_B

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 6:38 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1226-1229 > > > > > > Just nit, I think that we should separate the `_allocate()` and > > `_deallocate()` to

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENC

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147722 --- src/master/allocator/mesos/hierarchical.cpp (lines 483 - 484)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147718 --- src/master/allocator/mesos/hierarchical.cpp (lines 1212 - 1215) <

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 3, 2016, 6:05 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147674 --- Fix it, then Ship it! Modulo comments from others and I'll look

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147648 --- Jacob, can you please help rebase your patch due to some patches r

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 26, 2016, 6:24 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 275 > > > > > > I think we should use `insert(...)` instead of `=`; if the following > > event in the queue, are w

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 26, 2016, 2:24 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 275 > > > > > > I think we should use `insert(...)` instead of `=`; if the following > > event in the queue, are w

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147333 --- Patch looks great! Reviews applied: [51028, 51027] Passed comman

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147321 --- src/master/allocator/mesos/hierarchical.hpp (line 219)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 30, 2016, 4:50 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 30, 2016, 4:53 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 26, 2016, 6:24 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 275 > > > > > > I think we should use `insert(...)` instead of `=`; if the following > > event in the queue, are w

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146919 --- src/master/allocator/mesos/hierarchical.cpp (line 274)

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 23, 2016, 2:26 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 276-279 > > > > > > Probably extract this snippet in a function, e.g. > > `conditionalAllocate()`? >

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146673 --- Patch looks great! Reviews applied: [51028, 51027] Passed comman

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 23, 2016, 9:26 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1194-1195 > > > > > > `delay` already contains `dispatch`, so under "synchronously" you > > actually

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146620 --- @Jacob, can you please add more test cases in `Testing Done` secti

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146591 --- This patch really improved the performance a lot for allocator, I

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 23, 2016, 2:26 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1194-1195 > > > > > > `delay` already contains `dispatch`, so under "synchronously" you > > actually

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146588 --- src/master/allocator/mesos/hierarchical.hpp (line 380)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146499 --- src/master/allocator/mesos/hierarchical.cpp (lines 275 - 278)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146497 --- You may want to update the `Description` section to make sure each

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 18, 2016, 12:38 a.m., Guangya Liu wrote: > > Can you please also clarify some difference with > > https://reviews.apache.org/r/41658/, as here the work is carry from > > https://reviews.apache.org/r/41658/ , I think that this is more simple and > > clear compared with counter in http

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 23, 2016, 8:32 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 23, 2016, 8:24 a.m.) Review request for . Bugs: MESOS-3157

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 23, 2016, 8:24 a.m.) Review request for . Bugs: MESOS-3157

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146480 --- This can also help https://issues.apache.org/jira/browse/MESOS-307

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 八月 18, 2016, 12:38 a.m., Guangya Liu wrote: > > Can you please also clarify some difference with > > https://reviews.apache.org/r/41658/, as here the work is carry from > > https://reviews.apache.org/r/41658/ , I think that this is more simple and > > clear compared with counter in https:

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 17, 2016, 5:36 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 29 > > > > > > move this right before `#include ` Also move `#include ` with it. - Jiang Yan ---

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 17, 2016, 5:38 p.m., Guangya Liu wrote: > > Can you please also clarify some difference with > > https://reviews.apache.org/r/41658/, as here the work is carry from > > https://reviews.apache.org/r/41658/ , I think that this is more simple and > > clear compared with counter in https

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146094 --- src/master/allocator/mesos/hierarchical.hpp (line 216)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146058 --- Can you please also clarify some difference with https://reviews.

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146040 --- src/master/allocator/mesos/hierarchical.hpp (lines 381 - 382)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 17, 2016, 6:12 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review145980 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 17, 2016, 3:51 a.m.) Review request for mesos. Bugs: MESOS-3157

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 17, 2016, 3:46 a.m.) Review request for mesos. Bugs: MESOS-3157

Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- Review request for mesos. Repository: mesos Description --- - Triggered