Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review201381 --- Ship it! I will commit this now, fixing outstanding typos and s

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated April 18, 2018, 4:15 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On April 16, 2018, 10:32 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 286 (patched) > > > > > > Can we add a subfolder with current process pid to address scenarios >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review201184 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 286 (patched) <

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review201099 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 691-692 (origin

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On April 6, 2018, 2:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 104-113 (patched) > > > > > > Does this class have to be nested? How about making it >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On April 6, 2018, 2:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 104-113 (patched) > > > > > > Does this class have to be nested? How about making it >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated April 10, 2018, 2:39 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review200633 --- 3rdparty/libprocess/Makefile.am Lines 208 (patched)

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated April 3, 2018, 4:29 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated March 21, 2018, 7:52 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198409 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 305 (patched) <

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197990 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198018 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198065 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198061 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198030 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198057 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198052 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198047 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198043 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197986 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197982 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198004 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198022 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198014 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198038 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198034 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198026 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198008 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197998 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197977 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197970 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197966 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197961 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197957 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197953 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197949 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197945 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197939 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197933 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197929 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197922 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197917 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197905 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197897 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197893 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197889 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197883 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197879 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197875 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197869 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197865 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197861 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197856 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 12, 2018, 1:13 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 706-708 (patched) > > > > > > Why this is not a simple delay? To indicate that a profiling session i

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Oct. 31, 2017, 1:53 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 26 (patched) > > > > > > I realize you're probably copying the style of the cpu profiler, but

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated Feb. 21, 2018, 10:41 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 197-240 (patched) > > > > > > I would still merge these two functions. Since it is for internal use

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197256 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 654 (patched) <

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 243-249 (patched) > > > > > > I think it is safe to use this function because it is only accessed >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 243-249 (patched) > > > > > > I think it is safe to use this function because it is only accessed >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 630 (patched) > > > > > > Use `profilingTimer->timeout().remaining()` directly. There are two issues

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 264 (patched) > > > > > > Say "using std::string" in the beginning of the file and save hundreds > >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review196894 --- 3rdparty/libprocess/include/process/memory_profiler.hpp Lines 57

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated Feb. 6, 2018, 5:45 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated Feb. 1, 2018, 7:09 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Jan. 26, 2018, 5:31 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 198-240 (patched) > > > > > > Can we combine these two with in a `Result > > updateJemallocSetting(

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review196340 --- 3rdparty/libprocess/Makefile.am Lines 213 (patched)

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Oct. 31, 2017, 1:53 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 56-62 (patched) > > > > > > When I read 'dump' I think it will write some things to output or

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Nov. 10, 2017, 4:31 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 44-52 (patched) > > > > > > My gut feeling is that this will not fly on Windows. Is the plan to > >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review191026 --- Some suggestions from going over it together: * Maybe add an opti

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review190864 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 345-346 (patche

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Nov. 10, 2017, 4:31 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 287-296 (patched) > > > > > > Looks like these guys did not make it into MVP. Ah, now I see them in

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review190728 --- 3rdparty/libprocess/include/process/memory_profiler.hpp Lines 22

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review189680 --- Great to see this coming together! I did a quick high level pass,

Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository: