[GitHub] spark issue #15436: [SPARK-17875] [BUILD] Remove unneeded direct dependence ...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15436 **[Test build #3362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3362/consoleFull)** for PR 15436 at commit

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15553 Why, what problem does the dependency change solve? test scope doesn't affect anything but tests to begin with. Likewise the scaladoc plugin attaches to a phase that's only active when

[GitHub] spark pull request #15553: [SPARK-18008] [build] Add support for -Dmaven.tes...

2016-10-19 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/15553#discussion_r84047904 --- Diff: pom.xml --- @@ -2415,6 +2389,67 @@ + + docBuild + + + maven.javadoc.skip

[GitHub] spark pull request #15553: [SPARK-18008] [build] Add support for -Dmaven.tes...

2016-10-19 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/15553#discussion_r84047441 --- Diff: common/network-common/pom.xml --- @@ -77,27 +77,40 @@ compile - - - log4j - log4j

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15553 **[Test build #67192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67192/consoleFull)** for PR 15553 at commit

[GitHub] spark issue #15450: [SPARK-3261] [MLLIB] KMeans clusterer can return duplica...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15450 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67188/ Test PASSed. ---

[GitHub] spark pull request #15553: [SPARK-18008] [build] Add support for -Dmaven.tes...

2016-10-19 Thread mridulm
GitHub user mridulm opened a pull request: https://github.com/apache/spark/pull/15553 [SPARK-18008] [build] Add support for -Dmaven.test.skip=true and -Dmaven.javadoc.skip=true ## What changes were proposed in this pull request? Add support for -Dmaven.test.skip=true and

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-19 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15553 +CC @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15450: [SPARK-3261] [MLLIB] KMeans clusterer can return duplica...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15450 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15450: [SPARK-3261] [MLLIB] KMeans clusterer can return duplica...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15450 **[Test build #67188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67188/consoleFull)** for PR 15450 at commit

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-10-19 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14650 @mgummelt ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15546 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67185/ Test FAILed. ---

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15546 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15546 **[Test build #67185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67185/consoleFull)** for PR 15546 at commit

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15546 **[Test build #67190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67190/consoleFull)** for PR 15546 at commit

[GitHub] spark issue #15382: [SPARK-17810] [SQL] Default spark.sql.warehouse.dir is r...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15382 **[Test build #67191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67191/consoleFull)** for PR 15382 at commit

[GitHub] spark issue #15382: [SPARK-17810] [SQL] Default spark.sql.warehouse.dir is r...

2016-10-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15382 @vanzin this may be more like what you're suggesting. I think the Windows issue makes this a little bit more complex than what you're describing but I think this ends up being workable.

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 The current running build has one testcase failure, `when schema inference is turned on, should read partition data`. It seems to be irrelevant. --- If your project is set up for it, you

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84043945 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -127,7 +134,9 @@ final class ChiSqSelector @Since("1.6.0")

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84044151 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -243,6 +245,19 @@ class ChiSqSelector @Since("2.1.0") () extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84044410 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -263,9 +278,15 @@ object ChiSqSelector { /** String name for

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84043926 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -104,6 +108,9 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84044249 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -243,6 +245,19 @@ class ChiSqSelector @Since("2.1.0") () extends

[GitHub] spark issue #15515: [SPARK-17970][SQL][WIP] store partition spec in metastor...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15515 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67186/ Test FAILed. ---

[GitHub] spark issue #15515: [SPARK-17970][SQL][WIP] store partition spec in metastor...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15515 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15515: [SPARK-17970][SQL][WIP] store partition spec in metastor...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15515 **[Test build #67186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67186/consoleFull)** for PR 15515 at commit

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84042900 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala --- @@ -82,6 +82,18 @@ class ChiSqSelectorSuite extends SparkFunSuite

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84041266 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -243,6 +245,19 @@ class ChiSqSelector @Since("2.1.0") () extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84042201 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -72,11 +72,15 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84040939 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -243,6 +245,19 @@ class ChiSqSelector @Since("2.1.0") () extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84042933 --- Diff: python/pyspark/ml/feature.py --- @@ -2624,7 +2624,9 @@ class ChiSqSelector(JavaEstimator, HasFeaturesCol, HasOutputCol, HasLabelCol, Ja

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84041851 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -72,11 +72,15 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84041519 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -243,6 +245,19 @@ class ChiSqSelector @Since("2.1.0") () extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84042250 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -72,11 +72,15 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84038840 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -243,6 +245,19 @@ class ChiSqSelector @Since("2.1.0") () extends

[GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML][WIP]add feature selector...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84042944 --- Diff: python/pyspark/ml/feature.py --- @@ -2700,7 +2702,6 @@ def getPercentile(self): def setAlpha(self, value): """

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14426 **[Test build #67189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67189/consoleFull)** for PR 14426 at commit

[GitHub] spark issue #14116: [SPARK-16452][SQL] Support basic INFORMATION_SCHEMA

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14116 The issue might be tackled later after Catalog Federation. Now, I close this PR since it's too stale. Thank you all for spending time at this PR. --- If your project is set up for it, you

[GitHub] spark pull request #14116: [SPARK-16452][SQL] Support basic INFORMATION_SCHE...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/14116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15552: [SPARK-18007][SparkR][ML] update SparkR MLP - add inital...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67187/ Test FAILed. ---

[GitHub] spark issue #15552: [SPARK-18007][SparkR][ML] update SparkR MLP - add inital...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15552: [SPARK-18007][SparkR][ML] update SparkR MLP - add inital...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15552 **[Test build #67187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67187/consoleFull)** for PR 15552 at commit

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15546 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15450: [SPARK-3261] [MLLIB] KMeans clusterer can return duplica...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15450 **[Test build #67188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67188/consoleFull)** for PR 15450 at commit

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15546 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67178/ Test PASSed. ---

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15546 **[Test build #67178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67178/consoleFull)** for PR 15546 at commit

[GitHub] spark issue #15450: [SPARK-3261] [MLLIB] KMeans clusterer can return duplica...

2016-10-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15450 _k_ is a parameter to the model building process, and I don't think it should change based on the model that comes out. It's the requested or maximum number of centroids, if you like. Or, weigh that

[GitHub] spark issue #15376: [SPARK-17796][SQL] Support wildcard character in filenam...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15376 Thank you for your review and approval, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15436: [SPARK-17875] [BUILD] Remove unneeded direct dependence ...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15436 **[Test build #3362 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3362/consoleFull)** for PR 15436 at commit

[GitHub] spark pull request #15546: [SPARK-17982][SQL] SQLBuilder should wrap the gen...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15546#discussion_r84032070 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala --- @@ -45,7 +45,7 @@ class LogicalPlanToSQLSuite extends

[GitHub] spark issue #15552: [SPARK-18007][SparkR][ML] update SparkR MLP - add inital...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15552 **[Test build #67187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67187/consoleFull)** for PR 15552 at commit

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 @rxin . I moved the test case and fixed a bug in `LogicalPlanToSQLSuite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #15552: [SPARK-18007][SparkR][ML] update SparkR MLP - add...

2016-10-19 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/15552 [SPARK-18007][SparkR][ML] update SparkR MLP - add initalWeights parameter ## What changes were proposed in this pull request? update SparkR MLP, add initalWeights parameter.

[GitHub] spark pull request #15546: [SPARK-17982][SQL] SQLBuilder should wrap the gen...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15546#discussion_r84031451 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala --- @@ -45,7 +45,7 @@ class LogicalPlanToSQLSuite extends

[GitHub] spark pull request #15546: [SPARK-17982][SQL] SQLBuilder should wrap the gen...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15546#discussion_r84031195 --- Diff: sql/hive/src/test/resources/sqlgen/limit.sql --- @@ -0,0 +1,4 @@ +-- This file is automatically generated by LogicalPlanToSQLSuite.

[GitHub] spark pull request #15538: [SPARK-17993][SQL] Fix Parquet log output redirec...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15538#discussion_r84030635 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -56,6 +56,7 @@ class ParquetFileFormat

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15546 **[Test build #67185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67185/consoleFull)** for PR 15546 at commit

[GitHub] spark issue #15515: [SPARK-17970][SQL][WIP] store partition spec in metastor...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15515 **[Test build #67186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67186/consoleFull)** for PR 15515 at commit

[GitHub] spark pull request #15538: [SPARK-17993][SQL] Fix Parquet log output redirec...

2016-10-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15538#discussion_r84030939 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -718,7 +717,8 @@ object

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15551 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15551 **[Test build #67183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67183/consoleFull)** for PR 15551 at commit

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15551 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67183/ Test FAILed. ---

[GitHub] spark issue #15505: [WIP][SPARK-17931][CORE] taskScheduler has some unneeded...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15505 **[Test build #67184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67184/consoleFull)** for PR 15505 at commit

[GitHub] spark pull request #15548: [SPARK-17985][CORE] Bump commons-lang3 version to...

2016-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15423: [SPARK-17860][SQL] SHOW COLUMN's database conflict check...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15423 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15423: [SPARK-17860][SQL] SHOW COLUMN's database conflict check...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15423 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67177/ Test PASSed. ---

[GitHub] spark issue #15423: [SPARK-17860][SQL] SHOW COLUMN's database conflict check...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15423 **[Test build #67177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67177/consoleFull)** for PR 15423 at commit

[GitHub] spark issue #15548: [SPARK-17985][CORE] Bump commons-lang3 version to 3.5.

2016-10-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15548 Given the discussion in https://github.com/apache/spark/pull/15525 indicates this change didn't cause the error, I'll merge it again. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15551 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67182/ Test FAILed. ---

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15551 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15551 **[Test build #67182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67182/consoleFull)** for PR 15551 at commit

[GitHub] spark issue #15394: [SPARK-17748][ML] One pass solver for Weighted Least Squ...

2016-10-19 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15394 @sethah Please see my inline comments, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15532: [SPARK-17989][SQL] Check ascendingOrder type in sort_arr...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15532 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15532: [SPARK-17989][SQL] Check ascendingOrder type in sort_arr...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15532 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67176/ Test PASSed. ---

[GitHub] spark issue #15532: [SPARK-17989][SQL] Check ascendingOrder type in sort_arr...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15532 **[Test build #67176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67176/consoleFull)** for PR 15532 at commit

[GitHub] spark pull request #15394: [SPARK-17748][ML] One pass solver for Weighted Le...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15394#discussion_r84024747 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala --- @@ -85,73 +104,191 @@ private[ml] class WeightedLeastSquares(

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15551 **[Test build #67180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67180/consoleFull)** for PR 15551 at commit

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15551 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67180/ Test FAILed. ---

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15551 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15481: [SPARK-17929] [CORE] Fix deadlock when CoarseGrai...

2016-10-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15481#discussion_r84024475 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -145,6 +145,9 @@ class

[GitHub] spark issue #10154: [SPARK-12149] [Web UI] Executor UI improvement suggestio...

2016-10-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/10154 Yes, I have not noticed the color to be confusing. What type of state are you looking at @rxin? it could be that with enough activity, failures are inevitable, and marking anything > 0 failures as

[GitHub] spark pull request #15547: [SPARK-18002][SQL] Pruning unnecessary IsNotNull ...

2016-10-19 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/15547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15547: [SPARK-18002][SQL] Pruning unnecessary IsNotNull predica...

2016-10-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15547 @cloud-fan yeah, I've not noticed `NullPropagation` already has rule for this. Close this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #15532: [SPARK-17989][SQL] Check ascendingOrder type in sort_arr...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15532 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67174/ Test PASSed. ---

[GitHub] spark issue #15532: [SPARK-17989][SQL] Check ascendingOrder type in sort_arr...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15532 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15547: [SPARK-18002][SQL] Pruning unnecessary IsNotNull predica...

2016-10-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15547 `IsNull`/`IsNotNull` may be optimized to literals in the `NullPropagation` rule, do you have an end-to-end example to show that your PR fixes some problems? --- If your project is set up for

[GitHub] spark issue #15532: [SPARK-17989][SQL] Check ascendingOrder type in sort_arr...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15532 **[Test build #67174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67174/consoleFull)** for PR 15532 at commit

[GitHub] spark issue #15377: [SPARK-17802] Improved caller context logging.

2016-10-19 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/15377 LGTM just some minor things. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15547: [SPARK-18002][SQL] Pruning unnecessary IsNotNull predica...

2016-10-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15547 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15551#discussion_r84020848 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriteOutput.scala --- @@ -0,0 +1,478 @@ +/* + * Licensed to the

[GitHub] spark pull request #15394: [SPARK-17748][ML] One pass solver for Weighted Le...

2016-10-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15394#discussion_r84020861 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15551 **[Test build #67183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67183/consoleFull)** for PR 15551 at commit

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 Ah. I see. `( )` means parenthesis, literally. I'll replace `CREATE VIEW` test case with SQL Generation suite. BTW, at the last commit, the PR is changed to add parenthesis if the child of

[GitHub] spark issue #15481: [SPARK-17929] [CORE] Fix deadlock when CoarseGrainedSche...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67173/ Test PASSed. ---

[GitHub] spark issue #15481: [SPARK-17929] [CORE] Fix deadlock when CoarseGrainedSche...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15551#discussion_r84018650 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriteOutput.scala --- @@ -0,0 +1,478 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #15551: [SQL] WriterContainer refactoring - WIP

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15551 **[Test build #67182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67182/consoleFull)** for PR 15551 at commit

[GitHub] spark issue #15546: [SPARK-17982][SQL] SQLBuilder should wrap the generated ...

2016-10-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 Sorry, but what do you mean by `the output has ( ) no?`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15481: [SPARK-17929] [CORE] Fix deadlock when CoarseGrainedSche...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15481 **[Test build #67173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67173/consoleFull)** for PR 15481 at commit

<    1   2   3   4   5   6   >