[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-18 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165957323 @andreor14 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9796 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r48083182 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -408,7 +408,8 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165923965 LGTM thanks @GraceH and @vanzin I'm merging this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r48070571 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -408,7 +408,8 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r48070489 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,23 +386,28 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165700508 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165700511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165700430 **[Test build #47984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47984/consoleFull)** for PR 9796 at commit [`0305815`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165678973 **[Test build #47984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47984/consoleFull)** for PR 9796 at commit [`0305815`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165677245 **[Test build #47983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47983/consoleFull)** for PR 9796 at commit [`bf2edd3`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165677249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165677248 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165677097 **[Test build #47983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47983/consoleFull)** for PR 9796 at commit [`bf2edd3`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165656751 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165656752 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165656705 **[Test build #47965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47965/consoleFull)** for PR 9796 at commit [`fd5f435`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-165626557 **[Test build #47965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47965/consoleFull)** for PR 9796 at commit [`fd5f435`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-164991082 I leave my thoughts under GraceH#2. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r47733929 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-164980444 @GraceH The "pending replacement" test is still not correct; we never actually updated the executors list after killing and replacing an executor. The test currently

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r47732666 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r47730960 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-164968673 This is not ready for merge yet, please see the unresolved comments thread. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r47730981 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-10 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-163839364 Thanks @zsxwing. The patch seems to pass all tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-163820203 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-163820204 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-163820124 **[Test build #47557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47557/consoleFull)** for PR 9796 at commit [`154ab31`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-163799207 **[Test build #47557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47557/consoleFull)** for PR 9796 at commit [`154ab31`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-12-10 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-163798442 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159884849 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159884854 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159884615 **[Test build #46752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46752/consoleFull)** for PR 9796 at commit [`154ab31`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159827044 **[Test build #46752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46752/consoleFull)** for PR 9796 at commit [`154ab31`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159824727 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159816201 **[Test build #46728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46728/consoleFull)** for PR 9796 at commit [`154ab31`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159816229 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159816226 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159796777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159796776 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159796691 **[Test build #46726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46726/consoleFull)** for PR 9796 at commit [`2e4884c`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45939198 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45939112 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45938914 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159781849 **[Test build #46728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46728/consoleFull)** for PR 9796 at commit [`154ab31`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159778113 **[Test build #46726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46726/consoleFull)** for PR 9796 at commit [`2e4884c`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45937858 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159778011 Yes. The replacement is finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45937732 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159777416 Do the tests pass locally? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45937706 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSu

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159776246 I have added the test case https://github.com/GraceH/spark/commit/2e4884c30d9edb0a366e9138cbad8772c5645c5d. Please let me know your comments. --- If your project is se

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread GraceH
Github user GraceH commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159774039 @andrewor14 Yes. you are so right. Meanwhile it seems the original implementation has waited for a while to check if the replacement is there. According to you suggestio

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159719315 @GraceH continuing our discussion on the "pending replacement" test: The problem is actually how the framework is set up. To speed up the test we don't wait f

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45913525 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuit

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159475199 **[Test build #46653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46653/consoleFull)** for PR 9796 at commit [`657849d`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159475247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159475246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-159461769 **[Test build #46653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46653/consoleFull)** for PR 9796 at commit [`657849d`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-23 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45685308 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45418928 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45418211 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45414046 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuit

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45412931 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-158216900 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-158216899 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-158216779 **[Test build #46340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46340/consoleFull)** for PR 9796 at commit [`4a6d06e`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-158161108 **[Test build #46340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46340/consoleFull)** for PR 9796 at commit [`4a6d06e`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45384135 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuit

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-158156689 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157913530 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157913531 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157912000 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157911999 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157910787 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157910788 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157910679 **[Test build #46253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46253/consoleFull)** for PR 9796 at commit [`0d8e6c1`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45284000 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45283718 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -462,7 +463,8 @@ class CoarseGrainedSchedulerBacke

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45283688 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -408,7 +408,8 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45283707 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -450,7 +450,8 @@ class CoarseGrainedSchedulerBacke

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45276326 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuit

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45276295 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuit

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157877967 **[Test build #46253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46253/consoleFull)** for PR 9796 at commit [`0d8e6c1`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157874859 ah, pyspark. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157874689 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157874510 **[Test build #46224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46224/consoleFull)** for PR 9796 at commit [`0d8e6c1`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157874686 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157813815 **[Test build #46224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46224/consoleFull)** for PR 9796 at commit [`0d8e6c1`](https://gith

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157810833 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45238295 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -408,7 +408,8 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45238332 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -450,7 +450,8 @@ class CoarseGrainedSchedulerBacke

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45237925 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -462,7 +463,8 @@ class CoarseGrainedSchedulerBacke

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157684033 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157683968 **[Test build #46187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46187/consoleFull)** for PR 9796 at commit [`0d8e6c1`](https://git

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157684030 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project