Github user mce closed the pull request at:
https://github.com/apache/spark/pull/5439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mce commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-101257316
@tdas sorry for the late response, i'm closing the pr now as i don't have
any time to work on this currently.
---
If your project is set up for it, you can reply to this
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-99269147
@mce Are you able to update this? If you are not able to work on this, mind
closing this PR?
---
If your project is set up for it, you can reply to this email and have
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-97622154
I am taking a look at this PR a little late. But I am not sure how this
work at all. AWSCredentials is not serializable.
---
If your project is set up for it, you can
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r29395910
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -68,7 +64,8 @@ private[kinesis] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-96767499
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mce commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-94652390
@cfregly any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mce commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93687457
@cfregly Moved initialization code into ```onStart``` method to fix
serialization error. I tested by running example application and it runs
without any problem.
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93668194
[Test build #30406 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30406/consoleFull)
for PR 5439 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93686710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93686694
[Test build #30406 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30406/consoleFull)
for PR 5439 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93354224
[Test build #30335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30335/consoleFull)
for PR 5439 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93348502
[Test build #30334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30334/consoleFull)
for PR 5439 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93398033
[Test build #30335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30335/consoleFull)
for PR 5439 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93348547
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28419555
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -82,15 +82,19 @@ private[kinesis] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93398087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28408535
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -24,8 +24,7 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-93306684
[Test build #30334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30334/consoleFull)
for PR 5439 at commit
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28408687
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -82,15 +82,19 @@ private[kinesis] class
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28408803
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -59,9 +61,10 @@ object KinesisUtils {
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28408842
--- Diff:
extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisReceiverSuite.scala
---
@@ -86,7 +86,7 @@ class KinesisReceiverSuite
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28408838
--- Diff:
extras/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java
---
@@ -34,7 +34,7 @@ public void testKinesisStream()
Github user mce commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28409139
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -32,7 +32,7 @@ A Kinesis stream can be set up at one of the valid
Kinesis endpoints with 1 or m
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390431
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -82,15 +82,19 @@ private[kinesis] class
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390749
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -59,9 +61,10 @@ object KinesisUtils {
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390150
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -24,8 +24,7 @@ import
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390315
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -82,15 +82,19 @@ private[kinesis] class
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390948
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -32,7 +32,7 @@ A Kinesis stream can be set up at one of the valid
Kinesis endpoints with 1 or m
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390980
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -67,6 +67,8 @@ A Kinesis stream can be set up at one of the valid
Kinesis endpoints with 1 or m
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390951
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -44,7 +44,7 @@ A Kinesis stream can be set up at one of the valid
Kinesis endpoints with 1 or m
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390832
--- Diff:
extras/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java
---
@@ -34,7 +34,7 @@ public void
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390845
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
---
@@ -113,7 +113,7 @@ private object
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390844
--- Diff:
extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -131,7 +131,7 @@ public static void
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390830
--- Diff:
extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisReceiverSuite.scala
---
@@ -86,7 +86,7 @@ class KinesisReceiverSuite
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28390679
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -16,6 +16,7 @@
*/
package
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28391083
--- Diff:
extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -131,7 +131,7 @@ public static void
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28391006
--- Diff:
extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -131,7 +131,7 @@ public static void
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-92039536
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-92039483
[Test build #30115 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30115/consoleFull)
for PR 5439 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28202950
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -90,8 +93,9 @@ object KinesisUtils {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-92027699
[Test build #30115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30115/consoleFull)
for PR 5439 at commit
Github user mce commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-92042569
@srowen tests passed, fyi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5439#issuecomment-91203788
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user mce opened a pull request:
https://github.com/apache/spark/pull/5439
SPARK-5960 allow aws credentials to be passed to KinesisUtils.createStream
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vngrs/spark SPARK-5960
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28054339
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -119,7 +132,9 @@ private[kinesis] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28054255
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -70,6 +69,20 @@ private[kinesis] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28054199
--- Diff: extras/kinesis-asl/pom.xml ---
@@ -48,6 +48,11 @@
scopetest/scope
/dependency
dependency
+
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28054428
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -16,6 +16,7 @@
*/
package
49 matches
Mail list logo
