Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636366947 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r163639 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636366372 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -116,6 +116,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636119247 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636118619 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636117355 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636111527 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala: ## @@ -91,6 +91,19 @@ abstract class AbstractSqlParser extends

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1636103861 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1635210439 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1635208023 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1635207432 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala: ## @@ -91,6 +91,19 @@ abstract class AbstractSqlParser extends

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1635206930 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1635204552 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1635203748 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1633655767 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -116,6 +116,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1633655767 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -116,6 +116,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1633503804 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -116,6 +116,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1633503094 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1633499316 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1632788387 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1632788387 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1632776839 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1632770533 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631776712 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631776712 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631776102 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631775974 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631774980 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala: ## @@ -91,6 +91,19 @@ abstract class AbstractSqlParser extends

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631774980 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala: ## @@ -91,6 +91,19 @@ abstract class AbstractSqlParser extends

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631774604 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1625792580 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1625792580 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1625787748 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -116,6 +116,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

dtenedor commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1624947797 ## sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala: ## @@ -581,6 +581,9 @@ case class MyParser(spark: SparkSession, delegate:

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

dtenedor commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1624946733 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -116,6 +116,57 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

dtenedor commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1624940908 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

dtenedor commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1624940407 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

melin commented on PR #46665: URL: https://github.com/apache/spark/pull/46665#issuecomment-2136546582 Can remove: SET.*? , or optimize the set syntax definition？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on PR #46665: URL: https://github.com/apache/spark/pull/46665#issuecomment-2132982040 @melin we are aware of this problem, it already exists without SQL scripting... example: using `SET VAR` to set a SQL variable with syntax error after the `=` (let's say `SELECT` query

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

melin commented on PR #46665: URL: https://github.com/apache/spark/pull/46665#issuecomment-2132652795 Multiple statements include set statements if the next statement of the set statement has a syntax error. The analysis is wrong, ``` sql BEGIN SET

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

melin commented on PR #46665: URL: https://github.com/apache/spark/pull/46665#issuecomment-2132566886 spark sql does not resolve multiple statements. For example, the following statements fail to be resolved ``` SQL BEGIN SET hive.exec.dynamic.partition.mode = nonstrict;

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613161561 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613389337 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613389337 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613386426 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613384389 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

dbatomic commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613213985 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613161561 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

davidm-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1613136311 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

miland-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1612427632 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

miland-db commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1612427632 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; } public boolean

Re: [PR] [SPARK-48342][SQL] Introduction of SQL Scripting Parser [spark]

dtenedor commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1612415090 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software