[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80563543 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,446 @@ +/* + * Licensed to the

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80582937 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80583033 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalogSuite.scala --- @@ -0,0 +1,34 @@ +/* + * Licensed to

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80582702 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80583392 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +83,177 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80573942 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80583326 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80574449 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80581975 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80582465 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class ListingFileCatalog(

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65930/ Test PASSed. ---

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #65930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65930/consoleFull)** for PR 13680 at commit

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS and YA...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14659 **[Test build #65934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65934/consoleFull)** for PR 14659 at commit

[GitHub] spark pull request #14659: [SPARK-16757] Set up Spark caller context to HDFS...

2016-09-26 Thread Sherry302
Github user Sherry302 commented on a diff in the pull request: https://github.com/apache/spark/pull/14659#discussion_r80579059 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2421,6 +2421,69 @@ private[spark] object Utils extends Logging { }

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS and YA...

2016-09-26 Thread Sherry302
Github user Sherry302 commented on the issue: https://github.com/apache/spark/pull/14659 Hi, @tgravescs Thanks a lot for the comments. I have updated the PR to rename local vals and remove the `@since` in `Utils.scala`. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65929/ Test FAILed. ---

[GitHub] spark pull request #14659: [SPARK-16757] Set up Spark caller context to HDFS...

2016-09-26 Thread Sherry302
Github user Sherry302 commented on a diff in the pull request: https://github.com/apache/spark/pull/14659#discussion_r80579032 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2421,6 +2421,69 @@ private[spark] object Utils extends Logging { }

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14897 **[Test build #65929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65929/consoleFull)** for PR 14897 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #65933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65933/consoleFull)** for PR 15246 at commit

[GitHub] spark pull request #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread Sherry302
GitHub user Sherry302 opened a pull request: https://github.com/apache/spark/pull/15246 [MINOR][SQL] Use resource path for test_script.sh ## What changes were proposed in this pull request? This PR modified the test case `test("script")` to use resource path for

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost

2016-09-26 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/14547 @sethah AFAIK, the original gradient boosting algorithm was generic, not specific to trees. That's Algorithm 1 from [https://statweb.stanford.edu/~jhf/ftp/trebst.pdf] and is what MLlib has

[GitHub] spark issue #14818: [SPARK-17157][SPARKR][WIP]: Add multiclass logistic regr...

2016-09-26 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14818 For example: `LogisticRegression` has `Threshold`, `Thresholds` and `AggregationDepth` etc as parameters. `GeneralizedLinearRegression` doesn't have such parameters. So the

[GitHub] spark pull request #15245: [SPARK-17666] Ensure that RecordReaders are close...

2016-09-26 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/15245#discussion_r80568308 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala --- @@ -30,7 +31,8 @@ import

[GitHub] spark issue #13998: [SPARK-12177][Streaming][Kafka] limit api surface area

2016-09-26 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/13998 @koeninger Could you take a look at this test flakiness in https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.4/1792/ --- If your project is set up for it, you can reply to

[GitHub] spark issue #9162: [SPARK-10655][SQL] Adding additional data type mappings t...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9162 **[Test build #65932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65932/consoleFull)** for PR 9162 at commit

[GitHub] spark issue #15245: [SPARK-17666] Ensure that RecordReaders are closed by da...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15245 **[Test build #65931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65931/consoleFull)** for PR 15245 at commit

[GitHub] spark pull request #15245: [SPARK-17666] Ensure that RecordReaders are close...

2016-09-26 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/15245#discussion_r80568112 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/RecordReaderIterator.scala --- @@ -27,7 +29,8 @@ import

[GitHub] spark pull request #15155: [SPARK-17477][SQL] SparkSQL cannot handle schema ...

2016-09-26 Thread wgtmac
Github user wgtmac closed the pull request at: https://github.com/apache/spark/pull/15155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15245: [SPARK-17666] Ensure that RecordReaders are closed by da...

2016-09-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15245 Nice one, looks like something that can only help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15245: [SPARK-17666] Ensure that RecordReaders are close...

2016-09-26 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/15245#discussion_r80567995 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/RecordReaderIterator.scala --- @@ -52,4 +55,18 @@ class

[GitHub] spark pull request #15245: [SPARK-17666] Ensure that RecordReaders are close...

2016-09-26 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/15245#discussion_r80567861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/RecordReaderIterator.scala --- @@ -38,7 +41,7 @@ class

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14426 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65927/ Test PASSed. ---

[GitHub] spark issue #14959: [SPARK-17387][PYSPARK] Creating SparkContext() from pyth...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/14959 I added a few comments @zjffdu. I also tested this PR out and looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14426 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15244: Update spark-standalone.md to fix link

2016-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15245: [SPARK-17666] Ensure that RecordReaders are close...

2016-09-26 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/15245 [SPARK-17666] Ensure that RecordReaders are closed by data source file scans ## What changes were proposed in this pull request? This patch addresses a potential cause of resource leaks

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65920/ Test FAILed. ---

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14426 **[Test build #65927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65927/consoleFull)** for PR 14426 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #65920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65920/consoleFull)** for PR 13680 at commit

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80567211 --- Diff: python/pyspark/conf.py --- @@ -118,28 +130,28 @@ def setIfMissing(self, key, value): def setMaster(self, value):

[GitHub] spark issue #15244: Update spark-standalone.md to fix link

2016-09-26 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15244 Thanks merged into master 2.0 and 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80566426 --- Diff: python/pyspark/java_gateway.py --- @@ -41,7 +41,7 @@ def can_convert_list(self, obj): ListConverter.can_convert = can_convert_list

[GitHub] spark issue #15102: [SPARK-17346][SQL] Add Kafka source for Structured Strea...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15102 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15102: [SPARK-17346][SQL] Add Kafka source for Structured Strea...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65926/ Test PASSed. ---

[GitHub] spark issue #15102: [SPARK-17346][SQL] Add Kafka source for Structured Strea...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15102 **[Test build #65926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65926/consoleFull)** for PR 15102 at commit

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-26 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r80565861 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala --- @@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80565092 --- Diff: python/pyspark/conf.py --- @@ -149,35 +161,53 @@ def setAll(self, pairs): :param pairs: list of key-value pairs to set

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80564836 --- Diff: python/pyspark/conf.py --- @@ -149,35 +161,53 @@ def setAll(self, pairs): :param pairs: list of key-value pairs to set

[GitHub] spark pull request #15225: [SPARK-17652] Fix confusing exception message whi...

2016-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15225: [SPARK-17652] Fix confusing exception message while rese...

2016-09-26 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15225 LGTM. Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80561545 --- Diff: python/pyspark/conf.py --- @@ -101,13 +101,25 @@ def __init__(self, loadDefaults=True, _jvm=None, _jconf=None): self._jconf =

[GitHub] spark pull request #14803: [SPARK-17153][SQL] Should read partition data whe...

2016-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80561001 --- Diff: python/pyspark/conf.py --- @@ -101,13 +101,25 @@ def __init__(self, loadDefaults=True, _jvm=None, _jconf=None): self._jconf =

[GitHub] spark issue #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-09-26 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15148 * Do we want to use the subpackage ```spark.ml.feature.lsh``` or just put the classes under ```spark.ml.feature```? This would be the first division of ```feature```. I'd prefer not using

[GitHub] spark issue #14803: [SPARK-17153][SQL] Should read partition data when readi...

2016-09-26 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/14803 Thanks, I'm going to merge this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15244: Update spark-standalone.md to fix link

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15244 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/15148#discussion_r80559677 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/lsh/LSH.scala --- @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #15244: Update spark-standalone.md to fix link

2016-09-26 Thread ammills01
GitHub user ammills01 opened a pull request: https://github.com/apache/spark/pull/15244 Update spark-standalone.md to fix link ## What changes were proposed in this pull request? Corrected a link to the configuration.html page, it was pointing to a page that does not exist

[GitHub] spark pull request #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/15148#discussion_r80556472 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/lsh/LSH.scala --- @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #14803: [SPARK-17153][SQL] Should read partition data whe...

2016-09-26 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/14803#discussion_r80556219 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -512,6 +512,12 @@ csvDF = spark \ These examples generate streaming DataFrames that

[GitHub] spark pull request #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/15148#discussion_r80555938 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/lsh/LSH.scala --- @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #15196: [SPARK-17614] [SQL] sparkSession.read() .jdbc(***) use t...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15196 **[Test build #65928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65928/consoleFull)** for PR 15196 at commit

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14897 **[Test build #65929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65929/consoleFull)** for PR 14897 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #65930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65930/consoleFull)** for PR 13680 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13680 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14897 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15196: [SPARK-17614] [SQL] sparkSession.read() .jdbc(***) use t...

2016-09-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15196 Sounds fine. I guess I'm surprised these wouldn't have to be overridden in the same way, but, on the other hand I suppose the existing query works today for MySQL et al? this is a more conservative

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2016-09-26 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13493 Same here, looks fine except for @holdenk 's comment. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14852: [SPARK-17138][ML][MLib] Add Python API for multinomial l...

2016-09-26 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14852 LGTM. @yanboliang what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15240: [SPARK-17556] Executor side broadcast for broadcast join...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15240 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15240: [SPARK-17556] Executor side broadcast for broadcast join...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15240 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65925/ Test FAILed. ---

[GitHub] spark issue #15240: [SPARK-17556] Executor side broadcast for broadcast join...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15240 **[Test build #65925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65925/consoleFull)** for PR 15240 at commit

[GitHub] spark issue #15196: [SPARK-17614] [SQL] sparkSession.read() .jdbc(***) use t...

2016-09-26 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/15196 @srowen, I think that @sureshthalamati is right and that we shouldn't override for those other dialects until we know that there's a problem with them. --- If your project is set up for it, you

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65922/ Test PASSed. ---

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #65922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65922/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65919/ Test PASSed. ---

[GitHub] spark issue #14818: [SPARK-17157][SPARKR][WIP]: Add multiclass logistic regr...

2016-09-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14818 Could you elaborate what's incompatible? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #65919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65919/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.

2016-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15243 Hi, @danix800 . Could you fix the following comment in this PR, too?

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2016-09-26 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/11601 So, I am trying to refresh my memory on this PR. I see we settled on not supporting vector type and not supporting mode. Did we ever settle on supporting multiple input columns? I am not sure I see

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80543997 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/ImputerSuite.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #15239: [SPARK-17665][SPARKR][WIP] Support options/mode all for ...

2016-09-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15239 also, you would need to add `@param ...` doc to pass the CRAN tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15239: [SPARK-17665][SPARKR][WIP] Support options/mode all for ...

2016-09-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15239 great, thanks. - we should consolidate the write.* function to use a helper to avoid code duplication - I'm a bit worry about the function signature changes - could we have some tests

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80541497 --- Diff: R/pkg/R/SQLContext.R --- @@ -835,7 +843,7 @@ loadDF <- function(x, ...) { #' @note createExternalTable since 1.4.0

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80540973 --- Diff: R/pkg/R/utils.R --- @@ -334,6 +334,27 @@ varargsToEnv <- function(...) { env } +# Utility function to capture the varargs

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80540376 --- Diff: R/pkg/R/DataFrame.R --- @@ -743,8 +743,12 @@ setMethod("toJSON", #' @note write.json since 1.6.0 setMethod("write.json",

[GitHub] spark issue #15216: [SPARK-17577][Follow-up][SparkR] SparkR spark.addFile su...

2016-09-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15216 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14818: [SPARK-17157][SPARKR][WIP]: Add multiclass logistic regr...

2016-09-26 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14818 @felixcheung If I added it to `spark.glm`, it will break the current `spark.glm` interface. `setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"),

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65923/ Test FAILed. ---

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14897 **[Test build #65923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65923/consoleFull)** for PR 14897 at commit

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14426 **[Test build #65927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65927/consoleFull)** for PR 14426 at commit

[GitHub] spark pull request #15231: [SPARK-17658][SPARKR] read.df/write.df API taking...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15231#discussion_r80536437 --- Diff: R/pkg/R/utils.R --- @@ -698,6 +698,21 @@ isSparkRShell <- function() { grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65921/ Test FAILed. ---

<    1   2   3   4   5   6   >