[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427286094 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,92 @@ case class

[GitHub] [spark] SparkQA removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as th

SparkQA removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630629887 **[Test build #122836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122836/testReport)** for PR 28511 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427284975 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,92 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427284881 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,92 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427284393 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,92 @@ case class

[GitHub] [spark] Ngone51 commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

Ngone51 commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427283021 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2439,6 +2439,17 @@ class DataFrameSuite extends QueryTest val

[GitHub] [spark] Ngone51 commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

Ngone51 commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427282822 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2439,6 +2439,17 @@ class DataFrameSuite extends QueryTest val

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427281461 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala ## @@ -247,6 +247,13 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427280158 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2439,6 +2439,17 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427279021 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala ## @@ -247,6 +247,13 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427278465 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -1735,8 +1735,22 @@ case class AnsiCast(child:

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427276916 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3071,15 +3071,31 @@ class Analyzer( case

[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

SparkQA commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630796651 **[Test build #122849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122849/testReport)** for PR 26624 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427275688 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3071,15 +3071,31 @@ class Analyzer( case

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630793502 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630793487 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630793487 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

cloud-fan commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630793034 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630789806 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630789806 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630789294 **[Test build #122848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122848/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630778923 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

AmplabJenkins commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630778923 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

SparkQA removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630719965 **[Test build #122846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122846/testReport)** for PR 28362 at commit

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

SparkQA commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630778746 **[Test build #122846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122846/testReport)** for PR 28362 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r420874873 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

AmplabJenkins removed a comment on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630770794 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

AmplabJenkins commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630770794 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

SparkQA removed a comment on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630633474 **[Test build #122837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122837/testReport)** for PR 28577 at commit

[GitHub] [spark] SparkQA commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

SparkQA commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630770251 **[Test build #122837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122837/testReport)** for PR 28577 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same

AmplabJenkins removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630750144 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the

AmplabJenkins commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630750144 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the table

SparkQA commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630749618 **[Test build #122847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122847/testReport)** for PR 28511 at commit

[GitHub] [spark] yaooqinn commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the table

yaooqinn commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630747207 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630746279 @cloud-fan seems like the failing test are not connected to the change... This is an automated message from

[GitHub] [spark] MichaelChirico commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

MichaelChirico commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630743034 Error seems related to SBT, not this PR This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same

AmplabJenkins removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630741521 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same

AmplabJenkins removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630741510 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the

AmplabJenkins commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630741510 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as th

SparkQA removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630633536 **[Test build #122839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122839/testReport)** for PR 28511 at commit

[GitHub] [spark] SparkQA commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the table

SparkQA commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630741091 **[Test build #122839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122839/testReport)** for PR 28511 at commit

[GitHub] [spark] h-vetinari commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

h-vetinari commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630740908 I'm a bit surprised that upgrading parquet has such a low priority, especially with many important features like column indexes & cleaning up the timestamp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630737405 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630737391 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

SparkQA removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630647473 **[Test build #122841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122841/testReport)** for PR 26624 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630737391 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

HyukjinKwon commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630736742 Looks good to me This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

SparkQA commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630736840 **[Test build #122841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122841/testReport)** for PR 26624 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

AmplabJenkins removed a comment on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630734709 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

AmplabJenkins removed a comment on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630734696 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

SparkQA removed a comment on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630641132 **[Test build #122840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122840/testReport)** for PR 28579 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

AmplabJenkins commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630734696 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

SparkQA commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630734197 **[Test build #122840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122840/testReport)** for PR 28579 at commit

[GitHub] [spark] GuoPhilipse commented on pull request #28568: [SPARK-31710][SQL]Add compatibility flag to cast long to timestamp

GuoPhilipse commented on pull request #28568: URL: https://github.com/apache/spark/pull/28568#issuecomment-630733921 For this particular case, I agree with @bart-samwel that we can fail by default for cast long to timestamp, and provide a legacy config to allow it with spark or

[GitHub] [spark] juliuszsompolski commented on a change in pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

juliuszsompolski commented on a change in pull request #28544: URL: https://github.com/apache/spark/pull/28544#discussion_r427196726 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2Listener.scala ## @@ -131,60

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

AmplabJenkins removed a comment on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-630731680 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

AmplabJenkins removed a comment on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-630731666 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

AmplabJenkins commented on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-630731666 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

SparkQA removed a comment on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-630629927 **[Test build #122835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122835/testReport)** for PR 28578 at commit

[GitHub] [spark] SparkQA commented on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

SparkQA commented on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-630731052 **[Test build #122835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122835/testReport)** for PR 28578 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

AmplabJenkins removed a comment on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630720554 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630720658 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] yaooqinn commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

yaooqinn commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630720451 cc @srowen @cloud-fan @dongjoon-hyun @HyukjinKwon @maropu thanks This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

AmplabJenkins commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630720658 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

AmplabJenkins commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630720554 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

SparkQA commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-630719965 **[Test build #122846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122846/testReport)** for PR 28362 at commit

[GitHub] [spark] SparkQA commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

SparkQA commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630720005 **[Test build #122845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122845/testReport)** for PR 28580 at commit

[GitHub] [spark] yaooqinn opened a new pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

yaooqinn opened a new pull request #28580: URL: https://github.com/apache/spark/pull/28580 ### What changes were proposed in this pull request? in `spark-daemon.sh`, `spark_rotate_log()` accepts `$2` as a custom setting for the number of maximum rotate log files, but

[GitHub] [spark] MichaelChirico commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

MichaelChirico commented on a change in pull request #28362: URL: https://github.com/apache/spark/pull/28362#discussion_r427178276 ## File path: R/pkg/R/DataFrame.R ## @@ -1652,34 +1607,43 @@ setMethod("dapplyCollect", #' gapply Review comment: Thanks @HyukjinKwon ,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630710355 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630710345 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630710345 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630709892 **[Test build #122844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122844/testReport)** for PR 28572 at commit

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]Fix millisecond and microsecond convert to timestamp in to_timestamp

bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427165637 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -846,6 +857,15 @@ abstract class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

HyukjinKwon commented on a change in pull request #28362: URL: https://github.com/apache/spark/pull/28362#discussion_r427158276 ## File path: R/pkg/R/DataFrame.R ## @@ -1652,34 +1607,43 @@ setMethod("dapplyCollect", #' gapply Review comment: You can check the

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

HyukjinKwon commented on a change in pull request #28362: URL: https://github.com/apache/spark/pull/28362#discussion_r427157063 ## File path: R/pkg/R/DataFrame.R ## @@ -1652,34 +1607,43 @@ setMethod("dapplyCollect", #' gapply Review comment: We could change

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

HyukjinKwon commented on a change in pull request #28362: URL: https://github.com/apache/spark/pull/28362#discussion_r427155885 ## File path: R/pkg/R/DataFrame.R ## @@ -1652,34 +1607,43 @@ setMethod("dapplyCollect", #' gapply Review comment: Shall we update here

[GitHub] [spark] bart-samwel commented on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

bart-samwel commented on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630696349 Note that if we were designing this fresh, the year 1970 would not be a great choice when it would be used to parse arbitrary Month/Day combinations. The reason being that

[GitHub] [spark] hvanhovell commented on pull request #28543: [SPARK-31721][SQL] Assert optimized is initialized before tracking the planning time

hvanhovell commented on pull request #28543: URL: https://github.com/apache/spark/pull/28543#issuecomment-630693306 Merging to master/3.0. Thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] hvanhovell closed pull request #28543: [SPARK-31721][SQL] Assert optimized is initialized before tracking the planning time

hvanhovell closed pull request #28543: URL: https://github.com/apache/spark/pull/28543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] Ngone51 commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

Ngone51 commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427147036 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3071,15 +3071,28 @@ class Analyzer( case p

[GitHub] [spark] Ngone51 commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

Ngone51 commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427146617 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala ## @@ -161,6 +161,10 @@ object

[GitHub] [spark] HyukjinKwon commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

HyukjinKwon commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-630690150 cc @cloud-fan FYI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

AmplabJenkins removed a comment on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630686710 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

AmplabJenkins commented on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630686710 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

SparkQA commented on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630686085 **[Test build #122843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122843/testReport)** for PR 28540 at commit

[GitHub] [spark] xuanyuanking commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

xuanyuanking commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427139637 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,39 @@ import

[GitHub] [spark] MaxGekk commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

MaxGekk commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427140383 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala ## @@ -291,4 +291,95 @@ class TimestampFormatterSuite

[GitHub] [spark] MaxGekk commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

MaxGekk commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427140383 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala ## @@ -291,4 +291,95 @@ class TimestampFormatterSuite

[GitHub] [spark] MaxGekk commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

MaxGekk commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427139018 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala ## @@ -291,4 +291,95 @@ class TimestampFormatterSuite

[GitHub] [spark] MaxGekk commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

MaxGekk commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427137030 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala ## @@ -291,4 +291,95 @@ class TimestampFormatterSuite

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427127270 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala ## @@ -161,6 +161,10 @@ object

[GitHub] [spark] Ngone51 commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

Ngone51 commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427126236 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala ## @@ -161,6 +161,10 @@ object

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427125934 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3071,15 +3071,28 @@ class Analyzer(

[GitHub] [spark] bart-samwel commented on pull request #28568: [SPARK-31710][SQL]Add compatibility flag to cast long to timestamp

bart-samwel commented on pull request #28568: URL: https://github.com/apache/spark/pull/28568#issuecomment-630669994 @GuoPhilipse I agree that if you want to do the smooth migration like that, then you need to have all queries using a subset of the language that works in both systems.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427121973 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala ## @@ -161,6 +161,10 @@ object

[GitHub] [spark] MaxGekk commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

MaxGekk commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427120597 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,39 @@ import

[GitHub] [spark] MaxGekk commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

MaxGekk commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427115840 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,39 @@ import

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630662852 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630662852 This is an automated message from the Apache Git Service. To respond to the message, please log on to

<    1   2   3   4   5   6   >