[GitHub] [spark] cloud-fan commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

cloud-fan commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-518110002 thanks, merging to master!

[GitHub] [spark] viirya commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

viirya commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#discussion_r310458845 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/p

[GitHub] [spark] AmplabJenkins removed a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

AmplabJenkins removed a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518109286 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

AmplabJenkins removed a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518109279 Merged build finished. Test PASSed. --

[GitHub] [spark] cloud-fan commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

cloud-fan commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-518109181 It takes time to educate the users that external shuffle service is now external block serv

[GitHub] [spark] AmplabJenkins commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

AmplabJenkins commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518109286 Test PASSed. Refer to this link for build results (access rights to CI server needed): https

[GitHub] [spark] AmplabJenkins commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

AmplabJenkins commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518109279 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA removed a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

SparkQA removed a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518072668 **[Test build #108639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] SparkQA commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

SparkQA commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518108742 **[Test build #108639 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] [spark] eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r310456244 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSui

[GitHub] [spark] SparkQA commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

SparkQA commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518106766 **[Test build #108647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108647/testReport)** for P

[GitHub] [spark] AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518106262 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518106257 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518106257 Merged build finished. Test PASSed. This is an automated m

[GitHub] [spark] AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518106262 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] SparkQA commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

SparkQA commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518103016 **[Test build #108646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108646/testReport)** for P

[GitHub] [spark] AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518102444 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins removed a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518102446 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518102446 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

AmplabJenkins commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-518102444 Merged build finished. Test PASSed. This is an automated m

[GitHub] [spark] eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r310451827 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSui

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

dongjoon-hyun commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#discussion_r310451831 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/ca

[GitHub] [spark] eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r310451767 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterTab

[GitHub] [spark] HyukjinKwon commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

HyukjinKwon commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518101409 +1 too This is an automated message

[GitHub] [spark] ScrapCodes commented on issue #24083: [SPARK-24432] Support dynamic allocation without external shuffle service

ScrapCodes commented on issue #24083: [SPARK-24432] Support dynamic allocation without external shuffle service URL: https://github.com/apache/spark/pull/24083#issuecomment-518100834 Hi @vanzin, Do you have an update? Can you please link the PR you were mentioning here? -

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

HyukjinKwon commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#discussion_r310450721 ## File path: sql/core/src/test/resources/sql-tests/results/udf/pgSQL/udf-

[GitHub] [spark] ScrapCodes edited a comment on issue #24083: [SPARK-24432] Support dynamic allocation without external shuffle service

ScrapCodes edited a comment on issue #24083: [SPARK-24432] Support dynamic allocation without external shuffle service URL: https://github.com/apache/spark/pull/24083#issuecomment-518100834 Hi @vanzin, Do you have an update? Can you please provide link to the PR you were mentioning here?

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25229: [SPARK-27900][K8s] Add jvm oom flag

dongjoon-hyun commented on a change in pull request #25229: [SPARK-27900][K8s] Add jvm oom flag URL: https://github.com/apache/spark/pull/25229#discussion_r310450127 ## File path: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ## @@ -60,14 +6

[GitHub] [spark] SparkQA commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

SparkQA commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518099443 **[Test build #108645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108645/testReport

[GitHub] [spark] AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518098981 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] [spark] AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518098972 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

AmplabJenkins removed a comment on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518099019 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins removed a comment on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

AmplabJenkins removed a comment on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518099017 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

AmplabJenkins commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518099017 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

AmplabJenkins commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518099019 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.b

[GitHub] [spark] AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518098981 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518098972 Merged build finished. Test PASSed.

[GitHub] [spark] gengliangwang commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

gengliangwang commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-518098604 In SQL, the keyword "as" is usually used for aliasing. How about changing the syntax as ``` sh

[GitHub] [spark] SparkQA commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

SparkQA commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518097770 **[Test build #108644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] dongjoon-hyun commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

dongjoon-hyun commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518094656 cc @HyukjinKwon This is an

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

dongjoon-hyun commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#discussion_r310445192 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] cloud-fan commented on a change in pull request #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

cloud-fan commented on a change in pull request #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#discussion_r310443661 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.sca

[GitHub] [spark] JkSelf commented on a change in pull request #25295: [SPARK-28560][SQL] Optimize shuffle reader to local shuffle reader when smj converted to bhj in adaptive execution

JkSelf commented on a change in pull request #25295: [SPARK-28560][SQL] Optimize shuffle reader to local shuffle reader when smj converted to bhj in adaptive execution URL: https://github.com/apache/spark/pull/25295#discussion_r310443519 ## File path: sql/core/src/main/scala/org/a

[GitHub] [spark] JkSelf commented on issue #25295: [SPARK-28560][SQL] Optimize shuffle reader to local shuffle reader when smj converted to bhj in adaptive execution

JkSelf commented on issue #25295: [SPARK-28560][SQL] Optimize shuffle reader to local shuffle reader when smj converted to bhj in adaptive execution URL: https://github.com/apache/spark/pull/25295#issuecomment-518092402 We have done the functionality and performance tests in 3TB TPC-DS. And

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

dongjoon-hyun commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#discussion_r310442564 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execut

[GitHub] [spark] HeartSaVioR commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncoding

HeartSaVioR commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518089775 First of all, whatever my

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310440369 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite

[GitHub] [spark] WeiWenda commented on issue #22344: [SPARK-25352][SQL] Perform ordered global limit when limit number is bigger than topKSortFallbackThreshold

WeiWenda commented on issue #22344: [SPARK-25352][SQL] Perform ordered global limit when limit number is bigger than topKSortFallbackThreshold URL: https://github.com/apache/spark/pull/22344#issuecomment-518089073 @viirya I meet the same problem when running "insert owerwrite xx select xx

[GitHub] [spark] SparkQA commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

SparkQA commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-518088927 **[Test build #108643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108643/testRepo

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310440612 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourc

[GitHub] [spark] AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-518088523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-518088516 Merged build finished. Test PASSed. Th

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310440369 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite

[GitHub] [spark] AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-518088516 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-518088523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] [spark] AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087938 Test FAILed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] SparkQA removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

SparkQA removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087572 **[Test build #108642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087934 Merged build finished. Test FAILed.

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310440024 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourc

[GitHub] [spark] AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087934 Merged build finished. Test FAILed. Thi

[GitHub] [spark] SparkQA commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

SparkQA commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087927 **[Test build #108642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108642/

[GitHub] [spark] SparkQA commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

SparkQA commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087572 **[Test build #108642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108642/t

[GitHub] [spark] dongjoon-hyun closed pull request #25313: [WIP][SPARK-28580][SQL] Support ANSI SQL Unique-Predicate syntax

dongjoon-hyun closed pull request #25313: [WIP][SPARK-28580][SQL] Support ANSI SQL Unique-Predicate syntax URL: https://github.com/apache/spark/pull/25313 This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] dongjoon-hyun commented on issue #25313: [WIP][SPARK-28580][SQL] Support ANSI SQL Unique-Predicate syntax

dongjoon-hyun commented on issue #25313: [WIP][SPARK-28580][SQL] Support ANSI SQL Unique-Predicate syntax URL: https://github.com/apache/spark/pull/25313#issuecomment-518087413 Hi, @beliefer . Thank you for your investigation, but we are using GitHub PRs for reviewing the implementations.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087224 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087228 Test PASSed. Refer to this link for build results (access rights to CI server needed): ht

[GitHub] [spark] AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087224 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518087228 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

AmplabJenkins removed a comment on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-517884834 Can one of the admins verify this patch? ---

[GitHub] [spark] dongjoon-hyun commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

dongjoon-hyun commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518086290 ok to test This is an automated message

[GitHub] [spark] dongjoon-hyun commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

dongjoon-hyun commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-518086274 Hi, @shivsood . So, do you mean this PR fails at UT in your local environment?

[GitHub] [spark] dongjoon-hyun commented on issue #25329: [WIP][SPARK-28596][SQL] Use Java 8 time API in the date_trunc() function

dongjoon-hyun commented on issue #25329: [WIP][SPARK-28596][SQL] Use Java 8 time API in the date_trunc() function URL: https://github.com/apache/spark/pull/25329#issuecomment-518085867 Thank you for the benchmark, @MaxGekk . I also didn't expect the slowdown. When you close this PR, could

[GitHub] [spark] SparkQA commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

SparkQA commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518085025 **[Test build #108641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518084671 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518084674 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] [spark] AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518084671 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-518084674 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

dongjoon-hyun edited a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518084351 Although there is [a side effect](https://github.com/apache/spark/pull/25357#discussion_r31

[GitHub] [spark] wangyum commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

wangyum commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#discussion_r310437370 ## File path: sql/core/src/test/resources/sql-tests/results/pgSQL/with.sql.out

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

dongjoon-hyun edited a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518084351 This PR seems to have a bigger positive side than a negative side. I'm supporting this PR,

[GitHub] [spark] dongjoon-hyun commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

dongjoon-hyun commented on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#issuecomment-518084351 This PR seems to have a bigger positive side than a negative side. I'm supporting this PR, @wangyu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

dongjoon-hyun commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#discussion_r310437023 ## File path: sql/core/src/test/resources/sql-tests/results/pgSQL/with.sq

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of Unsupporte

dongjoon-hyun edited a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518083496 I'm very sad to h

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of Unsupporte

dongjoon-hyun edited a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518083496 I'm very sad to h

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of Unsupporte

dongjoon-hyun edited a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518083496 I'm very sad to h

[GitHub] [spark] dongjoon-hyun commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodi

dongjoon-hyun commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518083496 I'm very sad to hear you

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310434883 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourc

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310434883 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourc

[GitHub] [spark] AmplabJenkins commented on issue #20640: [SPARK-19755][Mesos] Blacklist is always active for MesosCoarseGrainedSchedulerBackend

AmplabJenkins commented on issue #20640: [SPARK-19755][Mesos] Blacklist is always active for MesosCoarseGrainedSchedulerBackend URL: https://github.com/apache/spark/pull/20640#issuecomment-518082507 Can one of the admins verify this patch? --

[GitHub] [spark] dongjoon-hyun commented on issue #25356: [SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots

dongjoon-hyun commented on issue #25356: [SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots URL: https://github.com/apache/spark/pull/25356#issuecomment-518082502 Ya. I'm checking the other commits and found that #24560 passed 4 hours ago without thi

[GitHub] [spark] asfgit closed pull request #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

asfgit closed pull request #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] HyukjinKwon commented on issue #25356: [SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots

HyukjinKwon commented on issue #25356: [SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots URL: https://github.com/apache/spark/pull/25356#issuecomment-518082173 Thanks. ``` * checking CRAN incoming feasibility ...Error in readRDS(con) :

[GitHub] [spark] AmplabJenkins removed a comment on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

AmplabJenkins removed a comment on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-518081589 Test PASSed. Refer to this link for build results (access ri

[GitHub] [spark] AmplabJenkins removed a comment on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

AmplabJenkins removed a comment on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-518081587 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

AmplabJenkins commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-518081587 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

AmplabJenkins commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-518081589 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310435260 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourc

[GitHub] [spark] SparkQA removed a comment on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

SparkQA removed a comment on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-518066646 **[Test build #108638 has started](https://amplab.cs.berkeley.edu/je

[GitHub] [spark] AmplabJenkins removed a comment on issue #25356: [SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots

AmplabJenkins removed a comment on issue #25356: [SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots URL: https://github.com/apache/spark/pull/25356#issuecomment-518081357 Merged build finished. Test FAILed. ---

  1   2   3   4   5   >