Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20669
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175532438
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175522981
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175520457
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175518159
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175268465
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175262319
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175238936
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175238547
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175237767
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175237354
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -79,6 +79,12 @@ private[spark] object Config
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174902939
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174902563
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174638065
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174636792
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174636507
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174636337
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174635977
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174630216
--- Diff:
examples/src/main/scala/org/apache/spark/examples/SparkRemoteFileTest.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174629033
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174628986
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174628963
--- Diff: bin/docker-image-tool.sh ---
@@ -63,9 +63,11 @@ function build {
error "Cannot find docker image. This script must be run from a
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174627764
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174626914
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174626720
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174626627
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +184,31 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174626276
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174608662
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -33,7 +33,9 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174607871
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174606620
--- Diff:
examples/src/main/scala/org/apache/spark/examples/SparkRemoteFileTest.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174602662
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174597583
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174597008
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala
---
@@ -108,62 +111,42 @@ class
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174596718
--- Diff: bin/docker-image-tool.sh ---
@@ -63,9 +63,11 @@ function build {
error "Cannot find docker image. This script must be run from a
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174596786
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark] object
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174583140
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174582921
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174582150
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -33,7 +33,9 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174564001
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -110,30 +109,29
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174564815
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -33,7 +33,9 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174562210
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -202,6 +221,10
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174561587
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174350660
--- Diff: bin/docker-image-tool.sh ---
@@ -63,9 +63,11 @@ function build {
error "Cannot find docker image. This script must be run from a
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174348342
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala
---
@@ -108,62 +111,42 @@ class
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174345430
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174345374
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174345265
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +179,26
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174329806
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala
---
@@ -108,62 +111,42 @@ class
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174329513
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174329568
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174328774
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,6 +179,26 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174328964
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -202,6 +221,10 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174328623
--- Diff: bin/docker-image-tool.sh ---
@@ -63,9 +63,11 @@ function build {
error "Cannot find docker image. This script must be run from a
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r173912287
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r173871228
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85 @@
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r173866657
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r173665102
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r173663339
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r172678246
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r172677514
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
---
@@ -0,0 +1,85 @@
GitHub user ifilonenko opened a pull request:
https://github.com/apache/spark/pull/20669
[SPARK-22839][K8S] Remove the use of init-container for downloading remote
dependencies
## What changes were proposed in this pull request?
Removal of the init-container for
61 matches
Mail list logo
