Review Request 46889: Improve output of command execution retry logic on agents

2016-05-02 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit Mo

Re: Review Request 46889: Improve output of command execution retry logic on agents

2016-05-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131294 --- Ship it! Ship It! - Sebastian Toader On May 2, 2016, 2:05 p.

Re: Review Request 46889: Improve output of command execution retry logic on agents

2016-05-02 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131296 --- Ship it! Ship It! - Oliver Szabo On May 2, 2016, 12:05 p.m.,

Re: Review Request 46889: Improve output of command execution retry logic on agents

2016-05-02 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131297 --- Ship it! Ship It! - Laszlo Puskas On May 2, 2016, 12:05 p.m.

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

2016-05-02 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46833/ --- (Updated May 2, 2016, 12:55 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

2016-05-02 Thread Mugdha Varadkar
> On April 29, 2016, 6:09 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > line 357 > > > > > > Same as above. We dont do anything with

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

2016-05-02 Thread Mugdha Varadkar
> On April 29, 2016, 6:05 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml, > > line 52 > > > > > > I am assuming this is a new proper

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

2016-05-02 Thread Mugdha Varadkar
> On April 29, 2016, 6 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > line 350 > > > > > > check_ranger_service_support_kerberos() re

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

2016-05-02 Thread Mugdha Varadkar
> On April 29, 2016, 6:03 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > line 477 > > > > > > In the old logic we used to retry on ch

Re: Review Request 46889: Improve output of command execution retry logic on agents

2016-05-02 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131305 --- Ship it! Ship It! - Sandor Magyari On May 2, 2016, 12:05 p.m

Review Request 46895: Add smartconfig for Logsearch

2016-05-02 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46895/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 46895: Add smartconfig for Logsearch

2016-05-02 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46895/#review131311 --- Ship it! Ship It! - Sumit Mohanty On May 2, 2016, 1:56 p.m.,

Re: Review Request 46895: Add smartconfig for Logsearch

2016-05-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46895/#review131328 --- Ship it! Ship It! - Miklos Gergely On May 2, 2016, 1:56 p.m.

Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

2016-05-02 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46752/#review131329 --- Ship it! Ship It! - bhuvnesh chaudhary On April 28, 2016, 9:

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review131336 --- ambari-admin/src/main/resources/ui/admin-web/app/scripts/controll

Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

2016-05-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46898/ --- Review request for Ambari, Nate Cole and Sid Wagle. Bugs: AMBARI-16207 http

Re: Review Request 46861: AMBARI-16193 Message with "null" shows up in showRestartRequiredPopup

2016-05-02 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46861/#review131346 --- Ship it! Ship It! - Richard Zang On April 30, 2016, 12:59 a.

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

2016-05-02 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46852/#review131348 --- Ship it! Ship It! - Alexander Denissov On April 29, 2016, 8:

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-02 Thread Tim Thorpe
> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote: > > Do we have a branch cut with these changes in so that we can test HAWQ and > > PXF with this new logic ? After testing the branch can be merged to trunk > > and we will avoid any major surprises. > > Tim Thorpe wrote: > There i

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131350 --- ambari-web/app/controllers/main/service/reassign/step4_controller

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-02 Thread Keta Patel
> On May 2, 2016, 5:28 p.m., Di Li wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 75 > > > > > > what happens when permission_label is not Non

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-02 Thread Alexander Denissov
> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote: > > Do we have a branch cut with these changes in so that we can test HAWQ and > > PXF with this new logic ? After testing the branch can be merged to trunk > > and we will avoid any major surprises. > > Tim Thorpe wrote: > There i

Review Request 46903: Atlas Integration : Atlas start failed after removing old version of the atlas and installing new one

2016-05-02 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46903/ --- Review request for Ambari, John Speidel and Nate Cole. Bugs: AMBARI-16204 h

Review Request 46899: Disable alternate user search functionality by default

2016-05-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46899/ --- Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, Rob

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > > > > > Unless HAWQ is using YARN as the scheduler, HAWQ may still

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-05-02 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/ --- (Updated May 2, 2016, 2:24 p.m.) Review request for Ambari, Alejandro Fernandez

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-05-02 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review131379 --- ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (lin

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/ --- (Updated May 2, 2016, 9:47 p.m.) Review request for Ambari. Bugs: AMBARI-1617

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-05-02 Thread Nahappan Somasundaram
> On May 2, 2016, 2:44 p.m., Ajit Kumar wrote: > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 856 > > > > > > missed renaming this. Fixed. > On May 2, 2016, 2:44 p.m., Ajit Kumar wrote:

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-05-02 Thread Ajit Kumar
> On May 2, 2016, 9:44 p.m., Ajit Kumar wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 837 > > > > > > Othere tables have start_time as the column name. It will be good to > > have the

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131391 --- ambari-web/app/controllers/main/service/reassign/step4_controller

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
> On May 2, 2016, 10:16 p.m., Matt wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > > > > > If HAWQ is configured to work on Standalone mode, should HAWQ be in the > >

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread bhuvnesh chaudhary
> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > > > > > Unless HAWQ is using YARN as the scheduler, HAWQ may still

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131403 --- ambari-web/app/controllers/main/service/reassign/step4_controller

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-05-02 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/ --- (Updated May 2, 2016, 3:33 p.m.) Review request for Ambari, Alejandro Fernandez

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-02 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this couple of missing imports to ACCUMULO serv

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-02 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131409 --- ambari-server/src/main/resources/stacks/stack_advisor.py (line 61

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131414 --- Ship it! Looks good other than the comments - bhuvnesh chaudha

Review Request 46919: Enable addingNewRepository on trunk by default

2016-05-02 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46919/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-16208 https:

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread Matt
> On April 29, 2016, 5:21 p.m., bhuvnesh chaudhary wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > > > > > Unless HAWQ is using YARN as the scheduler, HAWQ may still b

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-02 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131430 --- Ship it! Ship It! - Matt On April 29, 2016, 5:51 p.m., Juanj

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > > > > > Unless HAWQ is using YARN as the scheduler, HAWQ may still

Re: Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

2016-05-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46898/#review131438 --- Ship it! Ship It! - Nate Cole On May 2, 2016, 2:17 p.m., Jon

Re: Review Request 46903: Atlas Integration : Atlas start failed after removing old version of the atlas and installing new one

2016-05-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46903/#review131439 --- Ship it! Ship It! - Nate Cole On May 2, 2016, 3:42 p.m., Tom

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/ --- (Updated May 3, 2016, 12:59 a.m.) Review request for Ambari. Bugs: AMBARI-161

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
> On May 2, 2016, 10:31 p.m., bhuvnesh chaudhary wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 581 > > > > > > somehow placing the logic here does not fit well to the meth

Re: Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

2016-05-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46898/#review131440 --- Ship it! Awesome !! We definetly needed this. - Sid Wagle On

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-02 Thread Jeff Zhang
> On April 29, 2016, 10:07 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json, > > line 1 > > > > > > Having 1.6.x.2.4 and 1.6.x.2.5 is definitely confusing e

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-02 Thread Jeff Zhang
> On April 29, 2016, 9:57 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml, > > line 24 > > > > > > We now support reading p

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-02 Thread Jeff Zhang
> On April 29, 2016, 9:53 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml, > > line 1 > > > > > > We shouldnt name this as 1.6.x.2.4. Just SPARK/1.6.0. I do

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-02 Thread Jeff Zhang
> On April 29, 2016, 10:10 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py, > > line 61 > > > > > > get_stack_to_compoent is now been rem

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-02 Thread Jeff Zhang
> On April 29, 2016, 12:25 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py, > > line 45 > > > > > > Will Spark hist server and livy ser

Review Request 46925: Write out new log property files under /etc/hive2/conf

2016-05-02 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46925/ --- Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar. Bugs: AMB

Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

2016-05-02 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46927/ --- Review request for Ambari, Jaimin Jetly and Sumit Mohanty. Repository: ambari

Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

2016-05-02 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42155/ --- (Updated 五月 3, 2016, 4:57 a.m.) Review request for Ambari and Matt. Changes -