Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review116935 --- Master (0eb753d) is red with this patch.

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/ --- (Updated Jan. 29, 2016, 12:44 a.m.) Review request for Aurora. Bugs:

Review Request 42964: Add flag to optionally disable the leader redirect filter.

2016-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1601

Re: Review Request 42922: Revert "Improving job update query performance."

2016-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42922/#review116970 --- I can't edit the review post-submit to add a link to the ticket,

Re: Review Request 42964: Add flag to optionally disable the leader redirect filter.

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review116973 --- Exploring ideas - would an HTTP header be more handy for this? -

Re: Review Request 42964: Add flag to optionally disable the leader redirect filter.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review116974 --- Ship it! Master (0eb753d) is green with this patch.

Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/ --- Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
> On Jan. 29, 2016, 3:56 p.m., Aurora ReviewBot wrote: > > Master (0eb753d) is red with this patch. > > ./build-support/jenkins/build.sh > > > >  """Stop the runner. If it's already > > completed, no-op. If it's still running, issue a kill.""" > >

Review Request 43005: Add Fitbit to the Aurora adopters list

2016-01-29 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43005/ --- Review request for Aurora. Repository: aurora Description --- Add

Review Request 42979: Enable ping query to prevent use of invalid pooled connections.

2016-01-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42979/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1596

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117044 --- docs/committers.md (line 73)

Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-01-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1596

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117046 --- Fix it, then Ship it! docs/committers.md (line 67)

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117053 --- Ship it! Master (0eb753d) is green with this patch.

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117064 --- Ship it! Master (0eb753d) is green with this patch.

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/#review117065 --- Master (0eb753d) is green with this patch.

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117071 --- Ship it! Master (0eb753d) is green with this patch.

Re: Review Request 42979: Enable ping query to prevent use of invalid pooled connections.

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42979/#review117037 --- Ship it! Ship It! - Bill Farner On Jan. 29, 2016, 2:38

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/ --- (Updated Jan. 29, 2016, 3:31 p.m.) Review request for Aurora. Bugs:

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/ --- (Updated Jan. 29, 2016, 3:30 p.m.) Review request for Aurora. Bugs:

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117068 --- jfarrell: I'm definitely going to wait on your opinion on this

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Joshua Cohen
> On Jan. 29, 2016, 10:42 p.m., Stephan Erb wrote: > > If this is crucial for recovery, this should really be documented. Yeah, for sure. I filed https://issues.apache.org/jira/browse/AURORA-1605 to track updating the recovery docs. - Joshua

Re: Review Request 42979: Enable ping query to prevent use of invalid pooled connections.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42979/#review117042 --- Master (0eb753d) is green with this patch.

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/#review117045 --- Ship it! Ship It! - John Sirois On Jan. 29, 2016, 4:23

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
> On Jan. 29, 2016, 4:29 p.m., Bill Farner wrote: > > docs/committers.md, line 67 > > > > > > The `[RESULT][VOTE]` part should become step 5 - successful and failed > > votes are closed out in the same way. > >

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/#review117049 --- Fix it, then Ship it!

Re: Review Request 43005: Add Fitbit to the Aurora adopters list

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43005/#review117086 --- Ship it! Sweet! - Bill Farner On Jan. 29, 2016, 6:08 p.m.,

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117087 --- Can you add a test case for the new behavior? Also, an 0.13.0

Re: Review Request 43005: Add Fitbit to the Aurora adopters list

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43005/#review117083 --- Ship it! Master (0eb753d) is green with this patch.

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117036 --- If this is crucial for recovery, this should really be

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Bill Farner
> On Jan. 29, 2016, 3:29 p.m., Bill Farner wrote: > > docs/committers.md, line 67 > > > > > > The `[RESULT][VOTE]` part should become step 5 - successful and failed > > votes are closed out in the same way. > >

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117054 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 29, 2016,

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117062 --- Master (0eb753d) is red with this patch.

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/ --- (Updated Jan. 29, 2016, 4:56 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117066 --- @ReviewBot retry - Benjamin Staffin On Jan. 29, 2016, 3:31

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117026 --- Ship it! Master (0eb753d) is green with this patch.

Re: Review Request 42964: Add flag to optionally disable the leader redirect filter.

2016-01-29 Thread Joshua Cohen
> On Jan. 29, 2016, 6:18 p.m., Bill Farner wrote: > > Exploring ideas - would an HTTP header be more handy for this? I like that idea, would save a restart and it would potentially be more generally useful. Will send an update going in that direction. - Joshua

Review Request 42975: Change the way arguments are passed to scheduler in debian

2016-01-29 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/ --- Review request for Aurora, John Sirois, Dmitriy Shirchenko, and Bill Farner.

Re: Review Request 42975: Change the way arguments are passed to scheduler in debian

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/#review117003 --- Ship it! Ship It! - John Sirois On Jan. 29, 2016, 1:17

Re: Review Request 42922: Revert "Improving job update query performance."

2016-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42922/ --- (Updated Jan. 29, 2016, 1:38 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 42922: Revert "Improving job update query performance."

2016-01-29 Thread John Sirois
> On Jan. 29, 2016, 10:56 a.m., Joshua Cohen wrote: > > I can't edit the review post-submit to add a link to the ticket, but we've > > filed https://issues.apache.org/jira/browse/AURORA-1603 to track the triage > > of what actually went wrong with this commit. I was able to click reopen, edit

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/ --- (Updated Jan. 29, 2016, 8:54 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Joshua Cohen
> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, > > line 45 > > > > > > Since this is a custom header perhaps we should prefix it with

Re: Review Request 42975: Change the way arguments are passed to scheduler in debian

2016-01-29 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/#review117007 --- Ship it! Ship It! - Dmitriy Shirchenko On Jan. 29, 2016,

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117013 --- I think you also need to add a flag/option to `aurora_admin` to

Re: Review Request 42975: Change the way arguments are passed to scheduler in debian

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/#review117014 --- Ship it! Ship It! - Bill Farner On Jan. 29, 2016, 12:17