Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-22 Thread Pierre Cheynier
> On March 22, 2016, 1:02 a.m., Joshua Cohen wrote: > > Sorry for the delay on this. After you filed the pull request, I > > investigated a bit what will be required once Mesos 0.30.0 lands: > > https://issues.apache.org/jira/browse/AURORA-1632. I think the problem goes > > beyond the failure

Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-22 Thread Pierre Cheynier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45104/ --- (Updated March 22, 2016, 9:50 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-22 Thread Zameer Manji
> On March 21, 2016, 8:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 345 > > > > > > I think we should be consistent and return a

Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/ --- (Updated March 22, 2016, 11:48 a.m.) Review request for Aurora, Benjamin Rice

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/ --- (Updated March 22, 2016, 3:49 p.m.) Review request for Aurora, Maxim

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/#review124832 --- Ship it! LGTM modulo Maxim's comment. - Zameer Manji On

Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/ --- Review request for Aurora, Benjamin Rice and Stephan Erb. Bugs: AURORA-1647

Review Request 45172: Tweak update-sources script to also update mesos config.

2016-03-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45172/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124833 --- Drive-by review: Please also add an entry to the

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124835 --- Ship it! Master (335cf88) is green with this patch.

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124841 --- Master (335cf88) is red with this patch.

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/ --- (Updated March 22, 2016, 6:51 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124839 --- Ship it! This change LGTM. I was a bit confused if

Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/#review124848 --- Ship it! Master (d5d7ec0) is green with this patch.

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124814 --- Ship it! Thanks for following up! - Maxim Khutornenko On

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124821 ---

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/ --- (Updated March 22, 2016, 4:25 p.m.) Review request for Aurora, Maxim

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124815 --- Master (335cf88) is red with this patch.

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124886 --- Ship it! Ship It! - Zameer Manji On March 22, 2016, 2:04

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124871 --- Ship it! Master (d5d7ec0) is green with this patch.

Re: Review Request 45178: Revert "Add support for storing and fetching images as properties of task configs."

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45178/#review124880 --- Ship it! Ship It! - Maxim Khutornenko On March 22, 2016,

Re: Review Request 45177: Prototype of setting DiscoveryInfo.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review124885 --- Master (b5c9e1b) is red with this patch.

Re: Review Request 45115: AURORA-1642: Thermos runner finalization broken.

2016-03-22 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ --- (Updated March 22, 2016, 1:06 p.m.) Review request for Aurora, Maxim

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ --- (Updated March 22, 2016, 2:04 p.m.) Review request for Aurora, Maxim

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124883 --- Ship it! Master (b5c9e1b) is green with this patch.

Review Request 45178: Revert "Add support for storing and fetching images as properties of task configs."

2016-03-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45178/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1648

Re: Review Request 45179: Support for overriding --mesos-root under upstart.

2016-03-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45179/ --- (Updated March 22, 2016, 4:49 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45182/#review124907 --- src/main/java/org/apache/aurora/scheduler/http/Mname.java (line

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124891 --- Ship it! src/main/python/apache/thermos/core/process.py (line

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/ --- (Updated March 22, 2016, 11:21 p.m.) Review request for Aurora, Maxim

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45182/#review124918 --- Ship it! Ship It! - Maxim Khutornenko On March 22, 2016,

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/#review124921 --- Ship it! Master (b5c9e1b) is green with this patch.

Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/#review124889 --- Looks good! A few notes regarding related sections, even though

Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois
> On March 22, 2016, 3:26 p.m., Stephan Erb wrote: > > Looks good! A few notes regarding related sections, even though not > > completely correleated with your change. Changes forthcoming. > On March 22, 2016, 3:26 p.m., Stephan Erb wrote: > > docs/installing.md, line 330 > >

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124899 --- Master (b5c9e1b) is red with this patch.

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-22 Thread John Sirois
On March 13, 2016, 6:04 a.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 45179: Support for overriding --mesos-root under upstart.

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45179/#review124910 --- Ship it! Ship It! - Stephan Erb On March 22, 2016, 11:49

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ --- (Updated March 22, 2016, 3:04 p.m.) Review request for Aurora, Maxim

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ --- (Updated March 22, 2016, 3:35 p.m.) Review request for Aurora, Maxim

Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45182/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45182/ --- (Updated March 23, 2016, 12:33 a.m.) Review request for Aurora and Maxim

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45182/#review124916 --- Master (b5c9e1b) is green with this patch.

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124922 --- @ReviewBot retry - Maxim Khutornenko On March 22, 2016, 10:35

Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/ --- (Updated March 22, 2016, 4:40 p.m.) Review request for Aurora, Benjamin Rice

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/#review124902 --- Ship it! Ship It! - Maxim Khutornenko On March 22, 2016,

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Stephan Erb
> On March 23, 2016, 12:12 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/http/Mname.java, line 62 > > > > > > ? Oh no, what whas I thinking :-) - Stephan

Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/#review124926 --- Ship it! Master (b5c9e1b) is green with this patch.

Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.

2016-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124929 --- Ship it! Master (b5c9e1b) is green with this patch.

Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/ --- Review request for Aurora, David Chung, Bill Farner, and Zameer Manji.

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/ --- (Updated March 22, 2016, 8:32 p.m.) Review request for Aurora, David Chung,

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124935 --- Thanks for the changes, this is looking great! My most pressing

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review124954 --- Ship it! Ship It! - Bill Farner On March 22, 2016, 7:32

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Bill Farner
> On March 22, 2016, 7:23 p.m., Bill Farner wrote: > > docs/security.md, line 289 > > > > > > I'd like to propose several changes to this section, which i've made in > > the rewritten block below. > > > >

Re: Review Request 45172: Tweak update-sources script to also update mesos config.

2016-03-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45172/#review124956 --- examples/vagrant/provision-dev-cluster.sh (lines 89 - 92)