://reviews.apache.org/r/32806/diff/
Testing
---
Test suite + end-to-end tests.
Thanks,
Bill Farner
b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
Diff: https://reviews.apache.org/r/33103/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79882
---
On April 11, 2015, 5:16 p.m., Bill Farner wrote
/aurora/scheduler/state/TaskAssignerImplTest.java
aca0234e037e85202d182affa2c0e988c6cfc854
Diff: https://reviews.apache.org/r/33105/diff/
Testing
---
Thanks,
Bill Farner
,
Bill Farner
On April 17, 2015, 5:59 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
lines 142-144
https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142
```
SetString allSlaves = Sets.newHashSet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33374/#review81046
---
Ship it!
Ship It!
- Bill Farner
On April 20, 2015, 10:19 p.m
'_makefile_refs'
```
Diffs
-
build-support/virtualenv 1cdfc7ff95fb4d2f748325610664f8912366bd2a
Diff: https://reviews.apache.org/r/33403/diff/
Testing (updated)
---
End-to-end tests pass.
Thanks,
Bill Farner
on the `Sets.newHashSet` usage before
this lands.
- Bill Farner
On April 21, 2015, 1:12 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597
.
- Bill Farner
On April 21, 2015, 7:53 p.m., Bhuvan Arumugam wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33366/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33279/#review81512
---
Ping - Maxim, can you check my replies above?
- Bill Farner
://reviews.apache.org/r/33279/#review80750
---
On April 16, 2015, 10 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On April 20, 2015, 6:14 p.m., Aurora ReviewBot wrote:
Master (b18dc44) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing
@ReviewBot retry
Bhuvan
, even if rudimentary.
- Please lift the first line of your description to the Summary, Fix the path
to download stdout/stderr. The summary becomes the first line of the commit
message, so it's ideal for it to explain the fix rather than state the problem.
- Bill Farner
On April 20, 2015, 5:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33317/#review80805
---
Ship it!
Ship It!
- Bill Farner
On April 20, 2015, 7:17 p.m
/storage/mem/StorageTransactionTest.java
bad9eb56b33c3e649c3b173e83d9c30da8f9317d
Diff: https://reviews.apache.org/r/33612/diff/
Testing
---
Unit tests and end-to-end tests, both using the new task store by default with
this change.
Thanks,
Bill Farner
ef502b7dcc48c716f71ab5ce920084917564f6ff
src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java
c96821683b4569977d6d2b8ed657b0625bdd1903
Diff: https://reviews.apache.org/r/33659/diff/
Testing
---
TODO(wfarner): Verify in end-to-end tests.
Thanks,
Bill Farner
-kerberos.conf
ef502b7dcc48c716f71ab5ce920084917564f6ff
src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java
c96821683b4569977d6d2b8ed657b0625bdd1903
Diff: https://reviews.apache.org/r/33659/diff/
Testing (updated)
---
End-to-end tests pass.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33537/#review81826
---
Ship it!
Ship It!
- Bill Farner
On April 27, 2015, 11:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33658/#review81990
---
On April 29, 2015, 9:24 p.m., Bill Farner wrote
to minimize the code to implement decorators.
[1]
http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/ForwardingExecutorService.html
- Bill Farner
On April 22, 2015, 10:58 p.m., Maxim Khutornenko wrote
.
docs/security.md
https://reviews.apache.org/r/33537/#comment132149
Markdown didn't like the format example here.
- Bill Farner
On April 24, 2015, 10:40 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail
/aurora/scheduler/storage/mem/MemTaskStoreTest.java
688a02f8c827d5185e35ae2ec919dd0ae5b958ec
Diff: https://reviews.apache.org/r/33600/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33243/#review81753
---
Ship it!
Ship It!
- Bill Farner
On April 27, 2015, 11:14 p.m
On April 28, 2015, 12:37 a.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 243
https://reviews.apache.org/r/33458/diff/1/?file=940120#file940120line243
I'm not too fond of this, it points out that `BenchmarkSettings` is
being used
coverage for
the database-backed task store. Since it will be enabled with a toggle, i
stopped here so the initial diff is only required to pass functional tests, and
we can then iterate on performance.
- Bill Farner
On April 28, 2015, 12:57 a.m., Bill Farner wrote
/scheduler/updater/JobUpdaterIT.java
010e75f05449f618017cb40fd3298e7147a1d2c8
Diff: https://reviews.apache.org/r/33611/diff/
Testing
---
Thanks,
Bill Farner
/StatusUpdateBenchmark.java
https://reviews.apache.org/r/33608/#comment132861
I should have asked the first time around - what's the thought process
behind including this? Given that this is a benchmark, it seems only to place
a ceiling on throughput.
- Bill Farner
On April 30, 2015, 12:35 a.m., Ben Mahler wrote
a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/
---
(Updated April 30, 2015, 12:12 a.m.)
Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33739/#review82321
---
Ship it!
Ship It!
- Bill Farner
On May 1, 2015, 9:32 p.m., Zeke
/
Testing
---
TODO(wfarner): Report back after verifying end-to-end tests pass for a fresh
vagrant machine.
Thanks,
Bill Farner
/SchedulerDriverModule.java
https://reviews.apache.org/r/33608/#comment132687
If anything, you should expose Scheduler.class to hide the implementation.
This should allow you to revert changes in MesosSchedulerImpl.java.
- Bill Farner
On April 29, 2015, 6:12 p.m., Ben Mahler wrote
/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33458/#review81850
---
Ship it!
Ship It!
- Bill Farner
On April 28, 2015, 5:24 p.m
2014b73a44cfdb198f738cb110399d62c396fa1f
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
010e75f05449f618017cb40fd3298e7147a1d2c8
Diff: https://reviews.apache.org/r/33611/diff/
Testing
---
Thanks,
Bill Farner
---
Thanks,
Bill Farner
/33676/diff/
Testing
---
Thanks,
Bill Farner
/mem/InMemTaskStoreTest.java
d1f4026f2b3d1cba542f96cecc0fe490e9ec8132
Diff: https://reviews.apache.org/r/33869/diff/
Testing
---
Thanks,
Bill Farner
/
Testing
---
Unit tests + end-to-end tests.
Thanks,
Bill Farner
---
On May 7, 2015, 11:58 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---
(Updated May 7, 2015, 11
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/update.py, line 122
https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122
Suggest --wait-until for consistency with job create command.
Bill Farner wrote:
`--wait
6fb1f71b7dc787c090fce7b8e7c51baee862f336
Diff: https://reviews.apache.org/r/33962/diff/
Testing
---
Unit tests.
Thanks,
Bill Farner
/test_end_to_end.sh
501d111f87dbaff8b6f22ffc67a9720b4dad
Diff: https://reviews.apache.org/r/33959/diff/
Testing
---
Unit tests + end-to-end tests.
Thanks,
Bill Farner
501d111f87dbaff8b6f22ffc67a9720b4dad
Diff: https://reviews.apache.org/r/33959/diff/
Testing
---
Unit tests + end-to-end tests.
Thanks,
Bill Farner
---
Thanks,
Bill Farner
---
On May 5, 2015, 11:16 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33869
task store by default with
this change.
Thanks,
Bill Farner
,
Bill Farner
/#review83242
---
On May 11, 2015, 5:58 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34046
://reviews.apache.org/r/33689/#comment134246
The histogram would be interesting, but possibly overkill. We should be
able to get good signal with stats we already have - number of status updates
vs number of log writes
- Bill Farner
On May 11, 2015, 6:55 p.m., Ben Mahler wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83331
---
Ship it!
Ship It!
- Bill Farner
On May 11, 2015, 10:19 p.m
this in a follow up).
Bill Farner wrote:
Unless you feel strongly, i would like to punt. I'm not too keen on
building out abstractions for multiple store implementations, since multiple
implementations is intended to be temporary.
Joshua Cohen wrote:
I think it will be very useful
concern that
should be addressed. If you don't mind, i'd like to conclude that discussion
before reviewing.
- Bill Farner
On May 9, 2015, 9:54 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
generated e-mail. To reply, visit:
https://reviews.apache.org/r/33612/#review82915
---
On May 5, 2015, 6:21 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83119
---
Ship it!
Ship It!
- Bill Farner
On May 9, 2015, 12:11 a.m., Joe
/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java
bad9eb56b33c3e649c3b173e83d9c30da8f9317d
Diff: https://reviews.apache.org/r/33612/diff/
Testing
---
Unit tests and end-to-end tests, both using the new task store by default with
this change.
Thanks,
Bill Farner
---
On May 9, 2015, 5:53 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33612
This is pretty weird behavior - 'no logging unless you ask really nicely'.
Rather than the enableLogging flag, how about we let the caller pass a
Logger, and for the finest-only logging, we have a logger that has its level
set appropriately?
- Bill Farner
On May 12, 2015, 8:40 p.m., Maxim
/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh # TODO(wfarner): Report
back, still executing.
```
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83515
---
On May 12, 2015, 10:54 p.m., Bill Farner wrote
Thanks, removed.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83513
---
On May 12, 2015, 11:41 p.m., Bill Farner wrote
/
Testing
---
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
Bill Farner
into if/else?
- Bill Farner
On May 13, 2015, 1:43 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34148
---
Thanks,
Bill Farner
/
---
(Updated May 13, 2015, 1:43 a.m.)
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
Adding more details into task state change result to facilitate task
reconciliation data collection.
Diffs
-
src/main/java/org/apache/aurora
/33273/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33200/#review80362
---
Ping?
- Bill Farner
On April 15, 2015, 12:04 a.m., Bill Farner
://reviews.apache.org/r/33200/diff/
Testing
---
Thanks,
Bill Farner
: https://reviews.apache.org/r/33103/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/#review79562
---
Ship it!
Ship It!
- Bill Farner
On April 9, 2015, 7:15 p.m
45a23fdc58ca7475a805c549463e87ddaa915e74
Diff: https://reviews.apache.org/r/32806/diff/
Testing
---
Test suite + end-to-end tests.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/#review79466
---
Ship it!
Great work!
- Bill Farner
On April 8, 2015, 9:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/#review79480
---
Ship it!
Ship It!
- Bill Farner
On April 8, 2015, 7:35 a.m
/test_http_signaler.py
c6a21708eb997f213f4cca038891a84f6c5218d4
src/test/python/apache/aurora/executor/common/test_health_checker.py
27c71711d52f757ed1552db4accda671a6bdafdd
Diff: https://reviews.apache.org/r/33026/diff/
Testing
---
Thanks,
Bill Farner
?
- Bill Farner
On April 17, 2015, 6:18 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33317/
---
(Updated
to drop all
the `eq()`s.
- Bill Farner
On April 16, 2015, 1:39 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597
On April 15, 2015, 3:07 a.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 135
https://reviews.apache.org/r/33202/diff/1/?file=929440#file929440line135
IMHO the empty string is a wart, and emphasizes my point about letting
://reviews.apache.org/r/33184/#comment129848
Can you test the inverse as well - keys that are not equal?
- Bill Farner
On April 14, 2015, 6:51 p.m., Stephan Erb wrote:
---
This is an automatically generated e-mail. To reply, visit
On April 3, 2015, 7:40 p.m., Stephan Erb wrote:
Thinking about it, we might as well drop all headers 'Description',
'Alerting' and 'Triage'. By just keeping their content around, the
resulting document should be much simpler to read.
Example of the current state:
://reviews.apache.org/r/32329/#comment127399
make this a constant
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
https://reviews.apache.org/r/32329/#comment127398
remove semicolon, remove newline above
- Bill Farner
On March 28, 2015, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review78603
---
Ship it!
Ship It!
- Bill Farner
On March 21, 2015, 2:19 a.m
for DbTaskStore on these benchmarks, i
believe these should be considered acceptable.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35587/#review88806
---
Ship it!
Ship It!
- Bill Farner
On June 19, 2015, 10:07 p.m
while you're here, remove this newline
- Bill Farner
On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760
the rationale behind the default.
- Bill Farner
On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761
. To reply, visit:
https://reviews.apache.org/r/35793/#review89022
---
On June 23, 2015, 6:28 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
,
Bill Farner
, a network
disconnection, or the anticipated case of a consistency violation.
Thanks,
Bill Farner
:
https://reviews.apache.org/r/35672/#review88605
---
On June 19, 2015, 10:43 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment141954
```
The scheduler command line argument enable_legacy_constraints has been
removed, and the scheduler no longer automatically injects 'host' and 'rack'
constraints for production services.
```
- Bill Farner
On June 23, 2015, 11:58 p.m., Zameer Manji wrote
(-)
Nice! 2 requests:
- Can you confirm that end-to-end tests still pass?
- Can you add to this patch a note in NEWS under 0.9.0 that the GC executor has
been removed?
- Bill Farner
On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote
,
Bill Farner
Farner
On June 26, 2015, 2:13 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35901/
---
(Updated June 26
of a consistency violation.
Thanks,
Bill Farner
On June 18, 2015, 4:42 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java,
line 314
https://reviews.apache.org/r/35587/diff/1/?file=986660#file986660line314
What's being tested here? If i'm reading correctly, this test case
)
https://reviews.apache.org/r/35587/#comment140904
What's being tested here? If i'm reading correctly, this test case would
pass before the patch.
- Bill Farner
On June 18, 2015, 1:02 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35639/#review88477
---
Ship it!
Ship It!
- Bill Farner
On June 19, 2015, 1:21 a.m
mostly varies with the response size.
Thanks,
Bill Farner
/UnsecureAuthModule.java (line 40)
https://reviews.apache.org/r/35627/#comment140957
Given how non-obvious this was, it deserves a comment to indicate why this
is necessary.
- Bill Farner
On June 18, 2015, 9:40 p.m., Kevin Sweeney wrote
/r/35630/#review88452
---
On June 18, 2015, 10:39 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35630
1 - 100 of 1035 matches
Mail list logo
