Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-02 Thread Bill Farner
76cb691e6d7d4fada3a18fde73aceed7039bcaa4 Diff: https://reviews.apache.org/r/32806/diff/ Testing --- Test suite + end-to-end tests. Thanks, Bill Farner

Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-02 Thread Bill Farner
://reviews.apache.org/r/32806/diff/ Testing --- Test suite + end-to-end tests. Thanks, Bill Farner

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-02 Thread Bill Farner
#remove()`. - Bill Farner On April 2, 2015, 11:39 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597

Review Request 32802: Add a benchmark for getRoleSummary.

2015-04-02 Thread Bill Farner
/ThriftModule.java c65e0218211b797ad50e2ac62e71136f967e5f5d Diff: https://reviews.apache.org/r/32802/diff/ Testing --- Will post jmh output shortly. Thanks, Bill Farner

Re: Review Request 32802: Add a benchmark for getRoleSummary.

2015-04-03 Thread Bill Farner
. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32802/#review78800 --- On April 3, 2015, 2:19 a.m., Bill Farner wrote

Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

2015-04-11 Thread Bill Farner
/ Testing --- Thanks, Bill Farner

Re: Review Request 33103: Skip known flaky tests.

2015-04-13 Thread Bill Farner
b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1 Diff: https://reviews.apache.org/r/33103/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33103: Skip known flaky tests.

2015-04-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79882 --- On April 11, 2015, 5:16 p.m., Bill Farner wrote

Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

2015-04-13 Thread Bill Farner
/aurora/scheduler/state/TaskAssignerImplTest.java aca0234e037e85202d182affa2c0e988c6cfc854 Diff: https://reviews.apache.org/r/33105/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33106: Simplify AttributeAggregate.

2015-04-13 Thread Bill Farner
, Bill Farner

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Bill Farner
On April 17, 2015, 5:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, lines 142-144 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142 ``` SetString allSlaves = Sets.newHashSet

Re: Review Request 33374: Resuming blocked updates on restart.

2015-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33374/#review81046 --- Ship it! Ship It! - Bill Farner On April 20, 2015, 10:19 p.m

Re: Review Request 33403: Upgrade to virtualenv 12.1.1

2015-04-21 Thread Bill Farner
'_makefile_refs' ``` Diffs - build-support/virtualenv 1cdfc7ff95fb4d2f748325610664f8912366bd2a Diff: https://reviews.apache.org/r/33403/diff/ Testing (updated) --- End-to-end tests pass. Thanks, Bill Farner

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Bill Farner
on the `Sets.newHashSet` usage before this lands. - Bill Farner On April 21, 2015, 1:12 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597

Re: Review Request 33366: Fix the path to download stdout/stderr

2015-04-21 Thread Bill Farner
. - Bill Farner On April 21, 2015, 7:53 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33279/#review81512 --- Ping - Maxim, can you check my replies above? - Bill Farner

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-20 Thread Bill Farner
://reviews.apache.org/r/33279/#review80750 --- On April 16, 2015, 10 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33366: download url for stdout/stderr broken

2015-04-20 Thread Bill Farner
On April 20, 2015, 6:14 p.m., Aurora ReviewBot wrote: Master (b18dc44) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry Bhuvan

Re: Review Request 33366: download url for stdout/stderr broken

2015-04-20 Thread Bill Farner
, even if rudimentary. - Please lift the first line of your description to the Summary, Fix the path to download stdout/stderr. The summary becomes the first line of the commit message, so it's ideal for it to explain the fix rather than state the problem. - Bill Farner On April 20, 2015, 5:57

Re: Review Request 33317: Upgrade to pystachio 0.8.0

2015-04-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33317/#review80805 --- Ship it! Ship It! - Bill Farner On April 20, 2015, 7:17 p.m

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Bill Farner
On April 24, 2015, 6:35 p.m., Bill Farner wrote: Ping - Maxim, can you check my replies above? Maxim Khutornenko wrote: My plan is to avoid changing behavior with the task store, so i did not have any intention of removing fields. Sorry, I was under assumption your

Review Request 33530: Simplify storage bindings, remove shims that are now mostly getting in the way.

2015-04-24 Thread Bill Farner
20c92044774d953aa5f1556a0053240b348e8f16 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 802c0901dc88fd587fde539682287f7dd527d661 Diff: https://reviews.apache.org/r/33530/diff/ Testing --- Thanks, Bill Farner

Review Request 33612: Add a task store implementation that uses a relational database.

2015-04-28 Thread Bill Farner
/storage/mem/StorageTransactionTest.java bad9eb56b33c3e649c3b173e83d9c30da8f9317d Diff: https://reviews.apache.org/r/33612/diff/ Testing --- Unit tests and end-to-end tests, both using the new task store by default with this change. Thanks, Bill Farner

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-04-28 Thread Bill Farner
, visit: https://reviews.apache.org/r/33612/#review81885 --- On April 28, 2015, 8:11 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
methods decouple us from the implementations of [Scheduled]ExecutorService, and the code to do it is very mechanical. However, it will likely require ~200 lines of this wiring code, which i can understand is undesirable at present. - Bill Farner On April 22, 2015, 10:58 p.m., Maxim Khutornenko

Review Request 33658: Remove redundant enable_api_security argument.

2015-04-28 Thread Bill Farner
/LocalSchedulerMain.java a91c4a2e911e24d4d4d5a9b8eb6544491affd890 Diff: https://reviews.apache.org/r/33658/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33658: Remove redundant enable_api_security argument.

2015-04-28 Thread Bill Farner
ca8e23b57a2fc17ca72102b64c70bb21b47bb860 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java a91c4a2e911e24d4d4d5a9b8eb6544491affd890 Diff: https://reviews.apache.org/r/33658/diff/ Testing --- Thanks, Bill Farner

Review Request 33659: Add support for shorthand names of security realm modules.

2015-04-28 Thread Bill Farner
ef502b7dcc48c716f71ab5ce920084917564f6ff src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java c96821683b4569977d6d2b8ed657b0625bdd1903 Diff: https://reviews.apache.org/r/33659/diff/ Testing --- TODO(wfarner): Verify in end-to-end tests. Thanks, Bill Farner

Re: Review Request 33659: Add support for shorthand names of security realm modules.

2015-04-28 Thread Bill Farner
-kerberos.conf ef502b7dcc48c716f71ab5ce920084917564f6ff src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java c96821683b4569977d6d2b8ed657b0625bdd1903 Diff: https://reviews.apache.org/r/33659/diff/ Testing (updated) --- End-to-end tests pass. Thanks, Bill Farner

Re: Review Request 33537: Document Aurora security features.

2015-04-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81826 --- Ship it! Ship It! - Bill Farner On April 27, 2015, 11:24 p.m

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
On April 27, 2015, 8 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 https://reviews.apache.org/r/33456/diff/1/?file=940089#file940089line71 Have you considered creating factory methods that apply decorators to ExecutorServices

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
On April 27, 2015, 8 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 https://reviews.apache.org/r/33456/diff/1/?file=940089#file940089line71 Have you considered creating factory methods that apply decorators to ExecutorServices

Re: Review Request 33659: Add support for shorthand names of security realm modules.

2015-04-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/#review82002 --- On April 29, 2015, 4:45 a.m., Bill Farner wrote

Re: Review Request 33658: Remove redundant enable_api_security argument.

2015-04-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/#review81990 --- On April 29, 2015, 9:24 p.m., Bill Farner wrote

Re: Review Request 33658: Remove redundant enable_api_security argument.

2015-04-29 Thread Bill Farner
/apache/aurora/scheduler/app/local/LocalSchedulerMain.java a91c4a2e911e24d4d4d5a9b8eb6544491affd890 Diff: https://reviews.apache.org/r/33658/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33659: Add support for shorthand names of security realm modules.

2015-04-29 Thread Bill Farner
--- End-to-end tests pass. Thanks, Bill Farner

Re: Review Request 33677: Remove dead code related to Java executor.

2015-04-29 Thread Bill Farner
suspect it might be flaky. - Bill Farner On April 29, 2015, 3:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-27 Thread Bill Farner
to minimize the code to implement decorators. [1] http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/ForwardingExecutorService.html - Bill Farner On April 22, 2015, 10:58 p.m., Maxim Khutornenko wrote

Re: Review Request 33537: Document Aurora security features.

2015-04-27 Thread Bill Farner
. docs/security.md https://reviews.apache.org/r/33537/#comment132149 Markdown didn't like the format example here. - Bill Farner On April 24, 2015, 10:40 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail

Review Request 33600: Extract an abstract base test for TaskStore implementations.

2015-04-27 Thread Bill Farner
/aurora/scheduler/storage/mem/MemTaskStoreTest.java 688a02f8c827d5185e35ae2ec919dd0ae5b958ec Diff: https://reviews.apache.org/r/33600/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33433: Revert Revert Make health check configurable

2015-04-27 Thread Bill Farner
On April 22, 2015, 5:58 p.m., Kevin Sweeney wrote: I think we need to hold off on this patch until 0.8.0 is released. +1 - Bill --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Bill Farner
/apache/aurora/scheduler/mesos/DriverFactoryImpl.java https://reviews.apache.org/r/33243/#comment132177 Remove `credentials.get()`, it will throw a NullPointerException in this branch. - Bill Farner On April 27, 2015, 10:44 p.m., Ben Mahler wrote

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81753 --- Ship it! Ship It! - Bill Farner On April 27, 2015, 11:14 p.m

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-27 Thread Bill Farner
On April 28, 2015, 12:37 a.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 243 https://reviews.apache.org/r/33458/diff/1/?file=940120#file940120line243 I'm not too fond of this, it points out that `BenchmarkSettings` is being used

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

2015-04-27 Thread Bill Farner
coverage for the database-backed task store. Since it will be enabled with a toggle, i stopped here so the initial diff is only required to pass functional tests, and we can then iterate on performance. - Bill Farner On April 28, 2015, 12:57 a.m., Bill Farner wrote

Review Request 33611: Add benchmarks for fetching tasks over the API.

2015-04-27 Thread Bill Farner
/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner

Review Request 33728: Fix query for active job updates when serving /updates.

2015-04-30 Thread Bill Farner
/ Testing --- Manually in vagrant :-/ File Attachments /updates https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png Thanks, Bill Farner

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-04-30 Thread Bill Farner
as they are going to be re-inserted right away by the following loop (a very likely scenario for something like 'killall'). In fact, I don't see how `saveTasks` could require deleting any configs at all. Perhaps leave a TODO to carve out a `deleteTasksWithoutConfigs` method? Bill Farner

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-30 Thread Bill Farner
/StatusUpdateBenchmark.java https://reviews.apache.org/r/33608/#comment132861 I should have asked the first time around - what's the thought process behind including this? Given that this is a benchmark, it seems only to place a ceiling on throughput. - Bill Farner On April 30, 2015, 12:35 a.m., Ben Mahler wrote

Re: Review Request 33705: Don't retry API requests that fail with auth errors.

2015-04-30 Thread Bill Farner
a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33705/ --- (Updated April 30, 2015, 12:12 a.m.) Review

Re: Review Request 33774: Aurora-1106: Release candidate script does not generate correct branch link

2015-05-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33774/#review82319 --- Ship it! Ship It! - Bill Farner On May 2, 2015, 3:30 a.m., Jake

Re: Review Request 33739: Enable GC executor to gc STARTING tasks which don't exist on the host

2015-05-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33739/#review82321 --- Ship it! Ship It! - Bill Farner On May 1, 2015, 9:32 p.m., Zeke

Re: Review Request 33773: Aurora-1302: Allow rc script to set an explicit version

2015-05-02 Thread Bill Farner
bump .auroraversion _after_ the release is complete? - Bill Farner On May 2, 2015, 3:18 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33773

Review Request 33784: Symlink upstart configurations in vagrant rather than copying.

2015-05-02 Thread Bill Farner
/ Testing --- TODO(wfarner): Report back after verifying end-to-end tests pass for a fresh vagrant machine. Thanks, Bill Farner

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-04 Thread Bill Farner
-support/python/make-mesos-native-egg - Bill Farner On May 2, 2015, 5:43 p.m., Steve Salevan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778

Re: Review Request 33728: Fix query for active job updates when serving /updates.

2015-04-30 Thread Bill Farner
-30_113250.png Thanks, Bill Farner

Review Request 33740: Handle UpdateConfigError when starting a job update.

2015-04-30 Thread Bill Farner
command: Pulse interval seconds must be at least 60 seconds. ``` Thanks, Bill Farner

Review Request 33738: Fix test fixture issue causing failing tests to report as passing.

2015-04-30 Thread Bill Farner
/client/cli/test_task.py abf62529c70db3e7ce6d1df0f95aaabab900b5a3 src/test/python/apache/aurora/client/cli/util.py 5903101cb4af24a11c9276f42cc712b8ee6c9da5 Diff: https://reviews.apache.org/r/33738/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Bill Farner
/SchedulerDriverModule.java https://reviews.apache.org/r/33608/#comment132687 If anything, you should expose Scheduler.class to hide the implementation. This should allow you to revert changes in MesosSchedulerImpl.java. - Bill Farner On April 29, 2015, 6:12 p.m., Ben Mahler wrote

Re: Review Request 33676: Always require slave checkpointing.

2015-04-29 Thread Bill Farner
--- On April 29, 2015, 3:04 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33676

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Bill Farner
minor. src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java https://reviews.apache.org/r/33608/#comment132689 This requires libmesos.so to be available, which i don't think we should do. Can you get away without a real `MesosSchedulerDriver`? - Bill Farner On April 29, 2015

Review Request 33705: Don't retry API requests that fail with auth errors.

2015-04-29 Thread Bill Farner
/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/#review81850 --- Ship it! Ship It! - Bill Farner On April 28, 2015, 5:24 p.m

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

2015-04-28 Thread Bill Farner
2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner

Review Request 33677: Remove dead code related to Java executor.

2015-04-29 Thread Bill Farner
--- Thanks, Bill Farner

Review Request 33676: Always require slave checkpointing.

2015-04-29 Thread Bill Farner
/33676/diff/ Testing --- Thanks, Bill Farner

Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.

2015-05-05 Thread Bill Farner
/mem/InMemTaskStoreTest.java d1f4026f2b3d1cba542f96cecc0fe490e9ec8132 Diff: https://reviews.apache.org/r/33869/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Bill Farner
/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653 Diff: https://reviews.apache.org/r/33854/diff/ Testing --- TODO(wfarner): Report back results of run against 0.8.0-rc0 Thanks, Bill Farner

Re: Review Request 33950: AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33950/#review82862 --- Ship it! Ship It! - Bill Farner On May 7, 2015, 6:20 p.m., Jake

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Bill Farner
-mail. To reply, visit: https://reviews.apache.org/r/33854/#review82837 --- On May 5, 2015, 10:14 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Bill Farner
Bill Farner wrote: The issue becomes the current strict gradle version check. I will change the gradle version check to be less strict, which will make me comfortable with using the system-installed gradle here. Kevin Sweeney wrote: This is a complete duplication of the gradle

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Bill Farner
://reviews.apache.org/r/33854/diff/ Testing (updated) --- Successfully ran `./build-support/release/verify-release-candidate 0.8.0-rc0`. Thanks, Bill Farner

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82914 --- Ping? - Bill Farner On May 5, 2015, 6:21 p.m., Bill Farner wrote

Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
/ Testing --- Unit tests + end-to-end tests. Thanks, Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote: `--wait

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- On May 7, 2015, 11:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 7, 2015, 11

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote: `--wait

Review Request 33962: Remove often-redundant Error executing command prefix from client output.

2015-05-07 Thread Bill Farner
6fb1f71b7dc787c090fce7b8e7c51baee862f336 Diff: https://reviews.apache.org/r/33962/diff/ Testing --- Unit tests. Thanks, Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
Diff: https://reviews.apache.org/r/33959/diff/ Testing --- Unit tests + end-to-end tests. Thanks, Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
/test_end_to_end.sh 501d111f87dbaff8b6f22ffc67a9720b4dad Diff: https://reviews.apache.org/r/33959/diff/ Testing --- Unit tests + end-to-end tests. Thanks, Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
501d111f87dbaff8b6f22ffc67a9720b4dad Diff: https://reviews.apache.org/r/33959/diff/ Testing --- Unit tests + end-to-end tests. Thanks, Bill Farner

Re: Review Request 33924: Adding missing API hook support in kill commands.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33924/#review82901 --- Ship it! Ship It! - Bill Farner On May 7, 2015, 1:28 a.m

Re: Review Request 33955: Invoke pip as a python module rather than directly.

2015-05-07 Thread Bill Farner
git clean -fdx ./rbt ./build-support/python/make-pycharm-virtualenv ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, Bill Farner

Review Request 33955: Invoke pip as a python module rather than directly.

2015-05-07 Thread Bill Farner
. Thanks, Bill Farner

Review Request 33905: Updgrade to gradle 2.4.

2015-05-06 Thread Bill Farner
--- Thanks, Bill Farner

Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.

2015-05-06 Thread Bill Farner
--- On May 5, 2015, 11:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869

Re: Review Request 33787: fix link to contributing page

2015-05-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33787/#review82546 --- Ship it! Ship It! - Bill Farner On May 5, 2015, 6:01 p.m

Review Request 33854: Fix RC verification script.

2015-05-05 Thread Bill Farner
--- Script has drifted over time, this makes it functional again. Diffs - build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653 Diff: https://reviews.apache.org/r/33854/diff/ Testing --- Ran it and verified 0.8.0. Thanks, Bill Farner

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-05 Thread Bill Farner
. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82344 --- On April 28, 2015, 8:11 p.m., Bill Farner wrote

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-05 Thread Bill Farner
task store by default with this change. Thanks, Bill Farner

Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Bill Farner
, Bill Farner

Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Bill Farner
-Pbenchmarks='UpdateStoreBenchmarks'`. Thanks, Bill Farner

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Bill Farner
Diff: https://reviews.apache.org/r/33991/diff/ Testing --- Successfully ran `./gradlew jmh -Pbenchmarks='UpdateStoreBenchmarks'`. Thanks, Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner
) - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82968 --- On May 8, 2015, 1:04 a.m., Bill Farner wrote

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner
--- On May 8, 2015, 1:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner
. - Bill Farner On May 8, 2015, 9:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8

Re: Review Request 34046: Upgade h2 to 1.4.187.

2015-05-11 Thread Bill Farner
/#review83242 --- On May 11, 2015, 5:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34046

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-11 Thread Bill Farner
://reviews.apache.org/r/33689/#comment134246 The histogram would be interesting, but possibly overkill. We should be able to get good signal with stats we already have - number of status updates vs number of log writes - Bill Farner On May 11, 2015, 6:55 p.m., Ben Mahler wrote

Re: Review Request 34015: Improve client update json output to consistently use lastModified

2015-05-11 Thread Bill Farner
://reviews.apache.org/r/34015/#comment134201 IMHO it's the other side that should conform to `last_modified` since snake case is used in ~all other fields. - Bill Farner On May 9, 2015, 4:57 p.m., Joe Smith wrote

Re: Review Request 34015: Improve client update json output to consistently use last_modified

2015-05-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/#review83331 --- Ship it! Ship It! - Bill Farner On May 11, 2015, 10:19 p.m

  1   2   3   4   5   6   7   8   9   10   >