Re: Review Request 16306: job status command, with wildcard support.

2014-01-08 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16306/#review31166 --- On Dec. 18, 2013, 4:27 p.m., Mark Chu-Carroll wrote

Re: Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16743/#review31415 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 8, 2014, 6:15 p.m

Re: Review Request 16306: job status command, with wildcard support.

2014-01-09 Thread Mark Chu-Carroll
://reviews.apache.org/r/16306/#comment59968 Thanks, good catch. - Mark Chu-Carroll On Jan. 8, 2014, 5:32 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16306

Re: Review Request 16306: job status command, with wildcard support.

2014-01-09 Thread Mark Chu-Carroll
/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION Diff: https://reviews.apache.org/r/16306/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Mark Chu-Carroll
. - Mark Chu-Carroll On Jan. 8, 2014, 7:12 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16423

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Mark Chu-Carroll
. Thanks, Mark Chu-Carroll

Re: Review Request 16945: AURORA-41: Fix broken test in client.cli.job

2014-01-16 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16945/#review32019 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 15, 2014, 11:29

Re: Review Request 16984: Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).

2014-01-16 Thread Mark Chu-Carroll
. SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17051: Add clientv2 implementations of update and list jobs.

2014-01-17 Thread Mark Chu-Carroll
/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll

Re: Review Request 17051: Add clientv2 implementations of update and list jobs.

2014-01-17 Thread Mark Chu-Carroll
/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll

Re: Review Request 17051: Add clientv2 implementations of update and list jobs.

2014-01-17 Thread Mark Chu-Carroll
de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll

Re: Review Request 17051: Add clientv2 implementations of update and list jobs.

2014-01-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/#review32377 --- ping? - Mark Chu-Carroll On Jan. 17, 2014, 3:05 p.m., Mark Chu

Review Request 17153: Implement restart command for client v2.

2014-01-21 Thread Mark Chu-Carroll
=== src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17153: Implement restart command for client v2.

2014-01-21 Thread Mark Chu-Carroll
/python/apache/aurora/client/cli/test_restart.py ... === 23 passed in 1.39 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu

Re: Review Request 17153: Implement restart command for client v2.

2014-01-22 Thread Mark Chu-Carroll
://reviews.apache.org/r/17153/#review32454 --- On Jan. 21, 2014, 5:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17153: Implement restart command for client v2.

2014-01-22 Thread Mark Chu-Carroll
-Carroll On Jan. 21, 2014, 5:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/ --- (Updated Jan. 21

Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-22 Thread Mark Chu-Carroll
src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Mark Chu-Carroll

Review Request 17270: Bridge framework for client v2.

2014-01-23 Thread Mark Chu-Carroll
] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll

Review Request 17332: Add a noun supporting operations on roles

2014-01-24 Thread Mark Chu-Carroll
... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-25 Thread Mark Chu-Carroll
that a quota could be set at a lower level the first is more extensible aurora quota get west/ksweeney/prod aurora quota get west/ksweeney/prod/appserver - Kevin Sweeney On January 24th, 2014, 2:07 p.m. PST, Mark Chu-Carroll wrote: Review request for Aurora, Kevin Sweeney and Brian Wickman

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Mark Chu-Carroll
src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Mark Chu-Carroll
. SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Mark Chu-Carroll
., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 1:21 p.m.) Review

Re: Review Request 17270: Bridge framework for client v2.

2014-01-28 Thread Mark Chu-Carroll
. - Mark Chu-Carroll On Jan. 23, 2014, 6:10 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270

Re: Review Request 17270: Bridge framework for client v2.

2014-01-28 Thread Mark Chu-Carroll
-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll

Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-28 Thread Mark Chu-Carroll
: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-30 Thread Mark Chu-Carroll
://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17270: Bridge framework for client v2.

2014-01-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33055 --- On Jan. 28, 2014, 10:23 a.m., Mark Chu-Carroll wrote

Re: Review Request 17270: Bridge framework for client v2.

2014-01-30 Thread Mark Chu-Carroll
incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-30 Thread Mark Chu-Carroll
(all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review32757 --- On Jan. 24, 2014, 5:07 p.m., Mark Chu-Carroll wrote

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33344 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 31, 2014, 2:34 p.m

Review Request 17614: Fix whitespace glitches I missed in review.

2014-01-31 Thread Mark Chu-Carroll
--- Fix whitespace glitches. Diffs - src/main/python/apache/aurora/client/commands/admin.py d8b9a44a02cd9e8873a97e9107a7b18e3c97b66b Diff: https://reviews.apache.org/r/17614/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33358 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 31, 2014, 2:52 p.m

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33359 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:09 p.m., Mark Chu

Re: Review Request 17270: Bridge framework for client v2.

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33360 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:03 p.m., Mark Chu

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33435 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 3, 2014, 10:58 a.m

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
://reviews.apache.org/r/17457/#comment62917 Because in the vmware precise64 image, git and python-setuptools aren't included. With these added to the list, the test works on both vmware and virtualbox. - Mark Chu-Carroll On Feb. 3, 2014, 11:30 a.m., Mark Chu-Carroll wrote

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
/flask_example_updated.aurora https://reviews.apache.org/r/17457/#comment62947 Really? Shouldn't there be a newline at the end of the last line? - Mark Chu-Carroll On Feb. 3, 2014, 11:30 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33475 --- On Feb. 3, 2014, 3:16 p.m., Mark Chu-Carroll wrote

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
with $SLAVE_IP_ADDRESS lazy expansion with \$? Mark Chu-Carroll wrote: Interpolation doesn't work in a here doc in a script. Try putting the following into a shell script file: export SLAVE_IP_ADDRESS=INTERPOLATE cat testfile EOF #!/bin/bash export LD_LIBRARY_PATH=/usr/lib

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
: https://reviews.apache.org/r/17457/#review33510 --- On Feb. 3, 2014, 3:16 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
)]$ Thanks, Mark Chu-Carroll

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-04 Thread Mark Chu-Carroll
/ksweeney/prod/appserver On January 31st, 2014, 7:37 a.m. PST, *Mark Chu-Carroll* wrote: I've been thinking about this, debating it in my own head, and I just can't agree. Quota isn't a standalone entity; A quota is an attribute of a role. It doesn't make sense to me to have

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-04 Thread Mark Chu-Carroll
unsure if this has been discussed, but possibly instead: aurora quota get smf1/role aurora quota set smf1/role ... -Toby. On Tue, Feb 4, 2014 at 10:26 AM, Mark Chu-Carroll mchucarr...@apache.org wrote: I disagree. To me, the fundamental issue is just what a quota is. Is a quota

Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations.

2014-02-04 Thread Mark Chu-Carroll
, Mark Chu-Carroll

Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails

2014-02-04 Thread Mark Chu-Carroll
/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing --- Manual testing on the command line. Thanks, Mark Chu-Carroll

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-05 Thread Mark Chu-Carroll
. SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/#review33721 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 5, 2014, 12:45 p.m

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread Mark Chu-Carroll
://reviews.apache.org/r/17645/#comment63329 I would prefer for the help to make it clear what adding the parameter would do. If false, prevent update from performing a rollback. - Mark Chu-Carroll On Feb. 3, 2014, 4 p.m., David Robinson wrote

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33798 --- ping? - Mark Chu-Carroll On Feb. 5, 2014, 10:08 a.m., Mark Chu

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Mark Chu-Carroll
/17270/#review33471 --- On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
://reviews.apache.org/r/17332/#comment63426 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. - Mark Chu-Carroll On Feb. 5, 2014, 10:08 a.m

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
, Mark Chu-Carroll

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu

Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails

2014-02-06 Thread Mark Chu-Carroll
/ssh.py d1499ec1e9e910bc32f5f9f4b050c53316348503 src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing --- Manual testing on the command line. Thanks, Mark Chu-Carroll

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Mark Chu-Carroll
://reviews.apache.org/r/17270/#comment63479 That's actually the way that I originally wrote it, and wickman wanted me to change it to this. - Mark Chu-Carroll On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote

Re: Review Request 17270: Bridge framework for client v2.

2014-02-07 Thread Mark Chu-Carroll
On Feb. 6, 2014, 5:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 149 https://reviews.apache.org/r/17270/diff/3/?file=456886#file456886line149 That's actually the way that I originally wrote it, and wickman wanted me to change

Re: Review Request 17270: Bridge framework for client v2.

2014-02-07 Thread Mark Chu-Carroll
: 18afec3ae3a5d896f69984784a1dbc6e0e743e44 date: Thursday Jan 23, 2014 Aurora API version: APIVersion(major=3) V2 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll

Re: Review Request 17270: Bridge framework for client v2.

2014-02-07 Thread Mark Chu-Carroll
COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-07 Thread Mark Chu-Carroll
., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 5, 2014, 3:09 p.m.) Review request

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-07 Thread Mark Chu-Carroll
. SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-07 Thread Mark Chu-Carroll
, but rbt hasn't caught up. Will upload ASAP. src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/17752/#comment63778 D'oh. This is called during the argument processing. The context isn't around yet. - Mark Chu-Carroll On Feb. 7, 2014, 1:55 p.m., Mark Chu

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-07 Thread Mark Chu-Carroll
=== src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll

Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-11 Thread Mark Chu-Carroll
of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34187 --- ping?! - Mark Chu-Carroll On Feb. 7, 2014, 3:44 p.m., Mark Chu

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

2014-02-11 Thread Mark Chu-Carroll
://reviews.apache.org/r/17877/#comment64205 Die expects a message string, not an exception object. die('Invalid unit specification') would end up with a better error message. - Mark Chu-Carroll On Feb. 10, 2014, 2:17 p.m., Dan Norris wrote

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-11 Thread Mark Chu-Carroll
=== src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-13 Thread Mark Chu-Carroll
--- On Feb. 11, 2014, 10:31 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948

Re: Review Request 18086: Fixing python test failure.

2014-02-13 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18086/#review34380 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 13, 2014, 11:45

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-13 Thread Mark Chu-Carroll
need self? - Mark Chu-Carroll On Feb. 12, 2014, 7:01 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-14 Thread Mark Chu-Carroll
me, so that I can send it to someone else? Having this outstanding is making it very difficult for me. - Mark Chu-Carroll On Feb. 11, 2014, 10:31 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34515 --- On Feb. 11, 2014, 9:16 p.m., Mark Chu-Carroll wrote

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll
://reviews.apache.org/r/17948/#comment64931 Yeah, but that'll add a leading CR. I think it's better to just leave it as is. - Mark Chu-Carroll On Feb. 18, 2014, 10:06 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-18 Thread Mark Chu-Carroll
=== src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll
://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll

Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugins)]$ Thanks, Mark Chu-Carroll

Review Request 18267: Implement help for v2 bridge

2014-02-19 Thread Mark Chu-Carroll
. SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34878 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 18, 2014, 6:19 p.m

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Mark Chu-Carroll
. Thanks! - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/#review34876 --- On Feb. 19, 2014, 8:29 a.m., Mark Chu-Carroll wrote

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-20 Thread Mark Chu-Carroll
Ping? I would really like to get this pushed and hopefully deployed soon. -Mark On Wed, Feb 19, 2014 at 12:55 PM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ Review request

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread Mark Chu-Carroll
. SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread Mark Chu-Carroll
://reviews.apache.org/r/18267/#comment65466 Where the bleep did that come from? - Mark Chu-Carroll On Feb. 20, 2014, 4:02 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread Mark Chu-Carroll
. SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll

Re: Review Request 18267: Implement help for v2 bridge

2014-02-21 Thread Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll

Review Request 18354: Add a packaging target for clientv2.

2014-02-21 Thread Mark Chu-Carroll
--- Thanks, Mark Chu-Carroll

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Mark Chu-Carroll
://reviews.apache.org/r/18296/#comment65563 This comment doesn't make sense to me. I don't understand what an instance of this class is. Is it a list of hosts? Maybe start the comment with what the thing is, and then explain what it does? - Mark Chu-Carroll On Feb. 19, 2014, 8:15 p.m., Maxim

Re: Review Request 16144: ZookeeperSchedulerClient url property errored when no proxy_url was set, and the client was not connected.

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16144/#review35154 --- Ship it! Ship It! - Mark Chu-Carroll On Dec. 9, 2013, 8:57 p.m

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35152 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 20, 2014, 7:05 p.m

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Mark Chu-Carroll
them stricter? - Mark Chu-Carroll On Feb. 21, 2014, 11:30 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296

Re: Review Request 18354: Add a packaging target for clientv2.

2014-02-25 Thread Mark Chu-Carroll
-python-sdists 43e74be8496916cd4f56d4930b3e8d8a217c001c src/main/python/apache/aurora/client/BUILD 11ad955866b82b327a57a0f52cff0cdc1a2d83fc Diff: https://reviews.apache.org/r/18354/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.

2014-02-25 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35438 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 25, 2014, 1:59 p.m

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

2014-02-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35827 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 27, 2014, 8:32 p.m

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

2014-03-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/#review36551 --- Ship it! Ship It! - Mark Chu-Carroll On March 6, 2014, 5:42 p.m

  1   2   3   4   5   >