, visit:
https://reviews.apache.org/r/16629/#review31664
---
On Jan. 10, 2014, 9:23 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/org/apache/aurora/scheduler/thrift/ThriftIT.java
cce27a0e37452f370a3729b6b05bf0bea29f85f6
Diff: https://reviews.apache.org/r/16629/diff/
Testing
---
gradle build
Thanks,
Maxim Khutornenko
/org/apache/aurora/scheduler/thrift/ThriftIT.java
cce27a0e37452f370a3729b6b05bf0bea29f85f6
Diff: https://reviews.apache.org/r/16629/diff/
Testing
---
gradle build
Thanks,
Maxim Khutornenko
/org/apache/aurora/scheduler/thrift/ThriftIT.java
cce27a0e37452f370a3729b6b05bf0bea29f85f6
Diff: https://reviews.apache.org/r/16629/diff/
Testing
---
gradle build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16741/#review31927
---
Thanks. Pushed.
- Maxim Khutornenko
On Jan. 8, 2014, 11:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16265/#review31953
---
Ship it!
Nice!
- Maxim Khutornenko
On Jan. 15, 2014, 10:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17095/#review32254
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 18, 2014, 9:01
/CronJobManager.java
https://reviews.apache.org/r/17131/#comment61173
+1 for inlining it.
- Maxim Khutornenko
On Jan. 20, 2014, 9:01 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/#review32457
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 21, 2014, 11:18
://reviews.apache.org/r/17372/#comment61885
Optional?
- Maxim Khutornenko
On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17432/#review32917
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 27, 2014, 11:58
be nice here. Specifically, documenting the acquired
perf gain and data consistency guarantees.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
https://reviews.apache.org/r/17578/#comment62694
When do we stop fighting it? :)
- Maxim Khutornenko
On Jan. 31
://reviews.apache.org/r/17645/#comment62872
is
src/test/python/apache/aurora/client/api/test_restarter.py
https://reviews.apache.org/r/17645/#comment62871
Mind adding a simple test with rollback_on_failure=False here?
- Maxim Khutornenko
On Feb. 3, 2014, 3:18 a.m., David Robinson wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17637/#review33436
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 3, 2014, 3:58 p.m
---
On Feb. 3, 2014, 6:16 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17666
/org/apache/aurora/gen/api.thrift.md5
e88d29732ee8652ede6c7ee13513122086385646
Diff: https://reviews.apache.org/r/17666/diff/
Testing
---
gradle clean build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17689/#review33558
---
Thanks. Pushed.
- Maxim Khutornenko
On Feb. 4, 2014, 2 a.m
test
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17771/#review33749
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 6, 2014, 1:27 a.m
/TaskScheduler.java
https://reviews.apache.org/r/17785/#comment63415
Revert?
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java
https://reviews.apache.org/r/17785/#comment63416
Old habits die hard? :)
- Maxim Khutornenko
On Feb. 6, 2014, 6:29 a.m., Bill Farner wrote
/SchedulerThriftInterface.java
https://reviews.apache.org/r/17729/#comment63461
Done.
- Maxim Khutornenko
On Feb. 5, 2014, 1:59 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
.
- Maxim Khutornenko
On Feb. 5, 2014, 11:23 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17750
/state/CronJobManagerTest.java
0b565abc2187deeba466a63162de80b5e2bb5d47
Diff: https://reviews.apache.org/r/17955/diff/
Testing
---
gradle clean build
Thanks,
Maxim Khutornenko
24e1bc49a446bab9ec9a8aff62438cbde89e6569
src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java
0b565abc2187deeba466a63162de80b5e2bb5d47
Diff: https://reviews.apache.org/r/17955/diff/
Testing
---
gradle clean build
Thanks,
Maxim Khutornenko
. To reply, visit:
https://reviews.apache.org/r/17955/#review34218
---
On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply
c106b97a0902da5cd791b18117da3198bfb43b8c
src/test/python/apache/aurora/client/cli/test_sla.py PRE-CREATION
Diff: https://reviews.apache.org/r/18042/diff/
Testing
---
./pants src/test/python/apache/aurora/client:all
Thanks,
Maxim Khutornenko
/18086/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
/client:all
Thanks,
Maxim Khutornenko
https://reviews.apache.org/r/18042/#comment64530
Done.
- Maxim Khutornenko
On Feb. 13, 2014, 7:25 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18042
://reviews.apache.org/r/18042/diff/
Testing
---
./pants src/test/python/apache/aurora/client:all
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/18042/diff/
Testing
---
./pants src/test/python/apache/aurora/client:all
Thanks,
Maxim Khutornenko
/GcExecutorLauncher.java
https://reviews.apache.org/r/18141/#comment64657
s/public//
src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java
https://reviews.apache.org/r/18141/#comment64658
@Override
- Maxim Khutornenko
On Feb. 14, 2014, 8:09 p.m., Bill Farner wrote
of the Supplier
initialization? I find it hard to follow the logic as it is.
- Maxim Khutornenko
On Feb. 15, 2014, 12:21 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18141/#review34749
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 18, 2014, 7:16
/18153/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34735
---
On Feb. 15, 2014, 12:01 a.m., Maxim Khutornenko wrote
/#comment65044
Good, as I felt the same way but decided to stay consistent with other
options here. Dropped empty check to fire an error should this ever happen.
- Maxim Khutornenko
On Feb. 18, 2014, 7:30 p.m., Maxim Khutornenko wrote
/18153/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
/18153/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/18153/#review34788
---
On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34798
---
On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote
/18153/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
https://reviews.apache.org/r/18265/#comment65258
Inconsistent use of positional file arg.
- Maxim Khutornenko
On Feb. 19, 2014, 1:29 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Feb. 19, 2014, 5:13 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line
539
https://reviews.apache.org/r/18241/diff/1/?file=497164#file497164line539
This is too easy to forget. Any chance this assert could be moved
11ae990c0d8e41470c6df438d37d8a2a79907a58
Diff: https://reviews.apache.org/r/18296/diff/
Testing
---
./pants src/test/python/apache/aurora/client:all
Thanks,
Maxim Khutornenko
/aurora/client/commands/test_admin_sla.py
780ad180366a5b8664367e499fe86470418c1344
Diff: https://reviews.apache.org/r/18440/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/18354/#comment65891
Please, add this target into make-python-sdists as well.
- Maxim Khutornenko
On Feb. 21, 2014, 2:12 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18354/#review35410
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 25, 2014, 4:33
Done.
- Maxim Khutornenko
On Feb. 25, 2014, 1 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18440
780ad180366a5b8664367e499fe86470418c1344
Diff: https://reviews.apache.org/r/18440/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18440/#review35440
---
Thanks! Pushed to master.
- Maxim Khutornenko
On Feb. 25, 2014
/resources/org/apache/aurora/gen/api.thrift.md5
fafb5100443482e662db453429c5259f2ab80ae5
Diff: https://reviews.apache.org/r/18526/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18528/#review35553
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 26, 2014, 7:07
/scheduler/storage/log/WriteAheadStorage.java
https://reviews.apache.org/r/18487/#comment66157
Mind converting this comment into a message arg?
- Maxim Khutornenko
On Feb. 26, 2014, 12:12 a.m., Bill Farner wrote
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35589
---
On Feb. 26, 2014, 6:17 p.m., Maxim Khutornenko wrote
/MemTaskStore.java
https://reviews.apache.org/r/18526/#comment66445
Good point, completely missed the optional meaning there. Question: do we
treat an empty value set in a TaskQuery as (1) or (2)? I am leaning towards (1)
as a less strict and more intuitive. Any objections?
- Maxim Khutornenko
On Feb
/MemTaskStore.java
https://reviews.apache.org/r/18526/#comment66450
On a second thought, it's easier to reason about all this if we treat set
and non-set values the same way, namely non-null empty sets would return empty
results.
- Maxim Khutornenko
On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote
/apache/aurora/gen/api.thrift
https://reviews.apache.org/r/18526/#comment66463
Dropped.
- Maxim Khutornenko
On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
%f for a string?
- Maxim Khutornenko
On Feb. 28, 2014, 1:59 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602
/Resources.java
https://reviews.apache.org/r/18546/#comment66484
Mind adding the ticket that tracks collapsing work? AURORA-105?
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java
https://reviews.apache.org/r/18546/#comment66487
s/quota/ResourceAggregate
- Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35755
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 28, 2014, 2:37
20% slower
1000 .filter 250% faster
However, a looped get() outperformed .filter for anything below 100 keys.
Since the majority of our queries are well under 10 keys using a looped get()
seems to be a better alternative. Converting to it now.
- Maxim Khutornenko
/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
08c4c2a4717a1c827f4cef6405d78e7db5046a00
Diff: https://reviews.apache.org/r/18654/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18654/#review35873
---
On March 1, 2014, 12:14 a.m., Maxim Khutornenko wrote
On March 1, 2014, 12:16 a.m., Bill Farner wrote:
Incomplete feature?
Maxim Khutornenko wrote:
This is needed to unlock two additional CRs I am about to post. One that
follows up on supporting jobKeys in scheduler and the other one that uses it
on the client.
Bill Farner wrote
/build.sh
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/18655/#comment66705
from is currently intended to unambiguously give a single IJobKey
instance derived from role/env/name. I am not sure exposing a SetIJobKey
would be a good idea.
- Maxim Khutornenko
On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote
, 2014, 4:06 a.m.)
Review request for Aurora, Maxim Khutornenko and Tom Galloway.
Repository: aurora
Description
---
- Simplify TOC and anchors
- Enable syntax highlighting
- Minor cleanups, make formatting more consistent
Diffs
-
docs/clientcommands.md
feel that the
construction side should remain separate (byJob, byJobKeys). Thoughts?
- Maxim Khutornenko
On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 1, 2014, 1:32 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 178
https://reviews.apache.org/r/18655/diff/1/?file=507499#file507499line178
from is currently intended to unambiguously give a single IJobKey
instance derived
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review36054
---
On March 3, 2014, 11:26 p.m., Maxim Khutornenko wrote
-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/18655/#comment66922
Done.
- Maxim Khutornenko
On March 3, 2014, 11:26 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655
https://reviews.apache.org/r/18713/#comment66968
Not sure how shutdownRegistry.addAction() fits into this specific Closure.
It there anything forcing it here? If not shouldn't be one level up within the
constructor body?
- Maxim Khutornenko
On March 3, 2014, 11:31 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review36187
---
Ping, Kevin?
- Maxim Khutornenko
On March 4, 2014, 1:03 a.m
/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18720/#review36428
---
Ping.
- Maxim Khutornenko
On March 4, 2014, 1:20 a.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review36427
---
Waiting for Kevin.
- Maxim Khutornenko
On March 4, 2014, 1:03
/
Testing
---
/build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
---
/build-support/jenkins/build.sh
Thanks,
Maxim Khutornenko
://reviews.apache.org/media/uploaded/files/2014/03/08/790daac1-89ac-436f-8c92-5e5dc7483154__Metadata_Role.png
Job
https://reviews.apache.org/media/uploaded/files/2014/03/08/7ca45940-666f-439b-867f-b89f42b11a38__Metadata_Job.png
Thanks,
Maxim Khutornenko
---
On March 8, 2014, 12:28 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18935
-5e5dc7483154__Metadata_Role.png
Job
https://reviews.apache.org/media/uploaded/files/2014/03/08/7ca45940-666f-439b-867f-b89f42b11a38__Metadata_Job.png
Thanks,
Maxim Khutornenko
On March 8, 2014, 12:56 a.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 179
https://reviews.apache.org/r/18935/diff/1/?file=513979#file513979line179
feel free to rename this to packagesDEPRECATED
Maxim Khutornenko wrote:
That would require
://reviews.apache.org/r/18996/#comment67853
Mind adding a test case for this one?
- Maxim Khutornenko
On March 10, 2014, 11:44 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/#review36792
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 11, 2014, 4:12
On March 11, 2014, 7:46 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/commands/core.py, line 398
https://reviews.apache.org/r/19061/diff/1/?file=516614#file516614line398
This will fail if a kill is attempted for a job that does not exist.
Mark Chu-Carroll
>
Review Request 19078: Part 2 of converting from Packages to Metadata.
reviews
-- Thread --
-- Date --
Review Request 19078: Part 2 of converting from Packages to Metadata.
Maxim Khutorne
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36888
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 12, 2014, 1:26
://reviews.apache.org/r/19061/#comment68082
+1. The idea here is to make scripting of production job kills harder and
it achieves just that despite its ugliness.
- Maxim Khutornenko
On March 11, 2014, 10:23 p.m., Mark Chu-Carroll wrote
://reviews.apache.org/r/19159/#comment68251
As it's implemented, the --force flag is a required option for this
command. Feels redundant as killall mandatory wait period should be enough here.
I presume making kill require --shards is going to be tracked in a separate
RB?
- Maxim
On March 12, 2014, 10:25 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/commands/core.py, line 399
https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
This is deliberate: the kill command doesn't have a force option.
So this ensures that
What looks odd though is a command that is unusable without the --force
flag. The standard optional semantic of that flag feels violated here.
On Thu, Mar 13, 2014 at 11:10 AM, Maxim Khutornenko ma...@apache.orgwrote:
What looks odd though is a command that is unusable without the --force
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19245/#review37293
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 14, 2014, 11:32
/ConstraintFilter.java
https://reviews.apache.org/r/19250/#comment68769
Any chance this could be merged with the next statement?
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
https://reviews.apache.org/r/19250/#comment68770
Add checks for 1.6 and 1.7?
- Maxim
src/test/python/apache/aurora/config/test_thrift.py
4be11b5d53c286614565f22795f5026cfbe26f0a
Diff: https://reviews.apache.org/r/19331/diff/
Testing
---
./build-support/jenkins/build.sh
Local client run:
- aurora status
- aurora update
Thanks,
Maxim Khutornenko
00a80d90c2ce9b6134784a91c2cb9d9e966446ae
Diff: https://reviews.apache.org/r/19331/diff/
Testing
---
./build-support/jenkins/build.sh
Local client run:
- aurora status
- aurora update
Thanks,
Maxim Khutornenko
run:
- aurora status
- aurora update
Thanks,
Maxim Khutornenko
1 - 100 of 1219 matches
Mail list logo
