Re: Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Maxim Khutornenko
https://reviews.apache.org/r/16743/#comment59879 How would the unhandled exception surface from here? Does it make sense to setUncaughtExceptionHandler()? - Maxim Khutornenko On Jan. 8, 2014, 11:15 p.m., Bill Farner wrote

Re: Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16743/#review31413 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 8, 2014, 11:15

Re: Review Request 16444: Client side changes for the client quota check.

2014-01-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16444/#review31418 --- Thanks. Submitted. - Maxim Khutornenko On Jan. 4, 2014, 2:01 a.m

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-08 Thread Maxim Khutornenko
/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java https://reviews.apache.org/r/16740/#comment59909 Do we need rules to transition from THROTTLED state on scheduler restart? - Maxim Khutornenko On Jan. 8, 2014, 8:05 p.m., Bill Farner wrote

Re: Review Request 16767: Begin cleanup of StateManager interface by removing state change via Query.

2014-01-10 Thread Maxim Khutornenko
://reviews.apache.org/r/16767/#comment60067 Nice! - Maxim Khutornenko On Jan. 9, 2014, 10:40 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16767

Re: Review Request 16629: Client quota check (server side)

2014-01-10 Thread Maxim Khutornenko
/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java cce27a0e37452f370a3729b6b05bf0bea29f85f6 Diff: https://reviews.apache.org/r/16629/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 16629: Client quota check (server side)

2014-01-13 Thread Maxim Khutornenko
, visit: https://reviews.apache.org/r/16629/#review31664 --- On Jan. 10, 2014, 9:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 16629: Client quota check (server side)

2014-01-13 Thread Maxim Khutornenko
/org/apache/aurora/scheduler/thrift/ThriftIT.java cce27a0e37452f370a3729b6b05bf0bea29f85f6 Diff: https://reviews.apache.org/r/16629/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 16834: Dropping scheduler_list_job_updates from aurora_admin

2014-01-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16834/#review31691 --- Thanks. Pushed. - Maxim Khutornenko On Jan. 13, 2014, 11:34 p.m

Re: Review Request 16629: Client quota check (server side)

2014-01-14 Thread Maxim Khutornenko
/org/apache/aurora/scheduler/thrift/ThriftIT.java cce27a0e37452f370a3729b6b05bf0bea29f85f6 Diff: https://reviews.apache.org/r/16629/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 16629: Client quota check (server side)

2014-01-15 Thread Maxim Khutornenko
/org/apache/aurora/scheduler/thrift/ThriftIT.java cce27a0e37452f370a3729b6b05bf0bea29f85f6 Diff: https://reviews.apache.org/r/16629/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 16741: Converting py source dist versions to upper() for consistency with java side.

2014-01-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16741/#review31927 --- Thanks. Pushed. - Maxim Khutornenko On Jan. 8, 2014, 11:06 p.m

Re: Review Request 16265: Script for creating tags

2014-01-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review31953 --- Ship it! Nice! - Maxim Khutornenko On Jan. 15, 2014, 10:57 p.m

Review Request 16931: Fixing admin scheduler_print_recovery_tasks.

2014-01-15 Thread Maxim Khutornenko
Task ID INFO] www-data hello 0 RUNNING 1389653898736-www-data-prod-hello-0-3b147157-31d1-4d5b-9a70-0e508efe15ee Thanks, Maxim Khutornenko

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

2014-01-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32093 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 16, 2014, 10:12

Re: Review Request 17095: Only export counters in TaskVars after SchedulerActive event.

2014-01-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17095/#review32254 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 18, 2014, 9:01

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-21 Thread Maxim Khutornenko
/CronJobManager.java https://reviews.apache.org/r/17131/#comment61173 +1 for inlining it. - Maxim Khutornenko On Jan. 20, 2014, 9:01 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15

2014-01-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/#review32457 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 21, 2014, 11:18

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-22 Thread Maxim Khutornenko
sense moving it into a separate file? - Maxim Khutornenko On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873

Re: Review Request 17351: Use only a single write transaction to save HostAttributes in resourceOffers.

2014-01-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17351/#review32777 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 25, 2014, 6:03

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Maxim Khutornenko
://reviews.apache.org/r/17372/#comment61885 Optional? - Maxim Khutornenko On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372

Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

2014-01-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32917 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 27, 2014, 11:58

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Maxim Khutornenko
be nice here. Specifically, documenting the acquired perf gain and data consistency guarantees. src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java https://reviews.apache.org/r/17578/#comment62694 When do we stop fighting it? :) - Maxim Khutornenko On Jan. 31

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread Maxim Khutornenko
://reviews.apache.org/r/17645/#comment62872 is src/test/python/apache/aurora/client/api/test_restarter.py https://reviews.apache.org/r/17645/#comment62871 Mind adding a simple test with rollback_on_failure=False here? - Maxim Khutornenko On Feb. 3, 2014, 3:18 a.m., David Robinson wrote

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33436 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 3, 2014, 3:58 p.m

Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Maxim Khutornenko
/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646 Diff: https://reviews.apache.org/r/17666/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Maxim Khutornenko
--- On Feb. 3, 2014, 6:16 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Maxim Khutornenko
/org/apache/aurora/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646 Diff: https://reviews.apache.org/r/17666/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko

Review Request 17676: Adding PGP key for ma...@apache.org

2014-02-03 Thread Maxim Khutornenko
PGP key for ma...@apache.org Diffs - KEYS 5c9d99a2de0deadaf612b602b182e521f7f7ab64 Diff: https://reviews.apache.org/r/17676/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 17676: Adding PGP key for ma...@apache.org

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17676/#review33518 --- Thanks, pushed. - Maxim Khutornenko On Feb. 3, 2014, 10:07 p.m

Re: Review Request 17683: change max backoff timeout to be compatible with the preemption_wait hardcoded.

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17683/#review33542 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 4, 2014, 12:28

Review Request 17689: Fixing submit instructions.

2014-02-03 Thread Maxim Khutornenko
--- Fixing submit instructions. Diffs - build-support/release/tag-release 9bb00da86fc4e640ca6a9d8bf48444744659e3bc Diff: https://reviews.apache.org/r/17689/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 17689: Fixing submit instructions.

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17689/#review33558 --- Thanks. Pushed. - Maxim Khutornenko On Feb. 4, 2014, 2 a.m

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33559 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 3, 2014, 9 p.m

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-03 Thread Maxim Khutornenko
/apache/aurora/scheduler/async/OfferQueue.java https://reviews.apache.org/r/17672/#comment63084 This does not seem to be used. - Maxim Khutornenko On Feb. 3, 2014, 8:43 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-04 Thread Maxim Khutornenko
/SlotSizeCounter.java https://reviews.apache.org/r/17680/#comment63130 Is it public only because of MachineResourceProvider interface? - Maxim Khutornenko On Feb. 3, 2014, 11:20 p.m., Bill Farner wrote: --- This is an automatically

Review Request 17712: Fixing @Override public.

2014-02-04 Thread Maxim Khutornenko
test Thanks, Maxim Khutornenko

Review Request 17723: Implementing support for DRAINING state.

2014-02-04 Thread Maxim Khutornenko
10fcf08f87abb8a0e3d2750237b482ebdd3ac65d Diff: https://reviews.apache.org/r/17723/diff/ Testing --- gradle clean test Thanks, Maxim Khutornenko

Re: Review Request 17712: Fixing @Override public.

2014-02-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17712/#review33672 --- Thanks. Pushed. - Maxim Khutornenko On Feb. 4, 2014, 5:51 p.m

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/#review33724 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 5, 2014, 8:31 p.m

Re: Review Request 17771: AURORA-193: Fix license plugin

2014-02-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/#review33749 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 6, 2014, 1:27 a.m

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Maxim Khutornenko
/TaskScheduler.java https://reviews.apache.org/r/17785/#comment63415 Revert? src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java https://reviews.apache.org/r/17785/#comment63416 Old habits die hard? :) - Maxim Khutornenko On Feb. 6, 2014, 6:29 a.m., Bill Farner wrote

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-06 Thread Maxim Khutornenko
/SchedulerThriftInterface.java https://reviews.apache.org/r/17729/#comment63461 Done. - Maxim Khutornenko On Feb. 5, 2014, 1:59 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-06 Thread Maxim Khutornenko
10fcf08f87abb8a0e3d2750237b482ebdd3ac65d Diff: https://reviews.apache.org/r/17729/diff/ Testing --- gradle clean build ./pants src/test/python/apache/aurora:all aurora_client diff/update in vagrant with/without JobConfigValidation in api.thrift Thanks, Maxim Khutornenko

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Maxim Khutornenko
Feb. 6, 2014, 6:29 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-194 https://issues.apache.org/jira/browse/AURORA-194 Repository: aurora Description --- Since the introduction of the THROTTLED state, the Preemptor

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/#review33877 --- Rebased, re-run tests and pushed to master. - Maxim Khutornenko

Re: Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-07 Thread Maxim Khutornenko
. - Maxim Khutornenko On Feb. 5, 2014, 11:23 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17750

Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Maxim Khutornenko
/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Maxim Khutornenko
24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Maxim Khutornenko
. To reply, visit: https://reviews.apache.org/r/17955/#review34218 --- On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34221 --- Thanks, pushed. - Maxim Khutornenko On Feb. 11, 2014, 7:40 p.m

Review Request 18042: Adding sla get_task_up_count command.

2014-02-12 Thread Maxim Khutornenko
c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_sla.py PRE-CREATION Diff: https://reviews.apache.org/r/18042/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko

Re: Review Request 17723: Implementing support for DRAINING state.

2014-02-13 Thread Maxim Khutornenko
c0cc0a472e61ceae22845541544c3e7d68ce7657 src/test/resources/org/apache/aurora/gen/api.thrift.md5 2bdd038553107404c238a2fb8f28f9aa5bfc8549 Diff: https://reviews.apache.org/r/17723/diff/ Testing --- gradle clean test Thanks, Maxim Khutornenko

Review Request 18086: Fixing python test failure.

2014-02-13 Thread Maxim Khutornenko
/18086/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34393 --- On Feb. 13, 2014, 12:01 a.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-13 Thread Maxim Khutornenko
/client:all Thanks, Maxim Khutornenko

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-13 Thread Maxim Khutornenko
https://reviews.apache.org/r/18042/#comment64530 Done. - Maxim Khutornenko On Feb. 13, 2014, 7:25 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-13 Thread Maxim Khutornenko
://reviews.apache.org/r/18042/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-14 Thread Maxim Khutornenko
-CREATION Diff: https://reviews.apache.org/r/18042/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-14 Thread Maxim Khutornenko
. Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34513 --- On Feb. 14, 2014, 5:42 p.m., Maxim Khutornenko wrote

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-14 Thread Maxim Khutornenko
://reviews.apache.org/r/18042/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-14 Thread Maxim Khutornenko
/GcExecutorLauncher.java https://reviews.apache.org/r/18141/#comment64657 s/public// src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java https://reviews.apache.org/r/18141/#comment64658 @Override - Maxim Khutornenko On Feb. 14, 2014, 8:09 p.m., Bill Farner wrote

Review Request 18153: Added sla get_job_uptime command.

2014-02-14 Thread Maxim Khutornenko
/python/apache/aurora/client/api/test_sla.py 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 src/test/python/apache/aurora/client/cli/test_sla.py 703d39e4566a30900f1e9bcca5871c4a426cc6c3 Diff: https://reviews.apache.org/r/18153/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim

Re: Review Request 18149: Cron predictor conformance test.

2014-02-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18149/#review34556 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 14, 2014, 11:43

Re: Review Request 18157: Compute task host attribute aggregates once when scheduling tasks.

2014-02-14 Thread Maxim Khutornenko
of the Supplier initialization? I find it hard to follow the logic as it is. - Maxim Khutornenko On Feb. 15, 2014, 12:21 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18141/#review34749 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 18, 2014, 7:16

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
/18153/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34735 --- On Feb. 15, 2014, 12:01 a.m., Maxim Khutornenko wrote

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
/#comment65044 Good, as I felt the same way but decided to stay consistent with other options here. Dropped empty check to fire an error should this ever happen. - Maxim Khutornenko On Feb. 18, 2014, 7:30 p.m., Maxim Khutornenko wrote

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
/18153/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
/18153/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
://reviews.apache.org/r/18153/#review34788 --- On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34798 --- On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
/18153/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Maxim Khutornenko
https://reviews.apache.org/r/18265/#comment65258 Inconsistent use of positional file arg. - Maxim Khutornenko On Feb. 19, 2014, 1:29 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.

2014-02-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review35054 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 20, 2014, 6:41

Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-20 Thread Maxim Khutornenko
On Feb. 19, 2014, 5:13 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 539 https://reviews.apache.org/r/18241/diff/1/?file=497164#file497164line539 This is too easy to forget. Any chance this assert could be moved

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Maxim Khutornenko
e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35150 --- On Feb. 20, 2014, 1:15 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Maxim Khutornenko
11ae990c0d8e41470c6df438d37d8a2a79907a58 Diff: https://reviews.apache.org/r/18296/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko

Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.

2014-02-24 Thread Maxim Khutornenko
/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18354: Add a packaging target for clientv2.

2014-02-25 Thread Maxim Khutornenko
://reviews.apache.org/r/18354/#comment65891 Please, add this target into make-python-sdists as well. - Maxim Khutornenko On Feb. 21, 2014, 2:12 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18354: Add a packaging target for clientv2.

2014-02-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/#review35410 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 25, 2014, 4:33

Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.

2014-02-25 Thread Maxim Khutornenko
Done. - Maxim Khutornenko On Feb. 25, 2014, 1 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440

Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.

2014-02-25 Thread Maxim Khutornenko
780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.

2014-02-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35440 --- Thanks! Pushed to master. - Maxim Khutornenko On Feb. 25, 2014

Review Request 18485: Improving sla_list_safe_domain performance

2014-02-25 Thread Maxim Khutornenko
/test_sla.py 4f0a2c07fbed975a43438f32b6a576e6b85da4f8 Diff: https://reviews.apache.org/r/18485/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:sla Thanks, Maxim Khutornenko

Re: Review Request 18523: Remove rogue apostrophes.

2014-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18523/#review35539 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 26, 2014, 5:43

Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-26 Thread Maxim Khutornenko
/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.

2014-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review35553 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 26, 2014, 7:07

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-02-26 Thread Maxim Khutornenko
/scheduler/storage/log/WriteAheadStorage.java https://reviews.apache.org/r/18487/#comment66157 Mind converting this comment into a message arg? - Maxim Khutornenko On Feb. 26, 2014, 12:12 a.m., Bill Farner wrote

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35589 --- On Feb. 26, 2014, 6:17 p.m., Maxim Khutornenko wrote

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66445 Good point, completely missed the optional meaning there. Question: do we treat an empty value set in a TaskQuery as (1) or (2)? I am leaning towards (1) as a less strict and more intuitive. Any objections? - Maxim Khutornenko On Feb

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66450 On a second thought, it's easier to reason about all this if we treat set and non-set values the same way, namely non-null empty sets would return empty results. - Maxim Khutornenko On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
/apache/aurora/gen/api.thrift https://reviews.apache.org/r/18526/#comment66463 Dropped. - Maxim Khutornenko On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko
://reviews.apache.org/r/18602/#comment66473 If we are going this route, how about adding a log message to make it more visible? Also, you might want to consider a more specific env var with AURORA in it to avoid an unlikely but possible collision. - Maxim Khutornenko On Feb. 28, 2014, 1

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko
://reviews.apache.org/r/18602/#comment66478 Change line ordering here to avoid parsing error in %f - Maxim Khutornenko On Feb. 28, 2014, 1:45 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko
%f for a string? - Maxim Khutornenko On Feb. 28, 2014, 1:59 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

2014-02-27 Thread Maxim Khutornenko
/Resources.java https://reviews.apache.org/r/18546/#comment66484 Mind adding the ticket that tracks collapsing work? AURORA-105? src/main/java/org/apache/aurora/scheduler/quota/Quotas.java https://reviews.apache.org/r/18546/#comment66487 s/quota/ResourceAggregate - Maxim Khutornenko

  1   2   3   4   5   6   7   8   9   10   >