kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377986596
##
File path:
pkuwm opened a new issue #756: Add write REST endpoints to helix rest for
metadata store directory
URL: https://github.com/apache/helix/issues/756
We have metadata store directory service to help scale out zookeeper.
Metadata store directory service provides REST APIs to access.
This
nikhilvavs commented on issue #748: Huge CPU spike after upgrading from 0.8.2
to 0.8.4
URL: https://github.com/apache/helix/issues/748#issuecomment-585063817
We took flame graphs of the CPU with and without the upgraded version.
The upgraded version had 25.7% samples from
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377995356
##
File path:
narendly merged pull request #744: Add read endpoints of metadata store
directory service to helix rest
URL: https://github.com/apache/helix/pull/744
This is an automated message from the Apache Git Service.
To respond to
alirezazamani commented on issue #741: Fix ConcurrentModification exception in
Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#issuecomment-585041520
This PR is ready to be merged, approved by @narendly.
Final commit message:
Title:
Fix
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377987956
##
File path:
pkuwm commented on issue #744: Add read endpoints of metadata store directory
service to helix rest
URL: https://github.com/apache/helix/pull/744#issuecomment-584944817
Unit tests in helix-rest are passed.
This PR is ready to be merged, approved by @narendly
Commit msg:
```
Add
pkuwm opened a new issue #755: Create MetadataStoreDirectory's abstract
resource class
URL: https://github.com/apache/helix/issues/755
We have a plan to move MetadataStoreDirectoryService out of helix-rest
module. To handle dependency after MetadataStoreDirectoryService is moved out
of
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377986596
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377990567
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377990453
##
File path:
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377995356
##
File path:
narendly opened a new issue #754: Improve callback function for
MetadataStoreDirectoy
URL: https://github.com/apache/helix/issues/754
> @Override
> public synchronized void handleDataDeleted(String s) {
> if (_zkClient.isClosed()) {
> return;
> }
> //
alirezazamani commented on a change in pull request #741: Fix
ConcurrentModification exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377986361
##
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##
pkuwm commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377986296
##
File path:
alirezazamani commented on a change in pull request #741: Fix
ConcurrentModification exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377986318
##
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377982247
##
File path:
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377987956
##
File path:
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377987956
##
File path:
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377987956
##
File path:
kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377995356
##
File path:
pkuwm opened a new pull request #757: Add write REST endpoints to helix rest
for metadata store directory
URL: https://github.com/apache/helix/pull/757
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
Implements #756
alirezazamani opened a new pull request #747: Stabilize TestZKWatch
URL: https://github.com/apache/helix/pull/747
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR title:
Fixes #746
### Description
- [x] Here are some details about
alirezazamani opened a new issue #746: Test ZKWatch is unstable
URL: https://github.com/apache/helix/issues/746
Test ZKWatch is unstable and needs to be stabilized
This is an automated message from the Apache Git Service.
To
alirezazamani closed pull request #747: Stabilize TestZKWatch
URL: https://github.com/apache/helix/pull/747
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jiajunwang commented on issue #748: Huge CPU spike after upgrading from 0.8.2
to 0.8.4
URL: https://github.com/apache/helix/issues/748#issuecomment-584794700
@nikhilvavs Thanks for reporting the issue. We will take a look at this.
Could you please share more about your profiling? What
alirezazamani commented on issue #747: Stabilize TestZKWatch
URL: https://github.com/apache/helix/pull/747#issuecomment-584794652
@i3wangyi proposed another approach to stabilize this test. I will close
this PR.
This is an
zhangmeng916 commented on a change in pull request #729: Implement Helix API
for updating customized state
URL: https://github.com/apache/helix/pull/729#discussion_r377833786
##
File path: helix-core/src/main/java/org/apache/helix/PropertyPathBuilder.java
##
@@ -112,6
i3wangyi opened a new pull request #749: Fix the flaky test - TestZkWatch
URL: https://github.com/apache/helix/pull/749
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
(Fixes #747 )
### Description
- [ ]
narendly commented on issue #749: Fix the flaky test - TestZkWatch
URL: https://github.com/apache/helix/pull/749#issuecomment-584808560
@i3wangyi
Thanks for the fix! Could you just run the full mvn test a few more times to
make sure this doesn't show up as failure?
NealSun96 opened a new pull request #751: Implement getAllMappingUnderPath and
getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
Fixes #750 0
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377844743
##
File path:
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377847093
##
File path:
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377845516
##
File path:
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377844856
##
File path:
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377845123
##
File path:
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377846650
##
File path:
narendly commented on a change in pull request #741: Fix ConcurrentModification
exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377793701
##
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##
@@
nikhilvavs opened a new issue #748: Huge CPU spike after upgrading from 0.8.2
to 0.8.4
URL: https://github.com/apache/helix/issues/748
We were using apache helix 0.8.2 and upgraded to using 0.8.4.
After upgrading, we saw a huge spike in the CPU usage where it jumped from
around 80% to
narendly commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377818842
##
File path:
alirezazamani commented on issue #747: Stabilize TestZKWatch
URL: https://github.com/apache/helix/pull/747#issuecomment-584782793
@narendly Yes I ran it twice and seems to be fine. Let me run it few more
times until tonight and report the status. I think it should be fixed now. I
will ask
mgao0 commented on a change in pull request #718: Implement Helix nonblocking
lock
URL: https://github.com/apache/helix/pull/718#discussion_r377833465
##
File path:
helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLockInfo.java
##
@@ -0,0 +1,92 @@
+/*
+ *
mgao0 commented on a change in pull request #718: Implement Helix nonblocking
lock
URL: https://github.com/apache/helix/pull/718#discussion_r377832567
##
File path:
helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLockInfo.java
##
@@ -0,0 +1,92 @@
+/*
+ *
NealSun96 opened a new issue #750: Implement getAllMappingUnderPath and
getMetadataStoreRealm for ZkMetadataStoreDirectory
URL: https://github.com/apache/helix/issues/750
Methods `getAllMappingUnderPath` and `getMetadataStoreRealm` in
`ZkMetadataStoreDirectory` were not previously
mgao0 commented on a change in pull request #718: Implement Helix nonblocking
lock
URL: https://github.com/apache/helix/pull/718#discussion_r377829738
##
File path:
helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLock.java
##
@@ -0,0 +1,198 @@
+/*
+ *
mgao0 commented on a change in pull request #718: Implement Helix nonblocking
lock
URL: https://github.com/apache/helix/pull/718#discussion_r377829043
##
File path: helix-lock/src/main/java/org/apache/helix/lock/HelixLockScope.java
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to
pkuwm commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377836071
##
File path:
pkuwm opened a new issue #752: Add left-over read MSDS endpoints to helix rest
URL: https://github.com/apache/helix/issues/752
There are some operations that are unsupported like
getAllNamespaces
getAllMappingUnderPath
getMetadataStoreRealm
etc..
Note: endpoint of
narendly commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377848392
##
File path:
dasahcc commented on issue #684: Add zookeeper-api module to Apache Helix
URL: https://github.com/apache/helix/pull/684#issuecomment-584811520
Overall, the structure looks good to me. Just one thing: for the module
folder. org/apache/helix/zookeeper/api/api. Shall we leave the module
pkuwm commented on issue #744: Add read endpoints of metadata store directory
service to helix rest
URL: https://github.com/apache/helix/pull/744#issuecomment-584811029
Unit tests in helix-rest are passed.
This PR is ready to be merged, approved by @narendly
Commit msg:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377854671
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377892533
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377853190
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377853401
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377853468
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377857618
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377854671
##
File path:
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377854593
##
File path:
mgao0 commented on a change in pull request #718: Implement Helix nonblocking
lock
URL: https://github.com/apache/helix/pull/718#discussion_r377872027
##
File path: helix-lock/src/main/java/org/apache/helix/lock/HelixLockScope.java
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377872125
##
File path:
alirezazamani commented on a change in pull request #741: Fix
ConcurrentModification exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377880822
##
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##
narendly commented on a change in pull request #741: Fix ConcurrentModification
exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377954143
##
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##
@@
narendly commented on a change in pull request #741: Fix ConcurrentModification
exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377954310
##
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##
@@
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377957591
##
File path:
narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377960269
##
File path:
lei-xia commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377964586
##
File path:
narendly commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377967223
##
File path:
pkuwm commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377969769
##
File path:
i3wangyi commented on issue #749: Fix the flaky test - TestZkWatch
URL: https://github.com/apache/helix/pull/749#issuecomment-584872554
Latest mvn test
```
[ERROR] Tests run: 1083, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
4,534.661 s <<< FAILURE! - in TestSuite
[ERROR]
i3wangyi opened a new issue #753:
TestControllerLeadershipChange.testMissingTopStateDurationMonitoring is unstable
URL: https://github.com/apache/helix/issues/753
```
[ERROR] Tests run: 1083, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
4,534.661 s <<< FAILURE! - in TestSuite
narendly commented on issue #684: Add zookeeper-api module to Apache Helix
URL: https://github.com/apache/helix/pull/684#issuecomment-584874889
This PR is ready to be merged, approved by @dasahcc @jiajunwang
Add metrics-common, zookeeper-api, helix-common modules
We want to
NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377938345
##
File path:
narendly commented on issue #684: Add zookeeper-api module to Apache Helix
URL: https://github.com/apache/helix/pull/684#issuecomment-584873707
> LGTM! Thanks for working on this huge task.
>
> One concern is the ivy file helix-core/helix-core-0.9.2-SNAPSHOT.ivy.
'commons-math3" is
i3wangyi edited a comment on issue #749: Fix the flaky test - TestZkWatch
URL: https://github.com/apache/helix/pull/749#issuecomment-584872554
Latest mvn test
```
[ERROR] Tests run: 1083, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
4,534.661 s <<< FAILURE! - in TestSuite
narendly closed issue #631: Create zookeeper-api module to decouple ZK API from
helix-core
URL: https://github.com/apache/helix/issues/631
This is an automated message from the Apache Git Service.
To respond to the message,
narendly merged pull request #684: Add zookeeper-api module to Apache Helix
URL: https://github.com/apache/helix/pull/684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
i3wangyi commented on issue #749: Fix the flaky test - TestZkWatch
URL: https://github.com/apache/helix/pull/749#issuecomment-584880351
The PR is ready to be merged into master, approved by @alirezazamani
@narendly
final commit message:
Fix the unstable TestZkWatch
- The
dasahcc commented on a change in pull request #744: Add read endpoints of
metadata store directory service to helix rest
URL: https://github.com/apache/helix/pull/744#discussion_r377933092
##
File path:
pkuwm removed a comment on issue #744: Add read endpoints of metadata store
directory service to helix rest
URL: https://github.com/apache/helix/pull/744#issuecomment-584811029
Unit tests in helix-rest are passed.
This PR is ready to be merged, approved by @narendly
Commit
81 matches
Mail list logo
