[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. IMPALA-7893: Correctly

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 3: Tim, thanks for the review

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11993 to look at the new patch set (#3). Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: (2 comments) Looks like a useful change

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 4: Code-Review+2 --

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11791 ) Change subject: IMPALA-5200: Count child time for parent's total time .. Patch Set 2: Build Successful

[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh

2018-11-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12006 Change subject: Regenerate missing configuration files in run-all.sh .. Regenerate missing configuration files in run-all.sh When

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11967 to look at the new patch set (#8). Change subject: IMPALA-1048: show sinks in exec summary

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. IMPALA-7895: Incorrect

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 4: Verified+1 -- To

[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12006 ) Change subject: Regenerate missing configuration files in run-all.sh .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 3: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function

2018-11-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 ) Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function .. Patch Set 3: Code-Review+1 (1 comment) Soft +2 for

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-11-28 Thread Csaba Ringhofer (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11984 to look at the new patch set (#4). Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-11-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 4: Patch set 4 is a rebase +

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11952 ) Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 ) Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-2343: Add lifecycle timeline to plan nodes

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11992 ) Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 3: > Patch Set 1: > > I'm vaguely

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 1: (3 comments) Thanks for doing this.

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 3: Code-Review+1 (2 comments) carry

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11967 to look at the new patch set (#7). Change subject: IMPALA-1048: show sinks in exec summary

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-11-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12004 Change subject: IMPALA-7889: Write new logical types in Parquet .. IMPALA-7889: Write new logical types in Parquet Fill the

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12005 Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 1: I'm vaguely uncomfortable with

[Impala-ASF-CR] IMPALA-2343: Add lifecycle timeline to plan nodes

2018-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11992 ) Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes .. Patch Set 7: (8 comments)

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11947 to look at the new patch set (#4). Change subject: IMPALA-6656: BufferAllocator observability

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-2343: Add lifecycle timeline to plan nodes

2018-11-28 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11992 to look at the new patch set (#8). Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11874 to look at the new patch set (#9). Change subject: IMPALA-7738: Implement timeouts for HDFS open calls

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11874 to look at the new patch set (#8). Change subject: IMPALA-7738: Implement timeouts for HDFS open calls

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Michael Ho (Code Review)
Hello Balazs Jeszenszky, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12000 to look at the new patch set (#2). Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 2: Code-Review+1 LGTM. -- To view,

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-28 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-11-28 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11791 to look at the new patch set (#2). Change subject: IMPALA-5200: Count child time for parent's total time