[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 12:

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 3: Code-Review+1 (1 comment) I

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14697 Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. IMPALA-9150: Use HBase's stop-hbase.sh script for

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14661 ) Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14661 ) Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause .. Patch Set 3: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-12 Thread Alex Rodoni (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14661 to look at the new patch set (#3). Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14661 ) Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause .. Patch Set 3: Build Started

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9127: explicit probe state machine in hash join

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14688 ) Change subject: IMPALA-9127: explicit probe state machine in hash join .. IMPALA-9127: explicit probe state machine in hash join This

[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 ) Change subject: IMPALA-9082: make WebserverTest error checking stricter .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14668 to look at the new patch set (#4). Change subject: IMPALA-9128: part 2: dump traces for slow RPCs

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: (3 comments) A few more comments. Planning to take

[Impala-ASF-CR] IMPALA-9127: explicit probe state machine in hash join

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14688 ) Change subject: IMPALA-9127: explicit probe state machine in hash join .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. IMPALA-9128: part 2: dump traces for slow RPCs This adds trace events

[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: I probably should have asked

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14661 ) Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14668 to look at the new patch set (#5). Change subject: IMPALA-9128: part 2: dump traces for slow RPCs

[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 ) Change subject: IMPALA-9082: make WebserverTest error checking stricter .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 ) Change subject: IMPALA-9082: make WebserverTest error checking stricter .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9127: explicit probe state machine in hash join

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14688 ) Change subject: IMPALA-9127: explicit probe state machine in hash join .. Patch Set 5: This depends on

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8205: Support number of true and false statistics for boolean column

2019-11-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 ) Change subject: IMPALA-8205: Support number of true and false statistics for boolean column .. Patch Set 1: (8 comments) Thanks

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. IMPALA-9128: part 1: log on slow data stream RPCs

[Impala-ASF-CR] IMPALA-9128: part 1: log on slow data stream RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 ) Change subject: IMPALA-9128: part 1: log on slow data stream RPCs .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 12:

[Impala-ASF-CR] IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14700 ) Change subject: IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode

2019-11-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14700 Change subject: IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode .. IMPALA-7506: [DOCS] Global INVALIDATE is

[Impala-ASF-CR] IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14700 ) Change subject: IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14672 ) Change subject: IMPALA-9082: make WebserverTest error checking stricter .. IMPALA-9082: make WebserverTest error

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 ) Change subject: IMPALA-9082: make WebserverTest error checking stricter .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

2019-11-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 ) Change subject: IMPALA-9092 : Disable show create table tests on Kudu .. Patch Set 3: I think it makes sense to move forward with

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#5). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 12:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 12:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 13:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 13:

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

2019-11-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 ) Change subject: IMPALA-9092 : Disable show create table tests on Kudu .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14697 to look at the new patch set (#2). Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14661 ) Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 12:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 12:

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#4). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread