[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: > (5 comments) > > The historical t

[Impala-ASF-CR] IMPALA-5847: Fix incorrect use of SET in .test files

2019-01-21 Thread Thomas Marshall (Code Review)
Hello Michael Brown, David Knupp, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12220 to look at the new patch set (#5). Change subject: IMPALA-5847: Fix incorrect use of SET in .test files

[Impala-ASF-CR] IMPALA-5847: Fix incorrect use of SET in .test files

2019-01-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12220 ) Change subject: IMPALA-5847: Fix incorrect use of SET in .test files .. Patch Set 5: Code-Review+2 carrying forward -- To view, vi

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-22 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#3). Change subject: IMPALA-4555: Make QueryState's status reporting more robust .

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-22 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 3: (8 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12260/

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-01-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 1: Code-Revie

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-28 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: Code-Review+1 lgtm, but I'll give Michael a chance to do

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12260/2

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-29 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#4). Change subject: IMPALA-4555: Make QueryState's status reporting more robust

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 4: (5 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-01-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12297 Change subject: IMPALA-8138: Reintroduce rpc debugging options .. IMPALA-8138: Reintroduce rpc debugging options In the past, we had

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-01-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12299 Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. IMPALA-2990: timeout unresponsive queries in coordinator

[Impala-ASF-CR] IMPALA-8140: Fix use-after-poison in grouping aggregator

2019-01-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12298 ) Change subject: IMPALA-8140: Fix use-after-poison in grouping aggregator .. Patch Set 1: Code-Review+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-01-30 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12299 to look at the new patch set (#2). Change subject: IMPALA-2990: timeout unresponsive queries in coordinator ..

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-01-30 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: (9 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#5). Change subject: IMPALA-4555: Make QueryState's status reporting more robust

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 6: (7 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#6). Change subject: IMPALA-4555: Make QueryState's status reporting more robust

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#7). Change subject: IMPALA-4555: Make QueryState's status reporting more robust

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-07 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 7: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py

2019-02-07 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12397 Change subject: IMPALA-8173: Fix KeyError in run-workload.py .. IMPALA-8173: Fix KeyError in run-workload.py A recent change (IMPALA-

[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py

2019-02-07 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 ) Change subject: IMPALA-8173: Fix KeyError in run-workload.py .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12397

[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py

2019-02-07 Thread Thomas Marshall (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12397 to look at the new patch set (#2). Change subject: IMPALA-8173: Fix KeyError in run-workload.py .. IMPALA-

[Impala-ASF-CR] IMPALA-8154: Disable Kerberos auth to local setting

2019-02-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12405 ) Change subject: IMPALA-8154: Disable Kerberos auth_to_local setting .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-02-11 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12

[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py

2019-02-11 Thread Thomas Marshall (Code Review)
Hello Lars Volker, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12397 to look at the new patch set (#3). Change subject: IMPALA-8173: Fix KeyError in run-workload.py .

[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py

2019-02-11 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 ) Change subject: IMPALA-8173: Fix KeyError in run-workload.py .. Patch Set 3: Code-Review+2 carrying forward -- To view, visit http

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12461 Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .. IMPALA-8183: fix test_reportexecstatus_retry flakiness The

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12461 to look at the new patch set (#2). Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12461 ) Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12461 ) Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .. Patch Set 2: Code-Review+2 carrying forward -- To view,

[Impala-ASF-CR] IMPALA-8199: Fix stress test: 'No module named RuntimeProfile.ttypes'

2019-02-13 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12472 Change subject: IMPALA-8199: Fix stress test: 'No module named RuntimeProfile.ttypes' .. IMPALA-8199: Fix stress test: 'No module nam

[Impala-ASF-CR] IMPALA-8199: Fix stress test: 'No module named RuntimeProfile.ttypes'

2019-02-13 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12472 to look at the new patch set (#2). Change subject: IMPALA-8199: Fix stress test: 'No module named RuntimeProfile.ttypes' ..

[Impala-ASF-CR] Exclude stress test queries from run-workload

2019-02-13 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12476 Change subject: Exclude stress test queries from run-workload .. Exclude stress test queries from run-workload A recent commit (IMPAL

[Impala-ASF-CR] Exclude stress test queries from run-workload

2019-02-13 Thread Thomas Marshall (Code Review)
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/12476 ) Change subject: Exclude stress test queries from run-workload .. Abandoned Realized there are similar issues with tpcds that I should solve a

[Impala-ASF-CR] IMPALA-8199: Fix stress test: 'No module named RuntimeProfile.ttypes'

2019-02-14 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12472 ) Change subject: IMPALA-8199: Fix stress test: 'No module named RuntimeProfile.ttypes' .. Patch Set 3: Code-Review+2 (1 comment) ca

[Impala-ASF-CR] IMPALA-8207: Fix query loading for perf and stress tests

2019-02-15 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12503 Change subject: IMPALA-8207: Fix query loading for perf and stress tests .. IMPALA-8207: Fix query loading for perf and stress tests

[Impala-ASF-CR] IMPALA-8207: Fix query loading for perf and stress tests

2019-02-15 Thread Thomas Marshall (Code Review)
Hello David Knupp, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12503 to look at the new patch set (#2). Change subject: IMPALA-8207: Fix query loading for perf and stress tests ...

[Impala-ASF-CR] IMPALA-8207: Fix query loading for perf and stress tests

2019-02-15 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12503 ) Change subject: IMPALA-8207: Fix query loading for perf and stress tests .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR](2.x) IMPALA-6812: Fix flaky Kudu scan tests

2019-02-20 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12513 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2019-02-20 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12521 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 6: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-8222: disable per-query timeouts in stress test

2019-02-20 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12531 ) Change subject: IMPALA-8222: disable per-query timeouts in stress test .. Patch Set 3: Code-Review+2 > This might be a controversial

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 ) Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. Patch Set 4: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-02-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: (4 comments) > Any update ? Got distracte

[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only

2019-02-26 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12610 ) Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport()

2019-03-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12651 ) Change subject: IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport() .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-03-07 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12297 to look at the new patch set (#2). Change subject: IMPALA-8138: Reintroduce rpc debugging options .

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-03-07 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 2: (3 comments) This is not really ready for full revie

[Impala-ASF-CR] IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column()

2019-03-07 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12692 ) Change subject: IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column() .. Patch Set 1: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12672/2/be/

[Impala-ASF-CR] IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored

2019-03-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12694 ) Change subject: IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored .. Patch Set 1: Code-Review+2 (1 comment) http://ge

[Impala-ASF-CR] [stress] factor out MemBroker into its own file.

2019-03-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12687 ) Change subject: [stress] factor out MemBroker into its own file. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] [stress] pull out QueryRunner

2019-03-11 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 ) Change subject: [stress] pull out QueryRunner .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12578/3

[Impala-ASF-CR] IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table

2019-03-13 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12746 Change subject: IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table .. IMPALA-8299: Fix crash in GroupingAggregator o

[Impala-ASF-CR] IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table

2019-03-13 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12746 to look at the new patch set (#2). Change subject: IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table

[Impala-ASF-CR] IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table

2019-03-14 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12746 to look at the new patch set (#3). Change subject: IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-03-15 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12299 to look at the new patch set (#3). Change subject: IMPALA-2990: timeout unresponsive queries in coordinator ..

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-03-15 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12299 to look at the new patch set (#4). Change subject: IMPALA-2990: timeout unresponsive queries in coordinator ..

[native-toolchain-CR] Fix error when PUBLISH DEPENDENCIES=0

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12793 Change subject: Fix error when PUBLISH_DEPENDENCIES=0 .. Fix error when PUBLISH_DEPENDENCIES=0 Running the build with PUBLISH_DEPENDE

[native-toolchain-CR] Bump Kudu version to 1.9.0

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12794 Change subject: Bump Kudu version to 1.9.0 .. Bump Kudu version to 1.9.0 Change-Id: Ie749174fdd84ee7d9918e498b1fade0351575ad3 --- M b

[native-toolchain-CR] Bump Kudu version to 1.9.0

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12794 ) Change subject: Bump Kudu version to 1.9.0 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12794 To un

[Impala-ASF-CR] IMPALA-6326: part 1: refactor result hashing

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12676 ) Change subject: IMPALA-6326: part 1: refactor result hashing .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera

[native-toolchain-CR] Bump Kudu version to 1.9.0

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12794 ) Change subject: Bump Kudu version to 1.9.0 .. Bump Kudu version to 1.9.0 Change-Id: Ie749174fdd84ee7d9918e498b1fade0351575ad

[native-toolchain-CR] Bump Kudu version to 1.9.0

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12794 ) Change subject: Bump Kudu version to 1.9.0 .. Patch Set 2: Verified+1 Code-Review+2 carrying forward -- To view, visit http://gerr

[native-toolchain-CR] Fix error when PUBLISH DEPENDENCIES=0

2019-03-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/12793 ) Change subject: Fix error when PUBLISH_DEPENDENCIES=0 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12793 To unsubscribe, vis

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12824 Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Bump toolchain version to 8430101a-b65f-

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: I was working with the ne

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: Also, some additional con

[native-toolchain-CR] Add documentation for docker-based toolchain builds

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] Add CREATE KUDU section for table 'nullrows'

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12826 Change subject: Add CREATE_KUDU section for table 'nullrows' .. Add CREATE_KUDU section for table 'nullrows' A recent patch (IMPALA-8

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12827 Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Remove setting of 'kudu.master_addresses' from Kud

[Impala-ASF-CR] Add CREATE KUDU section for table 'nullrows'

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/12826 ) Change subject: Add CREATE_KUDU section for table 'nullrows' .. Abandoned A better solution: https://gerrit.cloudera.org/#/c/12827/ -- To vie

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Thomas Marshall (Code Review)
Hello David Knupp, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12827 to look at the new patch set (#2). Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading ...

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-22 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: > lgtm. Did you make sure

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 2: gvo failed due to IMPALA-

[native-toolchain-CR] Add documentation for docker-based toolchain builds

2019-03-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.clou

[native-toolchain-CR] Add documentation for docker-based toolchain builds

2019-03-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Add documentation for docker-based toolchain builds T

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-03-25 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12299 to look at the new patch set (#5). Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-03-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 3: Code-Review+1 (4 comments) Looks good, thanks for doing this

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-03-26 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12299 to look at the new patch set (#7). Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .

[Impala-ASF-CR] IMPALA-6326: part 2: remove fetch thread in stress test

2019-03-27 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12681 ) Change subject: IMPALA-6326: part 2: remove fetch thread in stress test .. Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-28 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12672/5/be/s

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-03-28 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: Rebased on top of the latest version of https://gerri

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-03-28 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12297 to look at the new patch set (#3). Change subject: IMPALA-8138: Reintroduce rpc debugging options .

[Impala-ASF-CR] Fix stress test tracking of past metrics values

2019-04-01 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12903 Change subject: Fix stress test tracking of past metrics values .. Fix stress test tracking of past metrics values The stress test ke

[Impala-ASF-CR] Revert "Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8"

2019-04-01 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12905 Change subject: Revert "Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8" .. Revert "Bump toolchain version

[native-toolchain-CR] Check for thirft.protocol.fastbinary in both lib and lib64

2019-04-02 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12915 ) Change subject: Check for thirft.protocol.fastbinary in both lib and lib64 .. Check for thirft.protocol.fastbinary in both li

[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d

2019-04-03 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12928 Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. IMPALA-8377: bump toolchain version to 107-acaeac961d This f

[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS

2019-04-03 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12929 Change subject: Remove '-static-libstdc++' from CXXFLAGS .. Remove '-static-libstdc++' from CXXFLAGS CXXFLAGS used to be ignored by t

[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS

2019-04-03 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12929 ) Change subject: Remove '-static-libstdc++' from CXXFLAGS .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:80

[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS

2019-04-03 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12929 ) Change subject: Remove '-static-libstdc++' from CXXFLAGS .. Remove '-static-libstdc++' from CXXFLAGS CXXFLAGS used to be ign

[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d

2019-04-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: > Seems good to me aside from the conflict wit

[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d

2019-04-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: Code-Review+2 carrying forward -- To view, v

[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d

2019-04-04 Thread Thomas Marshall (Code Review)
Hello Lars Volker, Hector Acosta, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12928 to look at the new patch set (#2). Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d ...

[Impala-ASF-CR] Revert "Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8"

2019-04-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/12905 ) Change subject: Revert "Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8" .. Abandoned Instead of reverting, we're

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-04-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 ) Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table .. Patch Set 4: (1 comment) Please be sure to g

  1   2   3   4   5   6   >