[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 9: Code-Review+2 Thanks Lars! -- To view, visit http://gerrit.cloudera.org:8080/4187 To

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4677/2/be/src/exec/exec-node.cc

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. MT_DOP > 0 is only supported

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be able to run the Random Query Generator with

[Impala-ASF-CR] IMPALA-3644 Make predicate order deterministic

2016-10-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-3644 Make predicate order deterministic .. IMPALA-3644 Make predicate order deterministic This adds a tie-break to make sure that we sort predicates in a

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3644 Make predicate order deterministic

2016-10-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3644 Make predicate order deterministic .. Patch Set 4: This change now still passes on Java 7 and fixes all but 3 tests in PlannerTest. I will run the

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3943: Do not throw scan errors for empty Parquet files.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3943: Address post-merge comments.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4696 Change subject: IMPALA-3943: Address post-merge comments. .. IMPALA-3943: Address post-merge comments. Adds code comments and issues a

[Impala-ASF-CR] IMPALA-4287: EE tests fail to run when KUDU IS SUPPORTED�lse

2016-10-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4697 Change subject: IMPALA-4287: EE tests fail to run when KUDU_IS_SUPPORTED=false .. IMPALA-4287: EE tests fail to run when

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4673/6//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-12 Thread Alex Behm (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4673 to look at the new patch set (#7). Change subject: IMPALA-2789: More compact mem layout with null bits at the end.

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4698 Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. IMPALA-4277: bump Hadoop component versions

[Impala-ASF-CR] IMPALA-3943: Address post-merge comments.

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3943: Address post-merge comments. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4696 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4700 Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. IMPALA-3718: Add test_cancellation tests for Kudu Additional

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0 --- M

[Impala-ASF-CR](hadoop-next) IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4701 Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. IMPALA-4277: temporary hack to avoid

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. Patch Set 7: Code-Review+1 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4673

[Impala-ASF-CR] IMPALA-4287: EE tests fail to run when KUDU IS SUPPORTED�lse

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4287: EE tests fail to run when KUDU_IS_SUPPORTED=false .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4697 To

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 5: (2 comments) So much better http://gerrit.cloudera.org:8080/#/c/4685/5/buildall.sh File

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4700/1/tests/query_test/test_cancellation.py File

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4685/5/buildall.sh File buildall.sh:

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread Tim Armstrong (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4685 to look at the new patch set (#6). Change subject: IMPALA-4259: build Impala without any test cluster setup. ..

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#5). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be able to run the Random Query Generator with

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 3: (8 comments) Looking good, just some small things then I'll +1.

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() This patch is mostly mechanical move of codegen

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 5: Henry, do you have any further comments on this one? Thanks. -- To

[Impala-ASF-CR] IMPALA-4274: hang in buffered-block-mgr-test

2016-10-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4274: hang in buffered-block-mgr-test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4690 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 4: Code-Review+1 (1 comment) Carry David's +1

[Impala-ASF-CR] IMPALA-4274: hang in buffered-block-mgr-test

2016-10-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4274: hang in buffered-block-mgr-test .. IMPALA-4274: hang in buffered-block-mgr-test We started seeing hangs in CreateDestroyMulti() where a

[Impala-ASF-CR] IMPALA-3943: Do not throw scan errors for empty Parquet files.

2016-10-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. .. IMPALA-3943: Do not throw scan errors for empty Parquet files. For Parquet files

[Impala-ASF-CR] IMPALA-3943: Do not throw scan errors for empty Parquet files.

2016-10-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4693 To

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-12 Thread Jim Apple (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4674 to look at the new patch set (#4). Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment ..

[Impala-ASF-CR] Impala-3342 Adding thread counters to measure time spent during plan fragment execution

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Impala-3342 Adding thread counters to measure time spent during plan fragment execution .. Patch Set 2: (4 comments)

[Impala-ASF-CR] Reduce LLVM module's preparation time by lazily creating the IRFunction::Type to LLVM::Function* mappings.

2016-10-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Reduce LLVM module's preparation time by lazily creating the IRFunction::Type to LLVM::Function* mappings. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] Reduce LLVM module's preparation time by lazily creating the IRFunction::Type to LLVM::Function* mappings.

2016-10-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: Reduce LLVM module's preparation time by lazily creating the IRFunction::Type to LLVM::Function* mappings. .. Reduce LLVM module's preparation time by lazily

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4685 To unsubscribe,

[Impala-ASF-CR] IMPALA-3002/1473: Cardinality observability cleanup

2016-10-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-3002/1473: Cardinality observability cleanup .. IMPALA-3002/1473: Cardinality observability cleanup IMPALA-3002: The shell prints an incorrect

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 7: Code-Review+2 The merge failed because the merge jump runs buildall.sh from a

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 4: Tim, I added you in case you wanted to talk about how this might work with Ubuntu

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. Patch Set 6: Code-Review+1 (2 comments) Thanks! LGTM, just a few comments for the commit

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 8: Code-Review+1 Carry -- To view, visit http://gerrit.cloudera.org:8080/4448 To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/4678/5//COMMIT_MSG Commit Message: PS5,

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/4494/8//COMMIT_MSG Commit Message: PS8, Line 17: 64 > 32,

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 4: Rebase onto Alex's change. -- To view, visit

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4685 To unsubscribe,