[kudu-CR] Add initial internal INT128/ int128 support

2017-11-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8533 to look at the new patch set (#14). Change subject: Add initial internal INT128/__int128 support

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8533 to look at the new patch set (#13). Change subject: Add initial internal INT128/__int128 support

[kudu-CR] Add public INT128 column type support

2017-11-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8553 to look at the new patch set (#2). Change subject: Add public INT128 column type support .. Add public

[kudu-CR] WIP [catalog manager] introduce replica type matching policy

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Adar Dembo from this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: WIP [catalog manager] introduce replica type matching policy .. Removed reviewer Adar Dembo. -- To view, visit

[kudu-CR] WIP [client] expose non-voter replicas for kudu CLI tool

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8586 Change subject: WIP [client] expose non-voter replicas for kudu CLI tool .. WIP [client] expose non-voter replicas for kudu CLI tool

[kudu-CR] WIP [catalog manager] introduce replica type matching policy

2017-11-16 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8161 to look at the new patch set (#4). Change subject: WIP [catalog manager] introduce replica type matching policy

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 ) Change subject: Fix compiler warnings in tablet_replacement-itest .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8584 ) Change subject: Fix compiler warnings in tablet_replacement-itest .. Fix compiler warnings in tablet_replacement-itest This

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8584 ) Change subject: Fix compiler warnings in tablet_replacement-itest .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [itests] fix compilation with ExternalDaemon::Pause()

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8582 ) Change subject: [itests] fix compilation with ExternalDaemon::Pause() .. Abandoned Abandonded since https://gerrit.cloudera.org/#/c/8584/ has

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1454 [part 2]: enable scan locality for Spark

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8560 ) Change subject: KUDU-1454 [part 2]: enable scan locality for Spark .. Patch Set 1: (1 comment)

[kudu-CR] Improve breakpad tooling

2017-11-16 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8576 Change subject: Improve breakpad tooling .. Improve breakpad tooling Kudu has used Google Breakpad to produce minidumps since

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] Improve breakpad tooling

2017-11-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8576 ) Change subject: Improve breakpad tooling .. Patch Set 1: Failure was: 10:55:58 ../nondebug/libpmemobj/tx.o: file not recognized: File

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1454 [part 1]: update propagated timestamp on the driver

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8552 ) Change subject: KUDU-1454 [part 1]: update propagated timestamp on the driver .. Patch Set 1: (3 comments)

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment)

[kudu-CR] dist test: enable sharding of a few more tests

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 ) Change subject: dist_test: enable sharding of a few more tests .. Patch Set 1: (1 comment)

[kudu-CR] [java] Add ReplicaSelection in KuduScanToken

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 ) Change subject: [java] Add ReplicaSelection in KuduScanToken .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1078. Fix 'ops in future' error under load

2017-11-16 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8563 to look at the new patch set (#3). Change subject: KUDU-1078. Fix 'ops in future' error under load ..

[kudu-CR] KUDU-1078. Fix 'ops in future' error under load

2017-11-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8563 ) Change subject: KUDU-1078. Fix 'ops in future' error under load .. Patch Set 2: (3 comments)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8561 to look at the new patch set (#3). Change subject: [RaftPeerPB] introduce attributes and health status ..

[kudu-CR] KUDU-1078. Fix 'ops in future' error under load

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8563 ) Change subject: KUDU-1078. Fix 'ops in future' error under load .. Patch Set 2: (3 comments) Nice, I wasn't sure of the cause of this

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. KUDU-2048. consensus: only

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 6: Code-Review+2 (1

[kudu-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8570 to look at the new patch set (#2). Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 3: (3 comments)

[kudu-CR] Mark hms client-test as RUN SERIAL to avoid timeouts

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8566 ) Change subject: Mark hms_client-test as RUN_SERIAL to avoid timeouts .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Deflake tablet replica-test anchor and transaction count assertions

2017-11-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8564 ) Change subject: Deflake tablet_replica-test anchor and transaction count assertions .. Patch Set 1: Verified+1 Test failures are some

[kudu-CR] Deflake tablet replica-test anchor and transaction count assertions

2017-11-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8564 ) Change subject: Deflake tablet_replica-test anchor and transaction count assertions .. Deflake tablet_replica-test anchor and

[kudu-CR] Deflake tablet replica-test anchor and transaction count assertions

2017-11-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Deflake tablet_replica-test anchor and transaction count assertions .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] dist test: enable sharding of a few more tests

2017-11-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 ) Change subject: dist_test: enable sharding of a few more tests .. Patch Set 1: (1 comment)

[kudu-CR] dist test: enable sharding of a few more tests

2017-11-16 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8565 to look at the new patch set (#2). Change subject: dist_test: enable sharding of a few more tests ..

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 2: (2 comments)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 3: (3 comments)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8561 to look at the new patch set (#4). Change subject: [RaftPeerPB] introduce attributes and health status

[kudu-CR] [itests] fix compilation with ExternalDaemon::Pause()

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8582 ) Change subject: [itests] fix compilation with ExternalDaemon::Pause() .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [itests] fix compilation with ExternalDaemon::Pause()

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8582 ) Change subject: [itests] fix compilation with ExternalDaemon::Pause() .. Patch Set 1: Verified+1 unrelated flakes in:

[kudu-CR] Improve breakpad tooling

2017-11-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8576 ) Change subject: Improve breakpad tooling .. Patch Set 2: Test failures look they're due to Jenkins problems; other precommits are

[kudu-CR] [RaftPeerPB] introduce new status fields

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce new status fields .. Patch Set 2: (1 comment)

[kudu-CR] Improve breakpad tooling

2017-11-16 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8576 to look at the new patch set (#2). Change subject: Improve breakpad tooling .. Improve breakpad tooling Kudu has

[kudu-CR] Add public INT128 column type support

2017-11-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8553 to look at the new patch set (#3). Change subject: Add public INT128 column type support .. Add public

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8533 to look at the new patch set (#15). Change subject: Add initial internal INT128/__int128 support

[kudu-CR] [RaftPeerPB] introduce new status fields

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce new status fields .. Patch Set 2: (2 comments)

[kudu-CR] Deflake tablet replica-test anchor and transaction count assertions

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8564 ) Change subject: Deflake tablet_replica-test anchor and transaction count assertions .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Deflake tablet replica-test anchor and transaction count assertions

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8564 ) Change subject: Deflake tablet_replica-test anchor and transaction count assertions .. Patch Set 1: Code-Review+2 Nice detective work.

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: Code-Review+2 sgtm. As a side

[kudu-CR] Improve breakpad tooling

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8576 ) Change subject: Improve breakpad tooling .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8576 To

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: (5 comments)

[kudu-CR] [spark] Remove AsyncClient in KuduContext

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8551 ) Change subject: [spark] Remove AsyncClient in KuduContext .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1454 [part 1]: update propagated timestamp on the driver

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8552 ) Change subject: KUDU-1454 [part 1]: update propagated timestamp on the driver .. Patch Set 4: LGTM, but I think we should solve the

[kudu-CR] Mark hms client-test as RUN SERIAL to avoid timeouts

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8566 ) Change subject: Mark hms_client-test as RUN_SERIAL to avoid timeouts .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] dist test: enable sharding of a few more tests

2017-11-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 ) Change subject: dist_test: enable sharding of a few more tests .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] wire protocol: optimize RewriteRowBlockPointers

2017-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8554 ) Change subject: wire_protocol: optimize RewriteRowBlockPointers .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-1454 [part 1]: update propagated timestamp on the driver

2017-11-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8552 ) Change subject: KUDU-1454 [part 1]: update propagated timestamp on the driver .. Patch Set 3: (8 comments)

[kudu-CR] KUDU-1454 [part 1]: update propagated timestamp on the driver

2017-11-16 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8552 to look at the new patch set (#3). Change subject: KUDU-1454 [part 1]: update propagated timestamp on the driver

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#26). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 25: (10 comments)

[kudu-CR] [java] Add ReplicaSelection in KuduScanToken

2017-11-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 ) Change subject: [java] Add ReplicaSelection in KuduScanToken .. Patch Set 2: (3 comments)

[kudu-CR] [java] Add ReplicaSelection in KuduScanToken

2017-11-16 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8559 to look at the new patch set (#2). Change subject: [java] Add ReplicaSelection in KuduScanToken ..

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: (10 comments)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 4: Code-Review+2 I'm ok either way, naming is a pretty

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1078. Fix 'ops in future' error under load

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8563 ) Change subject: KUDU-1078. Fix 'ops in future' error under load .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: (3 comments)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 4: (1 comment)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1454 [part 2]: enable scan locality for Spark

2017-11-16 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8560 to look at the new patch set (#2). Change subject: KUDU-1454 [part 2]: enable scan locality for Spark

[kudu-CR] KUDU-1454 [part 2]: enable scan locality for Spark

2017-11-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8560 ) Change subject: KUDU-1454 [part 2]: enable scan locality for Spark .. Patch Set 2: (1 comment)

[kudu-CR] [RaftPeerPB] introduce attributes and health status

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 ) Change subject: [RaftPeerPB] introduce attributes and health status .. Patch Set 2: (1 comment)

[kudu-CR] [itests] fix compilation with ExternalDaemon::Pause()

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8582 Change subject: [itests] fix compilation with ExternalDaemon::Pause() .. [itests] fix compilation with ExternalDaemon::Pause()

[kudu-CR] Add scoped macros to allow/disallow IO and waiting

2017-11-16 Thread Mike Percy (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8583 to review the following change. Change subject: Add scoped macros to allow/disallow IO and waiting .. Add scoped

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8584 to review the following change. Change subject: Fix compiler warnings in tablet_replacement-itest .. Fix compiler

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 ) Change subject: Fix compiler warnings in tablet_replacement-itest .. Patch Set 1: > that's fun: https://gerrit.cloudera.org/#/c/8582/

[kudu-CR] [itests] fix compilation with ExternalDaemon::Pause()

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8582 ) Change subject: [itests] fix compilation with ExternalDaemon::Pause() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 ) Change subject: Fix compiler warnings in tablet_replacement-itest .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Fix compiler warnings in tablet replacement-itest

2017-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 ) Change subject: Fix compiler warnings in tablet_replacement-itest .. Patch Set 1: that's fun: https://gerrit.cloudera.org/#/c/8582/

[kudu-CR] Add scoped macros to allow/disallow IO and waiting

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8583 ) Change subject: Add scoped macros to allow/disallow IO and waiting .. Patch Set 1: (1 comment)

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2017-11-16 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8585 Change subject: [spark] add 'local-cluster' mode for unit test .. [spark] add 'local-cluster' mode for unit test This patch adds

[kudu-CR] KUDU-1454 [part 1]: update propagated timestamp on the driver

2017-11-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8552 ) Change subject: KUDU-1454 [part 1]: update propagated timestamp on the driver .. Patch Set 4: > Build Failed > >

[kudu-CR] [spark] Remove AsyncClient in KuduContext

2017-11-16 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8551 to look at the new patch set (#3). Change subject: [spark] Remove AsyncClient in KuduContext

[kudu-CR] [spark] Remove AsyncClient in KuduContext

2017-11-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8551 ) Change subject: [spark] Remove AsyncClient in KuduContext .. Patch Set 3: (1 comment)

[kudu-CR] Add scoped macros to allow/disallow IO and waiting

2017-11-16 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8583 to look at the new patch set (#2). Change subject: Add scoped macros to allow/disallow IO and waiting

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: (11 comments) Overall I'm not convinced of whether the CHECK