[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 7: Verified+1 Overriding Jenkins, unrelated Java test

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 ) Change subject: [tablet] clean-up on replay of WAL entries .. Patch Set 1: (2 comments)

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 3: (1 comment)

[kudu-CR] [gradle] Add rerunTests property

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. Patch Set 1: (1 comment) So I had a sneaking suspicion that Java test retrying

[kudu-CR] [gradle] Add rerunTests property

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. Patch Set 1: This is slightly different. Maybe I need a better name for the

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11032 to look at the new patch set (#2). Change subject: [tablet] clean-up on replay of WAL entries

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11036 to review the following change. Change subject: hms tools: do not require HMS configuration flags .. hms

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-24 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11018 to look at the new patch set (#5). Change subject: hms-tool: refactor check tool and combine upgrade and fix

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Patch Set 2: Verified+1 Overriding Jenkins, more Java flakes.

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11030 to look at the new patch set (#3). Change subject: Scala code formatting with Scalafmt ..

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 ) Change subject: [tablet] clean-up on replay of WAL entries .. Patch Set 2: Verified+1 Unrelated flakes in

[kudu-CR] [gradle] Add rerunTests property

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11035 Change subject: [gradle] Add rerunTests property .. [gradle] Add rerunTests property [gradle] Add rerunTests property Gradle keeps

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 3: (7 comments)

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 3: Code-Review-1 (1 comment) It's still aligning case arrows,

[kudu-CR] schema: add is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11029 to look at the new patch set (#2). Change subject: deltamemstore: support iteration with snap_to_exclude

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 5: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] schema: add is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 7: Verified+1 Overriding Jenkins, unrelated Java test failures. --

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 5: Verified+1 Overriding Jenkins, unrelated Java

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Removed reviewer Dan Burkert. -- To view, visit

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 ) Change subject: [tablet] clean-up on replay of WAL entries .. Patch Set 2: (3 comments)

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11032 ) Change subject: [tablet] clean-up on replay of WAL entries .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 3: (1 comment)

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 ) Change subject: [tablet] clean-up on replay of WAL entries .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11037 Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. [Java] Retry tests that don’t inherit from BaseKuduTest The

[kudu-CR] Allow non-HMS compatible tables to be renamed after turning on HMS integration

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11016 ) Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration .. Patch Set 2: (1 comment)

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11030 to look at the new patch set (#5). Change subject: Scala code formatting with Scalafmt ..

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11030 to look at the new patch set (#4). Change subject: Scala code formatting with Scalafmt ..

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11037 ) Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. Patch Set 2: (2 comments)

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 5: (3 comments)

[kudu-CR] [tablet] clean-up on replay of WAL entries

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11032 ) Change subject: [tablet] clean-up on replay of WAL entries .. [tablet] clean-up on replay of WAL entries Simplified handling

[kudu-CR] Allow non-HMS compatible tables to be renamed after turning on HMS integration

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11016 ) Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration .. Patch Set 2: (1 comment)

[kudu-CR] Allow non-HMS compatible tables to be renamed after turning on HMS integration

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11016 ) Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] Allow non-HMS compatible tables to be renamed after turning on HMS integration

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11016 ) Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration .. Patch Set 2: Verified+1 Getting

[kudu-CR] Allow non-HMS compatible tables to be renamed after turning on HMS integration

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11016 ) Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration .. Allow non-HMS compatible

[kudu-CR] Allow non-HMS compatible tables to be renamed after turning on HMS integration

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] exactly once writes-itest for faulty disks

2018-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8388 ) Change subject: exactly_once_writes-itest for faulty disks .. Patch Set 8: (7 comments)

[kudu-CR] [gradle] Add rerunTests property

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. [gradle] Add rerunTests property Gradle keeps track of changes and will

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 1: (2 comments)

[kudu-CR] [gradle] Add rerunTests property

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [gradle] Add rerunTests property .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11035 To unsubscribe, visit

[kudu-CR] [gradle] Add rerunTests property

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11035 ) Change subject: [gradle] Add rerunTests property .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11035 To

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 1: (7 comments)

[kudu-CR] [NOT FOR REVIEW WIP] Design doc for repeatable reads

2018-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/5229 ) Change subject: [NOT FOR REVIEW WIP] Design doc for repeatable reads .. Abandoned no longer relevant since was largely fixed in other

[kudu-CR] [rpc tests] Reduce flakyness by setting a longer keepalive in TSAN

2018-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/6289 ) Change subject: [rpc tests] Reduce flakyness by setting a longer keepalive in TSAN .. Abandoned I no longer have a patch around I can

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 6: (2 comments)

[kudu-CR] hms precheck tool

2018-07-24 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11040 to review the following change. Change subject: hms precheck tool .. hms precheck tool This commit adds a

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11017 to look at the new patch set (#3). Change subject: Add alter_external_catalogs flag to table rename tool

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11036 to look at the new patch set (#2). Change subject: hms tools: do not require HMS configuration flags

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 2: (8 comments)

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 3: (1 comment)

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 7: (2 comments)

[kudu-CR] schema: add is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 7: (1 comment) > I'm curious how this will plumb through all the way

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11037 ) Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11037 ) Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. Patch Set 1: (1 comment)

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] schema: add is deleted virtual column

2018-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 7: (1 comment) I'm curious how this will plumb through all the way

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11036 to look at the new patch set (#3). Change subject: hms tools: do not require HMS configuration flags

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11037 ) Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. Patch Set 1: (3 comments)

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11037 ) Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. Patch Set 1: (4 comments)

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11037 to look at the new patch set (#2). Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest

[kudu-CR] Add a way to pin clean time advancement

2018-07-24 Thread David Ribeiro Alves (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9641 to look at the new patch set (#7). Change subject: Add a way to pin clean time advancement

[kudu-CR] [flaky tests] Increase the result ttl for ExactlyOnceRpcTest.TestExactlyOnceSemanticsGarbageCollectionStressTest

2018-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/4644 ) Change subject: [flaky tests] Increase the result ttl for ExactlyOnceRpcTest.TestExactlyOnceSemanticsGarbageCollectionStressTest ..

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2018-07-24 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#28). Change subject: Simplify OpId/Timestamp assignment and make it atomic

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 2: (3 comments)

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11037 to look at the new patch set (#3). Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 5: (4 comments)

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 2: (2 comments)

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 3: Code-Review+1 (1 comment)

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Patch Set 3: Verified+1 unrelated flake -- To view, visit

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11017 ) Change subject: Add alter_external_catalogs flag to table rename tool .. Add alter_external_catalogs flag to table rename tool

[kudu-CR] Add alter external catalogs flag to table rename tool

2018-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: Add alter_external_catalogs flag to table rename tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11017 To

[kudu-CR] [Java] Retry tests that don’t inherit from BaseKuduTest

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11037 ) Change subject: [Java] Retry tests that don’t inherit from BaseKuduTest .. [Java] Retry tests that don’t inherit from

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 ) Change subject: hms-tool: refactor check tool and combine upgrade and fix .. Patch Set 7: (9 comments)

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 5: (4 comments)

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10926 to look at the new patch set (#8). Change subject: memrowset: support iteration with snap_to_exclude

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-24 Thread Adar Dembo (Code Review)
Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10929 to look at the new patch set (#6). Change subject: memrowset: support iteration with include_deleted_rows

[kudu-CR] schema: add is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Hello Mike Percy, Dan Burkert, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#8). Change subject: schema: add is_deleted virtual column

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 7: (2 comments)

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 5: (3 comments)

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10990 to look at the new patch set (#6). Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 8: Code-Review+1 much easier for me to follow now,

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-24 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11018 to look at the new patch set (#7). Change subject: hms-tool: refactor check tool and combine upgrade and fix

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11036 to look at the new patch set (#4). Change subject: hms tools: do not require HMS configuration flags

[kudu-CR] Add a way to pin clean time advancement

2018-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9641 ) Change subject: Add a way to pin clean time advancement .. Patch Set 7: Verified+1 (24 comments) Oops had some unposted old

[kudu-CR] Add a way to pin clean time advancement

2018-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: Add a way to pin clean time advancement .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9641 To unsubscribe,

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Tony Foerster (Code Review)
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 6: Hmm, Jenkins is failing but the same target

[kudu-CR] KUDU-2095 - Add scanner `keepAlive` RPC call to Java API

2018-07-24 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7749 to look at the new patch set (#8). Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 6: (1 comment) You could try wrapping in a no format comment as a

[kudu-CR] Scala code formatting with Scalafmt

2018-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2511 fix for SingleReplicasStayOrMove scenario

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11046 Change subject: KUDU-2511 fix for SingleReplicasStayOrMove scenario .. KUDU-2511 fix for SingleReplicasStayOrMove scenario The

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10990 to look at the new patch set (#7). Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] schema: add is deleted virtual column

2018-07-24 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#9). Change subject: schema: add is_deleted virtual column

[kudu-CR] KUDU-2511 fix for SingleReplicasStayOrMove scenario

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11046 ) Change subject: KUDU-2511 fix for SingleReplicasStayOrMove scenario .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] KUDU-2511 fix for SingleReplicasStayOrMove scenario

2018-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11046 ) Change subject: KUDU-2511 fix for SingleReplicasStayOrMove scenario .. Patch Set 1: Verified+1 Unrelated flake in:

  1   2   >