[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. build-support: option to retry all failed tests Currently,

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 5: (1 comment)

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11342 to look at the new patch set (#6). Change subject: build-support: option to retry all failed tests

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11342 to look at the new patch set (#5). Change subject: build-support: option to retry all failed tests

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 5: (3 comments)

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] error manager: rename error types

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11303

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11248 to look at the new patch set (#6). Change subject: KUDU-2469 pt 1: add an IOContext

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. Patch Set 6: (1 comment)

[kudu-CR] error manager: rename error types

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 6: (1 comment)

[kudu-CR] error manager: rename error types

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 6: Rebased, but didn't change the implementation. Still not sure whether

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11248

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 7: (2 comments)

[kudu-CR] build: different libunwind workaround for 0dc19bfb3

2018-08-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11343 to review the following change. Change subject: build: different libunwind workaround for 0dc19bfb3 ..

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11313 to look at the new patch set (#4). Change subject: [location_awareness] Add 'location' column in tserver list

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11313 to look at the new patch set (#3). Change subject: [location_awareness] Add 'location' column in tserver list

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 2: (1 comment)

[kudu-CR] bitmap: add equality method

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11292 to look at the new patch set (#6). Change subject: KUDU-428: Sentry integration scaffolding ..

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11345 Change subject: Fix misplaced TRACE in scan path .. Fix misplaced TRACE in scan path Change-Id:

[kudu-CR] build: different libunwind workaround for 0dc19bfb3

2018-08-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11343 ) Change subject: build: different libunwind workaround for 0dc19bfb3 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 3: (2 comments)

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Patch Set 9: (7 comments)

[kudu-CR] bitmap: add equality method

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 3: (1 comment)

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 4: (1 comment)

[kudu-CR] build: different libunwind workaround for 0dc19bfb3

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11343 ) Change subject: build: different libunwind workaround for 0dc19bfb3 .. build: different libunwind workaround for 0dc19bfb3

[kudu-CR] KUDU-1291: efficiently support predicates on non-prefix key components

2018-08-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291: efficiently support predicates on non-prefix key components .. Patch Set 20: (10 comments)

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 ) Change subject: KUDU-428: Sentry integration scaffolding .. Patch Set 6: The design doc has been published [1]. There are some open

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Fix misplaced TRACE in scan path .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11345 To unsubscribe, visit

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11345 ) Change subject: Fix misplaced TRACE in scan path .. Fix misplaced TRACE in scan path Change-Id:

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11345 ) Change subject: Fix misplaced TRACE in scan path .. Patch Set 1: Verified+1 TSAN compilation failed in LLVM compile due to a known

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 ) Change subject: KUDU-428: Sentry integration scaffolding .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 4: > Uploaded patch set 4. It seems lint is

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11345 ) Change subject: Fix misplaced TRACE in scan path .. Patch Set 1: What was the symptom that led you to make this change? -- To view,

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 ) Change subject: KUDU-428: Sentry integration scaffolding .. Patch Set 7: (3 comments)

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11292 to look at the new patch set (#7). Change subject: KUDU-428: Sentry integration scaffolding ..

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11345 ) Change subject: Fix misplaced TRACE in scan path .. Patch Set 2: > What was the symptom that led you to make this change? I asked

[kudu-CR] KUDU-428: add Sentry to thirdparty, mini-sentry

2018-08-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11347 to look at the new patch set (#2). Change subject: KUDU-428: add Sentry to thirdparty, mini-sentry

[kudu-CR] build: fix run-test.sh when not retrying all tests

2018-08-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11348 to look at the new patch set (#2). Change subject: build: fix run-test.sh when not retrying all tests .. build:

[kudu-CR] build: fix run-test.sh when not retrying all tests

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11348 ) Change subject: build: fix run-test.sh when not retrying all tests .. Patch Set 2: Also for reference, one with

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

2018-08-28 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11140 to look at the new patch set (#7). Change subject: deltafile-test: DeltaFileIterator fuzz test

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-28 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11292 ) Change subject: KUDU-428: Sentry integration scaffolding .. KUDU-428: Sentry integration scaffolding In preparation for

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-28 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11029 to look at the new patch set (#10). Change subject: deltamemstore: support iteration with snap_to_exclude

[kudu-CR] deltas: add SelectUpdates iterator method

2018-08-28 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11137 to look at the new patch set (#7). Change subject: deltas: add SelectUpdates iterator method

[kudu-CR] common: add equality methods to ColumnBlock and SelectionVector

2018-08-28 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11267 to look at the new patch set (#3). Change subject: common: add equality methods to ColumnBlock and SelectionVector

[kudu-CR] bitmap: add equality method

2018-08-28 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11266 to look at the new patch set (#4). Change subject: bitmap: add equality method

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Patch Set 10: Verified+1 Overriding Jenkins, unrelated ASAN

[kudu-CR] KUDU-428: add Sentry to thirdparty, mini-sentry

2018-08-28 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11347 Change subject: KUDU-428: add Sentry to thirdparty, mini-sentry .. KUDU-428: add Sentry to thirdparty, mini-sentry This commit adds

[kudu-CR] WIP KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption .. Patch Set 5: (6 comments) Still a WIP since I'd like to maybe

[kudu-CR] WIP KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11249 to look at the new patch set (#5). Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption

[kudu-CR] Fix misplaced TRACE in scan path

2018-08-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11345 ) Change subject: Fix misplaced TRACE in scan path .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 7: (2 comments) Merged before getting to your comments,

[kudu-CR] build: fix run-test.sh when not retrying all tests

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11348 Change subject: build: fix run-test.sh when not retrying all tests .. build: fix run-test.sh when not retrying all tests This is a

[kudu-CR] WIP KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11249 to look at the new patch set (#6). Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption

[kudu-CR] [WIP] KUDU-2245 Graceful leadership transfer

2018-08-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: [WIP] KUDU-2245 Graceful leadership transfer .. Patch Set 4: (14 comments) Just skimming through. I'm going to take

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-28 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. KUDU-2469 pt 1: add an IOContext This patch introduces the IOContext class

[kudu-CR] error manager: rename error types

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. error_manager: rename error types The previous ErrorHandlerType enum names

[kudu-CR] build-support: option to retry all failed tests

2018-08-28 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11342 to look at the new patch set (#4). Change subject: build-support: option to retry all failed tests

[kudu-CR] error manager: rename error types

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11248 to look at the new patch set (#5). Change subject: KUDU-2469 pt 1: add an IOContext

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. Patch Set 5: (3 comments)