[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 12: (3 comments) The location isn't getting piped

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11817 to look at the new patch set (#3). Change subject: [backup] Port keepAlive implementation to KuduBackupRDD

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11818 to review the following change. Change subject: catalog_manager: fix a TSAN race .. catalog_manager: fix a TSAN race

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11819 to review the following change. Change subject: rpc-test: fix TestClientConnectionMetrics .. rpc-test: fix

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 ) Change subject: [backup] Port keepAlive implementation to KuduBackupRDD .. Patch Set 1: (1 comment) I'd ask you to port the test too,

[kudu-CR] [examples] Add basic Spark example written in Scala

2018-10-29 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example written in Scala .. Patch Set 8: (2 comments)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 8: (1 comment)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 9: (1 comment)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 9: (44 comments) Still need to try running it. Will respond

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Patch Set 1: (2 comments)

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 ) Change subject: [backup] Port keepAlive implementation to KuduBackupRDD .. Patch Set 2: (1 comment)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 1: (2 comments) Looks good, just a couple of nits.

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11818 ) Change subject: catalog_manager: fix a TSAN race .. Patch Set 1: (2 comments)

[kudu-CR] [examples] Add basic Spark example written in Scala

2018-10-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example written in Scala .. Patch Set 8: (4 comments)

[kudu-CR] [rebalancer] location-aware rebalancer (part 5/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11746 to look at the new patch set (#4). Change subject: [rebalancer] location-aware rebalancer (part 5/n)

[kudu-CR] [examples] Add basic Spark example written in Scala

2018-10-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example written in Scala .. Patch Set 8: (1 comment)

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 ) Change subject: [backup] Port keepAlive implementation to KuduBackupRDD .. Patch Set 2: (1 comment)

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 ) Change subject: [backup] Port keepAlive implementation to KuduBackupRDD .. Patch Set 3: (1 comment)

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 2: (1 comment)

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 ) Change subject: [backup] Port keepAlive implementation to KuduBackupRDD .. Patch Set 1: I would really like to combine the

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11817 to look at the new patch set (#2). Change subject: [backup] Port keepAlive implementation to KuduBackupRDD

[kudu-CR] deltas: fuzz tests for delta file and dms

2018-10-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 ) Change subject: deltas: fuzz tests for delta file and dms .. Patch Set 15: (8 comments) looks good overall

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 9: (3 comments)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11788 to look at the new patch set (#9). Change subject: [examples] Add basic Spark example (scala)

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Patch Set 1: (1 comment)

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 ) Change subject: [backup] Port keepAlive implementation to KuduBackupRDD .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11748 to look at the new patch set (#3). Change subject: [rebalancer] location-aware rebalancer (part 7/n) ..

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 1: (3 comments)

[kudu-CR] [rebalancer] location-aware rebalancer (part 5/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11746 to look at the new patch set (#3). Change subject: [rebalancer] location-aware rebalancer (part 5/n) ..

[kudu-CR] [rebalancer] location-aware rebalancer (part 1/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11549 to look at the new patch set (#8). Change subject: [rebalancer] location-aware rebalancer (part 1/n) ..

[kudu-CR] [rebalancer] location-aware rebalancer (part 1/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11549 ) Change subject: [rebalancer] location-aware rebalancer (part 1/n) .. Patch Set 7: (2 comments)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 10: (41 comments)

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11818 ) Change subject: catalog_manager: fix a TSAN race .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11818/1//COMMIT_MSG

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11743 ) Change subject: [rebalancer] location-aware rebalancer (part 2/n) .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11743 ) Change subject: [rebalancer] location-aware rebalancer (part 2/n) .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 4/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11745 ) Change subject: [rebalancer] location-aware rebalancer (part 4/n) .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#13). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11744 ) Change subject: [rebalancer] location-aware rebalancer (part 3/n) .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 12: (2 comments)

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#15). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#2). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11818 to look at the new patch set (#2). Change subject: catalog_manager: fix a TSAN race ..

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] Stop using client-test-util in tools

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11821 ) Change subject: Stop using client-test-util in tools .. Patch Set 2: (2 comments)

[kudu-CR] [rebalancer] location-aware rebalancer (part 5/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11746 ) Change subject: [rebalancer] location-aware rebalancer (part 5/n) .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#4). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 1: (1 comment)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-29 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11788 to look at the new patch set (#10). Change subject: [examples] Add basic Spark example (scala)

[kudu-CR] [rebalancer] location-aware rebalancer (part 1/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11549 ) Change subject: [rebalancer] location-aware rebalancer (part 1/n) .. [rebalancer] location-aware rebalancer (part 1/n) Added

[kudu-CR] [rebalancer] location-aware rebalancer (part 6/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11747 ) Change subject: [rebalancer] location-aware rebalancer (part 6/n) .. Patch Set 4: Verified+1 Unrelated flake in

[kudu-CR] [rebalancer] location-aware rebalancer (part 5/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11746 ) Change subject: [rebalancer] location-aware rebalancer (part 5/n) .. Patch Set 4: Verified+1 Unrelated flakes in: *

[kudu-CR] [rebalancer] location-aware rebalancer (part 4/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11745 ) Change subject: [rebalancer] location-aware rebalancer (part 4/n) .. [rebalancer] location-aware rebalancer (part 4/n)

[kudu-CR] [rebalancer] location-aware rebalancer (part 6/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11747 ) Change subject: [rebalancer] location-aware rebalancer (part 6/n) .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11743 ) Change subject: [rebalancer] location-aware rebalancer (part 2/n) .. [rebalancer] location-aware rebalancer (part 2/n) Small

[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11744 ) Change subject: [rebalancer] location-aware rebalancer (part 3/n) .. [rebalancer] location-aware rebalancer (part 3/n) Some

[kudu-CR] Stop using client-test-util in tools

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11821 Change subject: Stop using client-test-util in tools .. Stop using client-test-util in tools The `kudu hms` and `kudu table` tools

[kudu-CR] Stop using client-test-util in tools

2018-10-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11821 to look at the new patch set (#2). Change subject: Stop using client-test-util in tools

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#14). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 6/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11747 ) Change subject: [rebalancer] location-aware rebalancer (part 6/n) .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 5/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11746 ) Change subject: [rebalancer] location-aware rebalancer (part 5/n) .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 6/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11747 ) Change subject: [rebalancer] location-aware rebalancer (part 6/n) .. [rebalancer] location-aware rebalancer (part 6/n) Added

[kudu-CR] [rebalancer] location-aware rebalancer (part 5/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11746 ) Change subject: [rebalancer] location-aware rebalancer (part 5/n) .. [rebalancer] location-aware rebalancer (part 5/n) Added

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 1: (2 comments)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#3). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] [rebalancer] location-aware rebalancer (part 4/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11745 ) Change subject: [rebalancer] location-aware rebalancer (part 4/n) .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11743 ) Change subject: [rebalancer] location-aware rebalancer (part 2/n) .. Patch Set 3: Verified+1 Unrelated flakes in: 1)

[kudu-CR] [rebalancer] location-aware rebalancer (part 4/n)

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11745 ) Change subject: [rebalancer] location-aware rebalancer (part 4/n) .. Patch Set 3: Verified+1 Unrelated flake in

[kudu-CR] [rebalancer] location-aware rebalancer (part 1/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11549 ) Change subject: [rebalancer] location-aware rebalancer (part 1/n) .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] Stop using client-test-util in tools

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11821 ) Change subject: Stop using client-test-util in tools .. Patch Set 1: (1 comment)

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11818 ) Change subject: catalog_manager: fix a TSAN race .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] Stop using client-test-util in tools

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11821 ) Change subject: Stop using client-test-util in tools .. Patch Set 2: (1 comment)

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 13: (8 comments) > (3 comments) > > The

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 14: Code-Review+1 (2 comments)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated test failure. -- To

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11818 ) Change subject: catalog_manager: fix a TSAN race .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11818 To

[kudu-CR] deltas: fuzz tests for delta file and dms

2018-10-29 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11140 to look at the new patch set (#16). Change subject: deltas: fuzz tests for delta file and dms

[kudu-CR] mt-rowset delta compaction-test: remove dead code

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11824 to review the following change. Change subject: mt-rowset_delta_compaction-test: remove dead code ..

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. rpc-test: fix TestClientConnectionMetrics Every now and then, this

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#5). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2542: add initial authorization token impl

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 ) Change subject: KUDU-2542: add initial authorization token impl .. Patch Set 3: (6 comments) Overall looks good, just a few

[kudu-CR] mt-rowset delta compaction-test: remove dead code

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11824 ) Change subject: mt-rowset_delta_compaction-test: remove dead code .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 15: Code-Review+1 -- To view, visit

[kudu-CR] deltas: fuzz tests for delta file and dms

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 ) Change subject: deltas: fuzz tests for delta file and dms .. Patch Set 15: (8 comments)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] catalog manager: fix a TSAN race

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11818 ) Change subject: catalog_manager: fix a TSAN race .. catalog_manager: fix a TSAN race Noticed this on the flaky test dashboard

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 5: Verified+1 Overriding Jenkins, unrelated TSAN failure. -- To

[kudu-CR] KUDU-2542: add initial authorization token impl

2018-10-29 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11750 to look at the new patch set (#4). Change subject: KUDU-2542: add initial authorization token impl

[kudu-CR] KUDU-2542: add initial authorization token impl

2018-10-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 ) Change subject: KUDU-2542: add initial authorization token impl .. Patch Set 4: (6 comments)

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 12: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 1: (3 comments)

[kudu-CR] [master] update placement logic for RF % 2 == 0

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11763 ) Change subject: [master] update placement logic for RF % 2 == 0 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [examples] Add basic Spark example written in Scala

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example written in Scala .. Patch Set 8: Verified+1 -- To view, visit

  1   2   >