[kudu-CR] [make site.sh] an option for the script: doxygen

2016-07-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3766 Change subject: [make_site.sh] an option for the script: doxygen .. [make_site.sh] an option for the script: doxygen By default, do not

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 14: (4 comments) Looked only at the doxygen comments in client.h file.

[kudu-CR] [make site.h] added C++ client API documentaion

2016-07-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3729 to look at the new patch set (#2). Change subject: [make_site.h] added C++ client API documentaion ..

[kudu-CR] [make site.h] added C++ client API documentaion

2016-07-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [make_site.h] added C++ client API documentaion .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3729/1/docs/support/scripts/make_site.sh File

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3723 Change subject: C++ client: deprecating KuduPartialRow::SetString() .. C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#2). Change subject: C++ client: deprecating KuduPartialRow::SetString() .. C++

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3723/1/src/kudu/client/stubs.h File

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3834 Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBatch::const_iterator] a minor clean-up More

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3834 to look at the new patch set (#2). Change subject: [KuduScanBatch::const_iterator] a minor clean-up ..

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/3809/3/src/kudu/client/client-internal.cc

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) Thank you for review. Will post an updated version soon.

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File

[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds

2016-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3825 Change subject: [doxygen] made DESTDIR applicable for ninja builds .. [doxygen] made DESTDIR applicable for ninja builds Moved the

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#7). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#8). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#7). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3952 Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3868/1//COMMIT_MSG Commit Message:

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#9). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#8). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#5). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#6). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: (3 comments) Will post the updated version soon.

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#4). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#9). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#6). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 5: (3 comments)

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#11). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#10). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [util] fixed build on MacOS X

2016-08-03 Thread Alexey Serbin (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3836 to look at the new patch set (#2). Change subject: [util] fixed build on MacOS X .. [util] fixed

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3840 Change subject: [C++ client] doxygenized all C++ client API .. [C++ client] doxygenized all C++ client API Doxygenized the rest of

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Abandoned Abandoned in favor of https://gerrit.cloudera.org/#/c/3952/ The new approach uses RPC messenger thread

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Abandoned Abandoning this in favor of http://gerrit.cloudera.org:8080/3868 which has been merged already. -- To

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3978 Change subject: [util/env_posix.cc] fixed build on MacOS X .. [util/env_posix.cc] fixed build on MacOS X Fixed a tiny typo which broke

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: > oops, my bad! np, and thank you for the instant review! -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#5). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] [util/stopwatch.h] fixed integer overflow

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3960 Change subject: [util/stopwatch.h] fixed integer overflow .. [util/stopwatch.h] fixed integer overflow Fixed integer overflow reported

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#3). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] monotime: remove granularity argument

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: monotime: remove granularity argument .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3966/1//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-13 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#4). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#10). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: (4 comments)

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3668 to look at the new patch set (#8). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#2). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 1: Code-Review+1 A tiny nit: is it possible to re-format the commit message to preserve

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#12). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 10: (1 comment) Thank you for the review, Mike!

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3840 to look at the new patch set (#2). Change subject: [C++ client] doxygenized all C++ client API .. [C++ client]

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3668 to look at the new patch set (#5). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3668 to look at the new patch set (#4). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

2016-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 2: Code-Review+1 > Build Started http://104.196.14.100/job/kudu-gerrit/2720/ The renaming of files

[kudu-CR] [CMakeLists.txt] dot is mandatory for doxygen

2016-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3855 Change subject: [CMakeLists.txt] dot is mandatory for doxygen .. [CMakeLists.txt] dot is mandatory for doxygen Require dot (graphviz)

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [C++ client] doxygenized all C++ client API .. Patch Set 2: (85 comments) Thank you for the review! Will post the updated patch soon.

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3840 to look at the new patch set (#3). Change subject: [C++ client] doxygenized all C++ client API .. [C++ client]

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3840 to look at the new patch set (#4). Change subject: [C++ client] doxygenized all C++ client API .. [C++ client]

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3840 to look at the new patch set (#5). Change subject: [C++ client] doxygenized all C++ client API .. [C++ client]

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [C++ client] doxygenized all C++ client API .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/client/callbacks.h File

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-08 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#4). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3723/3//COMMIT_MSG Commit Message: Line

[kudu-CR] client/sample.cc: fixed a couple of crashes

2016-08-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3685 to look at the new patch set (#3). Change subject: client/sample.cc: fixed a couple of crashes ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3868 Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduPartialRow::Set{Binary,String}()] copy input data

[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds

2016-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: > Looks good provided you've tested it with both make and ninja. Yes, I tested it with GNU

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 2: (3 comments) > (3 comments) > > Can we add basic test coverage for SetString() and

[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3874 Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED .. [client][gutil] introduced ATTRIBUTE_DEPRECATED The

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#2). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#3). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#5). Change subject: C++ client: deprecating KuduPartialRow::SetString()

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3999/1/src/kudu/util/monotime.cc File

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: (12 comments) Will post a new version shortly.

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: > I was going to say that the style guide frowns upon overloading, > but apparently it was

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: > (1 comment) Great! That's simplifies everything. Then I'll remove those obsolete checks.

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: > I was going to say that the style guide frowns upon overloading, > but apparently it was

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#8). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR](gh-pages) Add weekly update for 8/16

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add weekly update for 8/16 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md File

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3999 to look at the new patch set (#2). Change subject: [util/monotime] added handy operators for MonoTime ..

[kudu-CR](gh-pages) Add weekly update for 8/16

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add weekly update for 8/16 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md File

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3999/2/src/kudu/util/monotime.h File

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3952/6/src/kudu/client/client.cc File

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3999 to look at the new patch set (#3). Change subject: [util/monotime] added handy operators for MonoTime ..

[kudu-CR] tool: better handling for positional arguments

2016-08-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tool: better handling for positional arguments .. Patch Set 1: > (5 comments) > > There is a Go library which allows to implement rich CLI tools. If >

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 5: (1 comment) Thank you for the review!

[kudu-CR](gh-pages) Add weekly update for 8/16

2016-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add weekly update for 8/16 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4008 To unsubscribe, visit

[kudu-CR] tls socket: support zero-length writes

2017-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tls_socket: support zero-length writes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5861 To unsubscribe, visit

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

2017-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. Patch Set 3: Verified+1 Unrelated failure in DEBUG configuration: kudu/tests/test_scantoken.py

[kudu-CR] Allow configuring TlsContext with key wrappers

2017-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5845/4/src/kudu/security/tls_context.cc File

[kudu-CR] [security] adjust TLS certificate verification

2017-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] adjust TLS certificate verification .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5865/3/src/kudu/rpc/sasl_common.h

[kudu-CR] security: simplify CertSigner interface

2017-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: security: simplify CertSigner interface .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5846 To unsubscribe, visit

[kudu-CR] Fix some clang-tidy errors for std::move

2017-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix some clang-tidy errors for std::move .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5867 To unsubscribe, visit

[kudu-CR] [master] store CA information in the system table

2017-02-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#6). Change subject: [master] store CA information in the system table .. [master]

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

2017-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client: rename various function calls and classes to ConnectToCluster .. Patch Set 1: Code-Review+2 (1 comment) LGTM, consider fixing a tiny typo before

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

2017-02-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5870 to look at the new patch set (#3). Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() ..

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

2017-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. [mini_cluster] fix crash in GetLeaderMasterIndex() If at least one of the mini-masters is shutdown by

[kudu-CR] [master] store CA information in the system table

2017-02-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#8). Change subject: [master] store CA information in the system table .. [master]

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

2017-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5870 Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. [mini_cluster] fix crash in GetLeaderMasterIndex() If at least

[kudu-CR] [master] store CA information in the system table

2017-02-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#7). Change subject: [master] store CA information in the system table .. [master]

[kudu-CR] WIP: issue authentication tokens and CA certs to clients

2017-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: issue authentication tokens and CA certs to clients .. Patch Set 1: (4 comments)

[kudu-CR] [master] store CA information in the system table

2017-02-02 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#9). Change subject: [master] store CA information in the system table .. [master]

[kudu-CR] Fix some clang-tidy errors for std::move

2017-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix some clang-tidy errors for std::move .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/client/master_rpc.cc File

[kudu-CR] [master] store CA information in the system table

2017-02-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [master] store CA information in the system table .. Patch Set 10: (11 comments)

[kudu-CR] [master] store CA information in the system table

2017-02-03 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#11). Change subject: [master] store CA information in the system table .. [master]

  1   2   3   4   5   6   7   8   9   10   >