Todd Lipcon has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 13: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe,
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890 Allow renaming of primary key column
Removed the checks preventing renaming of primary key
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 13:
Addressed Todd's comments.
The jenkins testcase failure is unrelated to this change.
--
To view,
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#13).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#12).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 11:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6078/11/src/kudu/common/schema.h
File
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 11:
Merged with latest master branch
--
To view, visit http://gerrit.cloudera.org:8080/6078
To
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#10).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 9:
(5 comments)
Addressed code review comments
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#9).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 8:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema-test.cc
File
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 8:
Test failures are unrelated
--
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe,
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 8:
(5 comments)
Addressed Todd's comments
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#8).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 7:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/6078/7/docs/known_issues.adoc
File
Will Berkeley has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 5:
> (1 comment)
>
> Pretty much LGTM. One small docs nit, and it looks like a
>
Will Berkeley has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 5:
(1 comment)
Pretty much LGTM. One small docs nit, and it looks like a security-related
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 5:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#5).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Ram Mettu has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 4:
(4 comments)
Added test cases from alter_table-test.cc and alter_table-randomized-test.cc as
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#4).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Will Berkeley has posted comments on this change.
Change subject: KUDU-1890 Allow renaming of primary key column
..
Patch Set 3:
(4 comments)
Based on my experience in the alter code, I think this should "just work" after
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#3).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6078
to look at the new patch set (#2).
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890
Ram Mettu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6078
Change subject: KUDU-1890 Allow renaming of primary key column
..
KUDU-1890 Allow renaming of primary key column
Removed the checks
25 matches
Mail list logo