[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 13: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe,

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890 Allow renaming of primary key column Removed the checks preventing renaming of primary key

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 13: Addressed Todd's comments. The jenkins testcase failure is unrelated to this change. -- To view,

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#13). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#12). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/6078/11/src/kudu/common/schema.h File

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-15 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 11: Merged with latest master branch -- To view, visit http://gerrit.cloudera.org:8080/6078 To

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-15 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#10). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-15 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 9: (5 comments) Addressed code review comments

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-15 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#9). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema-test.cc File

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-07 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 8: Test failures are unrelated -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe,

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-07 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 8: (5 comments) Addressed Todd's comments

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-07 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#8). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/6078/7/docs/known_issues.adoc File

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: > (1 comment) > > Pretty much LGTM. One small docs nit, and it looks like a >

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: (1 comment) Pretty much LGTM. One small docs nit, and it looks like a security-related

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-27 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-27 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#5). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-26 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 4: (4 comments) Added test cases from alter_table-test.cc and alter_table-randomized-test.cc as

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-26 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#4). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 3: (4 comments) Based on my experience in the alter code, I think this should "just work" after

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-20 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#3). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-20 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#2). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-19 Thread Ram Mettu (Code Review)
Ram Mettu has uploaded a new change for review. http://gerrit.cloudera.org:8080/6078 Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890 Allow renaming of primary key column Removed the checks