Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96366 --- include/mesos/mesos.proto (line 914)

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review96370 --- After the TimeSpec change: src/master/master.cpp (lines 4139 -

Re: Review Request 37722: Added definitions of container rootfs directories.

2015-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96372 --- Ship it! src/slave/containerizer/provisioners/appc/paths.hpp

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review96375 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m.,

Re: Review Request 37189: Added std::hash template specializations.

2015-08-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96355 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 1:16 p.m.,

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96356 --- 3rdparty/libprocess/src/io.cpp (lines 36 - 37)

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/ --- (Updated Aug. 25, 2015, 10:03 a.m.) Review request for mesos, Benjamin

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/ --- (Updated Aug. 25, 2015, 10:03 a.m.) Review request for mesos, Benjamin

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 25, 2015, 10:03 a.m.) Review request for mesos, Benjamin

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Vaibhav Khanduja
On Aug. 25, 2015, 5:05 p.m., Timothy Chen wrote: src/docker/docker.cpp, line 102 https://reviews.apache.org/r/37114/diff/4/?file=1047856#file1047856line102 Also does this mean if a user put in tcp:/// we're just padding unix:///? I think it's safe to assume we should always

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/#review96365 --- After the TimeSpec change: src/tests/master_maintenance_tests.cpp

Re: Review Request 37188: Added std::hash template specializations.

2015-08-25 Thread Michael Park
On Aug. 25, 2015, 12:36 p.m., Michael Park wrote: 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 https://reviews.apache.org/r/37188/diff/6/?file=1037577#file1037577line677 I think this might be the right solution for the scope of the changes we're trying to make, but

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

2015-08-25 Thread Joseph Wu
On Aug. 25, 2015, 2:11 a.m., Guangya Liu wrote: src/master/maintenance.cpp, line 153 https://reviews.apache.org/r/37362/diff/7/?file=1048631#file1048631line153 Not quite under what does the paramter strict means here? Seems it was not used. See my comment:

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96342 --- 3rdparty/libprocess/include/process/io.hpp (line 145)

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96368 --- src/master/maintenance.cpp (line 121)

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96369 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 5:03 p.m.,

Review Request 37747: Introduced bind-mount based provisioner Backend.

2015-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/ --- Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.

Re: Review Request 37582: Maintenance Primitives: Add test for the hierarchical DRF allocator sending inverse offers.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37582/ --- (Updated Aug. 25, 2015, 10:39 a.m.) Review request for mesos, Benjamin

Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37281/#review96381 --- I think that this can be abandoned, as

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96382 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m.,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

2015-08-25 Thread Joseph Wu
On Aug. 24, 2015, 11:04 p.m., Guangya Liu wrote: include/mesos/mesos.proto, line 111 https://reviews.apache.org/r/36571/diff/14/?file=1048532#file1048532line111 Can you please show a case why end user want to hold more agents on a single machine? This may cause resource

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Joseph Wu
On Aug. 24, 2015, 5:57 p.m., Guangya Liu wrote: include/mesos/mesos.proto, line 939 https://reviews.apache.org/r/36321/diff/10/?file=1048529#file1048529line939 Can you please elaborate more for why in maintaince purpose, this field is always empty? Why cannot an operator set the

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 25, 2015, 8:24 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-25 Thread Michael Park
On Aug. 25, 2015, 12:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-25 Thread Michael Park
On Aug. 25, 2015, 12:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 25, 2015, 9:10 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96359 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:33 p.m.,

Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/ --- (Updated Aug. 25, 2015, 10:07 a.m.) Review request for mesos, Benjamin

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 6:02 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96348 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 4:02 p.m.,

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Joseph Wu
On Aug. 25, 2015, 1:36 a.m., Guangya Liu wrote: src/master/maintenance.cpp, line 121 https://reviews.apache.org/r/37358/diff/5/?file=1048624#file1048624line121 What does strict means here? I see it was not used This is explained in the previous review:

Re: Review Request 37188: Added std::hash template specializations.

2015-08-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96354 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 1:15 p.m.,

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 25, 2015, 4:40 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96360 --- src/docker/docker.hpp (line 44)

Re: Review Request 37189: Added std::hash template specializations.

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96336 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All

Review Request 37784: Remove the redundant check in HierarchicalDRFAlocator.

2015-08-25 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37784/ --- Review request for mesos. Bugs: MESOS-3301

Re: Review Request 37784: Remove the redundant check in HierarchicalDRFAlocator.

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37784/#review96488 --- Patch looks great! Reviews applied: [37784] All tests passed. -

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review96501 --- Patch looks great! Reviews applied: [37787] All tests passed. -

Review Request 37785: Fix Flaky SlaveTest.HTTPSchedulerSlaveRestart test

2015-08-25 Thread Anand Mazumdar
Lines: I0825 22:07:39.085610 27642 slave.cpp:1209] Will retry registration in 6.014445ms if necessary I0825 22:07:39.092914 27640 master.cpp:3773] Re-registering slave 20150825-220736-234885548-51219-27610-S0 at slave(286)@172.17.0.14:51219 (09c6504e3a31) I0825 22:07:39.093181 27630 slave.cpp:1209

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/#review96500 --- Ship it! Ship It! - Guangya Liu On Aug. 26, 2015, 2:13 a.m.,

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 25, 2015, 10:17 p.m.) Review request for Joris Van Remoortere

Re: Review Request 37785: Fix Flaky SlaveTest.HTTPSchedulerSlaveRestart test

2015-08-25 Thread Mesos ReviewBot
-registering slave 20150825-220736-234885548-51219-27610-S0 at slave(286)@172.17.0.14:51219 (09c6504e3a31) I0825 22:07:39.093181 27630 slave.cpp:1209] Will retry registration in 20.588077ms if necessary some lines and then I0825 22:07:39.094435 27640 master.cpp:3773] Re-registering slave

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Artem Harutyunyan
On Aug. 25, 2015, 9:29 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/io.cpp, lines 274-286 https://reviews.apache.org/r/36404/diff/7/?file=1027739#file1027739line274 This is the old style, in the new style we just dupliate the file descriptor so that if someone closes the

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-25 Thread Alexander Rukletsov
On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote: src/Makefile.am, line 182 https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182 It is better consider the alpha order of those files, we can add quota related files under module related files. Alexander

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/#review96308 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:48 p.m.,

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96309 --- src/master/maintenance.cpp (line 121)

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96302 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:43 p.m.,

Re: Review Request 37722: Added definitions of container rootfs directories.

2015-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- (Updated Aug. 25, 2015, 11:41 a.m.) Review request for mesos, Lily Chen, Chi

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 6:51 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review96386 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m.,

Re: Review Request 37197: Docker image store.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 25, 2015, 6:47 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 6:48 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 25, 2015, 6:48 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37582: Maintenance Primitives: Add test for the hierarchical DRF allocator sending inverse offers.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37582/#review96397 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 5:39 p.m.,

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/#review96398 --- Patch looks great! Reviews applied: [37722, 37747] All tests

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/#review96392 --- Patch looks great! Reviews applied: [37722, 37747] All tests

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review96393 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m.,

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-25 Thread Jan Schlicht
On Aug. 25, 2015, 2:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review96323 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m.,

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/#review96313 --- src/master/maintenance.cpp (line 153)

Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/#review96315 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 7:09 p.m.,

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/#review96316 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m.,

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/#review96317 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m.,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96126 --- include/mesos/mesos.proto (line 123)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Alexander Rukletsov
On Aug. 21, 2015, 6:35 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Alexander Rukletsov
On Aug. 25, 2015, 9:55 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 847-850 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line847 As per my comment for `InverseOffers`, let's clarify the contract and guarantees here. Or, as I said

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96421 --- src/Makefile.am (line 477)

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96433 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37200,

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Vaibhav Khanduja
On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote: src/docker/docker.cpp, line 104 https://reviews.apache.org/r/37114/diff/5/?file=1051861#file1051861line104 prefixit sounds wierd, how about prefixSocket? Will change On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote:

Re: Review Request 37722: Added definitions of container rootfs directories.

2015-08-25 Thread Jiang Yan Xu
On Aug. 24, 2015, 5:20 p.m., Timothy Chen wrote: src/slave/containerizer/provisioners/appc/paths.hpp, line 55 https://reviews.apache.org/r/37722/diff/2/?file=1048535#file1048535line55 Suggestion: It might make sense to nest one more directory rootfs so you can add metadata about

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-25 Thread Alexander Rukletsov
On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote: include/mesos/master/quota.proto, line 19 https://reviews.apache.org/r/36908/diff/4/?file=1032679#file1032679line19 Yes, does v1 API will be supportted for quota? Adding new protobufs should be backwards-compatible, so I suppose the

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:19 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37197: Docker image store.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 25, 2015, 8:57 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 25, 2015, 8:59 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37247: Added Docker image reference store.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 25, 2015, 9 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 25, 2015, 9:01 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 25, 2015, 9:02 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Vaibhav Khanduja
On Aug. 25, 2015, 5:05 p.m., Timothy Chen wrote: src/docker/docker.cpp, line 102 https://reviews.apache.org/r/37114/diff/4/?file=1047856#file1047856line102 Also does this mean if a user put in tcp:/// we're just padding unix:///? I think it's safe to assume we should always

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Joseph Wu
On Aug. 24, 2015, 4:56 p.m., Vinod Kone wrote: This review is a bit hard to follow because it's doing multiple things. I would recommend you to split this into multiple reviews #1) Expose framework user in state.json #2) Update framework user on re-registration (need a test for

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 9:03 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36868: Added - operators for Option, Try, Result.

2015-08-25 Thread Michael Park
On July 29, 2015, 4:42 a.m., Michael Park wrote: Why wasn't [r36869](https://reviews.apache.org/r/36869) just included in this patch? Ah, it's because this patch is `stout` whereas [r36869](https://reviews.apache.org/r/36869/) is `libprocess`. - Michael

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-25 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 8:58 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

2015-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/ --- (Updated Aug. 25, 2015, 5:19 p.m.) Review request for mesos, Lily Chen, Jie

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96301 --- include/mesos/maintenance/maintenance.proto (line 19)

Re: Review Request 37188: Added std::hash template specializations.

2015-08-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 3:15 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37189: Added std::hash template specializations.

2015-08-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 25, 2015, 3:16 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

2015-08-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37281/ --- (Updated Aug. 25, 2015, 10:48 p.m.) Review request for mesos, Benjamin

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 25, 2015, 3:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Joseph Wu
On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, line 129 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line129 For consistency, please one space between sentences! Here and below. The codebase isn't consistent in this respect.

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Joseph Wu
On Aug. 25, 2015, 10:21 a.m., Guangya Liu wrote: include/mesos/mesos.proto, line 939 https://reviews.apache.org/r/36321/diff/10/?file=1048529#file1048529line939 Thanks Joe! Got it, but I think that it is better that we can add some notes here to be more clear Next time, please

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96449 --- src/docker/docker.cpp (line 111)

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

2015-08-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Aug. 25, 2015, 10:48 p.m.) Review request for mesos, Benjamin

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review96453 --- Can you split the addition of suppress to the driver (sched.cpp)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96422 --- Patch looks great! Reviews applied: [37500] All tests passed. -

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 25, 2015, 9:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96414 --- src/docker/docker.cpp (line 104)

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96424 --- src/docker/docker.cpp (line 104)

Re: Review Request 36868: Added - operators for Option, Try, Result.

2015-08-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36868/#review96429 --- Ship it! Adjust the operator spacing. Keeping the current style

Re: Review Request 36869: Added try_tests.cpp to libprocess makefile.

2015-08-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36869/#review96430 --- Ship it! Ship It! - Joris Van Remoortere On July 28, 2015,

  1   2   >