Re: Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39300/ --- (Updated Oct. 14, 2015, 4:21 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

> On Oct. 14, 2015, 12:44 a.m., Ben Mahler wrote: > > src/tests/reservation_endpoints_tests.cpp, line 187 > > > > > > Shall we put this down before stopping the driver to be a bit clearer? > > A comment there would

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/#review102402 --- LGTM. 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

> On Oct. 6, 2015, 2:39 p.m., Bernd Mathiske wrote: > > Ship It! > > Ben Mahler wrote: > I don't think we should introduce this into stout in its current form. I > realize you're planning to use this for authentication stuff, but looking at > this on its own, it seems like a confusing

Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39263: Windows:[2/3] transitioned libprocess to use `os::raw::` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39263/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39265: Windows: Move `os::environment` to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39258: Add filesystem isolator with command executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/#review102393 --- Patch looks great! Reviews applied: [38900, 39258] All tests

Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39099/#review102416 --- Ship it! Ship It! - Guangya Liu On 十月 13, 2015, 8 a.m., Isabel

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 13, 2015, 7:53 a.m.) Review request for mesos and Michael Park.

Review Request 39259: Enable scheduler driver can use Call::REQUEST to request resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39259/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3715

Re: Review Request 39092: CMake:[2/3] prepared process library tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39092/#review102405 --- LGTM. - Artem Harutyunyan On Oct. 7, 2015, 9 a.m., Alex Clemmer

Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39091/#review102404 --- LGTM. - Artem Harutyunyan On Oct. 7, 2015, 9 a.m., Alex Clemmer

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102409 --- src/tests/credentials_tests.cpp (line 116)

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 13, 2015, 8:45 a.m.) Review request for mesos and Michael Park.

Re: Review Request 39259: Enable scheduler driver can use Call::REQUEST to request resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39259/#review102419 --- Patch looks great! Reviews applied: [39259] All tests passed. -

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102411 --- Ship it! I added the comments to the test you added, but some of

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102420 --- Ship it! I've committed this with the following minor style

Re: Review Request 39265: Windows: Move `os::environment` to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/#review102430 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096,

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review102428 --- Patch looks great! Reviews applied: [38869] All tests passed. -

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review102449 --- Ship it! Ship It! - Guangya Liu On 十月 13, 2015, 8:51 a.m.,

Re: Review Request 39259: Enable scheduler driver can use Call::REQUEST to request resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39259/ --- (Updated 十月 13, 2015, 1:29 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39230: Added check for SASL deprecation into configuration phase.

> On Oct. 12, 2015, 7:37 p.m., James Peach wrote: > > It's marginal, but I think ```AC_LANG_PROGRAM``` is a little clearer that > > ```AC_LANG_SOURCE```. > > > > If you are going to rely on the diagnostic pragmas, an alternative is to > > simply use those to disable the warning in the SASL

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review102435 --- Ship it! src/tests/fetcher_cache_tests.cpp (line 567)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review102433 --- src/master/http.cpp (line 787)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Oct. 13, 2015, 11:54 a.m., Joris Van Remoortere wrote: > > src/master/http.cpp, line 787 > > > > > > Let's add the corresponding HELP function for this. See Alex's earlier comment about providing the Help

Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/#review102458 --- LGTM. - Artem Harutyunyan On Oct. 12, 2015, 12:41 p.m., Alex

Re: Review Request 38747: Adding digest utilities

> On Oct. 13, 2015, 12:54 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, lines 85-120 > > > > > > These templates (here and below) have different levels of > > specializations,

Re: Review Request 39265: Windows: Move `os::environment` to its own file.

> On Oct. 13, 2015, 11:01 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180, 39181, > > 39201, 39182, 39202, 39203, 39204, 39207, 39208, 39209, 39210, 39213, > > 39217, 39218, 39219, 39220] > > > > Failed command:

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review102462 --- Patch looks great! Reviews applied: [39276] All tests passed. -

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 12, 2015, 5:54 a.m., Marco Massenzio wrote: > > Would it be possible to add a few unit tests, also to show usage patterns? > > especially given the absence of any documentation, it's kinda difficult to > > figure out how is this "intended to work" and, without tests, whether it > >

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/ --- (Updated Oct. 13, 2015, 9:27 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

> On 十月 13, 2015, 2:52 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 394 > > > > > > I have one question for this after second review: I see that in > > slave.cpp, most APIs are calling

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review102480 --- Patch looks great! Reviews applied: [37813] All tests passed. -

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

> On Oct. 13, 2015, 5:20 p.m., Michael Park wrote: > > All nits. > > > > ``` > > make check -j 4 GTEST_FILTER="" 1984.45s user 77.00s system 367% cpu > > 9:20.95 total > > make check -j 4 GTEST_FILTER="" 30.08s user 8.57s system 90% cpu 42.577 > > total > > ``` Oops. The `make check`

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102443 --- The documentation added in this patch is great! Also consider

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review102475 --- Ship it! All nits. ``` make check -j 4 GTEST_FILTER="" 1984.45s

Re: Review Request 39211: Check for trailing characters in JSON::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 13, 2015, 5:51 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39015/ --- (Updated Oct. 13, 2015, 7:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39017: RegistryClient refactor: encapsulated Manifest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Oct. 13, 2015, 7:16 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 13, 2015, 7:34 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39218: Windows: Added support for `process/address.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39218/#review102520 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2015, 11:35 a.m.,

Re: Review Request 39265: Windows: Move `os::environment` to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/#review102524 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092,

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39155/ --- (Updated Oct. 13, 2015, 7:17 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39112: RegistryClient refactor: fixed variable names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39112/ --- (Updated Oct. 13, 2015, 7:17 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39053/ --- (Updated Oct. 13, 2015, 7:16 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review102525 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2015, 11:36 a.m.,

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/#review102526 ---

Re: Review Request 39264: Windows:[3/3] Transitioned Mesos tests to use `os::raw` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39264/#review102529 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2015, 11:36 a.m.,

Re: Review Request 39263: Windows:[2/3] transitioned libprocess to use `os::raw::` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39263/#review102528 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2015, 11:36 a.m.,

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 13, 2015, 7:18 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 13, 2015, 7:18 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 13, 2015, 7:21 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102343 --- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 67)

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

> On Oct. 13, 2015, 7:38 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chsize.hpp, lines > > 24-25 > > > > > > This doc says that `ftruncate` needs an open fd too: > >

Re: Review Request 39068: RegistryClient refactor: Renamed fsLayerInfoList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39068/ --- (Updated Oct. 13, 2015, 7:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38941: Moved structs outside RegistryClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38941/ --- (Updated Oct. 13, 2015, 7:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39156/ --- (Updated Oct. 13, 2015, 7:18 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 13, 2015, 7:19 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Oct. 13, 2015, 7:19 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102512 --- Patch looks great! Reviews applied: [39211, 39018] All tests

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5 p.m., Michael Park wrote: > > src/common/resources.cpp, line 361 > > > > > > I think it would be better to only support one way of doing things > > here. I would opt for the array format. Is

Re: Review Request 39265: Windows: Move `os::environment` to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/#review102519 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2015, 11:37 a.m.,

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/#review102522 --- Ship it! src/slave/state.cpp (line 648)

Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39099/#review102501 --- Ship it! Ship It! - Michael Park On Oct. 13, 2015, 8 a.m.,

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/ --- (Updated Oct. 13, 2015, 6:28 p.m.) Review request for mesos, Artem

Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/ --- (Updated Oct. 13, 2015, 6:28 p.m.) Review request for mesos, Artem

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 3:35 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 114-118 > > > > > > Can this be removed or merged to the under comments? I put the comment here so that it wouldn't

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39204/ --- (Updated Oct. 13, 2015, 6:29 p.m.) Review request for mesos, Artem

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/ --- (Updated Oct. 13, 2015, 6:34 p.m.) Review request for mesos, Artem

Re: Review Request 39209: Windows: Move ::UUID to stout::UUID to avoid namespace collision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39209/ --- (Updated Oct. 13, 2015, 6:33 p.m.) Review request for mesos, Artem

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

> On Oct. 12, 2015, 2:13 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 41-42 > > > > > > Do you want to `#include ` too? > > Alex Clemmer wrote: > Interesting,

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

> On Oct. 12, 2015, 7:52 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 394 > > > > > > I have one question for this after second review: I see that in > > slave.cpp, most APIs are calling

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102473 --- Ship it! Ship It! - Guangya Liu On 十月 13, 2015, 1:39 a.m.,

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

> On Oct. 12, 2015, 2:29 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp, line 25 > > > > > > Don't you need to include `windows.hpp` to get `PATH_MAX` (on Windows, > > of

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102498 --- src/slave/containerizer/containerizer.cpp (line 256)

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/ --- (Updated Oct. 13, 2015, 6:31 p.m.) Review request for mesos, Artem

Re: Review Request 39207: Windows: Move `write` to its own file, `stout/os/write.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39207/ --- (Updated Oct. 13, 2015, 6:30 p.m.) Review request for mesos, Artem

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/ --- (Updated Oct. 13, 2015, 6:34 p.m.) Review request for mesos, Artem

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 13, 2015, 6:35 p.m.) Review request for mesos, Artem

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- (Updated Oct. 13, 2015, 6:35 p.m.) Review request for mesos, Artem

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review102495 --- Thanks for doing this! One minor issue about the use of the

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- (Updated Oct. 13, 2015, 6:26 p.m.) Review request for mesos, Artem

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/ --- (Updated Oct. 13, 2015, 6:26 p.m.) Review request for mesos, Artem

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39096/ --- (Updated Oct. 13, 2015, 6:26 p.m.) Review request for mesos, Artem

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/ --- (Updated Oct. 13, 2015, 6:25 p.m.) Review request for mesos, Artem

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- (Updated Oct. 13, 2015, 6:27 p.m.) Review request for mesos, Artem

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 13, 2015, 6:30 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39092: CMake:[2/3] prepared process library tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39092/ --- (Updated Oct. 13, 2015, 6:25 p.m.) Review request for mesos, Artem

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

> On Oct. 12, 2015, 9:13 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 41-42 > > > > > > Do you want to `#include ` too? Interesting, you must be seeing good reasons

Re: Review Request 39264: Windows:[3/3] Transitioned Mesos tests to use `os::raw` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39264/ --- (Updated Oct. 13, 2015, 6:36 p.m.) Review request for mesos, Artem

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

> On Oct. 13, 2015, 6:21 p.m., Niklas Nielsen wrote: > > src/slave/containerizer/containerizer.cpp, line 256 > > > > > > Shouldn't we only set this if it is not present? Since it gets set before the `foreach()`

Re: Review Request 39265: Windows: Move `os::environment` to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/ --- (Updated Oct. 13, 2015, 6:37 p.m.) Review request for mesos, Artem

Re: Review Request 39263: Windows:[2/3] transitioned libprocess to use `os::raw::` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39263/ --- (Updated Oct. 13, 2015, 6:36 p.m.) Review request for mesos, Artem

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5:38 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 367 > > > > > > Why not check error here? I'm sorry, I don't understand this comment. Are you referring to the error checking

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/ --- (Updated Oct. 13, 2015, 6:25 p.m.) Review request for mesos, Artem

Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39091/ --- (Updated Oct. 13, 2015, 6:25 p.m.) Review request for mesos, Artem

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5:38 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 367 > > > > > > Why not check error here? > > Greg Mann wrote: > I'm sorry, I don't understand this comment. Are you

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 13, 2015, 6:27 p.m.) Review request for mesos, Artem

  1   2   >