Review Request 39857: Master/Slave: Add a REASON for TASK_LOST with hard slave drain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39857/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2077 https://issues.ap

Re: Review Request 38214: PROTO: Add a REASON for TASK_LOST with hard slave drain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38214/ --- (Updated 十一月 3, 2015, 8:21 a.m.) Review request for mesos and Ben Mahler. Sum

Re: Review Request 39285: Added Quota Request Validation.

> On Nov. 2, 2015, 4:43 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 84 > > > > > > Mind adding a comment this is a "reference" role which is deduced from > > the resources in the request a

Re: Review Request 39886: Added documentation about roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104884 --- docs/roles.md (line 10)

Re: Review Request 39857: Master/Slave: Add a REASON for TASK_LOST with hard slave drain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39857/#review104886 --- Patch looks great! Reviews applied: [38214, 39857] All tests pass

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Nov. 3, 2015, 9:32 a.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 7, 2015, 1:03 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 879 > > > > > > The meos is now using 0.01 as the MIN_CPUS > > Guangya Liu wrote: > As the mesos is using 0.01 as the MIN_CPUS,

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review104895 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Re: Review Request 39886: Added documentation about roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104893 --- Great start. I agree with AlexR that the hierarchical DRF use of ro

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review104894 --- Great tests, thanks a lot Jörg! src/tests/master_quota_tests.cpp

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Oct. 25, 2015, 8:31 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 564 > > > > > > We should unify if use "role1" or role1 for all of the tests I vote for variables, since they were introdu

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 3, 2015, 1:31 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review104906 --- src/master/quota_handler.cpp (line 113)

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Oct. 23, 2015, 4:53 a.m., Jan Schlicht wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 800 > > > > > > Not yours, but please s/push_back/emplace_back > > Michael Park wrote: > I'm curious a

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Nov. 3, 2015, 9:38 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 3, 2015, 1:55 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources for

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/ --- (Updated Nov. 3, 2015, 3:46 p.m.) Review request for mesos, Bernd Mathiske, Joe

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 3, 2015, 3:47 p.m.) Review request for mesos, Bernd Mathiske, Joe

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/ --- (Updated Nov. 3, 2015, 3:46 p.m.) Review request for mesos, Bernd Mathiske, Joe

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

> On Nov. 3, 2015, 1:01 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/mark_mounts_rslave.hpp, line 36 > > > > > > I am thinking about making this more general and can be extended in > > case we need to (e.g.,

Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 6 p.m.) Review request for mesos and Michael Park. Bug

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Nov. 3, 2015, 6:06 p.m.) Review request for mesos and Joris Van Remoor

Review Request 39910: Fix build for RegistryClientTest.SimpleGetManifest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39910/ --- Review request for mesos, Ben Mahler and Artem Harutyunyan. Repository: mesos

Re: Review Request 39910: Fix build for RegistryClientTest.SimpleGetManifest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39910/#review104942 --- Ship it! Ship It! - Ben Mahler On Nov. 3, 2015, 6:09 p.m., Jose

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/#review104945 --- Can we merge the Tests from https://reviews.apache.org/r/39769/? -

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review104946 --- Ship it! Thanks! LGTM! src/log/consensus.cpp (line 46)

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104950 --- Patch looks great! Reviews applied: [39908] All tests passed. -

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Nov. 3, 2015, 7:13 p.m.) Review request for mesos, Jie Yu, Joris Van R

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104953 --- docs/upgrades.md (line 16)

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104955 --- Ship it! Modulo Neil's comment. - Michael Park On Nov. 3, 2015,

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > > > > > AFAIK this isn't Java-specific. This will mostly impact Java frameworks since they'll have to not only update the generated

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > > > > > AFAIK this isn't Java-specific. > > Isabel Jimenez wrote: > This will mostly impact Java frameworks since they'll have to

Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/ --- Review request for mesos, Ben Mahler and Cody Maloney. Repository: mesos Desc

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review104960 --- Are openssl and libevent present on the reviewbot machine? (And d

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > > > > > AFAIK this isn't Java-specific. > > Isabel Jimenez wrote: > This will mostly impact Java frameworks since they'll have to

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Oct. 22, 2015, 8:53 p.m., Jan Schlicht wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 800 > > > > > > Not yours, but please s/push_back/emplace_back > > Michael Park wrote: > I'm curious a

Re: Review Request 39886: Added documentation about roles.

> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote: > > docs/roles.md, line 12 > > > > > > Do you want to be consistent with the existing codebase and continue > > use "slave" for now? We already use "agent" in

Re: Review Request 39886: Added documentation about roles.

> On Nov. 3, 2015, 2:40 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 49 > > > > > > MESOS-3177 is planning to enable adding role dynamically, we may need > > to add a TODO here to reflect this. My

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 7:52 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39886: Added documentation about roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/ --- (Updated Nov. 3, 2015, 7:51 p.m.) Review request for mesos and Adam B. Change

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review104963 --- Ship it! Ship It! - Kapil Arya On Oct. 23, 2015, 3:21 p.m., Con

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review104962 --- src/common/http.cpp

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review104964 --- Ship it! Please rebase and address the comment below and I can get

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review104965 --- docs/networking-for-mesos-managed-containers.md (lines 276 - 278)

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104967 --- docs/upgrades.md (line 16)

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review104966 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

> On Nov. 3, 2015, 7:46 p.m., Joseph Wu wrote: > > Are openssl and libevent present on the reviewbot machine? > > (And does reviewbot use the modified version of `verify_reviews.py` when > > checking this one?) Not sure. I would think that the installation of dependencies exists outside the

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review104969 --- would this only test libevent and skip libev? if yes, we can't do t

Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39843/#review104971 --- Ship it! Ship It! - Vinod Kone On Nov. 2, 2015, 9:42 a.m., Guan

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote: > > would this only test libevent and skip libev? if yes, we can't do this. Would it help to add libev also? I was trying to make this look like the jenkins mesos builds. Console logs there show : ``` echo CMD ./bootstrap '&&' ./configure --verbos

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote: > > configure.ac, lines 612-621 > > > > > > If it's not too much trouble, it would be great to see this logic added > > also the `cmake/CompilationCOnfigure.cmake`.

Re: Review Request 39886: Added documentation about roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104977 --- Patch looks great! Reviews applied: [39886] All tests passed. -

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 16 > > > > > > this should also be mentioned in the CHANGELOG. The CHANGELOG will be created by the release managers for 0.26.0 (Bernd and T

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 18, 2015, 12:41 a.m., Michael Park wrote: > > src/common/resources.cpp, line 377 > > > > > > I think you need to check for `resource.role() == "*"` instead, since > > `role` has `[default = "*"]`. Please

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 18, 2015, 6:18 p.m., Michael Park wrote: > > src/common/resources.cpp, lines 482-532 > > > > > > How about a structure like the following? > > > > ```cpp > > Resources result; > > > >

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review104982 --- src/common/resources.cpp (lines 457 - 458)

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 16 > > > > > > this should also be mentioned in the CHANGELOG. > > Michael Park wrote: > The CHANGELOG will be created by the release man

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review104985 --- Ship it! Ship It! - Michael Park On Oct. 20, 2015, 6:09 a.m., G

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review104983 --- Ship it! docs/c++-style-guide.md (line 235)

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review104986 --- docs/c++-style-guide.md (line 262)

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 16 > > > > > > this should also be mentioned in the CHANGELOG. > > Michael Park wrote: > The CHANGELOG will be created by the release man

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review104989 --- Patch looks great! Reviews applied: [39914] All tests passed. -

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 10:23 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote: > > would this only test libevent and skip libev? if yes, we can't do this. > > Jojy Varghese wrote: > Would it help to add libev also? I was trying to make this look like the > jenkins mesos builds. Console logs there show : > ``` echo CM

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 10:30 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote: > > would this only test libevent and skip libev? if yes, we can't do this. > > Jojy Varghese wrote: > Would it help to add libev also? I was trying to make this look like the > jenkins mesos builds. Console logs there show : > ``` echo CM

Re: Review Request 39770: Write a newline in ABORT().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39770/#review104993 --- 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp (line 5

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review104994 --- 3rdparty/libprocess/src/subprocess.cpp (lines 179 - 180)

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Nov. 3, 2015, 10:52 p.m.) Review request for mesos, Bernd Mathiske, Be

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote: > > would this only test libevent and skip libev? if yes, we can't do this. > > Jojy Varghese wrote: > Would it help to add libev also? I was trying to make this look like the > jenkins mesos builds. Console logs there show : > ``` echo CM

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/ --- (Updated Nov. 3, 2015, 10:53 p.m.) Review request for mesos, Bernd Mathiske, Be

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Nov. 3, 2015, 10:55 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Nov. 2, 2015, 7:13 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, lines 1045-1076 > > > > > > Can we please move this to its own tests file so that we can run it on > > Wi

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 8, 2015, 9:07 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp, line 54 > > > > > > We have to support CentOS 5 which has glibc 2.5 FWICT. > > Benjamin Bannier wr

Review Request 39922: Add CHANGLOG for 0.26.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39922/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3824 https://issues.ap

Re: Review Request 39922: Update CHANGELOG for 0.26.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39922/ --- (Updated 十一月 3, 2015, 11:18 p.m.) Review request for mesos and Vinod Kone. Su

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105000 --- Patch looks great! Reviews applied: [39908] All tests passed. -

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105002 --- CHANGELOG (line 1)

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > > > > > s/Version 0.26.0/Version 0.26.0(WIP) This are the release notes, so they apply only for releases. No need to specify WIP - Isabel

Re: Review Request 39908: Added a section to Upgrades doc

> On 十一月 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > > > > > s/Version 0.26.0/Version 0.26.0(WIP) > > Isabel Jimenez wrote: > This are the release notes, so they apply only for releases. No n

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 4 > > > > > > Why not put this to `Bug` catalog? As this is an API breaking change we prefered to refer to it under 'API changes' even if the JIRA

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > > > > > s/Version 0.26.0/Version 0.26.0(WIP) > > Isabel Jimenez wrote: > This are the release notes, so they apply only for releases. No

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 11:41 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105009 --- docs/upgrades.md (line 16)

Re: Review Request 39922: Update CHANGELOG for 0.26.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39922/#review105010 --- Ship it! CHANGELOG (line 5)

Re: Review Request 39922: Updated CHANGELOG for 0.26.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39922/ --- (Updated 十一月 3, 2015, 11:51 p.m.) Review request for mesos and Vinod Kone. Su

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 11:51 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105011 --- CHANGELOG (lines 1 - 8)

Re: Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39841/#review105012 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2015, 1:36 a.m., Artem Ha

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 4, 2015, 12:14 a.m.) Review request for mesos and Michael Park.

Review Request 39923: Cleaned up configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.

Re: Review Request 39908: Added a section to Upgrades doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105014 --- Ship it! Ship It! - Guangya Liu On 十一月 4, 2015, 12:14 a.m., Isa

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

> On Nov. 3, 2015, 10:45 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 179-180 > > > > > > Technically we should not be appending strings like this since malloc > > is not async-signal-sa

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/ --- (Updated Nov. 4, 2015, 12:21 a.m.) Review request for mesos. Bugs: MESOS-3708

Re: Review Request 39770: Write a newline in ABORT().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39770/ --- (Updated Nov. 4, 2015, 12:25 a.m.) Review request for mesos. Bugs: MESOS-3708

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/ --- (Updated Nov. 4, 2015, 12:24 a.m.) Review request for mesos. Bugs: MESOS-3708

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/#review105017 --- Patch looks great! Reviews applied: [39005, 39006, 39007] All tes

Re: Review Request 39923: Cleaned up configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review105018 --- docs/configuration.md

  1   2   >