Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-25 Thread Till Toenshoff
> On Nov. 25, 2015, 11:57 a.m., Bernd Mathiske wrote: > > src/local/local.cpp, line 373 > > > > > > !isSome() -> isNone() Will fix while committing. - Till

Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-25 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40681/ --- (Updated Nov. 25, 2015, 4:01 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40697/#review108024 --- Bad patch! Reviews applied: [40431] Failed command:

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-25 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 25, 2015, 4:09 p.m.) Review request for mesos, Alexander

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/#review108010 --- Ship it! src/Makefile.am (line 1740)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-25 Thread Joris Van Remoortere
> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review107995 --- 1. General fly by style comments. 2. Have we thought about moving

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review108004 --- src/tests/master_quota_tests.cpp

Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40681/#review108021 --- Ship it! Will fix the issue Bernd noted and commit. - Till

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review108022 --- Patch looks great! Reviews applied: [40339, 40524, 40529, 40532,

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-11-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Nov. 25, 2015, 3:45 p.m.) Review request for mesos and Niklas

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review108006 --- Please adjust the JIRA ticket: MESOS-3983 - Alexander Rukletsov

Re: Review Request 40580: Added remove quota test.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40580/#review108009 --- Please adjust the JIRA ticket: MESOS-4014. - Alexander Rukletsov

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review108011 --- Please adjust the JIRA ticket: MESOS-4014. - Alexander Rukletsov

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review108007 --- Please adjust the JIRA ticket: MESOS-4013. - Alexander Rukletsov

Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review108008 --- Please adjust the JIRA ticket: MESOS-4013. - Alexander Rukletsov

Re: Review Request 40586: Corrected typos and formatting issues.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40586/#review108026 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 23, 2015,

Review Request 40710: Updated release-guide to include CMake specifics.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40710/ --- Review request for mesos and Alex Clemmer. Repository: mesos Description

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review108074 --- Ship it! Added ``` EXPECT_CALL(sched2, resourceOffers(, _))

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-25 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review108079 --- I'm thinking we are going to build a RoleManager as I comments in

Re: Review Request 40630: Upgrade pip to 7.1.2

2015-11-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40630/#review107852 --- Ship it! Verified `make distcheck` on Centos7, Ubunut 14, and

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review108075 --- Ship it! Resolved outstanding issues. - Joris Van Remoortere

Re: Review Request 40721: Cleaned up a test case.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40721/#review108073 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Michael Park
> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/master/http.cpp, lines 541-551 > > > > > > As far as its implementation, let's do: > > > > ```cpp > > static Resources removeDisks(Resources

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review108086 --- src/master/quota_handler.cpp (lines 372 - 386)

Re: Review Request 40710: Updated release-guide to include CMake specifics.

2015-11-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40710/#review108052 --- Ship it! Ship It! - Alex Clemmer On Nov. 25, 2015, 5:29 p.m.,

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108032 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

2015-11-25 Thread Joseph Wu
> On Nov. 25, 2015, 2:30 a.m., Alexander Rojas wrote: > > Overall, it looks good to me. But does the finalizes are called at all in > > this patch (Probablly just when the system process go down). As of this patch, `process::finalize` is only called once at the end of the libprocess tests

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review108038 --- src/master/quota_handler.cpp (lines 211 - 212)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-25 Thread Joris Van Remoortere
> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 180-181 > > > > > > "Offers that do > > // not contribute to satisfying quota request will be rescinded > >

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review108045 --- Patch looks great! Reviews applied: [40631] Passed command:

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Neil Conway
> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 159-162 > > > > > > I would suggest that we reorder these since we expect `registered` to > > occur

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 25, 2015, 10:21 p.m.) Review request for mesos, Greg Mann and

Review Request 40721: Cleaned up a test case.

2015-11-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40721/ --- Review request for mesos. Repository: mesos Description --- Make the

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review108069 --- Ship it! Minor nits, and addressed comments before committing. -

Re: Review Request 40580: Added remove quota test.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40580/#review108070 --- Ship it! Added some negative tests.

Re: Review Request 40679: Added filtering of CFS cgroup tests.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/#review108056 --- Patch looks great! Reviews applied: [40679] Passed command:

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Neil Conway
> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/master/http.cpp, lines 541-551 > > > > > > As far as its implementation, let's do: > > > > ```cpp > > static Resources removeDisks(Resources

Re: Review Request 40706: Clarified a comment for `Accept` call.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40706/#review108060 --- Patch looks great! Reviews applied: [40706] Passed command:

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review108059 --- Ship it! src/master/quota_handler.cpp (line 302)

Re: Review Request 40580: Added remove quota test.

2015-11-25 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40580/ --- (Updated Nov. 25, 2015, 9:38 p.m.) Review request for mesos, Alexander

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/ --- (Updated Nov. 25, 2015, 9:26 p.m.) Review request for mesos, Alexander

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Joris Van Remoortere
> On Nov. 23, 2015, 8:43 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 387 > > > > > > I think we need to check if the role is known by master just like what > > we did for set quota, and also need

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

2015-11-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/#review108046 --- Ship it! * Solves observed flakiness (Check!) * Test runs 10+

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review107998 --- docs/getting-started.md (line 63)

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/ --- (Updated Nov. 25, 2015, 3:11 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review108002 --- Ship it! Ship It! - Till Toenshoff On Nov. 25, 2015, 3:11

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-25 Thread Qian Zhang
> On Nov. 18, 2015, 3:51 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Review Request 40732: Enabling ResourcesTest.Precision

2015-11-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/ --- Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. Bugs:

Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

2015-11-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/ --- Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. Bugs:

Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-11-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. Bugs:

Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40681/#review107960 --- Patch looks great! Reviews applied: [40681] Passed command:

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/#review107953 --- Bad patch! Reviews applied: [40114, 40115] Failed command:

Re: Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

2015-11-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review107959 --- Overall, it looks good to me. But does the finalizes are called at

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-25 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 25, 2015, 8:38 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-25 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 25, 2015, 8:38 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 25, 2015, 8:55 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 40652: [stout] Made license-headers doxygen compatible.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40652/ --- (Updated Nov. 25, 2015, 9:05 a.m.) Review request for mesos and Till

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 25, 2015, 9:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 25, 2015, 9:59 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40641/#review107956 --- Ship it! src/tests/containerizer/filesystem_isolator_tests.cpp

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review107957 --- LGMT! - Till Toenshoff On Nov. 25, 2015, 9:59 a.m., Benjamin

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-25 Thread Benjamin Bannier
> On Nov. 24, 2015, 9:42 a.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107962 --- Ship it! Ship It! - Benjamin Bannier On Nov. 25, 2015, 1:54

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-25 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 25, 2015, 8:20 a.m.) Review request for mesos, Adam B, Guangya

Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40697/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40697/ --- (Updated Nov. 25, 2015, 8:30 a.m.) Review request for mesos and Adam B.

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/#review107944 --- Patch looks great! Reviews applied: [40672] Passed command:

Re: Review Request 40187: Fixed and formatted JSON examples.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review107947 --- Ship it! Ship It! - Till Toenshoff On Nov. 17, 2015, 10:41

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-25 Thread Yong Qiao Wang
> On Nov. 25, 2015, 2:48 a.m., Klaus Ma wrote: > > include/mesos/role/role.proto, line 38 > > > > > > I'm thinke whether we need to enhance weight to `int`. Any case that we > > has to use `double` as weight? If we

Re: Review Request 40700: Fixed a wrong comparison.

2015-11-25 Thread Jan Schlicht
> On Nov. 25, 2015, 11:53 a.m., Benjamin Bannier wrote: > > The commit should probably be called *Used matching types in comparison*. Yes, makes sense. - Jan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 40700: Fixed a wrong comparison.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40700/#review107966 --- Ship it! The commit should probably be called *Used matching

Review Request 40702: Clarified the comment about role/quota relation.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40702/ --- Review request for mesos, Bernd Mathiske and Joris Van Remoortere. Repository:

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40551/ --- (Updated Nov. 25, 2015, 11:39 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review107974 --- docs/getting-started.md (line 63)

Review Request 40700: Fixed a wrong comparison.

2015-11-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40700/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Bugs:

Re: Review Request 40667: Fixed flakiness in reservation endpoint tests

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40667/#review107970 --- Patch looks great! Reviews applied: [40667] Passed command:

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review107971 --- Ship it! Ship It! - Jan Schlicht On Nov. 24, 2015, 3:50 p.m.,

Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40681/#review107973 --- Ship it! src/local/local.cpp (line 373)

Re: Review Request 40700: Fixed signed vs. unsigned comparison in a test.

2015-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40700/#review107972 --- Ship it! Ship It! - Till Toenshoff On Nov. 25, 2015, 11:29

Re: Review Request 40700: Fixed signed vs. unsigned comparison in a test.

2015-11-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40700/ --- (Updated Nov. 25, 2015, 11:29 a.m.) Review request for mesos, Benjamin

Re: Review Request 40702: Clarified the comment about role/quota relation.

2015-11-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40702/#review107986 --- Ship it! Ship It! - Bernd Mathiske On Nov. 25, 2015, 3:36

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107982 --- Patch looks great! Reviews applied: [39320] Passed command:

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review107984 --- Ship it! Ship It! - Bernd Mathiske On Nov. 25, 2015, 5:26

Re: Review Request 40702: Clarified the comment about role/quota relation.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40702/ --- (Updated Nov. 25, 2015, 5:41 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit editors from hanging.

2015-11-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40241/#review107981 --- Ship it! Thanks for fixing this, I committed it without

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/ --- (Updated Nov. 25, 2015, 1:26 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review107983 --- Ship it! There are also other files need to be updated, but I

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-25 Thread Benjamin Bannier
> On Nov. 25, 2015, 12:17 p.m., Bernd Mathiske wrote: > > docs/getting-started.md, line 63 > > > > > > Depending on what grub version you are using, you need this instead: > > > > sudo sed -i

Review Request 40706: Clarified a comment for `Accept` call.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40706/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 40553: Enable mesos tests installation

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review107988 --- configure.ac (line 245)

Re: Review Request 40679: Added filtering of CFS cgroup tests.

2015-11-25 Thread Greg Mann
> On Nov. 25, 2015, 7:06 a.m., Timothy Chen wrote: > > src/tests/environment.cpp, line 147 > > > > > > Cfs should be CFS_ right? Currently, the tests are not prefixed with `CFS_` the way the CGROUP, etc. tests

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40690/#review107992 --- Patch looks great! Reviews applied: [40654, 40690] Passed