Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 8, 2015, 8:29 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41076: Added tests for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/ --- (Updated Dec. 8, 2015, 8:28 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40995: Added test cases for role behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- (Updated Dec. 8, 2015, 8:28 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > include/mesos/master/allocator.hpp, line 101 > > > > > > When allocator initialize, their should be no active frameworks in > > mesos, can we consider to

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 7, 2015, 11:02 p.m., Yong Qiao Wang wrote: > > > > Yong Qiao Wang wrote: > I have talked with our shepherd Adam B yesterday, and we all agree to > improve /roles endpoint to update/remove/list active roles, and Implicit > Roles will focus on removing the static role

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 8, 2015, 8:33 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40469: Update Allocator interface to support dynamic roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109297 --- Patch looks great! Reviews applied: [40431, 40469] Passed

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 8, 2015, 11:24 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 8, 2015, 11:24 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109305 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 1408)

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109308 --- src/master/allocator/mesos/hierarchical.cpp (line 301)

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > > > Yong Qiao Wang wrote: > I have talked with our shepherd Adam B yesterday, and we all agree to > improve /roles endpoint to update/remove/list active roles, and Implicit > Roles will focus on removing the static role

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 3:02 p.m., Yong Qiao Wang wrote: > > include/mesos/master/allocator.hpp, line 101 > > > > > > When allocator initialize, their should be no active frameworks in > > mesos, can we consider to

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 8, 2015, 11:23 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

> On Dec. 7, 2015, 11:51 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, lines 3218-3220 > > > > > > If this is an internal invariant, how about adding a `CHECK` here? How would the

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 8, 2015, 11:16 a.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 41077: Fixed the license header in src/linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41077/#review109310 --- Ship it! Ship It! - Benjamin Bannier On Dec. 8, 2015, 6:26

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/ --- (Updated Dec. 8, 2015, 1:24 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 40995: Added test cases for role behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109324 --- One thing we also agreed is to disallow empty string roles. Do you

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109321 --- src/master/allocator/mesos/hierarchical.hpp (line 367)

Re: Review Request 40995: Added test cases for role behavior.

> On Dec. 8, 2015, 12:51 a.m., Guangya Liu wrote: > > src/tests/role_tests.cpp, lines 24-27 > > > > > > I think that we should always use std first? > > > > using std::vector; > > > > using

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 8, 2015, 3:38 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109318 --- src/master/constants.cpp (line 49)

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41078/#review109306 --- Patch looks great! Reviews applied: [40872, 40873, 41078] Passed

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Dec. 8, 2015, 3:07 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 475-478 > > > > > > I'm slightly confused. Now we have two different authenticators: one > > for frameworks and one for

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > include/mesos/master/allocator.hpp, line 101 > > > > > > When allocator initialize, their should be no active frameworks in > > mesos, can we consider to

Re: Review Request 40999: Fixed flakiness in ReservationTest.ACLMultipleOperations.

> On Dec. 5, 2015, 12:54 a.m., Joseph Wu wrote: > > src/tests/reservation_tests.cpp, lines 1663-1664 > > > > > > You can be more explicit in your expectations (about batch allocations) > > by using

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/#review109343 --- Patch looks great! Reviews applied: [40617, 41042] Passed

Review Request 41090: Second iteration of changes for cmake build on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 41076: Added tests for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/#review109335 --- Patch looks great! Reviews applied: [40995, 41075, 41076] Passed

Re: Review Request 40999: Fixed flakiness in ReservationTest.ACLMultipleOperations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40999/ --- (Updated Dec. 8, 2015, 4:57 p.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 8, 2015, 4:53 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Dec. 8, 2015, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 2276-2282 > > > > > > Looks like the scope of the `Credential` protobuf is reduced. It looks > > like now it's only used to

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 8, 2015, 3:59 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109326 --- src/master/allocator/mesos/hierarchical.hpp (line 367)

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/ --- (Updated Dec. 8, 2015, 5:14 p.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, noon, Yong Qiao Wang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 320 > > > > > > In the current implementation, quota(quotaSorter) does not been removed > > after the

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109347 --- Would it be a good idea to split this review into smaller bits for

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 8, 2015, 5:52 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 41092: Added CMake file for agent executable build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109358 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40167/ --- (Updated Dec. 8, 2015, 5:51 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109354 --- Initial review. I haven't applied/tested this patche yet. --- I'd

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109360 --- src/slave/cmake/FindCurl.cmake (line 111)

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 3:20 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 407 > > > > > > s/iff/if/ "iff" is what was intended

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 5:26 p.m., Anand Mazumdar wrote: > > Would it be a good idea to split this review into smaller bits for ease of > > reviewing ? It would make it easier to commit the individual sub system > > component changes. > > > > One possible split can be: > > > > 1. Removal of

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40168/ --- (Updated Dec. 8, 2015, 6:07 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Dec. 8, 2015, 6:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Dec. 8, 2015, 7:03 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40256/ --- (Updated Dec. 8, 2015, 7:24 p.m.) Review request for mesos, Jie Yu, Michael

Review Request 41098: Fixed punctuation usage in some error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41098/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/#review109372 --- Patch looks great! Reviews applied: [40999, 41001] Passed

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40169/ --- (Updated Dec. 8, 2015, 6:44 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 41076: Added tests for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/ --- (Updated Dec. 8, 2015, 7:18 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 4:45 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 367 > > > > > > s/Frameworks/Roles? Thanks, fixed. > On Dec. 8, 2015, 4:45 p.m., Alexander Rukletsov

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Dec. 8, 2015, 6:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40995: Added test cases for role behavior.

> On Dec. 8, 2015, 2:55 p.m., Alexander Rukletsov wrote: > > One thing we also agreed is to disallow empty string roles. Do you think it > > makes sense to extend this patch with a test for that or do it separately? I think we should do this separately, perhaps as part of fixing MESOS-2210.

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 8, 2015, 7:18 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40995: Added test cases for role behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- (Updated Dec. 8, 2015, 7:18 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/ --- (Updated Dec. 8, 2015, 7:31 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

> On Dec. 2, 2015, 5:19 p.m., Alexander Rukletsov wrote: > > Do you think it makes sense to update "src/master/flags.cpp" as well? I assume you're referring to the help string for the `--acls` flag? I think we could skip adding to that, since it already includes examples for three different

Re: Review Request 41098: Fixed punctuation usage in some error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41098/#review109381 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2015, 7:29 p.m., Neil

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Dec. 8, 2015, 8:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41100: Fixed a broken test: HealthTest.ObserveEndpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41100/#review109388 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2015, 8:55 p.m., Neil

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

> On Nov. 30, 2015, 8:51 a.m., Benjamin Bannier wrote: > > src/tests/module_tests.cpp, line 123 > > > > > > None of these functions need to be (mutating!) member functions if you > > simply inject

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109243 --- This is starting to shape up, thanks Alexander. As we discussed

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40326/#review109385 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015,

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

> On Nov. 30, 2015, 8:51 a.m., Benjamin Bannier wrote: > > src/tests/oversubscription_tests.cpp, line 117 > > > > > > This isn't really too nice, and e.g. cmake does not put build libraries > > into these paths

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Dec. 8, 2015, 9 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Dec. 8, 2015, 9:01 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41092: Added CMake file for agent executable build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review109377 --- Bad patch! Reviews applied: [40951, 41090] Failed command:

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 4:45 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1543-1545 > > > > > > Why don't we consider roles without frameworks but with a non-default > > weight active? Or roles with

Re: Review Request 41097: Fixed hyphen usage in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41097/#review109379 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2015, 7:29 p.m., Neil

Re: Review Request 40327: mesos: Marked Boost as a "system" header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40327/#review109386 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015,

Re: Review Request 39597: Add Newbie guide.

> On Nov. 2, 2015, 8:59 p.m., Neil Conway wrote: > > docs/NewbieQuickStart.md, line 86 > > > > > > Links to other docs pages should take the form "(anchor-text)[foo.md]", > > rather than using the full URL. > >

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109405 --- Second part of my earlier review, this time I went throug the test

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 8, 2015, 11:53 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41114: Showed disk resources in the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41114/#review109470 --- Patch looks great! Reviews applied: [41114] Passed command:

Re: Review Request 39597: Add Newbie guide.

> On Nov. 6, 2015, 5:18 p.m., Vaibhav Khanduja wrote: > > docs/NewbieQuickStart.md, line 108 > > > > > > I am a "newbie" so was referring to your wip guide. I tried to run this > > command, but looks like it did

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 8, 2015, 11:55 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

> On Dec. 2, 2015, 6:32 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > > > > > More customary indentation: > > > > EXPECT_CALL(sched, resourceOffers(, _)) > >

Re: Review Request 39597: Add Newbie guide.

> On Oct. 23, 2015, 4:07 p.m., James Peach wrote: > > I'm pretty sure that Mesos only builds with the bundled GLog and GTest. At > > least I've always been unsuccessful in building against unbundled versions > > of those components. Hi James, do you think we should change some content based

Re: Review Request 39597: Add Newbie guide.

> On Oct. 23, 2015, 4:07 p.m., James Peach wrote: > > I'm pretty sure that Mesos only builds with the bundled GLog and GTest. At > > least I've always been unsuccessful in building against unbundled versions > > of those components. > > Diana Arroyo wrote: > Hi James, do you think we

Re: Review Request 39597: Add Newbie guide.

> On Nov. 2, 2015, 7:01 p.m., Timothy Chen wrote: > > Thanks for doing this Diana! Sorry for the delay, we need to figure out a > > place to put this on the website as well. You have suggestions? How about in this page: http://mesos.apache.org/community/ under the title: "Contribute a core

Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 39597: Add Newbie guide.

> On Nov. 21, 2015, 1:05 a.m., Timothy Chen wrote: > > Diana are you still able to finish the comments? > > Diana Arroyo wrote: > Hey Tim, Yes, I'll finish them up. Done. I only have to outstanding items from Neil I didn't fix but provided a comment instead. Do we wait for Neil to agree

Review Request 41114: Showed disk resources in the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41114/ --- Review request for mesos, Ben Mahler and Michael Park. Bugs: MESOS-4103

Re: Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/#review109432 --- Ship it! Looks good overall. Thanks Tim!

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

> On Nov. 23, 2015, 4:08 p.m., haosdent huang wrote: > > src/master/http.cpp, line 331 > > > > > > Seems miss credentials, whitelist These two flags returns as Path instead of protobuf. - Jian

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/ --- (Updated Dec. 9, 2015, 2:20 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37541: Add trace event API

> On Nov. 24, 2015, 12:53 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, lines 108-110 > > > > > > why are these public? Easy to access, instead of adding a get/set for each of them. > On Nov. 24, 2015, 12:53

Re: Review Request 39597: Add Newbie guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/ --- (Updated Dec. 8, 2015, 11:40 p.m.) Review request for mesos, Timothy Chen and

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109446 --- Ship it! Ship It! - Joseph Wu On Dec. 8, 2015, 7:59 a.m.,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 3:45 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 9, 2015, 3:45 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39597: Add Newbie guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review109454 --- Patch looks great! Reviews applied: [39597] Passed command:

Re: Review Request 40999: Fixed flakiness in ReservationTest.ACLMultipleOperations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40999/#review109457 --- Ship it! Ship It! - Michael Park On Dec. 8, 2015, 4:57 p.m.,

Re: Review Request 40995: Added test cases for role behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- (Updated Dec. 9, 2015, 5:53 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review109444 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,

Re: Review Request 41092: Added CMake file for agent executable build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review109357 --- Initial review. I haven't run this code yet. --- What do you

  1   2   >