Re: Review Request 38117: Export per container SNMP statistics

2015-12-14 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Dec. 15, 2015, 12:05 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 41253: Changed ownership semantics of ssl connect socket.

2015-12-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41253/#review110345 --- Bad patch! Reviews applied: [41252] Failed command:

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110340 --- docs/containerizer-internals.md (lines 6 - 10)

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- Another two comments here: 1) It is recommended to use past tense

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110358 --- include/mesos/v1/mesos.proto (line 1567)

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Dec. 15, 2015, 1:09 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41244: Using 'git rev-parse --git-dir' in post-reviews.py.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41244/ --- (Updated Dec. 15, 2015, 1:10 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40946/ --- (Updated Dec. 15, 2015, 1:27 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 41384: Added tests for HDFS client.

2015-12-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41384/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 41075: Added support for implicit roles.

2015-12-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110381 --- src/master/http.cpp (line 1556)

Re: Review Request 41166: Logger Module: Explicitly disallow use of the ContainerLogger with the External Containerizer.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41166/ --- (Updated Dec. 14, 2015, 3:47 p.m.) Review request for mesos, Benjamin Hindman

Review Request 41372: Add update for systemd in centos Getting Started

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/ --- Review request for mesos, Benjamin Hindman and Neil Conway. Bugs: MESOS-3954

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-12-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39851/#review110346 --- 3rdparty/libprocess/include/process/owned.hpp (lines 122 - 127)

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 15-23 > > > > > > What about moveing this after ### Type of containerizers Since this section is common to all

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110351 --- The description needs a little update as following: s/why they

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41364: Added NOTE to Examples in Getting Started on prod.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/ --- (Updated Dec. 15, 2015, 1:04 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41225: Added test cases for implicit roles.

2015-12-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/#review110359 --- Patch looks great! Reviews applied: [40995, 41075, 41225] Passed

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41280: Fixed header include order.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41280/#review110364 --- Ship it! Ship It! - Joseph Wu On Dec. 11, 2015, 3:51 p.m.,

Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41386/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Re: Review Request 41075: Added support for implicit roles.

2015-12-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110374 --- src/master/http.cpp (line 316)

Re: Review Request 41384: Added tests for HDFS client.

2015-12-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41384/#review110373 --- Ship it! I like this approach a lot. Maybe some more comments

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-14 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 14, 2015, 11:34 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-14 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/ --- (Updated Dec. 14, 2015, 11:34 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/ --- (Updated Dec. 15, 2015, 12:44 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 40941: Added a helper for HDFS client to shell out commands.

2015-12-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40941/ --- (Updated Dec. 15, 2015, 1:26 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-14 Thread Jie Yu
> On Dec. 4, 2015, 10:51 a.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.cpp, line 143 > > > > > > Maybe we can get some extra info about what subprocess failed to be > > reaped by capturing some values from above in

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-12-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40062/#review110366 --- Ship it! Ship It! - Adam B On Nov. 9, 2015, 9:16 p.m., Vaibhav

Re: Review Request 40829: Improved authorization documentation.

2015-12-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40829/#review110367 --- Ship it! Ship It! - Adam B On Dec. 1, 2015, 11:10 a.m., Neil

Re: Review Request 41280: Fixed header include order.

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41280/#review110369 --- Ship it! Ship It! - Guangya Liu On 十二月 11, 2015, 11:51 p.m.,

Re: Review Request 41075: Added support for implicit roles.

2015-12-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110371 --- src/master/http.cpp (line 1578)

Re: Review Request 41282: Added the interface for the V1 Executor HTTP Library.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41282/#review110370 --- include/mesos/v1/executor.hpp (lines 63 - 64)

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 10:47 p.m., Guangya Liu wrote: > > src/master/master.cpp, lines 2829-2845 > > > > > > How does this can resove overcommit issue? I think that the issue is > > still there? Another is that can

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-12-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/#review110382 --- Thanks for the detailed analysis of the issues! (1) My preference

Re: Review Request 41278: Add note to site-docker doc about tunneling

2015-12-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/#review110338 --- Patch looks great! Reviews applied: [41278] Passed command:

Review Request 41371: Fix getting started instructions for centos 7.1

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41371/ --- Review request for mesos, Benjamin Hindman and Neil Conway. Bugs: MESOS-3842

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Guangya Liu
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 21-23 > > > > > > Just a kind reminder, https://issues.apache.org/jira/browse/MESOS-1718 > > is planning to move get

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41371/ --- (Updated Dec. 15, 2015, 1:06 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41278: Added note to site-docker doc about tunneling.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/ --- (Updated Dec. 15, 2015, 1:06 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/ --- (Updated Dec. 15, 2015, 1:05 a.m.) Review request for mesos, Benjamin Hindman

Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41383/ --- Review request for mesos, Bernd Mathiske and Neil Conway. Bugs: MESOS-3305

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ --- (Updated Dec. 14, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 14, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

2015-12-14 Thread Joseph Wu
> On Dec. 12, 2015, 10:49 p.m., James DeFelice wrote: > > include/mesos/slave/container_logger.hpp, line 157 > > > > > > It may be useful here to include the executor labels here so that, for > > example,

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 14, 2015, 3:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/#review110363 --- include/mesos/executor/executor.proto (line 89)

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 9:53 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 511 > > > > > > Seems the executor_rootfs is not a slave configuraiton? I can only set > > launcher_dir, sandbox_dir and

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 14, 2015, 3:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-14 Thread Joseph Wu
> On Dec. 14, 2015, 1:21 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 227-245 > > > > > > I am wondering why logger has to be injected, instead of being owned by > > containerizer? Let containerizer owning the

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review110325 --- Ship it! Let's use snake_case in stout.

Re: Review Request 41168: Logger Module: Add ContainerLogger support to the MesosTest helpers

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41168/ --- (Updated Dec. 14, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41363: Reworded NOTE in Examples for Getting Started doc.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41363/ --- (Updated Dec. 15, 2015, 1:06 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41362: Added note in docs for installing wget, tar, git.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41362/ --- (Updated Dec. 15, 2015, 1:07 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41361/ --- (Updated Dec. 15, 2015, 1:07 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41360/ --- (Updated Dec. 15, 2015, 1:08 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41359: Forced horizontal scroll in docs code blocks.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41359/ --- (Updated Dec. 15, 2015, 1:08 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41286: Updated Getting Started for Mac OS X El Capitan.

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41286/ --- (Updated Dec. 15, 2015, 1:09 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/ --- (Updated Dec. 14, 2015, 6:14 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Review Request 41370: Logger Module: Update DockerContainerizer test helpers

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Re: Review Request 35711: Disallow special characters in role name.

2015-12-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review110341 --- Looking good! Minor nit below. src/tests/roles_tests.cpp (line

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. Even if it goes over the 70 characters for the git summary? Or should I reword to stay

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 3:05 p.m., Qian Zhang wrote: > > src/master/validation.cpp, line 331 > > > > > > So now we allow a task has both ExecutorInfo and CommandInfo, right? If > > so, then you may need to update the

Re: Review Request 41345: [WIP] MESOS-3892: Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.

2015-12-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41345/ --- (Updated Dec. 14, 2015, 8:12 p.m.) Review request for mesos. Changes ---

Review Request 41345: [WIP] MESOS-3892: Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.

2015-12-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41345/ --- Review request for mesos. Bugs: MESOS-3982

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-12-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review110205 --- Ship it! Ship It! - Till Toenshoff On Dec. 4, 2015, 1:53 p.m.,

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-14 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 14, 2015, 9:47 a.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 41337: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41337/#review110193 --- src/slave/slave.cpp (line 1497)

Re: Review Request 41326: Fixed error in authentication cleanup function.

2015-12-14 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41326/#review110209 --- Ship it! Ship It! - Bernd Mathiske On Dec. 13, 2015, 8:28

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 10:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 3556 > > > > > > Just wondering why we want to do `task.resources() - > > executor.resources())` here? I think in

Re: Review Request 41278: Add note to site-docker doc about tunneling

2015-12-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/#review110191 --- support/site-docker/README.md (line 20)

Re: Review Request 41337: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41337/ --- (Updated Dec. 14, 2015, 9:25 a.m.) Review request for mesos, Artem

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

2015-12-14 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/ --- (Updated Dec. 15, 2015, 3:20 a.m.) Review request for mesos, Artem

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

2015-12-14 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/ --- (Updated Dec. 15, 2015, 3:38 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-14 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review110391 ---

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-14 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review110387 --- LGTM, Just some minor style nits and suggestions.

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41286/#review110184 --- docs/getting-started.md (line 57)

Review Request 41340: Fixed a possible race condition where authentication could be used before it was set up.

2015-12-14 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41340/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Bugs:

Re: Review Request 41327: Fixed a race in Authentication tests where it was possible to connect to a non yet routed endpoint.

2015-12-14 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41327/ --- (Updated Dec. 14, 2015, 11:40 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-14 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 14, 2015, 4:02 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/#review110244 --- docs/authorization.md (line 7)

Re: Review Request 40829: Improved authorization documentation.

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40829/#review110383 --- docs/authorization.md (line 24)

Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-14 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- Review request for mesos, Adam B and Anand Mazumdar. Repository: mesos

Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41383/#review110409 --- Patch looks great! Reviews applied: [41286, 41359, 41360, 41361,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-14 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review110392 ---

Re: Review Request 40829: Improved authorization documentation.

2015-12-14 Thread Adam B
> On Dec. 14, 2015, 7:25 p.m., Guangya Liu wrote: > > docs/authorization.md, line 24 > > > > > > Not yours, shall we file a JIRA ticket to update shutdown_frameworks to > > teardown_frameworks to make it consistent

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-12-14 Thread Adam B
> On Dec. 14, 2015, 5:47 p.m., Adam B wrote: > > Ship It! Only missing piece is an API change mention in the CHANGELOG. I'll add that. - Adam --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

2015-12-14 Thread Klaus Ma
> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-14 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review110385 ---

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/#review110389 --- src/docker/executor.hpp (line 89)

Re: Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox.

2015-12-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41386/#review110399 --- src/tests/container_logger_tests.cpp (line 158)

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

2015-12-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review110388 --- src/slave/containerizer/docker.cpp (line 139)

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

2015-12-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review110395 --- src/docker/docker.cpp (line 593)

Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers

2015-12-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/#review110397 --- Ship it! Ship It! - Timothy Chen On Dec. 15, 2015, 2:14 a.m.,

  1   2   >