Re: Review Request 42792: Fix compile error in container logger tests.

2016-01-26 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116333 --- Ship it! Ship It! - Klaus Ma On Jan. 26, 2016, 4:12 p.m.,

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116330 --- src/tests/fetcher_cache_tests.cpp (line 196)

Review Request 42794: URL query string order is defined.

2016-01-26 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-3317

Re: Review Request 42594: Introduced framework registry operations.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42594/#review116340 --- Patch looks great! Reviews applied: [42591, 42594] Passed

Re: Review Request 42516: Add support for user-defined networks.

2016-01-26 Thread Ezra Silvera
> On Jan. 24, 2016, 6:58 a.m., Shuai Lin wrote: > > src/docker/docker.cpp, line 519 > > > > > > typo, s/sempty/empty :) good catch. thanks :-) - Ezra ---

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review116556 --- Patch looks great! Reviews applied: [42181, 42843, 42844, 42185,

Re: Review Request 42685: Added roles validation to master.

2016-01-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/ --- (Updated Jan. 27, 2016, 1:26 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42685: Added roles validation to master.

2016-01-26 Thread Qian Zhang
> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, lines 1980-1983 > > > > > > This should probably be replaced with `strings::join("'", > > frameworkInfo.roles())` which could be

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

2016-01-26 Thread Joerg Schad
> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote: > > docs/home.md, line 17 > > > > > > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the > > link structure [label](file.md). I.e. s/endpoints/

Re: Review Request 42516: Add support for user-defined networks.

2016-01-26 Thread Ezra Silvera
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 27, 2016, 7:05 a.m.) Review request for mesos and TimothyIL

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

2016-01-26 Thread Joerg Schad
> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote: > > docs/home.md, line 12 > > > > > > FYI: The links from > > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't > > seem to work for me...

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

2016-01-26 Thread Kevin Klues
> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote: > > docs/home.md, line 12 > > > > > > FYI: The links from > > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't > > seem to work for me...

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

2016-01-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42836/ --- (Updated Jan. 27, 2016, 4:04 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Jan. 27, 2016, 4:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

2016-01-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42836/#review116533 --- Ship it! Ship It! - Michael Park On Jan. 27, 2016, 4:04

Review Request 42844: Drop `404 NotFound` responses in the executor library.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42844/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Review Request 42843: Ensure `ServiceUnavailable` is not received for `Subscribe` calls.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42843/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Re: Review Request 42185: Added an example executor based on the new V1 API.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/ --- (Updated Jan. 27, 2016, 4:13 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/#review116537 --- Patch looks great! Reviews applied: [42806] Passed command:

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread haosdent huang
> On Jan. 26, 2016, 9:18 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 196 > > > > > > Good idea, but then we need to set checkpointing to true for the > > recovery test below. @bernd,

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116547 --- Patch looks great! Reviews applied: [42696] Passed command:

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-01-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review116317 --- Ship it! Ship It! - Guangya Liu On 一月 25, 2016, 11:02 p.m.,

Re: Review Request 39060: Create master detector per url & not per framework.

2016-01-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review116314 --- Ship it! src/sched/sched.cpp (line 167)

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

2016-01-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/#review116329 --- docs/home.md (line 12)

Re: Review Request 42754: Added support for labels to resource reservations.

2016-01-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review116304 --- src/tests/reservation_endpoints_tests.cpp (line 782)

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote: > > src/tests/disk_quota_tests.cpp, lines 132-133 > > > > > > Can you add a simple DiskUsageCollectorTest here to test the exclude > > path? `du` excludes symlinks

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

2016-01-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/#review116327 --- docs/home.md (line 17)

Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42278/#review116326 --- Patch looks great! Reviews applied: [42379, 42277, 42278]

Re: Review Request 42735: Make bash scripts portable.

2016-01-26 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Jan. 26, 2016, 8:42 a.m.) Review request for mesos, Artem Harutyunyan

Review Request 42792: Fix compile error in container logger tests.

2016-01-26 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-4508

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 26, 2016, 12:13 a.m.) Review request for Artem Harutyunyan and

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 205 > > > > > > can you do the following? > > > > ``` > > info->paths[path].usage =

Re: Review Request 42735: Make commit-msg hook portable.

2016-01-26 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Jan. 26, 2016, 8:40 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42735: Make commit-msg hook portable.

2016-01-26 Thread David Forsythe
> On Jan. 25, 2016, 9:52 p.m., Ian Downes wrote: > > Can you please fix the other bash Linux-isms in this patch while you're at > > it? > > ``` > > [1350][idownes:mesos]$ git grep "!\/bin\/bash" > > support/atexit.sh:#!/bin/bash > > support/coverage.sh:#!/bin/bash > >

Re: Review Request 42792: Fix compile error in container logger tests.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116350 --- Patch looks great! Reviews applied: [42792] Passed command:

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-01-26 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Jan. 26, 2016, 1:54 p.m.) Review request for mesos, Artem

Review Request 42797: Fix expire CERN GPG key link.

2016-01-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42797/ --- Review request for mesos, Adam B and Timothy Chen. Bugs: MESOS-4511

Re: Review Request 42794: URL query string order is defined.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116355 --- Patch looks great! Reviews applied: [42794] Passed command:

Re: Review Request 42794: URL query string order is defined.

2016-01-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116362 --- 3rdparty/libprocess/src/http.cpp (line 787)

Re: Review Request 42477: Corrected example in quota user doc.

2016-01-26 Thread Alexander Rukletsov
> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote: > > docs/quota.md, line 166 > > > > > > Please explain what this seemingly redundant field is doing. > > Guangya Liu wrote: > I think this is because the

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-26 Thread Alexander Rukletsov
> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I feel that optimizing here (with = 16) is more confusing than helpful, > > especially as this protobuf is

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-26 Thread Alexander Rukletsov
> On Jan. 25, 2016, 8:40 a.m., Joris Van Remoortere wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I don't get the `16` as per Joerg's comment. Commented on above. > On Jan. 25, 2016, 8:40 a.m.,

Re: Review Request 42477: Corrected example in quota user doc.

2016-01-26 Thread Bernd Mathiske
> On Jan. 22, 2016, 8:34 a.m., Bernd Mathiske wrote: > > docs/quota.md, line 166 > > > > > > Please explain what this seemingly redundant field is doing. > > Guangya Liu wrote: > I think this is because the

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review116371 --- Patch looks great! Reviews applied: [40951, 41090, 41092]

Re: Review Request 42477: Corrected example in quota user doc.

2016-01-26 Thread Alexander Rukletsov
> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote: > > docs/quota.md, line 166 > > > > > > Please explain what this seemingly redundant field is doing. > > Guangya Liu wrote: > I think this is because the

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 26, 2016, 4:33 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.

2016-01-26 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42803/ --- Review request for mesos, Joseph Wu and Jan Schlicht. Bugs: MESOS-4513

Re: Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.

2016-01-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42803/#review116375 --- Ship it! Ship It! - Jan Schlicht On Jan. 26, 2016, 5:47

Re: Review Request 42797: Fix expire CERN GPG key link.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42797/#review116377 --- Patch looks great! Reviews applied: [42797] Passed command:

Re: Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42803/#review116381 --- Ship it! I wish clang had included `-Wsign-compare` in

Re: Review Request 42762: Improved performance of 'roles::validate'.

2016-01-26 Thread Benjamin Bannier
> On Jan. 26, 2016, 3:14 a.m., Anand Mazumdar wrote: > > LGTM. Puzzled me for a bit at why the temporary is being constructed > > (assuming the correct `operator==` for `const char*` was being invoked) > > till I looked up here: > > > >

Re: Review Request 40553: Enable mesos tests installation.

2016-01-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116385 --- Could you please rebase? This doesn't apply for me with

Re: Review Request 42751: Tweaked some resource test cases.

2016-01-26 Thread Neil Conway
> On Jan. 26, 2016, 6:37 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 1603 > > > > > > Why do you update here? The goal of this test is to validate that two resources with different

Review Request 42806: Added the fetcher plugin module interface.

2016-01-26 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3926

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-01-26 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- (Updated Jan. 26, 2016, 5:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-01-26 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- (Updated Jan. 26, 2016, 5:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-01-26 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- (Updated Jan. 26, 2016, 5:58 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42794: URL query string order is defined.

2016-01-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116392 --- 3rdparty/libprocess/src/http.cpp (lines 787 - 791)

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review116400 --- Patch looks great! Reviews applied: [42477, 42476] Passed

Re: Review Request 42754: Added support for labels to resource reservations.

2016-01-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Jan. 26, 2016, 6:34 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42754: Added support for labels to resource reservations.

2016-01-26 Thread Neil Conway
> On Jan. 26, 2016, 8:03 a.m., Guangya Liu wrote: > > src/tests/reservation_endpoints_tests.cpp, line 782 > > > > > > why does the offerResources contain the labeledResources2? The > > labeledResources2 should be

Re: Review Request 42787: Fixed whitespace errors in help strings for mesos/src.

2016-01-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42787/#review116402 --- Ship it! Ship It! - Neil Conway On Jan. 26, 2016, 7:41

Re: Review Request 42788: Fixed whitespace errors in help strings for 3rdparty/libprocess.

2016-01-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42788/#review116403 --- Ship it! Ship It! - Neil Conway On Jan. 26, 2016, 7:41

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 26, 2016, 10:48 a.m.) Review request for mesos, Artem

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2016-01-26 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Jan. 26, 2016, 7:24 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2016-01-26 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Jan. 26, 2016, 7:24 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2016-01-26 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Jan. 26, 2016, 7:24 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42792: Fix compile error in container logger tests.

2016-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116427 --- Sorry about that. Till already committed an identical patch.

Re: Review Request 42790: Added documentation for all http endpoints.

2016-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42790/#review116423 --- Instead of committing these auto-generated files, it might be

Re: Review Request 42790: Added documentation for all http endpoints.

2016-01-26 Thread Greg Mann
> On Jan. 26, 2016, 7:37 p.m., Joseph Wu wrote: > > Instead of committing these auto-generated files, it might be better to > > consider adding `mesos-endpoint-docs` to the website generating Rakefile. Perhaps it's good to have a static copy of the files committed to the repo, so that a user

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-01-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated Jan. 26, 2016, 7:49 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 42810: Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.

2016-01-26 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/ --- (Updated Jan. 26, 2016, 7:52 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review116441 --- Patch looks great! Reviews applied: [41704, 41705, 41818]

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

2016-01-26 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 26, 2016, 8:18 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-01-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated Jan. 26, 2016, 8:20 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review116424 --- Fix it, then Ship it! src/tests/disk_quota_tests.cpp (lines

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2016-01-26 Thread Anand Mazumdar
> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 361 > > > > > > dont you want to set `subscribe` and `nonSubscribe` to None()? As per our discussion, we don't set them to

Re: Review Request 41283: V1 Executor Library over HTTP

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 26, 2016, 8:33 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

2016-01-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42786/#review116432 --- 3rdparty/libprocess/include/process/help.hpp (line 111)

Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

2016-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42820/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till

Re: Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

2016-01-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42789/#review116436 --- support/endpoint-docs.cpp (line 80)

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-26 Thread Alexander Rukletsov
> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I feel that optimizing here (with = 16) is more confusing than helpful, > > especially as this protobuf is

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/#review116447 --- Bad patch! Reviews applied: [39850, 39851, 39852, 39888, 39889,

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 26, 2016, 8:48 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 42821: Cleaned up namespace-qualified identifiers.

2016-01-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42821/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42820/#review116450 --- src/slave/container_loggers/lib_logrotate.hpp (line 104)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 26, 2016, 9:19 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

2016-01-26 Thread Greg Mann
> On Jan. 26, 2016, 8:34 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 111 > > > > > > Returning a raw pointer here is unfortunate. I wonder if it would be > > better to return the

Re: Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

2016-01-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42789/#review116417 --- Thanks for writing this, Kevin! I'm going to extend it to output

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review116453 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
> On Jan. 26, 2016, 12:26 p.m., Jie Yu wrote: > > src/tests/disk_quota_tests.cpp, lines 144-147 > > > > > > This should be wrapped with ifdef linux. I fixed it for you. Thanks Jie, there is a ticket to make sure we

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

2016-01-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42711/ --- (Updated Jan. 26, 2016, 9:56 p.m.) Review request for mesos and Joris Van

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

2016-01-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42738/ --- (Updated Jan. 26, 2016, 10:02 p.m.) Review request for mesos and Joris Van

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2016-01-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review116455 --- Fix it, then Ship it! Looking good. Just some minor things.

Re: Review Request 42810: Added the CgroupInfo protobuf.

2016-01-26 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/ --- (Updated Jan. 26, 2016, 10:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42741: Included reserved resources in stage 1 of allocation.

2016-01-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42741/ --- (Updated Jan. 26, 2016, 10:10 p.m.) Review request for mesos and Joris Van

Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/ --- Review request for mesos and Michael Park. Bugs: MESOS-1469 and MESOS-4478

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

2016-01-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42711/#review116459 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 26, 2016,

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

2016-01-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42738/ --- (Updated Jan. 26, 2016, 10:29 p.m.) Review request for mesos and Joris Van

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

2016-01-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42711/ --- (Updated Jan. 26, 2016, 10:34 p.m.) Review request for mesos and Joris Van

  1   2   >