Re: Review Request 42685: Added roles validation to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review116564 --- Patch looks great! Reviews applied: [42415, 42685] Passed comman

Re: Review Request 42016: Windows:[2/2] Added zookeeper-3.4.5 to Mesos build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 27, 2016, 9:03 a.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 42016: Windows:[2/2] Added zookeeper-3.4.5 to Mesos build.

> On Jan. 25, 2016, 7:51 p.m., Alex Clemmer wrote: > > 3rdparty/CMakeLists.txt, line 48 > > > > > > The comment here seems like it could be clearer -- it's not actually > > setting a directory, it's setting the envir

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116567 --- Patch looks great! Reviews applied: [42516] Passed command: expo

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

> On Jan. 27, 2016, 3 a.m., Alex Clemmer wrote: > > Aside from the relatively minor comments below, I have one major > > suggestion: I'd like to point Windows builds at ZK commit > > 06d3f3fa1bff258e62c0670309ad1849b1434bb1[1], (or _some_ commit later in the > > version history) so that we can

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116572 --- I think the description is a bit outdated, you introduce one test

Re: Review Request 42603: Added an http::Authenticator factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116582 --- include/mesos/authentication/http/basic_authenticator_factory.hpp

Re: Review Request 42603: Added an http::Authenticator factory.

> On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote: > > src/authentication/http/authenticator.cpp, lines 58-60 > > > > > > If multiple HTTP authenticators are not supported, why is > > `authenticators` supposed to be

Re: Review Request 42603: Added an http::Authenticator factory.

> On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote: > > src/master/master.cpp, line 535 > > > > > > Good that you check for `NULL` here! > > > > The error message is fairly generic though. It would be great i

Re: Review Request 42603: Added an http::Authenticator factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 27, 2016, 4:38 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42603: Added an http::Authenticator factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116591 --- Could you separate changes due to `http::Authenticator` and for up

Re: Review Request 42839: WIP: Appc cache redesign.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42839/ --- (Updated Jan. 27, 2016, 5:01 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 27, 2016, 5:02 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41892/#review116595 --- src/docker/executor.cpp (line 136)

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about "a

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/#review116599 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 27, 2016, 5:54 p.m.) Review request for mesos, Benjamin Bannier a

Review Request 42860: Add paths::sameParent to find out the same root of a path list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4521

Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4521

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 27, 2016, 6:24 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

> On Jan. 27, 2016, 11:30 a.m., Alexander Rukletsov wrote: > > I think the description is a bit outdated, you introduce one test instead > > of two : ). Whoops! Thanks Alex :-) - Greg --- This is an automatically generated e-mail. To r

Re: Review Request 42662: Added common command utils file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/#review116600 --- Fix it, then Ship it! This is looking good! Some nits and we're

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated Jan. 27, 2016, 6:36 p.m.) Review request for mesos, Jie Yu and Joris V

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Jan. 27, 2016, 6:36 p.m.) Review request for mesos, Jie Yu and Joris V

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Jan. 27, 2016, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Jan. 27, 2016, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Jan. 27, 2016, 6:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42648: Moved http authenticator initialization to main.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42648/ --- (Updated Jan. 27, 2016, 7:50 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116608 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 42794: URL query string order is defined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/ --- (Updated Jan. 27, 2016, 7:07 p.m.) Review request for mesos, Kapil Arya and Jan

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review116609 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116610 --- Looks mostly good to me. A few things were unclear to me: * Would

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 27, 2016, 11:55 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 27, 2016, 8:26 p.m.) Review request for Jie Yu. Changes ---

Re: Review Request 42839: WIP: Appc cache redesign.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42839/ --- (Updated Jan. 27, 2016, 8:25 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 42662: Added common command utils file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/ --- (Updated Jan. 27, 2016, 8:29 p.m.) Review request for mesos and Jie Yu. Chang

Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 42864: Add subprocess methods to release ownership of pipe FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42864/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 27, 2016, 9:03 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 40553: Enable mesos tests installation.

> On Jan. 27, 2016, 7:44 p.m., Benjamin Bannier wrote: > > Looks mostly good to me. A few things were unclear to me: > > > > * Would it make sense to add an `installcheck` target? My expectation for > > that would be for it to invoke the installed tests and adding the > > (in)correct `builddir

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/#review116606 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 6

Re: Review Request 42790: Added documentation for all http endpoints.

> On Jan. 26, 2016, 7:37 p.m., Joseph Wu wrote: > > Instead of committing these auto-generated files, it might be better to > > consider adding `mesos-endpoint-docs` to the website generating Rakefile. > > Greg Mann wrote: > Perhaps it's good to have a static copy of the files committed to

Re: Review Request 42790: Added documentation for all http endpoints.

> On Jan. 26, 2016, 11:37 a.m., Joseph Wu wrote: > > Instead of committing these auto-generated files, it might be better to > > consider adding `mesos-endpoint-docs` to the website generating Rakefile. > > Greg Mann wrote: > Perhaps it's good to have a static copy of the files committed to

Re: Review Request 42648: Moved http authenticator initialization to main.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42648/ --- (Updated Jan. 27, 2016, 10:23 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 42603: Added an http::Authenticator factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 27, 2016, 10:22 p.m.) Review request for mesos, Alexander Ruklets

Review Request 42872: Relaxed the subsystem check for net_cls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42872/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4530 https://issues.apache

Review Request 42873: Enhanced the NetClsIsolatorTest filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42873/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4530 https://issues.apache

Re: Review Request 42794: URL query string order is defined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116635 --- Patch looks great! Reviews applied: [42794] Passed command: expo

Re: Review Request 42773: Added utility function to compute SHA512 digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos. Changes ---

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos, Alex Naparu, Dari

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/#review116638 --- Ship it! Ship It! - Alex Clemmer On Jan. 27, 2016, 10:29 p.m

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116640 --- Ship it! Ship It! - Alex Clemmer On Jan. 27, 2016, 10:29 p.m

Review Request 42876: Disallowed non-`const` iteration over `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4534

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/ --- (Updated Jan. 27, 2016, 10:50 p.m.) Review request for mesos, Jie Yu and Joris

Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/ --- Review request for mesos, Greg Mann and Joris Van Remoortere. Repository: mesos

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/ --- (Updated Jan. 27, 2016, 10:56 p.m.) Review request for mesos, Greg Mann and Jor

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 27, 2016, 11:03 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 42603: Added an http::Authenticator factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116641 --- Fix it, then Ship it! include/mesos/authentication/http/basic_

Re: Review Request 42648: Moved http authenticator initialization to main.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42648/#review116648 --- src/master/main.cpp (line 112)

Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4530 https://issues.apache

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116649 --- Fix it, then Ship it! LGTM. src/tests/persistent_volume_endpo

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/ --- (Updated Jan. 27, 2016, 3:20 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/#review116651 --- Ship it! Ship It! - Anand Mazumdar On Jan. 27, 2016, 8:38 p.

Review Request 42880: Add test for LogrotateContainerLogger's FD management.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42880/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Re: Review Request 42880: Add test for LogrotateContainerLogger's FD management.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42880/#review116654 --- Fix it, then Ship it! src/tests/container_logger_tests.cpp (li

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/#review116656 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 27, 2016, 1

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/#review116657 --- src/slave/container_loggers/lib_logrotate.cpp (line 107)

Re: Review Request 42880: Add test for LogrotateContainerLogger's FD management.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42880/ --- (Updated Jan. 27, 2016, 4:09 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/ --- (Updated Jan. 27, 2016, 4:11 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 42881: Updated release guide to include running the benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42881/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

> On Jan. 27, 2016, 4:02 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/lib_logrotate.cpp, line 149 > > > > > > Is this supposed to be `outfds` or `errfds`? Do we need the `cloexec` > > at all? If jus

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/#review116661 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:50 a.m., Mi

Re: Review Request 42881: Updated release guide to include running the benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42881/#review116662 --- Ship it! Ship It! - Vinod Kone On Jan. 28, 2016, 12:11 a.m.,

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/#review116663 --- Ship it! Ship It! - Benjamin Hindman On Jan. 28, 2016, 12:11

Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/#review116664 --- Patch looks great! Reviews applied: [42866] Passed command: expo

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116652 --- Fix it, then Ship it! src/Makefile.am (line 1999)

Re: Review Request 40553: Enable mesos tests installation.

> On Jan. 27, 2016, 8:44 p.m., Benjamin Bannier wrote: > > Looks mostly good to me. A few things were unclear to me: > > > > * Would it make sense to add an `installcheck` target? My expectation for > > that would be for it to invoke the installed tests and adding the > > (in)correct `builddir

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 28, 2016, 12:49 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42662: Added common command utils file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/#review116665 --- src/common/command_utils.cpp (line 17)

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review116670 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:56 a.m., Ne

Re: Review Request 42615: mesos: Cleaned up usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42615/ --- (Updated Jan. 28, 2016, 12:56 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- (Updated Jan. 28, 2016, 12:56 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42872: Relaxed the subsystem check for net_cls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42872/#review116672 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Review Request 42887: Fixed a flaky test in disk quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42887/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Review Request 42888: Used absolute paths for excludes paths in posix disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42888/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Repositor

Re: Review Request 42888: Used absolute paths for excludes paths in posix disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42888/ --- (Updated Jan. 28, 2016, 1:14 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116676 --- Patch looks great! Reviews applied: [39850, 39851, 39852, 39888,

Re: Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/#review116677 --- Fix it, then Ship it! src/tests/containerizer/isolator_tests.c

Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/ --- Review request for mesos, Jie Yu and Michael Park. Repository: mesos Descript

Re: Review Request 42887: Fixed a flaky test in disk quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42887/#review116683 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 28, 2016, 1

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/ --- (Updated Jan. 28, 2016, 1:44 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/ --- (Updated Jan. 28, 2016, 1:48 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/#review116692 --- Ship it! Ship It! - Jie Yu On Jan. 28, 2016, 1:44 a.m., Jori

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

> On Jan. 27, 2016, 9:06 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68 > > > > > > I am extremely confused about the expected semantics of this function > > (e.g

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated Jan. 28, 2016, 2:12 a.m.) Review request for mesos, Jie Yu and Joris V

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Jan. 28, 2016, 2:12 a.m.) Review request for mesos, Jie Yu and Joris V

Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42835/#review116695 --- src/master/allocator/mesos/hierarchical.cpp (line 1341)

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/#review116696 --- src/master/allocator/sorter/drf/sorter.cpp (line 358)

  1   2   >