Re: Review Request 45746: Fixed the indent for continuation statements.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45746/#review127105 --- Patch looks great! Reviews applied: [45746] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127088 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

2016-04-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review127092 --- Ship it! Ship It! - Bernd Mathiske On April 5, 2016, 6:27

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

2016-04-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated April 5, 2016, 1:27 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

2016-04-05 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review127091 --- Ship it! Ship It! - Neil Conway On April 5, 2016, 1:27

Re: Review Request 45370: Implemented prepare() for dvd isolator.

2016-04-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review127145 --- src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/#review127173 --- Ship it! Ship It! - Cong Wang On April 5, 2016, 6:25 p.m.,

Re: Review Request 45734: Fix 'pivot_root is not available' error on powerpc platform.

2016-04-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45734/#review127138 --- Ship it! Ship It! - Vinod Kone On April 5, 2016, 9:25 a.m.,

Re: Review Request 45455: Added test for recovering orphaned docker containers.

2016-04-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45455/#review127126 --- Fix it, then Ship it! Ship It!

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

2016-04-05 Thread Jie Yu
> On April 2, 2016, 7:25 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 817 > > > > > > We should have a comment here explaining why we are not returning a > >

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

2016-04-05 Thread Jie Yu
> On April 5, 2016, 6:32 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 824 > > > > > > Just wondering if there are any cases that > > `containerNetwork.networkInfo`

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-05 Thread James Peach
> On April 4, 2016, 5:35 p.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-05 Thread Jie Yu
> On April 5, 2016, 5:03 p.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 1963 > > > > > > It is still not clear why we need to handle this case, at least I don't >

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/ --- (Updated April 5, 2016, 5:25 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

2016-04-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/ --- (Updated April 5, 2016, 5:33 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review127149 --- Ship it! Ship It! - Jie Yu On April 5, 2016, 6:19 a.m.,

Re: Review Request 45749: Adjusted lifetimes of member variables.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45749/#review127157 --- Patch looks great! Reviews applied: [45749] Passed command:

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/ --- (Updated April 5, 2016, 6:25 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127151 --- Ship it! Ship It! - Jie Yu On April 5, 2016, 5:33 p.m.,

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/#review127155 --- include/mesos/mesos.proto (line 1604)

Re: Review Request 45749: Adjusted lifetimes of member variables.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45749/#review127165 --- Ship it! Ship It! - Joseph Wu On April 5, 2016, 9:01 a.m.,

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Avinash sridharan
> On April 5, 2016, 6:25 a.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 152 > > > > > > Should we mention that an image has to be provided && for mesos > > containerizer only? > > Avinash sridharan wrote:

Re: Review Request 45594: Introduced a new agent flag docker_config.

2016-04-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45594/#review127191 --- src/slave/flags.cpp (line 136)

Re: Review Request 45773: Updated the CHANGELOG for 0.28.1.

2016-04-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45773/#review127202 --- Ship it! Ship It! - Ben Mahler On April 5, 2016, 8:13 p.m.,

Re: Review Request 45493: Added namespace option to subprocess [3/5].

2016-04-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45493/#review127182 --- What is the high-level reasoning for making these namespace

Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

2016-04-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/#review127187 --- Fix it, then Ship it!

Re: Review Request 45595: Implemented slave default docker config file support.

2016-04-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45595/ --- (Updated April 5, 2016, 12:22 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review127195 --- src/tests/cluster.cpp (lines 364 - 366)

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-05 Thread Joseph Wu
> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/ --- Review request for mesos, Joerg Schad and Vinod Kone. Bugs: MESOS-5126

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Kevin Klues
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Review Request 45773: Updated the CHANGELOG for 0.28.1.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45773/ --- Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and

Re: Review Request 45491: Refactored subprocess options [1/5].

2016-04-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review127172 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 80)

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-04-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45495/#review127185 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 279)

Re: Review Request 45594: Introduced a new agent flag docker_config.

2016-04-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45594/ --- (Updated April 5, 2016, 12:21 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45596/ --- (Updated April 5, 2016, 12:34 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45595: Implemented slave default docker config file support.

2016-04-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45595/ --- (Updated April 5, 2016, 12:34 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45492: Used ChildHooks in Mesos [2/5].

2016-04-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/#review127177 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 45594: Introduced a new agent flag docker_config.

2016-04-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45594/ --- (Updated April 5, 2016, 12:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/#review127198 --- support/hooks/commit-msg (line 20)

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-05 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 6, 2016, 5:33 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review126845 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp (line 33)

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review127121 ---

Review Request 45749: Adjusted lifetimes of member variables.

2016-04-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45749/ --- Review request for mesos, Joseph Wu and Michael Park. Bugs: MESOS-5000

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-05 Thread Jay Guo
> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review127115 --- Patch looks great! Reviews applied: [45039] Passed command:

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/ --- (Updated April 5, 2016, 4:45 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/#review127136 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 42551: Porting mesos on ppc64le.

2016-04-05 Thread Vinod Kone
> On March 24, 2016, 2:14 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [42551] > > > > Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' > > COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; > > ./support/docker_build.sh > > Zhiwei Chen

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-05 Thread Jie Yu
> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too

Re: Review Request 45454: Cleanup orphaned docker containers owned by previous agent instance.

2016-04-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45454/#review127119 --- Ship it! Ship It! - Timothy Chen On March 29, 2016, 10:44

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-05 Thread Jiang Yan Xu
> On March 24, 2016, 9:54 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 568 > > > > > > It seems that we don't need to modify `totalProjectIds` (which can be a > > const)

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-05 Thread haosdent huang
> On April 5, 2016, 4:55 p.m., haosdent huang wrote: > > By the way, I saw you didn't support `create`, `remove` and `path` methods while it exists in dvdcli. Are they unnecessary here? - haosdent --- This is an automatically

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review127132 --- src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/#review127137 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 45594: Introduced a new agent flag docker_config.

2016-04-05 Thread Gilbert Song
> On April 5, 2016, 12:28 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 136 > > > > > > Can you probably elaborate a bit more why a docker config file > > configuration is needed? > > > > I know

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45596/#review127207 --- Patch looks great! Reviews applied: [45594, 45595, 45596]

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45596/#review127223 --- docs/docker-containerizer.md (lines 64 - 65)

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

2016-04-05 Thread Michael Park
> On March 18, 2016, 5:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 177 > > > > > > Can we remove the `struct` in `struct tm`? Submitted with this fix. -

Re: Review Request 45595: Implemented slave default docker config file support.

2016-04-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45595/#review127217 --- Ship it! - Jie Yu On April 5, 2016, 7:34 p.m., Gilbert Song

Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

2016-04-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos and Joris Van

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 5, 2016, 3:40 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-05 Thread Jiang Yan Xu
> On April 5, 2016, 12:52 p.m., Joseph Wu wrote: > > src/tests/cluster.cpp, lines 364-366 > > > > > > The destructor will only dereference a null `containerizer` if this > > error case is hit (or if you pass in a

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 5, 2016, 11 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45455: Added test for recovering orphaned docker containers.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45455/#review127248 --- Patch looks great! Reviews applied: [45453, 45454, 45455]

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-05 Thread James Peach
> On April 5, 2016, 10:25 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 286 > > > > > > `s/directory/path`. As discussed, we only accept directories now. > On April 5,

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 5, 2016, 11:40 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 5, 2016, 11:40 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 5, 2016, 10:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 5, 2016, 10:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 5, 2016, 11 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 5, 2016, 10:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-05 Thread James Peach
> On April 5, 2016, 4:52 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp, line 33 > > > > > > Doesn't look like the utils header is used in this header? > > > > Otherwise

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Joris Van

Re: Review Request 45455: Added test for recovering orphaned docker containers.

2016-04-05 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45455/ --- (Updated April 5, 2016, 10:05 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45622: Fixed Nvidia GPU isolator build for gcc.

2016-04-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45622/#review127231 --- Ship it! Ship It! - Ben Mahler On April 2, 2016, 9:35 p.m.,

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 5, 2016, 3:33 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/#review127228 --- Patch looks great! Reviews applied: [45767, 45768] Passed

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review127166 --- Fix it, then Ship it! Looking good. Just a few minor comments,

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 5, 2016, 3:33 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-05 Thread Jiang Yan Xu
> On April 1, 2016, 12:27 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp, line 71 > > > > > > We have > > > > `makeQuotaInfo` vs. `mkfile` & `mkloop`. Can we make the use of the

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 5, 2016, 11 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-05 Thread Michael Park
> On April 4, 2016, 1:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 311-320 > > > > > > Conceptutally, `Try` is not something we pass around like this. A > > function

Re: Review Request 45715: Added support to grant access to /dev/nvidiactl in Nvidia GPU isolator.

2016-04-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45715/#review127255 --- Fix it, then Ship it!

Re: Review Request 45715: Added support to grant access to /dev/nvidiactl in Nvidia GPU isolator.

2016-04-05 Thread Ben Mahler
> On April 5, 2016, 11:53 p.m., Ben Mahler wrote: > > Do we also need the uvm device? - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45715/#review127255

Re: Review Request 44364: Added tests for the Nvidia GPU isolator.

2016-04-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44364/ --- (Updated April 6, 2016, 12:38 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44364: Added tests for the Nvidia GPU isolator.

2016-04-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44364/#review127243 --- Fix it, then Ship it! Nice test!

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review127259 --- Ship it! src/tests/cluster.hpp (line 188)

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127266 --- src/cli/execute.cpp (line 354)

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127262 --- Patch looks great! Reviews applied: [45067, 45440] Passed

  1   2   >