Re: Review Request 49780: Added a `Clock::settle()` to ensure agent has finished recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49780/#review141272 --- Ship it! Ship It! - zhou xing On 七月 8, 2016, 2:12 a.m.,

Re: Review Request 49244: Implement READ_FILE for master operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/ --- (Updated 七月 8, 2016, 11:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/ --- (Updated 七月 8, 2016, 11:51 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49759: Implemented 'GetTasks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49759/#review141277 --- src/slave/http.cpp (lines 1240 - 1261)

Review Request 49798: Added test case for 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49798/ --- Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.

Review Request 49800: Added test case for 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/ --- Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.

Re: Review Request 49243: Create readFile method in FilesProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/ --- (Updated 七月 8, 2016, 11:49 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49679/ --- (Updated 七月 8, 2016, 11:47 a.m.) Review request for mesos, Anand Mazumdar and

Review Request 49796: Added negative number check for read_file offset parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49796/ --- Review request for mesos and Anand Mazumdar. Bugs: mesos-5515

Re: Review Request 49242: Add ReadFile protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/ --- (Updated 七月 8, 2016, 11:48 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49693: Cleaned up some minor style issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49693/#review141276 --- Ship it! Ship It! - Joerg Schad On July 6, 2016, 8:39 a.m.,

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49757/ --- (Updated July 8, 2016, 4:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49758: Implemented 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49758/ --- (Updated July 8, 2016, 4:14 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/ --- (Updated July 8, 2016, 4:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49797: Added test case for 'GetFrameworks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49797/ --- (Updated July 8, 2016, 4:14 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49798: Added test case for 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49798/ --- (Updated July 8, 2016, 4:14 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49760: Implemented 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49760/ --- (Updated July 8, 2016, 4:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review141176 --- Code LGTM. :) Comments mainly on tests.

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/ --- (Updated July 8, 2016, 10:29 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review141297 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated July 8, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141294 --- Patch looks great! Reviews applied: [48593] Passed command:

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

> On May 3, 2016, 10:32 p.m., Michael Park wrote: > > src/tests/persistent_volume_tests.cpp, lines 573-575 > > > > > > ```cpp > > Resources taskResources = > > Resources::parse("cpus:1;mem:128;disk("

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated July 8, 2016, 5:16 p.m.) Review request for mesos, Alexander

Re: Review Request 49692: Removed an unnecessary `Clock::settle` from a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49692/#review141301 --- src/tests/master_slave_reconciliation_tests.cpp (line 617)

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- (Updated July 8, 2016, 5:35 p.m.) Review request for mesos, James Peach, Joris

Re: Review Request 49616: Add suppression benchmark.

> On July 6, 2016, 11:19 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3609-3616 > > > > > > We can simply: > > > > ``` > > cout << "Using " << slaveCount << " agents

Re: Review Request 49616: Add suppression benchmark.

> On July 8, 2016, 5:49 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3640 > > > > > > I think that the reason you want to use `batch` is because you want to > > speed up the test

Re: Review Request 49616: Add suppression benchmark.

> On July 8, 2016, 5:54 a.m., Guangya Liu wrote: > > Another nit is that in `Testing Done` section, it is better add some > > testing command and test data but not only `make check`. > > > > Such as following: > > > > GLOG_v=1 ./bin/mesos-tests.sh --benchmark > >

Re: Review Request 49243: Create readFile method in FilesProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/#review141289 --- Looks pretty good and close to being shippable. I also included

Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49781/#review141316 --- Patch looks great! Reviews applied: [49781] Passed command:

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review141302 --- Fix it, then Ship it! src/tests/gc_tests.cpp (line 899)

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- (Updated July 8, 2016, 5:55 p.m.) Review request for mesos, James Peach, Joris

Re: Review Request 49244: Implement READ_FILE for master operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/#review141315 --- src/master/http.cpp (line 2796)

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/#review141317 --- src/slave/http.cpp (line 85)

Re: Review Request 49796: Added negative number check for read_file offset parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49796/ --- (Updated July 8, 2016, 6:58 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 49796: Added negative number check for read_file offset parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49796/#review141319 --- src/files/files.cpp (lines 512 - 513)

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49679/#review141320 --- include/mesos/agent/agent.proto (line 82)

Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49822: Implemented `CgroupsIsolatorProcess::notify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49822/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49816: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49816/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49815: Implemented `CgroupsIsolatorProcess::prepareHierarchy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49815/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49812: Added missing header `version.hpp` in `src/linux/perf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49812/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49818: Implemented `CgroupsIsolatorProcess::createCgroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49818/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Re: Review Request 49242: Add ReadFile protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review141322 --- Fix it, then Ship it! include/mesos/agent/agent.proto (line

Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Re: Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.

> On July 6, 2016, 3:46 p.m., Benjamin Mahler wrote: > > You also need to disable the tests in this patch now, yes? Yup. Added. > On July 6, 2016, 3:46 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/test_linkee.cpp, line 41 > >

Re: Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49543/ --- (Updated July 8, 2016, 2:25 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.

Yan can you review this? On Fri, Jul 8, 2016 at 11:53 AM, Mesos ReviewBot wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49781/ > > Patch looks great! > > Reviews applied: [49781] > > Passed command: export

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141348 --- src/common/values.cpp (line 271)

Review Request 49835: Moved netlink cleanup functions to separate files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49835/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Repository: mesos

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated July 8, 2016, 11:05 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 8, 2016, 11:03 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On July 8, 2016, 4:30 p.m., Jiang Yan Xu wrote: > > src/tests/resources_tests.cpp, line 2563 > > > > > > I suggest we don't reuse variables, perhaps even use `const`. > > > > ``` > > const Resources

Re: Review Request 48616: Add v1 changes for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/ --- (Updated July 8, 2016, 11:04 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review141337 --- Patch looks great! Reviews applied: [49616] Passed command:

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/#review141358 --- Patch looks great! Reviews applied: [49796, 49679, 49242, 49243,

Review Request 49837: Fixed the flaky `MasterAPITest.Subscribe` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49837/ --- Review request for mesos, Vinod Kone and Zhitao Li. Bugs: MESOS-5812

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/ --- (Updated 七月 9, 2016, 12:36 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/#review141385 --- Fix it, then Ship it! src/tests/api_tests.cpp (lines 2561 -

Re: Review Request 49244: Implement READ_FILE for master operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/#review141384 --- Fix it, then Ship it! src/tests/api_tests.cpp (lines 1993 -

Review Request 49847: Added document about reopening old reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49847/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Vinod

Re: Review Request 49243: Create readFile method in FilesProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/ --- (Updated 七月 9, 2016, 12:34 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49243: Create readFile method in FilesProcess.

> On 七月 8, 2016, 6:43 p.m., Anand Mazumdar wrote: > > src/files/files.cpp, line 621 > > > > > > Not yours. We don't end error messages with a new line character. Can > > you verify if the WebUI/Pailer depends on

Re: Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49543/#review141373 --- Patch looks great! Reviews applied: [49543] Passed command:

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49679/#review141379 --- Ship it! Ship It! - Anand Mazumdar On July 9, 2016, 12:32

Review Request 49846: The SorterTest.RevocableResources should add total resources for slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49846/ --- Review request for mesos, Benjamin Mahler, Vinod Kone, and Jiang Yan Xu.

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 4:22 a.m., Zhitao Li wrote: > > src/master/master.cpp, lines 7602-7610 > > > > > > Does the order of these two statements matter (e.g. we need ot ensure > > `subscribers.subscribed` always has

Re: Review Request 49244: Implement READ_FILE for master operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/ --- (Updated 七月 9, 2016, 2:53 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/ --- (Updated 七月 9, 2016, 2:53 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review141387 --- src/master/master.cpp (lines 7598 - 7606)

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141392 --- Patch looks great! Reviews applied: [49835, 49839, 49840, 49841]

Review Request 49839: Removed the network isolator specific check in netlink socket method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49839/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Repository: mesos

Review Request 49841: Reorganized the routing tests into basic and advanced groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Repository: mesos

Review Request 49840: Fixed the right angle brackets in routing tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49840/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Repository: mesos

Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/ --- Review request for mesos, Vinod Kone and Zhitao Li. Bugs: MESOS-5812

Re: Review Request 49796: Added negative number check for read_file offset parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49796/#review141378 --- Ship it! Ship It! - Anand Mazumdar On July 9, 2016, 12:32

Re: Review Request 49837: Fixed the flaky `MasterAPITest.Subscribe` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49837/#review141388 --- Ship it! Ship It! - Zhitao Li On July 8, 2016, 11:40 p.m.,

Re: Review Request 49796: Added negative number check for read_file offset parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49796/ --- (Updated 七月 9, 2016, 12:32 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 49242: Add ReadFile protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/ --- (Updated 七月 9, 2016, 12:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49679/ --- (Updated 七月 9, 2016, 12:32 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review141382 --- Bad patch! Reviews applied: [49571, 45967, 45966, 45964, 45963,

Re: Review Request 49244: Implement READ_FILE for master operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/ --- (Updated 七月 9, 2016, 12:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49243: Create readFile method in FilesProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/#review141381 --- Ship it! Ship It! - Anand Mazumdar On July 9, 2016, 12:34

Re: Review Request 49242: Add ReadFile protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review141380 --- Ship it! Ship It! - Anand Mazumdar On July 9, 2016, 12:33

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 4:22 a.m., Zhitao Li wrote: > > src/master/master.cpp, lines 7602-7610 > > > > > > Does the order of these two statements matter (e.g. we need ot ensure > > `subscribers.subscribed` always has

Re: Review Request 49794: Added texts for authorization in endpoint docs for '/files/debug'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49794/#review141262 --- Ship it! So strange, because it looks like Vinod generated the

Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49781/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Bugs: MESOS-5800

Review Request 49794: Added texts for authorization in endpoint docs for '/files/debug'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49794/ --- Review request for mesos and Adam B. Bugs: MESOS-5708

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/#review141261 --- Discarded this patch because it's old and stale. Feel free to

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

> On July 7, 2016, 5:20 p.m., Zhitao Li wrote: > > src/slave/http.cpp, line 1032 > > > > > > nit: capture `[this, contentType]` Then we don't need defer(slave->self() as well.. - Abhishek

  1   2   >