Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157436 --- Fix it, then Ship it! Looks good! :)

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 17, 2016, 9:20 a.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, line 201 > > > > > > Consolidate this with `case Shard::STAGING`? > > > > We can just do: > > > >

Re: Review Request 53853: Expanded the comment around `ContainerInfo` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53853/#review157605 --- Ship it! Ship It! - Avinash sridharan On Nov. 17, 2016,

Re: Review Request 53853: Expanded the comment around `ContainerInfo` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53853/#review157604 --- include/mesos/mesos.proto (line 2131)

Re: Review Request 52295: Added additional unit tests for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review157627 --- Ship it! Will commit after I run it.

Re: Review Request 54241: Updated IOSwitchboard to block IO until connected for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54241/#review157630 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2016, 4:13 a.m.,

Re: Review Request 54245: Updated signatures of v1 agent API handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54245/#review157633 --- Ship it! Nice cleanup! - Anand Mazumdar On Dec. 1, 2016,

Re: Review Request 54194: Added `devolve` helper for `ContainerID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54194/#review157632 --- Ship it! Ship It! - Anand Mazumdar On Nov. 30, 2016, 3:55

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157616 --- Mostly minor comments all around. The two major ones include

Re: Review Request 53287: Overrided the default navbar color to match project website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53287/#review157636 --- Ship it! Ship It! - Benjamin Mahler On Nov. 26, 2016, 5:50

Re: Review Request 53288: Show Mesos logo in the navbar brand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53288/#review157637 --- Ship it! Ship It! - Benjamin Mahler On Nov. 26, 2016, 5:51

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54262/#review157658 --- Patch looks great! Reviews applied: [54262] Passed command:

Re: Review Request 46228: Create persistent volume with a supplied user.

> On Nov. 15, 2016, 8 p.m., Greg Mann wrote: > > src/slave/slave.cpp, lines 2848-2850 > > > > > > What's the rationale for including the sticky bit here? I wonder if the > > gain in security is worth the

Review Request 54262: Added macOS 10.12 instructions to the getting started page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54262/ --- Review request for mesos, Jie Yu and James Peach. Repository: mesos

Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53895/ --- (Updated Dec. 1, 2016, 10:16 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 1, 2016, 9:29 p.m., Greg Mann wrote: > > src/examples/persistent_volume_framework.cpp, lines 502-508 > > > > > > I would suggest that we should run this test framework in the test > > suite with both

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157642 --- Fix it, then Ship it!

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54262/#review157668 --- Ship it! Ship It! - haosdent huang On Dec. 1, 2016, 8:49

Review Request 54271: Disambiguate return type of lambda passed to `Future::then`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54271/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Joseph Wu.

Re: Review Request 54275: Fixed inaccurate documentation of `--hostname` for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54275/ --- (Updated Dec. 1, 2016, 4:26 p.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 46228: Create persistent volume with a supplied user.

> On Nov. 15, 2016, 8 p.m., Greg Mann wrote: > > src/slave/slave.cpp, lines 2848-2850 > > > > > > What's the rationale for including the sticky bit here? I wonder if the > > gain in security is worth the

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review157651 --- Thanks Jay, looks pretty good! Could you split this patch into

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Dec. 1, 2016, 10:38 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 54197: Introduced Resource.AllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54197/#review157669 --- Fix it, then Ship it! Looks good, just a small suggestion

Re: Review Request 54271: Disambiguated return type of lambda passed to `Future::then`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54271/ --- (Updated Dec. 1, 2016, 11:48 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Dec. 2, 2016, 12:02 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 2, 2016, 12:02 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 54275: Fixed inaccurate documentation of `--hostname` for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54275/#review157678 --- Ship it! I think your summary is one character too long and

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 1, 2016, 10:38 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 18, 2016, 11:56 a.m., Gastón Kleiman wrote: > > src/examples/persistent_volume_framework.cpp, line 150 > > > > > > Would it make sense to add the `shared-vol` prefix to the shard name in > > order to

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 1, 2016, 9:29 p.m., Greg Mann wrote: > > src/examples/persistent_volume_framework.cpp, lines 427-430 > > > > > > Could you provide comments here or elsewhere which give a high-level > > overview of the

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- (Updated Dec. 1, 2016, 10:37 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 54275: Fixed inaccurate documentation of `--hostname` for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54275/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Dec. 2, 2016, 12:25 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Dec. 2, 2016, 12:24 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54179: Updated master to use BoundedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54179/ --- (Updated Dec. 1, 2016, 10:34 p.m.) Review request for mesos and Vinod Kone.

Review Request 54274: Made `http::serv()` use the streaming request decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54274/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On 十二月 1, 2016, 10:36 p.m., Benjamin Mahler wrote: > > src/master/master.cpp, lines 2336-2349 > > > > > > It seems problematic here that `frameworkInfo.role()` is accesssed when > > the framework is MULTI_ROLE

Re: Review Request 54271: Disambiguated return type of lambda passed to `Future::then`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54271/#review157692 --- Patch looks great! Reviews applied: [54271] Passed command:

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 2:38 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54271: Disambiguated return type of lambda passed to `Future::then`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54271/#review157693 --- Ship it! Ship It! - Joseph Wu On Dec. 1, 2016, 3:48 p.m.,

Re: Review Request 53479: Perform GC asynchronously.

> On Nov. 21, 2016, 6:47 p.m., Benjamin Mahler wrote: > > Thanks for fixing this! It would be great to include some of the context > > from the ticket so that the commit message provides enough context (and/or > > points to the JIRA). In particular, that before this change, the launching > >

Re: Review Request 53479: Perform GC asynchronously.

> On Nov. 12, 2016, 12:48 a.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp, line 120 > > > > > > 'removal' and 'rm(dir)' sound too synonymous... > > > > > > To distinguish the two promises, perhaps name

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated Dec. 2, 2016, 2:58 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated Dec. 2, 2016, 3:01 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54088: Removed unused header include from stout's hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54088/#review157695 --- Ship it! Ship It! - Michael Park On Nov. 26, 2016, 12:28

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46229/#review157656 --- src/tests/containerizer/linux_filesystem_isolator_tests.cpp

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 1:02 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46229/#review157683 --- I was just trying to apply this to test and it looks like it

Re: Review Request 54245: Updated signatures of v1 agent API handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54245/ --- (Updated Dec. 2, 2016, 12:59 a.m.) Review request for mesos and Anand

Review Request 54278: Made `configure.ac` default to use brew apr on OS X in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54278/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 54278: Made `configure.ac` default to use brew apr on OS X in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54278/ --- (Updated Dec. 1, 2016, 4:59 p.m.) Review request for mesos and Benjamin

Review Request 54280: Made `configure.ac` default to use to brew apr on OS X in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54280/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54279: Made `configure.ac` default to use brew apr on OS X in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54279/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 54193: Refactored `Slave::Http::launchNestedContainer()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54193/ --- (Updated Dec. 2, 2016, 1 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 46228: Create persistent volume with a supplied user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/#review157686 --- src/slave/slave.cpp (lines 2923 - 2931)

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157562 --- Bad patch! Reviews applied: [54196, 54194, 54193, 54245, 54115,

Re: Review Request 53689: Use a common fixture for the PID namespace test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/#review157702 --- @jpeach I think you meant to add my ID asridharan? - Avinash

Re: Review Request 53688: Implement a namespace/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/#review157703 --- src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp (line

Re: Review Request 54274: Made `http::serv()` use the streaming request decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54274/#review157704 --- Ship it! The failed test is expected since the IOSwitchbaord

Re: Review Request 54274: Made `http::serv()` use the streaming request decoder.

> On Dec. 2, 2016, 6:24 a.m., Kevin Klues wrote: > > The failed test is expected since the IOSwitchbaord assumes *non* streaming > > requests at the moment. Maybe disable this test and commit this, and I'll > > reenable it in a follow on patch. Otherwise, I can give you the code that > >

Re: Review Request 54274: Made `http::serv()` use the streaming request decoder.

> On Dec. 2, 2016, 6:24 a.m., Kevin Klues wrote: > > The failed test is expected since the IOSwitchbaord assumes *non* streaming > > requests at the moment. Maybe disable this test and commit this, and I'll > > reenable it in a follow on patch. Otherwise, I can give you the code that > >

Review Request 54293: Supported TTY in I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54292: Added os::setctty to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54292/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54291: Added os::ptsname to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54294: Added an I/O switchboard test with TTY enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54289: Added a check to require I/O switchboard server for TTY support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54289/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54290: Added a ErrnoFailure similar to ErrnoError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54290/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos

Review Request 54296: Updated the IOSwitchboard http handler to work with streaming requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54296/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Bugs: MESOS-6467

Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Bugs: MESOS-6467

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review157710 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157697 --- Fix it, then Ship it! LGTM minus a small query regarding

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

> On Dec. 1, 2016, 7:49 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 1982 > > > > > > Why not be explicit here and set it to `ContainerClass::DEFAULT` like > > we do for the corresponding session one?

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 4:42 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 5:54 a.m.) Review request for mesos and Anand Mazumdar.