Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56867/#review166140 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166133 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/ --- (Updated Feb. 22, 2017, 1:23 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

> On Feb. 21, 2017, 11:20 p.m., Zhitao Li wrote: > > docs/upgrades.md, lines 252-260 > > > > > > 1. Is the order of these actions matter? I recall we specifically say > > order of upgrading each component does not

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 22, 2017, 1:14 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56621: Updated Mesos tests to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56621/ --- (Updated Feb. 22, 2017, 1:24 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/#review166285 --- Fix it, then Ship it! Looks good; just a couple of minor

Re: Review Request 56771: Added regression test against fetcher SSL spillover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56771/#review166299 --- Patch looks great! Reviews applied: [56711, 56771] Passed

Re: Review Request 56771: Added regression test against fetcher SSL spillover.

> On Feb. 21, 2017, 5:16 p.m., Adam B wrote: > > Looks good to me. Just a cuminor comments. s/cuminor/few minor/ - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56771/#review166187

Re: Review Request 56619: Updated 'Files' handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/ --- (Updated Feb. 22, 2017, 1:17 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56771: Added regression test against fetcher SSL spillover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56771/#review166187 --- Fix it, then Ship it! Looks good to me. Just a cuminor

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 22, 2017, 1:15 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review166284 --- A few superficial suggestions attached -- will take a closer look

Re: Review Request 56675: Silence MSVC compiler warnings in libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56675/#review166017 --- I'm going to review/commit this patch in a piece-meal fashion, as

Review Request 56906: WIP: Dealt with a corner case in the ReadFile API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56906/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 56901: Updated master validation code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56901/ --- Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till

Re: Review Request 56904: Documented provisioner auto backend semantic.

> On Feb. 21, 2017, 4:05 p.m., Qian Zhang wrote: > > docs/container-image.md, line 308 > > > > > > Duplicated `the`. Fixed. Thanks, Qian! :) - Gilbert ---

Re: Review Request 56904: Documented provisioner auto backend semantic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56904/ --- (Updated Feb. 21, 2017, 11:04 p.m.) Review request for mesos, Adam B, Avinash

Re: Review Request 56904: Documented provisioner auto backend semantic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56904/#review166323 --- Patch looks great! Reviews applied: [56904] Passed command:

Re: Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56889/#review166337 --- Ship it! Using this patch, I was able to adopt the

Re: Review Request 56809: Added test for nested container machine reboot case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56809/#review166317 --- Patch looks great! Reviews applied: [56808, 56809] Passed

Re: Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56889/ --- (Updated Feb. 22, 2017, 8:54 a.m.) Review request for mesos and Gilbert Song.

Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56889/ --- Review request for mesos. Bugs: MESOS-6563

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/ --- (Updated Feb. 21, 2017, 4:04 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/#review166184 --- src/slave/containerizer/fetcher.cpp (line 846)

Review Request 56771: Added regression test against fetcher SSL spillover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56771/ --- Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann. Repository:

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/#review166216 --- Looks good, thanks! Can you split the `timedout.clear()` change

Re: Review Request 56831: Minor fix to a comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56831/#review166219 --- include/mesos/mesos.proto (line 655)

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56867/#review166262 --- docs/upgrades.md (lines 249 - 257)

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

> On Feb. 21, 2017, 3:20 p.m., Zhitao Li wrote: > > docs/upgrades.md, lines 252-260 > > > > > > 1. Is the order of these actions matter? I recall we specifically say > > order of upgrading each component does not

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/ --- (Updated Feb. 21, 2017, 11:32 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/ --- (Updated Feb. 22, 2017, 1:18 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56530: Prevent resource of old agents being allocated to MULTI_ROLE frameworks.

> On Feb. 22, 2017, 5:30 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 214-241 > > > > > > Can you pull this out into a separate patch? > > > > Also, I would suggest we

Re: Review Request 56833: Added validation for on termination policy to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56833/#review166235 --- Can you add unit tests for the validation?

Re: Review Request 56809: Added test for nested container machine reboot case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56809/ --- (Updated Feb. 21, 2017, 2 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 56809: Added test for nested container machine reboot case.

> On Feb. 19, 2017, 8:32 p.m., Jie Yu wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp, lines 998-1012 > > > > > > Instead of that, can we call 'provisioner->provision' and use > >

Re: Review Request 56830: Introduced `TaskInfo::OnTerminationPolicy` protobuf.

> On Feb. 21, 2017, 1:50 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 1558 > > > > > > s/On// I think `OnTerminationPolicy` looks ugly not because of `On` but rather it's a three word term which is

Re: Review Request 56814: Wrapped IOSwitchboard.connect() in a dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56814/#review166244 --- Fix it, then Ship it!

Re: Review Request 56830: Introduced `TaskInfo::OnTerminationPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56830/#review166255 --- include/mesos/mesos.proto (lines 1641 - 1642)

Re: Review Request 56834: Send a TASK_ERROR update if a task specifies `OnTerminationPolicy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56834/#review166237 --- src/docker/executor.cpp (line 133)

Re: Review Request 56808: Fixed nested container agent flapping issue after reboot.

> On Feb. 19, 2017, 8:22 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, line 134 > > > > > > Any reason you need this state? Can 'state' just been a boolean (i.e., > >

Re: Review Request 56808: Fixed nested container agent flapping issue after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56808/ --- (Updated Feb. 21, 2017, 2:34 p.m.) Review request for mesos, Avinash

Re: Review Request 56809: Added test for nested container machine reboot case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56809/ --- (Updated Feb. 21, 2017, 2:34 p.m.) Review request for mesos, Avinash

Re: Review Request 56830: Introduced `TaskInfo::OnTerminationPolicy` protobuf.

> On Feb. 21, 2017, 1:50 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 1581 > > > > > > also for unknown status (e.g., OOM) Since Mesos never defined tasks as processes only, It's whatever the

Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- Review request for mesos. Repository: mesos Description --- With

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated Feb. 21, 2017, 6:58 p.m.) Review request for mesos. Bugs:

Re: Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56742/#review166203 --- Fix it, then Ship it! CHANGELOG (line 108)

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56867/#review166204 --- Ship it! Ship It! - Vinod Kone On Feb. 21, 2017, 7:57 a.m.,

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review166206 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 56530: Prevent resource of old agents being allocated to MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56530/#review166229 --- src/master/allocator/mesos/hierarchical.cpp (lines 1535 - 1544)

Re: Review Request 56830: Introduced `TaskInfo::OnTerminationPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56830/#review166233 --- include/mesos/mesos.proto (line 1558)

Re: Review Request 56837: Added slave capabilities to HierarchicalAllocatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56837/#review166227 --- Hm.. I think you need to update the `updateSlave` function as

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated Feb. 21, 2017, 9:42 p.m.) Review request for mesos. Bugs:

Re: Review Request 56832: Added output operator for `OnTerminationPolicy` enum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56832/#review166221 --- src/common/type_utils.cpp (line 580)

Re: Review Request 56644: Added a constant to store agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56644/#review166224 --- Ship it! Ship It! - Benjamin Mahler On Feb. 20, 2017, 7:18

Re: Review Request 56645: Added agent capabilities to `/state`(v0) endpoint of agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56645/#review166226 --- Ship it! Ship It! - Benjamin Mahler On Feb. 20, 2017, 7:19

Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56195/#review166201 --- Fly-by-question: include/mesos/slave/container_logger.hpp

Re: Review Request 56808: Fixed nested container agent flapping issue after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56808/ --- (Updated Feb. 21, 2017, 1:54 p.m.) Review request for mesos, Avinash

Re: Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56889/#review166183 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 56904: Documented provisioner auto backend semantic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56904/ --- Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.

Re: Review Request 56537: Added a test to ensure framework can upgrade to support MULTI_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56537/#review166265 --- Ship it! src/tests/master_tests.cpp (lines 6489 - 6497)

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/ --- (Updated Feb. 21, 2017, 11:46 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 56375: Added a test to ensure offers with different roles cannot be combined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56375/#review166271 --- Ship it! src/tests/master_tests.cpp (lines 1885 - 1902)

Re: Review Request 56904: Documented provisioner auto backend semantic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56904/#review166273 --- docs/container-image.md (line 308)