Re: Review Request 63390: Create/destroy volume test for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/#review193064 --- src/tests/resource_provider/storage_local_tests.cpp Lines 1

Re: Review Request 63390: Unit tests for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/ --- (Updated Dec. 7, 2017, 7:05 a.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/ --- (Updated Dec. 7, 2017, 3:11 a.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64400/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Repository: mesos

Re: Review Request 63555: Publish resource provider resources before container launch or update.

> On Dec. 7, 2017, 3:17 a.m., Jie Yu wrote: > > src/tests/slave_tests.cpp > > Lines 8961-8964 (patched) > > > > > > Can we call `subscribedDefault`? If we do not intercept `subscribed` calls, then we cannot get

Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64400/#review193090 --- Ship it! Ship It! - Jie Yu On Dec. 7, 2017, 3:14 a.m., Greg

Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.

> On Nov. 30, 2017, 7:49 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 39 (patched) > > > > > > For the sake of consistency. I think we should either rename this to > >

Re: Review Request 63555: Publish resource provider resources before container launch or update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/#review193083 --- src/slave/slave.hpp Lines 556 (patched)

Review Request 64398: Renamed the resource provider PUBLISH event to PUBLISH_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64398/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Repository: mesos

Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64399/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Repository: mesos

Re: Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64399/#review193089 --- Ship it! Ship It! - Jie Yu On Dec. 7, 2017, 3:13 a.m., Greg

Re: Review Request 63914: Changed agent reregistration to work with message directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/ --- (Updated Dec. 6, 2017, 4:24 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64383: Removed redundant `get()` call on a smart pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64383/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 64351: Moved generated CSI code into public directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64351/#review193012 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 10:05 p.m.,

Re: Review Request 64264: Added excluded image parameter to containerizer pruneImages().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64264/ --- (Updated Dec. 6, 2017, 10:52 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 64264: Added excluded image parameter to containerizer pruneImages().

> On Dec. 1, 2017, 11:32 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.hpp > > Lines 182-184 (original), 183-185 (patched) > > > > > > Not yours. Can we swap these two lines to make it

Re: Review Request 64352: Added default VolumeProfile module implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64352/#review193017 --- src/resource_provider/volume_profile.cpp Lines 53-54 (patched)

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

> On Dec. 2, 2017, 12:49 a.m., Qian Zhang wrote: > > src/messages/flags.proto > > Lines 113 (patched) > > > > > > DurationInfo seems a too small time unit (nanosecond) which may not > > convenient for operator to

Re: Review Request 64266: Added an optional agent flag '--image_gc_config'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64266/#review193028 --- Ship it! Ship It! - Zhitao Li On Dec. 6, 2017, 7:09 p.m.,

Re: Review Request 64197: Tracked layers in memory for provisioned containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64197/#review193032 --- Ship it! Ship It! - Gilbert Song On Nov. 29, 2017, 10:32

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ --- (Updated Dec. 6, 2017, 6:31 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64383: Removed redundant `get()` call on a smart pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64383/#review193019 --- Ship it! Ship It! - Vinod Kone On Dec. 6, 2017, 4:52 p.m.,

Re: Review Request 64264: Added excluded image parameter to containerizer pruneImages().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64264/#review193026 --- Ship it! Ship It! - Zhitao Li On Dec. 6, 2017, 6:52 p.m.,

Review Request 64386: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 64266: Added an optional agent flag '--image_gc_config'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64266/ --- (Updated Dec. 6, 2017, 11:09 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 64267: Supported basic auto image gc in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64267/ --- (Updated Dec. 6, 2017, 11:13 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 64271: Added an unit test for docker image auto gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64271/ --- (Updated Dec. 6, 2017, 11:15 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 64271: Added an unit test for docker image auto gc.

> On Dec. 2, 2017, 1:27 a.m., Qian Zhang wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 561 (patched) > > > > > > Why calling `paths::listLayer()` again here? Can we directly check > >

Re: Review Request 64271: Added an unit test for docker image auto gc.

> On Dec. 3, 2017, 2:53 p.m., Zhitao Li wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 463 (patched) > > > > > > Indicate why this needs `ROOT_` permission? due to the chroot. all other

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64265/#review193027 --- Ship it! Ship It! - Zhitao Li On Dec. 6, 2017, 7:07 p.m.,

Re: Review Request 64267: Supported basic auto image gc in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64267/#review193029 --- Fix it, then Ship it! Ship It! src/slave/slave.cpp Line 6170

Review Request 64389: Used a wrapper message for storage resource provider info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64389/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Repository: mesos

Re: Review Request 64389: Used a wrapper message for storage resource provider info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64389/#review193034 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 6, 2017, 7:40

Re: Review Request 64270: Fixed comments for linux MACRO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64270/ --- (Updated Dec. 6, 2017, 11:47 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193013 --- include/mesos/resource_provider/volume_profile.hpp Lines 34

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

> On Dec. 3, 2017, 2:14 p.m., Zhitao Li wrote: > > src/messages/flags.proto > > Lines 112-113 (patched) > > > > > > `required` fields are generally harder to handler during upgrade once > > we introduce them. Can

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64265/ --- (Updated Dec. 6, 2017, 11:07 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 64266: Added an optional agent flag '--image_gc_config'.

> On Dec. 3, 2017, 2:16 p.m., Zhitao Li wrote: > > docs/configuration/agent.md > > Lines 886-887 (patched) > > > > > > I would suggest only support files with support of refreshing its > > content without agent

Re: Review Request 64267: Supported basic auto image gc in the agent.

> On Dec. 3, 2017, 2:33 p.m., Zhitao Li wrote: > > src/slave/slave.cpp > > Lines 6159 (patched) > > > > > > Not necessarily this diff, but I wonder what kind of high level > > separation we want to keep between

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Dec. 6, 2017, 7:50 p.m.) Review request for mesos, James DeFelice,

Review Request 64380: Stout: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64380/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.

Re: Review Request 64168: Introduced a 'UUID' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/ --- (Updated Dec. 6, 2017, 5:09 p.m.) Review request for mesos, Benjamin Bannier

Review Request 64384: Added new 'any' setting for configuration_compatibility flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64384/ --- Review request for mesos. Repository: mesos Description --- Added new

Review Request 64379: Improved logs displayed after a slave failed recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 64381: Mesos: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64381/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

> On Dec. 4, 2017, 11:37 a.m., Michael Park wrote: > > src/master/master.hpp > > Line 128 (original), 128 (patched) > > > > > > Maybe we can consider making this `vector&&` as discussed in > >

Review Request 64385: Used more restrictive mount flags for host network bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64385/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-8286

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review193010 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Dec. 6, 2017, 8:01 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 64391: Fixed incorrect testing of existence of variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64391/#review193042 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 6, 2017,

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/ --- (Updated Dec. 6, 2017, 8:05 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192999 --- src/status_update_manager/offer_operation.hpp Lines 17 (patched)

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193036 --- include/mesos/resource_provider/volume_profile.hpp Lines 104-105

Re: Review Request 63555: Publish resource provider resources before container launch or update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/ --- (Updated Dec. 6, 2017, 8:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 64352: Added default VolumeProfile module implementation.

> On Dec. 6, 2017, 10:56 a.m., Jie Yu wrote: > > src/resource_provider/volume_profile.cpp > > Lines 53-54 (patched) > > > > > > See my comments in the previous patch regarding default profile. > > > > For

Re: Review Request 63390: Create/destroy volume test for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/ --- (Updated Dec. 6, 2017, 8:06 p.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Review Request 64391: Fixed incorrect testing of existence of variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64391/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 64370: Provided resource providere infos in 'UPDATE_STATE' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64370/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 64370: Provided resource providere infos in 'UPDATE_STATE' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64370/#review192973 --- Fix it, then Ship it! Could you fix the mixup between

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/ --- (Updated Dec. 6, 2017, 10:46 a.m.) Review request for mesos, Alexander

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/#review192975 --- Fix it, then Ship it! src/tests/reservation_tests.cpp Line

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193055 --- include/mesos/resource_provider/volume_profile.hpp Lines 106

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 12:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 12:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 6:37 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 92 (patched) > > > > > > We chatted about having an ability to define a default profile. To > > support

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Dec. 6, 2017, 3:50 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Dec. 7, 2017, 12:21 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/#review193038 --- src/resource_provider/storage/provider.cpp Lines 1286-1293

Re: Review Request 64385: Used more restrictive mount flags for host network bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64385/#review193054 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2017, 4:33 p.m.,

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Dec. 6, 2017, 3:37 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Re: Review Request 63971: Defined a module interface for translating volume profiles.

> On Dec. 6, 2017, 10:37 a.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 92 (patched) > > > > > > We chatted about having an ability to define a default profile. To > > support

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193065 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2017, 11:50 p.m.,

Re: Review Request 64335: Made "agent_features" flag available on non-Linux systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64335/#review193072 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 10:59 a.m., Jan

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/ --- (Updated Dec. 6, 2017, 5:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/ --- (Updated Dec. 6, 2017, 5:21 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 6, 2017, 5:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

> On Dec. 6, 2017, 12:29 p.m., Greg Mann wrote: > > src/status_update_manager/offer_operation.hpp > > Lines 48 (patched) > > > > > > This doesn't need to be `virtual` since we don't expect to use this as > > a base

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/ --- (Updated Dec. 6, 2017, 2:47 p.m.) Review request for mesos and Alexander