Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review199532 --- Bad patch! Reviews applied: [65875, 65666, 65665, 65640, 65976,

Re: Review Request 65694: Made the default executor's handling of kill escalations more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65694/#review199538 --- src/launcher/default_executor.cpp Lines 1223 (patched)

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/#review199539 --- src/launcher/default_executor.cpp Lines 1272 (patched)

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/#review199540 --- A high level question I have is the semantics of a task kill. You

Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65962/#review199541 --- src/launcher/default_executor.cpp Lines 943-958 (original)

Re: Review Request 66157: Fixed header inclusions for `csi/spec.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66157/#review199544 --- Fix it, then Ship it! src/csi/utils.hpp Lines 23-24 (patched)

Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- Review request for mesos and James Peach. Bugs: MESOS-6575

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 20, 2018, 2:35 p.m.) Review request for mesos and James Peach.

Re: Review Request 66161: Renamed the internal namespace `profile` to `storage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66161/#review199542 --- Looking at the symbols under `src/resource_provider/storage`, we

Re: Review Request 66094: Bumped bundled gRPC to 1.10.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66094/#review199548 --- Please consider folding https://reviews.apache.org/r/66095/ into

Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66097/#review199551 --- Ship it! Looking good. Surprised they didn't provide another

Re: Review Request 66095: Fixed gRPC compilation in standalone libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66095/#review199547 --- I think it would make sense to fold this patch into

Re: Review Request 66162: Changed names in tests related to `DiskProfileAdaptor` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66162/#review199543 --- It might sense to pull the introduction of

Re: Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66096/#review199550 --- Ship it! Looking good. Surprised they didn't provide another

Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/#review199556 --- Fix it, then Ship it!

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review199554 --- PASS: Mesos patch 66173 was successfully built and tested.

Re: Review Request 66159: Made tests `CSIClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66159/#review199545 --- Fix it, then Ship it! src/tests/mock_csi_plugin.hpp Line 71

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/#review199546 --- Fix it, then Ship it! include/csi/spec.hpp Lines 23 (patched)

Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8617 and

Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`.

> On March 19, 2018, 1:35 p.m., Benjamin Bannier wrote: > > I am not convinced that this tool will be much more useful than e.g., the > > existing `support/mesos-tidy.sh`. While being able to generate compilation > > databases and generating prerequisites is great, this tool e.g., would not >

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/ --- (Updated March 20, 2018, 1:50 p.m.) Review request for mesos, Alexander

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review199594 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/#review199587 --- Ship it! Ship It! - Greg Mann On March 16, 2018, 7:57 p.m.,

Re: Review Request 66159: Made tests `CSIClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66159/ --- (Updated March 20, 2018, 10:48 p.m.) Review request for mesos, Andrew

Re: Review Request 66119: Added a mock sandbox garbage collector.

> On March 20, 2018, 11:08 p.m., Greg Mann wrote: > > src/tests/mesos.hpp > > Lines 3130 (patched) > > > > > > Let's make note here of the default behavior provided (i.e., always > > returns 'true' by default).

Re: Review Request 66119: Added a mock sandbox garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66119/#review199604 --- src/tests/mesos.cpp Lines 687-688 (patched)

Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Bugs:

Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66097/ --- (Updated March 20, 2018, 8:47 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66141: Fixed whitespace in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/#review199586 --- Ship it! Ship It! - Greg Mann On March 19, 2018, 6:08 p.m.,

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/ --- (Updated March 20, 2018, 11:44 p.m.) Review request for mesos, Benjamin

Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor.

> On March 20, 2018, 6:05 a.m., Alexander Rukletsov wrote: > > src/launcher/default_executor.cpp > > Lines 943-958 (original) > > > > > > I'd rather see such code shuffling in a separate patch. It is not > >

Re: Review Request 66161: Renamed the internal namespace `profile` to `storage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66161/ --- (Updated March 20, 2018, 10:50 p.m.) Review request for mesos, Benjamin

Re: Review Request 66175: Added isolator checks for namespaces support.

> On March 20, 2018, 8:18 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 91-94 (patched) > > > > > > Just one question: under what scenarios does

Review Request 66164: Added to a comment in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66164/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Bugs:

Re: Review Request 66118: Updated an agent test to use mock authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66118/#review199599 --- Ship it! Ship It! - Greg Mann On March 16, 2018, 6:17 p.m.,

Re: Review Request 66162: Changed names related to `DiskProfileAdaptor` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66162/ --- (Updated March 20, 2018, 10:52 p.m.) Review request for mesos, Benjamin

Re: Review Request 66119: Added a mock sandbox garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66119/#review199476 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 3130

Re: Review Request 66175: Added isolator checks for namespaces support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199574 --- Fix it, then Ship it!

Re: Review Request 66096: Adapted the new `grpcpp` C++ header for gRPC v1.10 in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66096/ --- (Updated March 20, 2018, 8:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66060: Added end-to-end tests for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/#review199451 --- Fix it, then Ship it!

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review199591 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66140/#review199592 --- Ship it! Ship It! - Greg Mann On March 19, 2018, 6:40 p.m.,

Review Request 66182: Fixed grammar errors in comments in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66182/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos

Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ --- (Updated March 20, 2018, 10:46 p.m.) Review request for mesos, Andrew

Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66177/#review199581 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated March 20, 2018, 2:47 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63994: Added new tests for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 20, 2018, 9:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.

> On March 20, 2018, 3:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 67 (patched) > > > > > > nit: Let's make this constructor `explicit`. I think it would also make > >

Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66182/#review199593 --- Ship it! Ship It! - Greg Mann On March 20, 2018, 10:12

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review199601 --- FAIL: Failed to apply the dependent review: 66164. Failed

Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66182/#review199609 --- PASS: Mesos patch 66182 was successfully built and tested.

Re: Review Request 65694: Made the default executor's handling of kill escalations more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65694/ --- (Updated March 20, 2018, 1:49 p.m.) Review request for mesos, Alexander

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

> On March 20, 2018, 5:53 a.m., Alexander Rukletsov wrote: > > A high level question I have is the semantics of a task kill. You retry > > `SIGKILL` but not `SIGTERM`. Why is it so? Do you expect frameworks to > > retry kills at some point of time (which should be less that the kill > >

Re: Review Request 66157: Fixed header inclusions for `csi/spec.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66157/ --- (Updated March 20, 2018, 10:43 p.m.) Review request for mesos, Benjamin

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review199629 --- Bad patch! Reviews applied: [66165, 66164] Failed command:

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199638 --- Bad patch! Reviews applied: [66163, 61118, 61096, 66162, 66161,

Re: Review Request 66120: Updated an agent test to use mock garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66120/#review199602 --- src/tests/mesos.hpp Lines 203-207 (original), 203-207 (patched)

Re: Review Request 66060: Added end-to-end tests for operation feedback.

> On March 20, 2018, 2:32 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3323 (patched) > > > > > > s/are/is/ Updated this patch, and also posted this RR fixing the same

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199613 --- FAIL: Failed to apply the dependent review: 66094. Failed

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

> On March 20, 2018, 3:55 p.m., Benjamin Bannier wrote: > > include/csi/spec.hpp > > Lines 23 (patched) > > > > > > Not really related to this particular patch, but referencing this > > somewhat internal define in a

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199606 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines

Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66177/#review199623 --- Patch looks great! Reviews applied: [66177] Passed command:

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated March 20, 2018, 6:32 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 20, 2018, 6:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66182/#review199634 --- Patch looks great! Reviews applied: [66182] Passed command:

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- (Updated March 20, 2018, 11:47 p.m.) Review request for mesos, Andrew

Re: Review Request 66160: Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66160/ --- (Updated March 20, 2018, 11:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 66060: Added end-to-end tests for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/ --- (Updated March 20, 2018, 4:49 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- (Updated March 20, 2018, 6:33 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/ --- (Updated March 20, 2018, 6:33 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review199631 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66177/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/ --- (Updated March 20, 2018, 11:35 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66175: Added isolator checks for namespaces support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199563 --- PASS: Mesos patch 66175 was successfully built and tested.

Review Request 66175: Added isolator checks for namespaces support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6555

Re: Review Request 66175: Added isolator checks for namespaces support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199573 --- Patch looks great! Reviews applied: [66175] Passed command: