ail. To reply, visit:
https://reviews.apache.org/r/71983/#review219993
-------
On March 18, 2020, 10:54 p.m., Qian Zhang wrote:
>
> ---
> This is an automa
.at(framework.id())` and check each task launched by the same
executor. Or we could do this validation in Mesos agent?
- Qian Zhang
On March 19, 2020, 10:10 a.m., Greg Mann wrote:
>
> ---
> This is a
nk we
could remove this.
src/slave/validation.cpp
Lines 476-504 (patched)
<https://reviews.apache.org/r/72221/#comment308269>
I think these validations should be done outside of the `if
(launch.has_container()) {` at L453, because we want to do them even there is
no `ContainerInfo
e want to do this validation for the specific
slave rather than across slaves.
- Qian Zhang
On March 19, 2020, 9:14 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
party/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd
3rdparty/Makefile.am 243a6190d436a4ec179aaaf37e1c6284f35917c7
3rdparty/rapidjson-1.1.0.patch PRE-CREATION
Diff: https://reviews.apache.org/r/72161/diff/4/
Changes: https://reviews.apache.org/r/72161/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
---
>
> (Updated March 20, 2020, 9:07 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10045
> https://issues.apache.org/jira/browse/MESOS-10045
>
>
> Repository: mesos
>
>
> Descr
(patched)
<https://reviews.apache.org/r/72221/#comment308294>
Why do we need this line? To backward compatible with how standalone
containers are launched currently?
- Qian Zhang
On March 20, 2020, 8:36 a.m., Greg Mann
Lines 531 (patched)
<https://reviews.apache.org/r/7/#comment308295>
Could you please also check the containers nested at the second level or
greater?
- Qian Zhang
On March 19, 2020, 10:12 a.m., Greg Mann wrote:
>
> ---
ession` protobuf message.
include/mesos/mesos.proto
Lines 3364-3365 (original), 3364-3365 (patched)
<https://reviews.apache.org/r/72250/#comment308297>
Ditto, there is not resource limits field in the `ExecutorInfo` protobuf
message.
- Qian Zhang
On March 19, 2020, 10:05 p.m., Gre
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72216/#review220034
---
Ship it!
Ship It!
- Qian Zhang
On March 20, 2020, 2:42 p.m
this test, which means we may need to change the
implementation of the function `JSON::Object model(const
google::protobuf::Map& map)`.
```
"resources": {
"disk": 0,
"mem": 128,
"gpus": 0,
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72262/#review220076
---
Ship it!
Ship It!
- Qian Zhang
On March 25, 2020, 4:48 a.m
r.html
Lines 178-179 (original), 194-195 (patched)
<https://reviews.apache.org/r/72269/#comment308457>
Not yours, but I think for a completed task, its resources should already
be freed rather than still allocated, so maybe we should remove `(allocated)`
here?
- Qian Zhang
On March
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220161
---
Ship it!
Ship It!
- Qian Zhang
On April 1, 2020, 12:14 a.m
tps://reviews.apache.org/r/72297/#comment308497>
Should we return right before this line?
src/tests/master_tests.cpp
Line 4334 (original), 4340-4341 (patched)
<https://reviews.apache.org/r/72297/#comment308498>
A newline between.
- Qian Zhang
On April 2, 2020, 8:40 a.m., Gre
limit again
here?
- Qian Zhang
On April 2, 2020, 11:37 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
> On April 2, 2020, 2:27 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
> > Lines 715 (patched)
> > <https://reviews.apache.org/r/72305/diff/2/?file=2216777#file2216777line715>
> >
> > We already get
pache.org/r/72309/#comment308510>
Ditto.
- Qian Zhang
On April 3, 2020, 1:51 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Why do we use different ways to compare `usage` v.s. `softLimit` and
`usage` v.s. `limit`? Can we use the same way?
- Qian Zhang
On April 3, 2020, 9:59 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72297/#review220207
---
Ship it!
Ship It!
- Qian Zhang
On April 3, 2020, 10:16 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72309/#review220233
---
Ship it!
Ship It!
- Qian Zhang
On April 7, 2020, 6:15 a.m
s.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660
src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d
src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72391/diff/1/
Testing
---
Thanks,
Qian Zhang
194c42cf57e34d803a21cab03db17614855e8692
Diff: https://reviews.apache.org/r/72398/diff/1/
Testing
---
Thanks,
Qian Zhang
mesos/containerizer.cpp
6aa4f3fe0940575aeea6a63cdb1ca3c77cd2359b
Diff: https://reviews.apache.org/r/72399/diff/1/
Testing
---
Thanks,
Qian Zhang
/
Testing
---
Thanks,
Qian Zhang
492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72401/diff/1/
Testing
---
Thanks,
Qian Zhang
https://reviews.apache.org/r/72391/diff/2/
Changes: https://reviews.apache.org/r/72391/diff/1-2/
Testing
---
Thanks,
Qian Zhang
72402/diff/1/
Testing
---
Thanks,
Qian Zhang
rizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72402/diff/2/
Changes: https://reviews.apache.org/r/72402/diff/1-2/
Testing (updated)
---
sudo make check
Thanks,
Qian Zhang
s.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db
Diff: https://reviews.apache.org/r/72399/diff/2/
Changes: https://reviews.apache.org/r/72399/diff/1-2/
Testing
---
Thanks,
Qian Zhang
://reviews.apache.org/r/72401/diff/2/
Changes: https://reviews.apache.org/r/72401/diff/1-2/
Testing
---
Thanks,
Qian Zhang
and Greg Mann.
Repository: mesos
Description
---
Updated `StatisticsEndpointRunningExecutor` to support resource limits.
Diffs
-
src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db
Diff: https://reviews.apache.org/r/72400/diff/1/
Testing
---
Thanks,
Qian
check
Thanks,
Qian Zhang
/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
src/tests/containerizer/docker_containerizer_tests.cpp
b069f518d51225c39f0cd5126c02fa08674566ab
Diff: https://reviews.apache.org/r/72401/diff/2/
Testing
---
Thanks,
Qian Zhang
(patched)
<https://reviews.apache.org/r/72408/#comment308802>
Should we name it `Frameworks`?
- Qian Zhang
On April 22, 2020, 3:58 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
593db
Diff: https://reviews.apache.org/r/72399/diff/3/
Changes: https://reviews.apache.org/r/72399/diff/2-3/
Testing
---
Thanks,
Qian Zhang
se in the
command task case?
- Qian Zhang
On April 22, 2020, 4 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> --
)
<https://reviews.apache.org/r/72410/#comment308809>
I see https://reviews.apache.org/r/72409 already has the content of this
section, so can we avoid duplicating them here?
- Qian Zhang
On April 22, 2020, 4:01 a.m., Greg Mann
e adjustment for burstable tasks
somewhere in the doc?
And I think we also need to describe the newly introduced
`REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in the doc `task-state-reasons.md`.
- Qian Zhang
On April 22, 2020, 4 a.m., Gre
inity, so I have to choose to use double.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72398/#review220471
------
/r/72398/diff/2/
Changes: https://reviews.apache.org/r/72398/diff/1-2/
Testing
---
Thanks,
Qian Zhang
_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8
src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db
Diff: https://reviews.apache.org/r/72399/diff/4/
Changes: https://reviews.apache.org/r/72399/diff/3-4/
Testing
---
Thanks,
Qian Zhang
ges: https://reviews.apache.org/r/72402/diff/3-4/
Testing
---
sudo make check
Thanks,
Qian Zhang
ould change the
> > type of existing fields. Why do we need to change this?
>
> Qian Zhang wrote:
> The reason that I changed it to double is we need to support infinite
> limit. As per
> https://en.cppreference.com/w/cpp/types/numeric_limits/has_infinity , integer
&
ges: https://reviews.apache.org/r/72402/diff/4-5/
Testing
---
sudo make check
Thanks,
Qian Zhang
ould change the
> > type of existing fields. Why do we need to change this?
>
> Qian Zhang wrote:
> The reason that I changed it to double is we need to support infinite
> limit. As per
> https://en.cppreference.com/w/cpp/types/numeric_limits/has_infinity , intege
_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8
src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db
Diff: https://reviews.apache.org/r/72399/diff/5/
Changes: https://reviews.apache.org/r/72399/diff/4-5/
Testing
---
Thanks,
Qian Zhang
iff/1/
Testing
---
Thanks,
Qian Zhang
194c42cf57e34d803a21cab03db17614855e8692
src/common/protobuf_utils.cpp 8d1d5c4cb0af911d8dc13e37a1adb62947513d0d
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
60c7a89fb809582723eb50d22f54f4c8ce697584
Diff: https://reviews.apache.org/r/72442/diff/1/
Testing
---
Thanks,
Qian Zhang
> On April 22, 2020, 5:07 p.m., Qian Zhang wrote:
> > docs/home.md
> > Line 76 (original), 76 (patched)
> > <https://reviews.apache.org/r/72408/diff/1/?file=2224547#file2224547line76>
> >
> > Should we name it `Frameworks`?
>
> Greg Mann wrot
> On April 22, 2020, 9:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID&
8>
I think we'd better to have a general description about the task resource
limits feature (like how [quota
limits](https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-9-x-quota-guarantees)
feature was described) rather than just mention CPU limits here.
- Qian Zhang
On
> On April 22, 2020, 10:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> > Do we want to mention how we set OOM score adjustment fo
593db
Diff: https://reviews.apache.org/r/72399/diff/6/
Changes: https://reviews.apache.org/r/72399/diff/5-6/
Testing
---
Thanks,
Qian Zhang
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72399/#review220528
---
On April 29, 2020, 7:53 p.m., Qian Zhang wrote:
>
> -
/3/
Changes: https://reviews.apache.org/r/72401/diff/2-3/
Testing
---
Thanks,
Qian Zhang
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72401/#review220529
---
On April 29, 2020, 8:07 p.m., Qian Zhang wrote:
>
> ---
> This
/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72449/diff/1/
Testing
---
Thanks,
Qian Zhang
hanks,
Qian Zhang
?
Because we do not enforce soft limit in this case, see
https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L715:L717 .
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.
ommon/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660
src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d
src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72391/diff/2/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220547
---
Ship it!
Ship It!
- Qian Zhang
On April 29, 2020, 8:01 a.m
> On April 22, 2020, 10:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> > Do we want to mention how we set OOM score adjustment fo
> On April 22, 2020, 9:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID&
ommon/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660
src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d
src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72391/diff/2/
Testing
---
Thanks,
Qian Zhang
iff/3/
Changes: https://reviews.apache.org/r/72391/diff/2-3/
Testing
---
Thanks,
Qian Zhang
r.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
src/tests/containerizer/docker_containerizer_tests.cpp
b069f518d51225c39f0cd5126c02fa08674566ab
Diff: https://reviews.apache.org/r/72402/diff/7/
Changes: https://reviews.apache.org/r/72402/diff/6-7/
Testing
---
sudo make check
Thanks,
Qian Zhang
09fc2795289e1292134b7d4bb2cc079c80d91c3d
src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72449/diff/1/
Testing
---
Thanks,
Qian Zhang
custom
executors in Docker containers, so I reopened this patch.
- Qian Zhang
On April 30, 2020, 9:52 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ners?
Done.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72391/#review220576
---
On May 1, 2020, 9:14 p.m., Qian Zhang wrote:
>
> -
09fc2795289e1292134b7d4bb2cc079c80d91c3d
src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
Diff: https://reviews.apache.org/r/72391/diff/4/
Changes: https://reviews.apache.org/r/72391/diff/3-4/
Testing
---
Thanks,
Qian Zhang
/
Testing
---
Thanks,
Qian Zhang
reason, so we must remove it.
Done.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72442/#review220599
-------
://reviews.apache.org/r/72442/ for more details.
- Qian Zhang
On April 7, 2020, 6:02 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Diff: https://reviews.apache.org/r/72399/diff/7/
Changes: https://reviews.apache.org/r/72399/diff/6-7/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72475/#review220668
---
Ship it!
Ship It!
- Qian Zhang
On May 7, 2020, 1:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220669
---
Ship it!
Ship It!
- Qian Zhang
On May 7, 2020, 8:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72478/#review220671
---
Ship it!
Ship It!
- Qian Zhang
On May 7, 2020, 2:19 a.m
ng volumes.
Diffs
-
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp
c547696f50a4df9cce4ee9078b5fe90b93fd91d2
Diff: https://reviews.apache.org/r/72516/diff/1/
Testing
---
Thanks,
Qian Zhang
://reviews.apache.org/r/72523/diff/1/
Testing
---
sudo make check
This test will fail without the previous patch
(https://reviews.apache.org/r/72516/ ).
Thanks,
Qian Zhang
ges: https://reviews.apache.org/r/72516/diff/1-2/
Testing
---
Thanks,
Qian Zhang
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72516/#review220856
-------
On May 26, 2020, 9:41 a.m., Qian Zhang wrote:
>
> ---
>
is method as well.
src/uri/fetchers/docker.cpp
Lines 305-320 (original), 305-320 (patched)
<https://reviews.apache.org/r/72575/#comment309729>
Can we add URI for these 3 failure messages too?
- Qian Zhang
On June 8, 2020, 8:49 p.m., A
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72575/#review220992
---
Ship it!
Ship It!
- Qian Zhang
On June 8, 2020, 8:49 p.m
Line 447 (original), 449 (patched)
<https://reviews.apache.org/r/72596/#comment309796>
I think it should be `args` rather than `names`, right?
- Qian Zhang
On June 16, 2020, 5:21 p.m., Andrei Budnik wrote:
>
> ---
07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72660/diff/1/
Testing
---
Thanks,
Qian Zhang
5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72660/diff/2/
Changes: https://reviews.apache.org/r/72660/diff/1-2/
Testing
---
Thanks,
Qian Zhang
07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/1/
Testing
---
Thanks,
Qian Zhang
---
Thanks,
Qian Zhang
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221170
-------
On July 9, 2020, 11:13 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail.
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221172
---
On July 8, 2020, 4:59 p.m., Qian Zhang wrote:
>
>
,
Qian Zhang
5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/2/
Changes: https://reviews.apache.org/r/72661/diff/1-2/
Testing
---
Thanks,
Qian Zhang
/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/3/
Changes: https://reviews.apache.org/r/72661/diff/2-3/
Testing
---
Thanks,
Qian Zhang
,
Qian Zhang
/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/4/
Changes: https://reviews.apache.org/r/72661/diff/3-4/
Testing
---
Thanks,
Qian Zhang
a87df9633fddcf35ba2767704465cbc24e4082e0
Diff: https://reviews.apache.org/r/72683/diff/1/
Testing
---
Thanks,
Qian Zhang
/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/5/
Changes: https://reviews.apache.org/r/72661/diff/4-5/
Testing
---
Thanks,
Qian Zhang
t:
https://reviews.apache.org/r/72660/#review221240
---
On July 14, 2020, 2:44 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e
1 - 100 of 2373 matches
Mail list logo
