Review Request 49240: Update HttpDockerExecutor with v1 API.

2016-06-26 Thread Yong Tang
88b7fc4c36ed3974ac6b103a29e1d975619f0c69 src/internal/devolve.hpp 4a6ae681d37b3405ee81c4a58388b8d501743ebf src/internal/devolve.cpp cecb22e49614c6ee47489eead1d3161e033a53ef Diff: https://reviews.apache.org/r/49240/diff/ Testing --- make check on Ubuntu 14.04 Thanks, Yong Tang

Re: Review Request 43859: Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.

2016-02-23 Thread Yong Tang
43859/diff/ Testing (updated) --- make check Thanks, Yong Tang

Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

2016-02-28 Thread Yong Tang
794510c0f31eab6dafe8b86d835710096aac3392 src/common/date_utils.cpp 64eb33fee0c6155db3d6bcd3086bfcf4d7d9f7c0 src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 Diff: https://reviews.apache.org/r/44147/diff/ Testing --- make make check Thanks, Yong Tang

Review Request 43859: Fix invalid usage of ATOMIC_FLAG_INIT (MESOS-4602).

2016-02-22 Thread Yong Tang
--- Thanks, Yong Tang

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-14 Thread Yong Tang
On March 4, 2016, 6:56 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44380/ > --- &

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-18 Thread Yong Tang
-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e Diff: https://reviews.apache.org/r/44758/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Yong Tang
- Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123734 --- On March 16, 2016, 1:37 a.m., Yon

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Yong Tang
7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e Diff: https://reviews.apache.org/r/44758/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang
ex: '^<.*.h>' > > Priority:1 > > - Regex: '^<.*.hpp>' > > Priority:3 > > - Regex: '^<.*>' > > Priority:2 > > - Regex: '.*' > > Priority:

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-13 Thread Yong Tang
7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e Diff: https://reviews.apache.org/r/44758/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-13 Thread Yong Tang
his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123323 ------- On March 14, 2016, 1:09 a.m., Yong Tang wrote: > > ---

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-13 Thread Yong Tang
verhead for all tests in this > > suite, even ones not creating any files. If that's something we wouldn't > > want, what about using separate suites for tests creating files (that would > > be `BufferedRead` and `Redirect`), and other ones? > > Yong Tang wrote: > Hi Benj

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Yong Tang
verhead for all tests in this > > suite, even ones not creating any files. If that's something we wouldn't > > want, what about using separate suites for tests creating files (that would > > be `BufferedRead` and `Redirect`), and other ones? > > Yong Tang wrote: > Hi Benj

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Yong Tang
directories via TemporaryDirectoryTest fixture (MESOS-4807). Diffs (updated) - 3rdparty/libprocess/src/tests/io_tests.cpp 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 Diff: https://reviews.apache.org/r/44380/diff/ Testing --- make check Thanks, Yong Tang

Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-12 Thread Yong Tang
/44758/diff/ Testing --- make check Thanks, Yong Tang

Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-03-19 Thread Yong Tang
26a637bec1193dd51437bd689c34fbe6d1935d89 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 444377df00922df12d4b3ed25b4cfe9071cff5c3 Diff: https://reviews.apache.org/r/45011/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-14 Thread Yong Tang
> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote: > > Looks mostly good to me. I left some comments, but if you want to make any > > progress here you'll still need to find a shepherd (see > > http://mesos.apache.org/documentation/latest/submitting-a-patch/).

Review Request 45070: Clean up libprocess gtest macros (MESOS-4112).

2016-03-18 Thread Yong Tang
://reviews.apache.org/r/45070/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-18 Thread Yong Tang
> On March 18, 2016, 7:03 p.m., haosdent huang wrote: > > docs/versioning.md, line 85 > > <https://reviews.apache.org/r/45033/diff/1/?file=1305277#file1305277line85> > > > > Any reason we need change here? > > Yong Tang wrote: > Hi

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Yong Tang
--- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44912: Used the same fixture for all related tests.

2016-03-19 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/#review123882 --- Ship it! Ship It! - Yong Tang On March 16, 2016, 3:47 p.m

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang
ted the review request. Let me know if there are other issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124090 ---

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

2016-03-19 Thread Yong Tang
/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

2016-03-19 Thread Yong Tang
skipped if it is not created. Diffs (updated) - src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 Diff: https://reviews.apache.org/r/44883/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-19 Thread Yong Tang
ly generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 --- On March 18, 2016, 2:48 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. T

Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).

2016-03-19 Thread Yong Tang
/diff/ Testing --- make check Also tested with configure --disable-optimize manually. Thanks, Yong Tang

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

2016-03-19 Thread Yong Tang
ch 17, 2016, 1:52 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44883/ > --- > > (Updated

Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-19 Thread Yong Tang
-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang
v list shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124038 --- On March 16, 2016, 1:37 a.m.,

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang
> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. > > Yong Tang wrote: > Hi Michael, Thanks a lot for the help! I

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-24 Thread Yong Tang
The Mesos codebase follows the Google C++ Style Guide with some > > notable differences, as described below. > > > > So basing off of Google and overriding the parts that don't match > > accurately defines our style guide. > > Yong Tang wrote: > Thanks M

Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-24 Thread Yong Tang
--- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45317/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
Just updated the CHANGELOG. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125464 --- On March

Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-25 Thread Yong Tang
944a493e0979c7ffbd99f3a67785a10425fd9040 src/authorizer/local/authorizer.cpp 0f0d9276337858984f0b19a82ffca74ee84dc650 Diff: https://reviews.apache.org/r/45342/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
eply, visit: https://reviews.apache.org/r/45304/#review125476 --- On March 25, 2016, 9:25 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
562b0acfd8555b9b773175f53defe0e7e2744641 src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 src/tests/mesos.hpp 23694885a69ddcbc7039de1186093ce0ad5eed22 Diff: https://reviews.apache.org/r/45304/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
2016, 9:19 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45304/ > --- > > (Updated March

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
- Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125465 --- On March 25, 2016, 9:19 p.m., Yong T

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-23 Thread Yong Tang
/non-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-23 Thread Yong Tang
. - Yong Tang On March 23, 2016, 2:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-19 Thread Yong Tang
--- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-19 Thread Yong Tang
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 ------- On March 19, 2016, 6:26 p.m., Yong Tang wrote: > > --- > This is an automatically generated e

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-19 Thread Yong Tang
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124256 --- On March 18, 2016, 11:11 p.m., Yong Tang wrote: > > --- > This is a

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-19 Thread Yong Tang
and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Yong Tang
1f52a423c8c83c58d38ba6731ab2625136a271bb Diff: https://reviews.apache.org/r/45327/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-24 Thread Yong Tang
0049e1383f50574c3dad6a29b91811001694e82c include/mesos/v1/scheduler/scheduler.proto 09fafedd06837f2307fedc6fa0e7b4460b21e5b0 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45317/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Yong Tang
of treating them as Event::ERROR. (MESOS-5020) Diffs (updated) - src/scheduler/scheduler.cpp 1f52a423c8c83c58d38ba6731ab2625136a271bb Diff: https://reviews.apache.org/r/45327/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Yong Tang
- Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125378 --- On March 25, 2016, 2:28 a.m., Yong T

Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-03-26 Thread Yong Tang
(Ubuntu 14.04) Thanks, Yong Tang

Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

2016-03-26 Thread Yong Tang
://reviews.apache.org/r/45357/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
/test_http_executor.cpp 562b0acfd8555b9b773175f53defe0e7e2744641 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45304/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
pdated the review request https://reviews.apache.org/r/45304/ as well. Again, thanks a lot for the help. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#revie

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45317/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-03 Thread Yong Tang
2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 Diff: https://reviews.apache.org/r/44380/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-04 Thread Yong Tang
(updated) - 3rdparty/libprocess/src/tests/io_tests.cpp 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 Diff: https://reviews.apache.org/r/44380/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-04 Thread Yong Tang
any issues and I will fix it. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review122030 --- On Ma

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
w request shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121753 --- On March 2, 2016,

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
> On March 3, 2016, 1 a.m., Vinod Kone wrote: > > Looks great. > > > > Can you also rename the class name in test_http_framework.cpp? > > s/EventCallScheduler/HTTPScheduler/ > > Yong Tang wrote: > Thanks Vinod. Will update the review request shortly.

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
cddb5208bce29cf84c40ff76aff0163d110a98d1 src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 Diff: https://reviews.apache.org/r/44266/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
9bac8021394675d416967f507fbc2556e08d src/tests/event_call_framework_test.sh cddb5208bce29cf84c40ff76aff0163d110a98d1 src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 Diff: https://reviews.apache.org/r/44266/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
(Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-07 Thread Yong Tang
with implicit roles (MESOS-4868). Diffs (updated) - src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 Diff: https://reviews.apache.org/r/44408/diff/ Testing --- make check (in Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-07 Thread Yong Tang
tically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122346 --- On March 7, 2016, 8:55 p.m., Yong Tang wrote: > > --- &

Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 Diff: https://reviews.apache.org/r/44408/diff/ Testing --- make check (in Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
with implicit roles (MESOS-4868). Diffs (updated) - src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 Diff: https://reviews.apache.org/r/44408/diff/ Testing --- make check (in Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
, Yong Tang

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122173 --- On March 5, 2016, 4:17 a.m., Yong Tang wrote: > > -

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-03 Thread Yong Tang
0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-03 Thread Yong Tang
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126755 --- On April 3, 2016, 11:47 p.m., Yong Tang wrote: > > --- > This is an automatically generated e

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-04-03 Thread Yong Tang
ed e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 --- On March 26, 2016, 10:35 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-03 Thread Yong Tang
request). Thanks, Yong Tang

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

2016-04-03 Thread Yong Tang
/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

2016-04-03 Thread Yong Tang
ssage have been updated. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/#review126756 --- On April 3,

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-03 Thread Yong Tang
ote: This commit includes patches from Kevin Klues and haosdent. > > ``` > > > > Thanks! Thanks Kevin. The commit message was updated. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-03 Thread Yong Tang
te: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >

Re: Review Request 45660: Fix non-printable chars in mesos source code.

2016-04-03 Thread Yong Tang
--- make check Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-03 Thread Yong Tang
it: https://reviews.apache.org/r/45033/#review126749 --- On April 3, 2016, 7:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 45660: Fix non-printable chars in mesos source code.

2016-04-03 Thread Yong Tang
0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang

Review Request 45659: Fix non-printable chars in libprocess (format.hpp).

2016-04-03 Thread Yong Tang
/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-03 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126733 --- On April 3, 2016, 7:46 p.m., Yong Tang wrote: > > -

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-03 Thread Yong Tang
about the actual matching going on here. > > > > This match doesn't exclude non-printable characters from the lower 127 > > ascii codes, nor does it exclude unicode characters (which I think we want > > to exclude). > > > > I updated the patch I

Re: Review Request 45659: Fix non-printable chars in libprocess (format.hpp).

2016-04-03 Thread Yong Tang
this is a separate review request. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-03 Thread Yong Tang
support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

2016-04-03 Thread Yong Tang
/libprocess/include/process/gtest.hpp 30d51d3704bd0ad82c6d21f1222d6158aaa61298 Diff: https://reviews.apache.org/r/45357/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

2016-04-03 Thread Yong Tang
eviews.apache.org/r/45357/#review126760 --- On April 4, 2016, 1:56 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 45663: Add AWAIT_TRUE_FOR/AWAIT_TRUE, AWAIT_FALSE_FOR/AWAIT_FALSE.

2016-04-03 Thread Yong Tang
. AWAIT_FALSE alias to AWAIT_ASSERT_FALSE. Diffs - 3rdparty/libprocess/include/process/gtest.hpp 30d51d3704bd0ad82c6d21f1222d6158aaa61298 Diff: https://reviews.apache.org/r/45663/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Review Request 45664: Replace `EQ(true/false` with `_TRUE/_FALSE` in tests.

2016-04-03 Thread Yong Tang
f8e141bfc0023128f40ca8ecdae7a5609818c2b1 Diff: https://reviews.apache.org/r/45664/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-04-03 Thread Yong Tang
cpp` for > > example? > > Is there perhaps a separate patch that I don't have a pointer to? > > Yong Tang wrote: > Thanks Michael. I was not sure when I did the change. Let me update the > review request shortly. > > Michael Park wrote: > Ah, ok. Thanks! Hi Michael, I

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Yong Tang
tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126806 --- On April 4, 2016, 2:31 p.m., Yong Tang wrote: > > --- > This is an au

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Yong Tang
126806 ------- On April 4, 2016, 2:31 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

2016-04-04 Thread Yong Tang
a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-04 Thread Yong Tang
cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Yong Tang
support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Yong Tang
- Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125768 --- On March 29, 2016, 2:04 a.m., Yong T

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-01 Thread Yong Tang
13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-04-01 Thread Yong Tang
request and merged the ascii check with mesos-style.py. I also skipped the .md check for now as there is another ticket MESOS-5077 for that. Let me know if there are other issues. - Yong Tang On April 2, 2016, 1:41 a.m., Yong Tang wrote

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Yong Tang
> do for the `line_number` in order to keep this all in one place. We could > > also use this opportunity to go for less incidental list formatting, e.g., > > > > chars=', '.join([str(char + 1) for char in char_errors]) # gives > > e.g., "Line: 10, Cha

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Yong Tang
s-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang

  1   2   >