Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2016-01-03 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review112441 --- Ship it! Looks good. I'm cleaning up the comments before I

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-28 Thread Avinash sridharan
> On Dec. 24, 2015, 11:10 a.m., Adam B wrote: > > Looks good, but I wonder if we need to go so far as to introduce the `enum > > Protocol` misnomer in the global IPAddress message now. We could always add > > it in later, when we actually get NetworkInfo off of it. > > Anand Mazumdar wrote: >

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 29, 2015, 1:10 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-24 Thread Anand Mazumdar
> On Dec. 24, 2015, 11:10 a.m., Adam B wrote: > > Looks good, but I wonder if we need to go so far as to introduce the `enum > > Protocol` misnomer in the global IPAddress message now. We could always add > > it in later, when we actually get NetworkInfo off of it. 1. Adam, can you elaborate

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-24 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111848 --- Looks good, but I wonder if we need to go so far as to introduce

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 22, 2015, 10:03 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 23, 2015, 2:09 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 23, 2015, 2:05 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 23, 2015, 3 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
> On Dec. 19, 2015, 10:01 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1576-1577 > > > > > > Do we expect to add more fields to the Vip message later? > > If not, why don't we just add a `repeated

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 22, 2015, 11:47 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Anand Mazumdar
> On Dec. 19, 2015, 10:01 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1576-1577 > > > > > > Do we expect to add more fields to the Vip message later? > > If not, why don't we just add a `repeated

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
> On Dec. 19, 2015, 10:01 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1576-1577 > > > > > > Do we expect to add more fields to the Vip message later? > > If not, why don't we just add a `repeated

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
> On Dec. 19, 2015, 10:01 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1576-1577 > > > > > > Do we expect to add more fields to the Vip message later? > > If not, why don't we just add a `repeated

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 20, 2015, 1:51 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
> On Dec. 18, 2015, 10:54 p.m., Artem Harutyunyan wrote: > > > > Artem Harutyunyan wrote: > Commit messages should usually end with a period. Fixed. > On Dec. 18, 2015, 10:54 p.m., Artem Harutyunyan wrote: > > include/mesos/mesos.proto, line 1579 > >

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Adam B
> On Dec. 18, 2015, 2:54 p.m., Artem Harutyunyan wrote: > > include/mesos/mesos.proto, line 1597 > > > > > > Why is it a Vip and not VIP, or VIp, or maybe even virtual_ip to be > > consistent with the style?

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111369 --- Please rename `Vip` back, or go with `VIP`. Or get rid of that

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111222 --- include/mesos/mesos.proto (line 1579)

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Artem Harutyunyan
> On Dec. 18, 2015, 2:54 p.m., Artem Harutyunyan wrote: > > Commit messages should usually end with a period. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111222

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Artem Harutyunyan
> On Dec. 17, 2015, 5:40 p.m., Adam B wrote: > > Let's get rid of the Vips message per MPark's recommendation, since we're > > unlikely to ever add any more fields to that message. Could you please also clean the `Depends On` field for this review? - Artem

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 19, 2015, 7:05 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 19, 2015, 7:16 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110922 --- This review depends on 41189, but 41189 is somehow marked as

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 17, 2015, 9:33 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Avinash sridharan
> On Dec. 17, 2015, 8:37 a.m., Kevin Klues wrote: > > This review depends on 41189, but 41189 is somehow marked as "Invite-only", > > so it is not viewable by the public. This is causing the jenkins > > review-bot to fail with: > > > > Verifying review 41381 > > Dependent review:

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 17, 2015, 10:41 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110939 --- Please explain (the intended use of) instance_port better.

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review02 --- Let's get rid of the Vips message per MPark's recommendation,

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 17, 2015, 3:31 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110807 --- Looks like this review has overlapping changes with

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 15, 2015, 4:35 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110474 --- Lookin good include/mesos/mesos.proto (line 1569)

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 15, 2015, 9:13 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 16, 2015, 12:28 a.m.) Review request for mesos, Adam B and Anand